234592 2021-12-21 20:52:39 -0800 Fix WebCore install headers with alternate build 2021-12-22 10:24:17 -0800 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 msaboff webkit-unassigned ap fpizlo jberlin webkit-bug-importer oldest_to_newest 1826209 0 msaboff 2021-12-21 20:52:39 -0800 We fail in the install headers step using an alternate root. There are two issues: There are extraneous ')' at the end of two NORMAL_PRODUCTION_FRAMEWORKS_DIR_... rules. The computation of OUTPUT_ALTERNATE_ROOT_PATH for macOS should produce a null value. 1826210 1 msaboff 2021-12-21 20:53:02 -0800 <rdar://86795488> 1826214 2 447780 msaboff 2021-12-21 21:01:42 -0800 Created attachment 447780 Patch 1826332 3 msaboff 2021-12-22 10:24:17 -0800 Committed r287361 (?): <https://commits.webkit.org/r287361> 447780 2021-12-21 21:01:42 -0800 2021-12-22 09:37:02 -0800 Patch 234592.patch text/plain 3279 msaboff SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI4NzM0MykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDIxLTEyLTIxICBNaWNoYWVs IFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAgICAgIEZpeCBXZWJDb3JlIGluc3Rh bGwgaGVhZGVycyB3aXRoIGFsdGVybmF0ZSBidWlsZAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjM0NTkyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgQ292ZXJlZCBieSBleGlzdGluZyB0ZXN0cy4KKworICAg ICAgICBGaXhlZCBPVVRQVVRfQUxURVJOQVRFX1JPT1RfUEFUSCBmb3IgbWFjT1MgdG8gcmV0dXJu IGFuIGVtcHR5IHZhbHVlIHNpbmNlIHdlIGRvbid0IG5lZWQgYSBzeW1saW5rCisgICAgICAgIGFz IHRoZSBXZWJDb3JlIGZyYW1ld29yayBpcyBpbiBhIHN1YmRpcmVjdG9yeSBvZiBXZWJLaXQuZnJh bWV3b3JrLgorICAgICAgICBGaXhlZCB0eXBvcyB3aXRoIE5PUk1BTF9QUk9EVUNUSU9OX0ZSQU1F V09SS1NfRElSX1VTRV9TWVNURU1fQ09OVEVOVF9QQVRIX1lFUyBydWxlcywKKyAgICAgICAgZWxp bWluYXRpbmcgdGhlICcpJ3MgYXQgdGhlIGVuZCBvZiB0aGUgbGluZXMuCisKKyAgICAgICAgKiBD b25maWd1cmF0aW9ucy9XZWJDb3JlLnhjY29uZmlnOgorCiAyMDIxLTEyLTIxICBCcmFkeSBFaWRz b24gIDxiZWlkc29uQGFwcGxlLmNvbT4KIAogICAgICAgICBNYWtlIE5vdGlmaWNhdGlvbiBpZGVu dGlmaWVycyBiZSBhIFVVSUQgc3RyaW5nIGluc3RlYWQgb2YgYSB1aW50NjRfdApJbmRleDogU291 cmNlL1dlYkNvcmUvQ29uZmlndXJhdGlvbnMvV2ViQ29yZS54Y2NvbmZpZwo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV2ViQ29yZS9Db25maWd1cmF0aW9ucy9XZWJDb3JlLnhjY29uZmlnCShyZXZpc2lv biAyODczNDMpCisrKyBTb3VyY2UvV2ViQ29yZS9Db25maWd1cmF0aW9ucy9XZWJDb3JlLnhjY29u ZmlnCSh3b3JraW5nIGNvcHkpCkBAIC03NSw5ICs3NSwxMCBAQCBBTFRFUk5BVEVfUk9PVF9QQVRI W3Nkaz1pcGhvbmUqXSA9ICQoU1lTCiBBTFRFUk5BVEVfUk9PVF9QQVRIW3Nkaz1tYWNvc3gqXSA9 ICQoRFlMSUJfSU5TVEFMTF9OQU1FX0JBU0VfUExBVEZPUk1fJChXS19VU0VfQUxURVJOQVRFX0ZS QU1FV09SS1NfRElSKSk7CiAKIE9VVFBVVF9BTFRFUk5BVEVfUk9PVF9QQVRIW3Nkaz1pcGhvbmUq XSA9ICQoT1VUUFVUX0FMVEVSTkFURV9ST09UX1BBVEhfJChVU0VfU1lTVEVNX0NPTlRFTlRfUEFU SCkpOwotT1VUUFVUX0FMVEVSTkFURV9ST09UX1BBVEhbc2RrPW1hY29zeCpdID0gJChPVVRQVVRf QUxURVJOQVRFX1JPT1RfUEFUSF8kKFVTRV9TWVNURU1fQ09OVEVOVF9QQVRIKSk7CiBPVVRQVVRf QUxURVJOQVRFX1JPT1RfUEFUSF9ZRVNbc2RrPWlwaG9uZSpdID0gJChEU1RST09UKSQoQUxURVJO QVRFX1JPT1RfUEFUSCkvJChGVUxMX1BST0RVQ1RfTkFNRSk7Ci1PVVRQVVRfQUxURVJOQVRFX1JP T1RfUEFUSF9ZRVNbc2RrPW1hY29zeCpdID0gJChEU1RST09UKSQoQUxURVJOQVRFX1JPT1RfUEFU SCkvJChGVUxMX1BST0RVQ1RfTkFNRSk7CisKK09VVFBVVF9BTFRFUk5BVEVfUk9PVF9QQVRIW3Nk az1tYWNvc3gqXSA9ICQoT1VUUFVUX0FMVEVSTkFURV9ST09UX1BBVEhfJChVU0VfU1lTVEVNX0NP TlRFTlRfUEFUSClfJChXS19VU0VfQUxURVJOQVRFX0ZSQU1FV09SS1NfRElSKSk7CitPVVRQVVRf QUxURVJOQVRFX1JPT1RfUEFUSF9ZRVNfWUVTW3Nkaz1tYWNvc3gqXSA9ICQoRFNUUk9PVCkkKEFM VEVSTkFURV9ST09UX1BBVEgpLyQoRlVMTF9QUk9EVUNUX05BTUUpOwogCiBXS19BTkdMRV9MREZM QUdTID0gLXdlYWstbEFOR0xFLXNoYXJlZDsKIApAQCAtMTU3LDggKzE1OCw4IEBAIFdFQkNPUkVf RlJBTUVXT1JLU19ESVJfVVNFX09WRVJSSURFX0ZSQU0KIFdFQkNPUkVfRlJBTUVXT1JLU19ESVJf VVNFX09WRVJSSURFX0ZSQU1FV09SS1NfRElSX1lFUyA9ICQoV0tfT1ZFUlJJREVfRlJBTUVXT1JL U19ESVIpOwogCiBOT1JNQUxfUFJPRFVDVElPTl9GUkFNRVdPUktTX0RJUiA9ICQoTk9STUFMX1BS T0RVQ1RJT05fRlJBTUVXT1JLU19ESVJfVVNFX1NZU1RFTV9DT05URU5UX1BBVEhfJChVU0VfU1lT VEVNX0NPTlRFTlRfUEFUSCkpOwotTk9STUFMX1BST0RVQ1RJT05fRlJBTUVXT1JLU19ESVJfVVNF X1NZU1RFTV9DT05URU5UX1BBVEhfWUVTW3Nkaz1pcGhvbmUqXSA9ICQoU1lTVEVNX0NPTlRFTlRf UEFUSCkkKFNZU1RFTV9MSUJSQVJZX0RJUikvUHJpdmF0ZUZyYW1ld29ya3MpOwotTk9STUFMX1BS T0RVQ1RJT05fRlJBTUVXT1JLU19ESVJfVVNFX1NZU1RFTV9DT05URU5UX1BBVEhfWUVTW3Nkaz1t YWNvc3gqXSA9ICQoU1lTVEVNX0NPTlRFTlRfUEFUSCkkKFNZU1RFTV9MSUJSQVJZX0RJUikvRnJh bWV3b3Jrcyk7CitOT1JNQUxfUFJPRFVDVElPTl9GUkFNRVdPUktTX0RJUl9VU0VfU1lTVEVNX0NP TlRFTlRfUEFUSF9ZRVNbc2RrPWlwaG9uZSpdID0gJChTWVNURU1fQ09OVEVOVF9QQVRIKSQoU1lT VEVNX0xJQlJBUllfRElSKS9Qcml2YXRlRnJhbWV3b3JrczsKK05PUk1BTF9QUk9EVUNUSU9OX0ZS QU1FV09SS1NfRElSX1VTRV9TWVNURU1fQ09OVEVOVF9QQVRIX1lFU1tzZGs9bWFjb3N4Kl0gPSAk KFNZU1RFTV9DT05URU5UX1BBVEgpJChTWVNURU1fTElCUkFSWV9ESVIpL0ZyYW1ld29ya3M7CiBO T1JNQUxfUFJPRFVDVElPTl9GUkFNRVdPUktTX0RJUl9VU0VfU1lTVEVNX0NPTlRFTlRfUEFUSF8g PSAkKE5PUk1BTF9QUk9EVUNUSU9OX0ZSQU1FV09SS1NfRElSX1VTRV9TWVNURU1fQ09OVEVOVF9Q QVRIX05PKTsKIE5PUk1BTF9QUk9EVUNUSU9OX0ZSQU1FV09SS1NfRElSX1VTRV9TWVNURU1fQ09O VEVOVF9QQVRIX05PW3Nkaz1pcGhvbmUqXSA9ICQoU0RLUk9PVCkkKFNZU1RFTV9MSUJSQVJZX0RJ UikvUHJpdmF0ZUZyYW1ld29ya3M7CiBOT1JNQUxfUFJPRFVDVElPTl9GUkFNRVdPUktTX0RJUl9V U0VfU1lTVEVNX0NPTlRFTlRfUEFUSF9OT1tzZGs9bWFjb3N4Kl0gPSAkKE5FWFRfUk9PVCkkKFNZ U1RFTV9MSUJSQVJZX0RJUikvRnJhbWV3b3JrczsK