23459 2009-01-21 12:01:25 -0800 Workers are not properly terminated if execution hasn't begun yet 2009-01-23 06:51:15 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 ap ap oldest_to_newest 106481 0 ap 2009-01-21 12:01:25 -0800 If Worker.terminate() is called before the worker thread has begun execution, it cannot forbid script execution. So, evaluating the script source can result in the thread entering a loop forever, taking 100% of processor (core) time. 106483 1 26900 ap 2009-01-21 12:04:20 -0800 Created attachment 26900 proposed patch 106497 2 26900 darin 2009-01-21 13:46:11 -0800 Comment on attachment 26900 proposed patch r=me 106581 3 26924 ap 2009-01-22 00:27:04 -0800 Created attachment 26924 Alternative patch I changed my mind - I now think it's better to go through the normal code path, to avoid getting out of sync in the future. It's slightly less efficient, but this use case is definitely not something to optimize for. 106744 4 ap 2009-01-23 06:51:15 -0800 Committed revision 40159. 26900 2009-01-21 12:04:20 -0800 2009-01-21 13:46:11 -0800 proposed patch EarlyTerminate.txt text/plain 1570 ap SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0MDA4NykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMDktMDEtMjEgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEB3ZWJr aXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzQ1OQorICAgICAgICBX b3JrZXJzIGFyZSBub3QgcHJvcGVybHkgdGVybWluYXRlZCBpZiBleGVjdXRpb24gaGFzbid0IGJl Z3VuIHlldAorCisgICAgICAgIERvZXNuJ3QgYWZmZWN0IG9ic2VydmFibGUgYmVoYXZpb3IsIHNv IHRlc3QgY2FzZSBpcyBub3QgcG9zc2libGUuCisKKyAgICAgICAgKiBkb20vV29ya2VyVGhyZWFk LmNwcDogKFdlYkNvcmU6OldvcmtlclRocmVhZDo6d29ya2VyVGhyZWFkKTogQmFpbCBvdXQgcXVp Y2tseSBpZiBzdG9wKCkKKyAgICAgICAgd2FzIGFscmVhZHkgY2FsbGVkLgorCiAyMDA5LTAxLTIx ICBOaWtvbGFzIFppbW1lcm1hbm4gIDxuaWtvbGFzLnppbW1lcm1hbm5AdG9yY2htb2JpbGUuY29t PgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFsZXhleSBQcm9za3VyeWFrb3YuCkluZGV4OiBXZWJD b3JlL2RvbS9Xb3JrZXJUaHJlYWQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvZG9tL1dvcmtl clRocmVhZC5jcHAJKHJldmlzaW9uIDQwMDg2KQorKysgV2ViQ29yZS9kb20vV29ya2VyVGhyZWFk LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTAyLDYgKzEwMiwxNCBAQCB2b2lkKiBXb3JrZXJUaHJl YWQ6OndvcmtlclRocmVhZCgpCiB7CiAgICAgewogICAgICAgICBNdXRleExvY2tlciBsb2NrKG1f dGhyZWFkQ3JlYXRpb25NdXRleCk7CisgICAgICAgIGlmIChtX21lc3NhZ2VRdWV1ZS5raWxsZWQo KSkgeworICAgICAgICAgICAgLy8gVGhlIHdvcmtlciB3YXMgdGVybWluYXRlZCBiZWZvcmUgdGhl IHRocmVhZCBoYWQgYSBjaGFuY2UgdG8gcnVuLiBTaW5jZSBmb3JiaWRFeGVjdXRpb24oKSBjb3Vs ZG4ndCBiZSBjYWxsZWQsCisgICAgICAgICAgICAvLyB3ZSBuZWVkIHRvIGJhaWwgb3V0IHF1aWNr bHkgdG8gYXZvaWQgZXZhbHVhdGluZyB0aGUgc2NyaXB0LgorICAgICAgICAgICAgVGhyZWFkSWRl bnRpZmllciB0aHJlYWRJRCA9IG1fdGhyZWFkSUQ7CisgICAgICAgICAgICBtX3N0YXJ0dXBEYXRh LmNsZWFyKCk7CisgICAgICAgICAgICBkZXRhY2hUaHJlYWQodGhyZWFkSUQpOworICAgICAgICAg ICAgcmV0dXJuIDA7CisgICAgICAgIH0KICAgICAgICAgbV93b3JrZXJDb250ZXh0ID0gV29ya2Vy Q29udGV4dDo6Y3JlYXRlKG1fc3RhcnR1cERhdGEtPm1fc2NyaXB0VVJMLCBtX3N0YXJ0dXBEYXRh LT5tX3VzZXJBZ2VudCwgdGhpcyk7CiAgICAgfQogCg== 26924 2009-01-22 00:27:04 -0800 2009-01-22 18:26:15 -0800 Alternative patch EarlyTerminate2.txt text/plain 1517 ap SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0MDExNykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMDktMDEtMjEgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEB3ZWJr aXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzQ1OQorICAgICAgICBX b3JrZXJzIGFyZSBub3QgcHJvcGVybHkgdGVybWluYXRlZCBpZiBleGVjdXRpb24gaGFzbid0IGJl Z3VuIHlldAorCisgICAgICAgIERvZXNuJ3QgYWZmZWN0IG9ic2VydmFibGUgYmVoYXZpb3IsIHNv IHRlc3QgY2FzZSBpcyBub3QgcG9zc2libGUuCisKKyAgICAgICAgKiBkb20vV29ya2VyVGhyZWFk LmNwcDogKFdlYkNvcmU6OldvcmtlclRocmVhZDo6d29ya2VyVGhyZWFkKTogQ2FsbCBmb3JiaWRF eGVjdXRpb24oKSBpZgorICAgICAgICBpdCBjb3VsZG4ndCBiZSBjYWxsZWQgZWFybGllci4KKwog MjAwOS0wMS0yMSAgRGF2aWQgSHlhdHQgIDxoeWF0dEBhcHBsZS5jb20+CiAKICAgICAgICAgRml4 IE5vZGUncyByZW5kZXJCb3goKSBtZXRob2Qgb24gV2luZG93cy4KSW5kZXg6IFdlYkNvcmUvZG9t L1dvcmtlclRocmVhZC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9kb20vV29ya2VyVGhyZWFk LmNwcAkocmV2aXNpb24gNDAxMTcpCisrKyBXZWJDb3JlL2RvbS9Xb3JrZXJUaHJlYWQuY3BwCSh3 b3JraW5nIGNvcHkpCkBAIC0xMDMsNiArMTAzLDExIEBAIHZvaWQqIFdvcmtlclRocmVhZDo6d29y a2VyVGhyZWFkKCkKICAgICB7CiAgICAgICAgIE11dGV4TG9ja2VyIGxvY2sobV90aHJlYWRDcmVh dGlvbk11dGV4KTsKICAgICAgICAgbV93b3JrZXJDb250ZXh0ID0gV29ya2VyQ29udGV4dDo6Y3Jl YXRlKG1fc3RhcnR1cERhdGEtPm1fc2NyaXB0VVJMLCBtX3N0YXJ0dXBEYXRhLT5tX3VzZXJBZ2Vu dCwgdGhpcyk7CisgICAgICAgIGlmIChtX21lc3NhZ2VRdWV1ZS5raWxsZWQoKSkgeworICAgICAg ICAgICAgLy8gVGhlIHdvcmtlciB3YXMgdGVybWluYXRlZCBiZWZvcmUgdGhlIHRocmVhZCBoYWQg YSBjaGFuY2UgdG8gcnVuLiBTaW5jZSB0aGUgY29udGV4dCBkaWRuJ3QgZXhpc3QgeWV0LCAKKyAg ICAgICAgICAgIC8vIGZvcmJpZEV4ZWN1dGlvbigpIGNvdWxkbid0IGJlIGNhbGxlZCBmcm9tIHN0 b3AoKS4KKyAgICAgICAgICAgbV93b3JrZXJDb250ZXh0LT5zY3JpcHQoKS0+Zm9yYmlkRXhlY3V0 aW9uKCk7CisgICAgICAgIH0KICAgICB9CiAKICAgICBXb3JrZXJTY3JpcHRDb250cm9sbGVyKiBz Y3JpcHQgPSBtX3dvcmtlckNvbnRleHQtPnNjcmlwdCgpOwo=