234574 2021-12-21 13:35:29 -0800 REGRESSION (12/21/2021): [iOS] TestWebKitAPI.WebKit.AddAndRemoveDataDetectors is consistently failing 2021-12-21 19:27:15 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ryanhaddad wenson_hsieh akeerthi megan_gardner thorton webkit-bot-watchers-bugzilla webkit-bug-importer wenson_hsieh oldest_to_newest 1826096 0 ryanhaddad 2021-12-21 13:35:29 -0800 TestWebKitAPI.WebKit.AddAndRemoveDataDetectors is consistently failing on iOS bots as of r287296 TestWebKitAPI.WebKit.AddAndRemoveDataDetectors 2021-12-21 05:31:26.975 TestWebKitAPI[11559:16050223] Writing analzed variants. /Volumes/Data/worker/ios-simulator-15-release/build/Tools/TestWebKitAPI/cocoa/TestWKWebView.mm:204 Expected equality of these values: count Which is: 5 [self stringByEvaluatingJavaScript:script].integerValue Which is: 4 https://results.webkit.org/?suite=api-tests&test=TestWebKitAPI.WebKit.AddAndRemoveDataDetectors 1826097 1 webkit-bug-importer 2021-12-21 13:35:42 -0800 <rdar://problem/86782559> 1826098 2 wenson_hsieh 2021-12-21 13:37:15 -0800 Regression point seems rather unlikely, but I can take a look... 1826171 3 wenson_hsieh 2021-12-21 17:31:54 -0800 ``` TEST(WebKit, AddAndRemoveDataDetectors) { … EXPECT_WK_STREQ("December 21, 2021", results[1].value); ``` 🤦🏻‍♂️ I should be able to fix this by just bumping the year to *much* later date.. 1826176 4 447768 wenson_hsieh 2021-12-21 17:48:49 -0800 Created attachment 447768 Patch 1826193 5 ap 2021-12-21 18:41:49 -0800 No one we care about will live to suffer from this in 2099? ;) 1826196 6 447768 wenson_hsieh 2021-12-21 19:11:17 -0800 Comment on attachment 447768 Patch (In reply to Alexey Proskuryakov from comment #5) > No one we care about will live to suffer from this in 2099? ;) 😅 1826197 7 ews-feeder 2021-12-21 19:27:12 -0800 Committed r287340 (245482@main): <https://commits.webkit.org/245482@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 447768. 447768 2021-12-21 17:48:49 -0800 2021-12-21 19:27:14 -0800 Patch bug-234574-20211221174848.patch text/plain 2490 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjg3MzIxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggN2JjMzM5YWIwOTQxNGE5NzcyM2NiMWM3MTJjOGQyNTQ2 NTBhMGQxMy4uNTI1MDM2ODQ4ZjY4NmY3ZTdmNGY2NWQ4OWFjNTdiY2MyMjU4ZjEzNyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDIxLTEyLTIxICBXZW5zb24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgor CisgICAgICAgIFJFR1JFU1NJT04gKDEyLzIxLzIwMjEpOiBbaU9TXSBUZXN0V2ViS2l0QVBJLldl YktpdC5BZGRBbmRSZW1vdmVEYXRhRGV0ZWN0b3JzIGlzIGNvbnNpc3RlbnRseSBmYWlsaW5nCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzQ1NzQKKyAg ICAgICAgcmRhcjovLzg2NzgyNTU5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgVGhpcyB0ZXN0IGJlZ2FuIGZhaWxpbmcgdG9kYXkgZHVlIHRvIERhdGFE ZXRlY3RvcnMgbm8gbG9uZ2VyIHJlY29nbml6aW5nICJEZWNlbWJlciAyMSwgMjAyMSIgYXMgYSB2 YWxpZCBkYXRlIGluCisgICAgICAgIHRoZSBmdXR1cmUuIEF2b2lkIHRoaXMgcHJvYmxlbSAoYXQg bGVhc3QsIHVudGlsIHRoZSBuZXh0IGNlbnR1cnkpIGJ5IGFkanVzdGluZyB0aGlzIGRhdGUgdG8g YmUgbXVjaCBsYXRlci4KKworICAgICAgICAqIFRlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29j b2EvRGF0YURldGVjdGlvbi5tbToKKyAgICAgICAgKFRFU1QpOgorICAgICAgICAqIFRlc3RXZWJL aXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvZGF0YS1kZXRlY3RvcnMuaHRtbDoKKwogMjAyMS0xMi0y MSAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNlbkB3ZWJraXQub3JnPgogCiAgICAgICAg IEFTU0VSVCBOT1QgUkVBQ0hFRCB1bmRlciBXZWJLaXQ6OkRhZW1vbjo6Q29ubmVjdGlvblRvTWFj aFNlcnZpY2Ugc2VlbiB3aXRoIFRlc3RXZWJLaXRBUEkuV2ViUHVzaEQuQmFzaWNDb21tdW5pY2F0 aW9uIGFuZCBQZXJtaXNzaW9uTWFuYWdlbWVudApkaWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFdlYktp dEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9EYXRhRGV0ZWN0aW9uLm1tIGIvVG9vbHMvVGVzdFdlYktp dEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9EYXRhRGV0ZWN0aW9uLm1tCmluZGV4IDdkNGEyMzc1NDM4 NDk1ZmRlNmM1ZmVkZjY4ODRlZjA4MTYwN2VkZjEuLjNjMjM5MWFiNDg5NDE2MjRlMTU2MDJmYTQ1 Y2Y1MGFjNzA2MDdmZTIgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2Vi S2l0Q29jb2EvRGF0YURldGVjdGlvbi5tbQorKysgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3Rz L1dlYktpdENvY29hL0RhdGFEZXRlY3Rpb24ubW0KQEAgLTE0Miw3ICsxNDIsNyBAQCBURVNUKFdl YktpdCwgQWRkQW5kUmVtb3ZlRGF0YURldGVjdG9ycykKICAgICAgICAgRVhQRUNUX1RSVUUoW3Jl c3VsdHNbMF0udmFsdWUgY29udGFpbnNTdHJpbmc6QCIyIEFwcGxlIFBhcmsgV2F5LCBDdXBlcnRp bm8gOTUwMTQiXSk7CiAgICAgICAgIEVYUEVDVF9XS19TVFJFUSgiU2lnbmF0dXJlQmxvY2siLCBy ZXN1bHRzWzBdLnR5cGUpOwogICAgICAgICBFWFBFQ1RfV0tfU1RSRVEoIkRhdGUiLCByZXN1bHRz WzFdLnR5cGUpOwotICAgICAgICBFWFBFQ1RfV0tfU1RSRVEoIkRlY2VtYmVyIDIxLCAyMDIxIiwg cmVzdWx0c1sxXS52YWx1ZSk7CisgICAgICAgIEVYUEVDVF9XS19TVFJFUSgiRGVjZW1iZXIgMjEs IDIwOTkiLCByZXN1bHRzWzFdLnZhbHVlKTsKICAgICAgICAgRVhQRUNUX1dLX1NUUkVRKCJGbGln aHRJbmZvcm1hdGlvbiIsIHJlc3VsdHNbMl0udHlwZSk7CiAgICAgICAgIEVYUEVDVF9XS19TVFJF USgiQUM3ODAiLCByZXN1bHRzWzJdLnZhbHVlKTsKIApkaWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFdl YktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9kYXRhLWRldGVjdG9ycy5odG1sIGIvVG9vbHMvVGVz dFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9kYXRhLWRldGVjdG9ycy5odG1sCmluZGV4IGY5 Zjg3YWY0Zjg4ODllYjc0NDQ0YjU5MDBlNjBhMTlmZTcxZTg1ZDUuLjZlNDVjMWM4NWJjZjQ1NmJj YmExNjVhNzU5YzlkNzJkNzYyZTBjYWIgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkv VGVzdHMvV2ViS2l0Q29jb2EvZGF0YS1kZXRlY3RvcnMuaHRtbAorKysgYi9Ub29scy9UZXN0V2Vi S2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL2RhdGEtZGV0ZWN0b3JzLmh0bWwKQEAgLTE4LDcgKzE4 LDcgQEAKIDwvdHI+CiA8dHI+CiAgICAgPHRkPkNhbGVuZGFyIGV2ZW50PC90ZD4KLSAgICA8dGQ+ RGVjZW1iZXIgMjEsIDIwMjE8L3RkPgorICAgIDx0ZD5EZWNlbWJlciAyMSwgMjA5OTwvdGQ+CiA8 L3RyPgogPHRyPgogICAgIDx0ZD5GbGlnaHQgbnVtYmVyPC90ZD4K