234570 2021-12-21 11:01:41 -0800 Web Inspector: Assertion Failed adding event listener in CSSPropertyNameCompletions.prototype._updateValuesWithLatestCSSVariablesIfNeeded 2021-12-21 17:40:43 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 pangle pangle ews-watchlist hi inspector-bugzilla-changes webkit-bug-importer oldest_to_newest 1826056 0 pangle 2021-12-21 11:01:41 -0800 From Devin: [Error] Assertion Failed (4) DOMNodeStyles "dom-node-styles-needs-refresh" function _handleNodesStylesNeedsRefresh(event) { this._needsVariablesFromInspectedNode = true; } CSSPropertyNameCompletions addEventListener (Object.js:53) _updateValuesWithLatestCSSVariablesIfNeeded (CSSPropertyNameCompletions.js:90) executeQuery (CSSPropertyNameCompletions.js:59) (anonymous function) (CSSKeywordCompletions.js:48) _nameCompletionDataProvider _updateCompletions (SpreadsheetTextField.js:436) _handleInput (SpreadsheetTextField.js:423) _handleInput Currently we continually add event listeners every time we update the completions. We should only add/remove this listener on a node changing. 1826057 1 webkit-bug-importer 2021-12-21 11:01:52 -0800 <rdar://problem/86776737> 1826059 2 447736 pangle 2021-12-21 11:07:08 -0800 Created attachment 447736 Patch v1.0 1826060 3 447736 hi 2021-12-21 11:12:18 -0800 Comment on attachment 447736 Patch v1.0 r=me, this is perhaps maybe slightly more inefficient cause we're now listening for `WI.DOMNodeStyles.Event.NeedsRefresh` even if we haven't called `allCSSVariables` yet, but I think it's fine 1826173 4 ews-feeder 2021-12-21 17:40:40 -0800 Committed r287338 (245480@main): <https://commits.webkit.org/245480@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 447736. 447736 2021-12-21 11:07:08 -0800 2021-12-21 17:40:41 -0800 Patch v1.0 bug-234570-20211221110707.patch text/plain 3298 pangle U3VidmVyc2lvbiBSZXZpc2lvbjogMjg3MjYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBi MjQ0NmI2YjhhODU4N2FkY2I3MmE1M2U4MDI4MTA3NjViMGRlOGJlLi40MjNiYjExMDRjNWM1YjAy YWFjMGEwOWZhZmYyYTQ3YWZmZDQxNTk5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOSBAQAorMjAyMS0xMi0yMSAgUGF0cmljayBBbmdsZSAgPHBhbmdsZUBhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogQXNzZXJ0aW9uIEZhaWxlZCBhZGRpbmcgZXZlbnQg bGlzdGVuZXIgaW4gQ1NTUHJvcGVydHlOYW1lQ29tcGxldGlvbnMucHJvdG90eXBlLl91cGRhdGVW YWx1ZXNXaXRoTGF0ZXN0Q1NTVmFyaWFibGVzSWZOZWVkZWQKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNDU3MAorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZGluZyBhbiBldmVudCBsaXN0ZW5lciB0byBs aXN0ZW4gZm9yIHN0eWxlIGNoYW5nZXMgZXZlcnkgdGltZSB3ZSB1cGRhdGUgdGhlIGxpc3Qgb2Yg Q1NTIHZhcmlhYmxlcyBpc24ndCBxdWl0ZQorICAgICAgICBjb3JyZWN0IGJlY2F1c2UgaXQgbWVh bnMgd2UgbWF5IGF0dGVtcHQgdG8gYWRkIHRoZSBldmVudCBsaXN0ZW5lciBtdWx0aXBsZSB0aW1l cy4gSW5zdGVhZCwgdGhpcyBzaG91bGQgYmUgZG9uZQorICAgICAgICBpbiByZXNwb25zZSB0byB0 aGUgSW5zcGVjdGVkTm9kZUNoYW5nZWQgZXZlbnQgZGlyZWN0bHkgdG8gYXZvaWQgYWRkaW5nIHRo ZSBldmVudCBsaXN0ZW5lciBtdWx0aXBsZSB0aW1lIHRvIHRoZQorICAgICAgICBzYW1lIERPTSBu b2RlLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9Nb2RlbHMvQ1NTUHJvcGVydHlOYW1lQ29t cGxldGlvbnMuanM6CisgICAgICAgIChXSS5DU1NQcm9wZXJ0eU5hbWVDb21wbGV0aW9ucy5wcm90 b3R5cGUuX3VwZGF0ZVZhbHVlc1dpdGhMYXRlc3RDU1NWYXJpYWJsZXNJZk5lZWRlZCk6CisgICAg ICAgIChXSS5DU1NQcm9wZXJ0eU5hbWVDb21wbGV0aW9ucy5wcm90b3R5cGUuX2hhbmRsZUluc3Bl Y3RlZE5vZGVDaGFuZ2VkKToKKwogMjAyMS0xMi0xNiAgTWljaGFlbCBTYWJvZmYgIDxtc2Fib2Zm QGFwcGxlLmNvbT4KIAogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjM0MTczCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9Nb2RlbHMvQ1NTUHJvcGVydHlOYW1lQ29tcGxldGlvbnMuanMgYi9Tb3VyY2UvV2ViSW5z cGVjdG9yVUkvVXNlckludGVyZmFjZS9Nb2RlbHMvQ1NTUHJvcGVydHlOYW1lQ29tcGxldGlvbnMu anMKaW5kZXggNjEzZTVmOWE0ZTY0ZWQ1MGI2Y2U5OTlhNmI3M2ViMGE4YzMxODhjYi4uY2QzN2Ri ZWE0YmIwNDNlNWI5YTg4MjRmNTlkZjlmOTA0MDEwZjdjMyAxMDA2NDQKLS0tIGEvU291cmNlL1dl Ykluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTW9kZWxzL0NTU1Byb3BlcnR5TmFtZUNvbXBsZXRp b25zLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVscy9D U1NQcm9wZXJ0eU5hbWVDb21wbGV0aW9ucy5qcwpAQCAtODYsMTAgKzg2LDcgQEAgV0kuQ1NTUHJv cGVydHlOYW1lQ29tcGxldGlvbnMgPSBjbGFzcyBDU1NQcm9wZXJ0eU5hbWVDb21wbGV0aW9ucyBl eHRlbmRzIFdJLkNTU0MKICAgICAgICAgICAgIHJldHVybjsKICAgICAgICAgfQogCi0gICAgICAg IGxldCBub2RlU3R5bGVzID0gV0kuY3NzTWFuYWdlci5zdHlsZXNGb3JOb2RlKFdJLmRvbU1hbmFn ZXIuaW5zcGVjdGVkTm9kZSk7Ci0gICAgICAgIG5vZGVTdHlsZXMuYWRkRXZlbnRMaXN0ZW5lcihX SS5ET01Ob2RlU3R5bGVzLkV2ZW50Lk5lZWRzUmVmcmVzaCwgdGhpcy5faGFuZGxlTm9kZXNTdHls ZXNOZWVkc1JlZnJlc2gsIHRoaXMpOwotCi0gICAgICAgIGxldCB2YWx1ZXMgPSBBcnJheS5mcm9t KG5vZGVTdHlsZXMuYWxsQ1NTVmFyaWFibGVzKTsKKyAgICAgICAgbGV0IHZhbHVlcyA9IEFycmF5 LmZyb20oV0kuY3NzTWFuYWdlci5zdHlsZXNGb3JOb2RlKFdJLmRvbU1hbmFnZXIuaW5zcGVjdGVk Tm9kZSkuYWxsQ1NTVmFyaWFibGVzKTsKICAgICAgICAgdmFsdWVzLnB1c2hBbGwodGhpcy5fY2Fj aGVkU29ydGVkUHJvcGVydHlOYW1lcyk7CiAgICAgICAgIHRoaXMucmVwbGFjZVZhbHVlcyh2YWx1 ZXMpOwogCkBAIC05OCwxMyArOTUsMTIgQEAgV0kuQ1NTUHJvcGVydHlOYW1lQ29tcGxldGlvbnMg PSBjbGFzcyBDU1NQcm9wZXJ0eU5hbWVDb21wbGV0aW9ucyBleHRlbmRzIFdJLkNTU0MKIAogICAg IF9oYW5kbGVJbnNwZWN0ZWROb2RlQ2hhbmdlZChldmVudCkKICAgICB7Ci0gICAgICAgIGlmICh0 aGlzLl9uZWVkc1ZhcmlhYmxlc0Zyb21JbnNwZWN0ZWROb2RlIHx8ICFldmVudC5kYXRhLmxhc3RJ bnNwZWN0ZWROb2RlKQotICAgICAgICAgICAgcmV0dXJuOwotCiAgICAgICAgIHRoaXMuX25lZWRz VmFyaWFibGVzRnJvbUluc3BlY3RlZE5vZGUgPSB0cnVlOwogCi0gICAgICAgIGxldCBub2RlU3R5 bGVzID0gV0kuY3NzTWFuYWdlci5zdHlsZXNGb3JOb2RlKGV2ZW50LmRhdGEubGFzdEluc3BlY3Rl ZE5vZGUpOwotICAgICAgICBub2RlU3R5bGVzLnJlbW92ZUV2ZW50TGlzdGVuZXIoV0kuRE9NTm9k ZVN0eWxlcy5FdmVudC5OZWVkc1JlZnJlc2gsIHRoaXMuX2hhbmRsZU5vZGVzU3R5bGVzTmVlZHNS ZWZyZXNoLCB0aGlzKTsKKyAgICAgICAgaWYgKGV2ZW50LmRhdGEubGFzdEluc3BlY3RlZE5vZGUp CisgICAgICAgICAgICBXSS5jc3NNYW5hZ2VyLnN0eWxlc0Zvck5vZGUoZXZlbnQuZGF0YS5sYXN0 SW5zcGVjdGVkTm9kZSkucmVtb3ZlRXZlbnRMaXN0ZW5lcihXSS5ET01Ob2RlU3R5bGVzLkV2ZW50 Lk5lZWRzUmVmcmVzaCwgdGhpcy5faGFuZGxlTm9kZXNTdHlsZXNOZWVkc1JlZnJlc2gsIHRoaXMp OworCisgICAgICAgIFdJLmNzc01hbmFnZXIuc3R5bGVzRm9yTm9kZShXSS5kb21NYW5hZ2VyLmlu c3BlY3RlZE5vZGUpLmFkZEV2ZW50TGlzdGVuZXIoV0kuRE9NTm9kZVN0eWxlcy5FdmVudC5OZWVk c1JlZnJlc2gsIHRoaXMuX2hhbmRsZU5vZGVzU3R5bGVzTmVlZHNSZWZyZXNoLCB0aGlzKTsKICAg ICB9CiAKICAgICBfaGFuZGxlTm9kZXNTdHlsZXNOZWVkc1JlZnJlc2goZXZlbnQpCg==