234544 2021-12-20 20:44:12 -0800 MSVC reports "X86Assembler.h(338): warning C5054: operator '+': deprecated between enumerations of different types" with /std:c++20 2022-01-04 23:01:02 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED WONTFIX InRadar P2 Normal --- 1 fujii fujii ews-watchlist keith_miller mark.lam msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1825862 0 fujii 2021-12-20 20:44:12 -0800 MSVC reports "X86Assembler.h(338): warning C5054: operator '+': deprecated between enumerations of different types" with /std:c++20 > Source\JavaScriptCore\assembler\X86Assembler.h(338): warning C5054: operator '+': deprecated between enumerations of different types > Source\JavaScriptCore\assembler\X86Assembler.h(343): warning C5054: operator '+': deprecated between enumerations of different types > Source\JavaScriptCore\assembler\X86Assembler.h(348): warning C5054: operator '+': deprecated between enumerations of different types > Source\JavaScriptCore\jit\ICStats.h(153): warning C5054: operator '+': deprecated between enumerations of different types > Source\JavaScriptCore\jit\ICStats.h(154): warning C5054: operator '+': deprecated between enumerations of different types 1825864 1 447683 fujii 2021-12-20 20:48:31 -0800 Created attachment 447683 Patch 1827026 2 webkit-bug-importer 2021-12-27 20:45:18 -0800 <rdar://problem/86948909> 1828189 3 fujii 2022-01-04 23:01:02 -0800 MSVC /std:c++20 switch introduces a lot of warning C5054 for WebKit. I'm going to suppress it in Bug 233448. Closed this ticket as WONTFIX. 447683 2021-12-20 20:48:31 -0800 2021-12-20 22:17:04 -0800 Patch bug-234544-20211221134829.patch text/plain 3183 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjg3Mjk2CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA3 ZmNkZGFmOGRlMTQ1Y2E5NGQ1YWZkMDQyMjljMjkyMjIxNjdlN2QyLi5mZDFkYjA0NmNkZjMyMmQ3 MGYzNWM0MWI3NzhlNTIwOWJiZmM0MmIwIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMSBAQAorMjAyMS0xMi0yMCAgRnVqaWkgSGlyb25vcmkgIDxIaXJvbm9yaS5GdWppaUBz b255LmNvbT4KKworICAgICAgICBNU1ZDIHJlcG9ydHMgIlg4NkFzc2VtYmxlci5oKDMzOCk6IHdh cm5pbmcgQzUwNTQ6IG9wZXJhdG9yICcrJzogZGVwcmVjYXRlZCBiZXR3ZWVuIGVudW1lcmF0aW9u cyBvZiBkaWZmZXJlbnQgdHlwZXMiIHdpdGggL3N0ZDpjKysyMAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjM0NTQ0CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgPiBTb3VyY2VcSmF2YVNjcmlwdENvcmVcYXNz ZW1ibGVyXFg4NkFzc2VtYmxlci5oKDMzOCk6IHdhcm5pbmcgQzUwNTQ6IG9wZXJhdG9yICcrJzog ZGVwcmVjYXRlZCBiZXR3ZWVuIGVudW1lcmF0aW9ucyBvZiBkaWZmZXJlbnQgdHlwZXMKKyAgICAg ICAgPiBTb3VyY2VcSmF2YVNjcmlwdENvcmVcaml0XElDU3RhdHMuaCgxNTMpOiB3YXJuaW5nIEM1 MDU0OiBvcGVyYXRvciAnKyc6IGRlcHJlY2F0ZWQgYmV0d2VlbiBlbnVtZXJhdGlvbnMgb2YgZGlm ZmVyZW50IHR5cGVzCisKKyAgICAgICAgKiBhc3NlbWJsZXIvWDg2QXNzZW1ibGVyLmg6CisgICAg ICAgIChKU0M6Olg4NkFzc2VtYmxlcjo6Y21vdmNjKToKKyAgICAgICAgKEpTQzo6WDg2QXNzZW1i bGVyOjpqY2NSZWwzMik6CisgICAgICAgIChKU0M6Olg4NkFzc2VtYmxlcjo6c2V0Y2NPcGNvZGUp OgorICAgICAgICAqIGppdC9JQ1N0YXRzLmg6CisgICAgICAgIChKU0M6OklDRXZlbnQ6Omhhc2gg Y29uc3QpOgorICAgICAgICBBZGRlZCBjYXN0aW5nLgorCiAyMDIxLTEyLTE5ICBSb3NzIEtpcnNs aW5nICA8cm9zcy5raXJzbGluZ0Bzb255LmNvbT4KIAogICAgICAgICBbSlNDXSBPcFBvdyBzaG91 bGQgaGF2ZSBhICJzbWFsbCBpbnQgZXhwb25lbnQiIGZhc3QgcGF0aCBhdCBsb3dlciB0aWVycwpk aWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9YODZBc3NlbWJsZXIu aCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvWDg2QXNzZW1ibGVyLmgKaW5kZXgg NzE0MTM2MzUzNWQ0NTA2OTMyNDU1OWJhYWY0MDI1YTY2YWI3YTkxZi4uOTE2MWU0YWQ1NDk4YmIy ZTljNmQxMjE5NTI3ODZjNDg1ODUxNWMwZCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRD b3JlL2Fzc2VtYmxlci9YODZBc3NlbWJsZXIuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv YXNzZW1ibGVyL1g4NkFzc2VtYmxlci5oCkBAIC0zMzUsMTcgKzMzNSwxNyBAQCBwcml2YXRlOgog ICAgIAogICAgIFR3b0J5dGVPcGNvZGVJRCBjbW92Y2MoQ29uZGl0aW9uIGNvbmQpCiAgICAgewot ICAgICAgICByZXR1cm4gKFR3b0J5dGVPcGNvZGVJRCkoT1AyX0NNT1ZDQyArIGNvbmQpOworICAg ICAgICByZXR1cm4gKFR3b0J5dGVPcGNvZGVJRCkoT1AyX0NNT1ZDQyArIChUd29CeXRlT3Bjb2Rl SUQpY29uZCk7CiAgICAgfQogCiAgICAgVHdvQnl0ZU9wY29kZUlEIGpjY1JlbDMyKENvbmRpdGlv biBjb25kKQogICAgIHsKLSAgICAgICAgcmV0dXJuIChUd29CeXRlT3Bjb2RlSUQpKE9QMl9KQ0Nf cmVsMzIgKyBjb25kKTsKKyAgICAgICAgcmV0dXJuIChUd29CeXRlT3Bjb2RlSUQpKE9QMl9KQ0Nf cmVsMzIgKyAoVHdvQnl0ZU9wY29kZUlEKWNvbmQpOwogICAgIH0KIAogICAgIFR3b0J5dGVPcGNv ZGVJRCBzZXRjY09wY29kZShDb25kaXRpb24gY29uZCkKICAgICB7Ci0gICAgICAgIHJldHVybiAo VHdvQnl0ZU9wY29kZUlEKShPUF9TRVRDQyArIGNvbmQpOworICAgICAgICByZXR1cm4gKFR3b0J5 dGVPcGNvZGVJRCkoT1BfU0VUQ0MgKyAoVHdvQnl0ZU9wY29kZUlEKWNvbmQpOwogICAgIH0KIAog ICAgIHR5cGVkZWYgZW51bSB7CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0 L0lDU3RhdHMuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSUNTdGF0cy5oCmluZGV4IDkx YjNiMzE1NTEwZGE2ODI0YjNjOTYzNDEwZTMzNmQ5NTg5YWJjN2MuLjVkMGIyZjMxY2M0MWZlMjJl ZjJhOWQwOWEyOWY2YmE0OGE5MTQzYTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9qaXQvSUNTdGF0cy5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSUNTdGF0cy5o CkBAIC0xNTAsOCArMTUwLDggQEAgcHVibGljOgogICAgIHVuc2lnbmVkIGhhc2goKSBjb25zdAog ICAgIHsKICAgICAgICAgaWYgKG1fcHJvcGVydHlOYW1lLmlzTnVsbCgpKQotICAgICAgICAgICAg cmV0dXJuIG1fa2luZCArIG1fcHJvcGVydHlMb2NhdGlvbiArIFdURjo6UHRySGFzaDxjb25zdCBD bGFzc0luZm8qPjo6aGFzaChtX2NsYXNzSW5mbyk7Ci0gICAgICAgIHJldHVybiBtX2tpbmQgKyBt X3Byb3BlcnR5TG9jYXRpb24gKyBXVEY6OlB0ckhhc2g8Y29uc3QgQ2xhc3NJbmZvKj46Omhhc2go bV9jbGFzc0luZm8pICsgU3RyaW5nSGFzaDo6aGFzaChtX3Byb3BlcnR5TmFtZS5zdHJpbmcoKSk7 CisgICAgICAgICAgICByZXR1cm4gc3RhdGljX2Nhc3Q8dW5zaWduZWQ+KG1fa2luZCkgKyBzdGF0 aWNfY2FzdDx1bnNpZ25lZD4obV9wcm9wZXJ0eUxvY2F0aW9uKSArIFdURjo6UHRySGFzaDxjb25z dCBDbGFzc0luZm8qPjo6aGFzaChtX2NsYXNzSW5mbyk7CisgICAgICAgIHJldHVybiBzdGF0aWNf Y2FzdDx1bnNpZ25lZD4obV9raW5kKSArIHN0YXRpY19jYXN0PHVuc2lnbmVkPihtX3Byb3BlcnR5 TG9jYXRpb24pICsgV1RGOjpQdHJIYXNoPGNvbnN0IENsYXNzSW5mbyo+OjpoYXNoKG1fY2xhc3NJ bmZvKSArIFN0cmluZ0hhc2g6Omhhc2gobV9wcm9wZXJ0eU5hbWUuc3RyaW5nKCkpOwogICAgIH0K ICAgICAKICAgICBib29sIGlzSGFzaFRhYmxlRGVsZXRlZFZhbHVlKCkgY29uc3QK