234537 2021-12-20 16:10:09 -0800 [LFC][IFC] Move enclosing line geometry computation to a dedicated function 2021-12-21 10:01:22 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1825797 0 zalan 2021-12-20 16:10:09 -0800 to make room for the visual vs. logical geometry logic. 1825799 1 447659 zalan 2021-12-20 16:11:59 -0800 Created attachment 447659 Patch 1826033 2 ews-feeder 2021-12-21 10:00:20 -0800 Committed r287320 (245470@main): <https://commits.webkit.org/245470@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 447659. 1826034 3 webkit-bug-importer 2021-12-21 10:01:22 -0800 <rdar://problem/86773892> 447659 2021-12-20 16:11:59 -0800 2021-12-21 10:00:22 -0800 Patch bug-234537-20211220161158.patch text/plain 6232 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjg3MjYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWQ2Njk1MjYwMzA2MmFj N2EyMTFlYjYxOThiYzRjMzM2M2Q0OTA2YS4uZmE2MjBkOGZiZDRmYzYyNTNlODEzOTE3MDUxNWE5 ZTY1MGNmNjc2YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIxLTEyLTIwICBBbGFu IEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbTEZDXVtJRkNdIE1vdmUgZW5j bG9zaW5nIGxpbmUgZ2VvbWV0cnkgY29tcHV0YXRpb24gdG8gYSBkZWRpY2F0ZWQgZnVuY3Rpb24K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNDUzNwor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogbGF5b3V0 L2Zvcm1hdHRpbmdDb250ZXh0cy9pbmxpbmUvZGlzcGxheS9JbmxpbmVEaXNwbGF5Q29udGVudEJ1 aWxkZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TGF5b3V0OjpJbmxpbmVEaXNwbGF5Q29udGVu dEJ1aWxkZXI6OnByb2Nlc3NCaWRpQ29udGVudCk6CisgICAgICAgICogbGF5b3V0L2Zvcm1hdHRp bmdDb250ZXh0cy9pbmxpbmUvZGlzcGxheS9JbmxpbmVEaXNwbGF5TGluZUJ1aWxkZXIuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6TGF5b3V0OjpJbmxpbmVEaXNwbGF5TGluZUJ1aWxkZXI6OmNvbGxl Y3RFbmNsb3NpbmdMaW5lR2VvbWV0cnkgY29uc3QpOgorICAgICAgICAoV2ViQ29yZTo6TGF5b3V0 OjpJbmxpbmVEaXNwbGF5TGluZUJ1aWxkZXI6OmJ1aWxkIGNvbnN0KToKKyAgICAgICAgKFdlYkNv cmU6OkxheW91dDo6SW5saW5lRGlzcGxheUxpbmVCdWlsZGVyOjpidWlsZCk6IERlbGV0ZWQuCisg ICAgICAgICogbGF5b3V0L2Zvcm1hdHRpbmdDb250ZXh0cy9pbmxpbmUvZGlzcGxheS9JbmxpbmVE aXNwbGF5TGluZUJ1aWxkZXIuaDoKKwogMjAyMS0xMi0yMCAgQWxhbiBCdWp0YXMgIDx6YWxhbkBh cHBsZS5jb20+CiAKICAgICAgICAgW0xGQ11bSUZDXSBTdGFydCB1c2luZyBEaXNwbGF5OjpMaW5l IGdlb21ldHJ5IGluIElubGluZURpc3BsYXlDb250ZW50QnVpbGRlcgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvbGF5b3V0L2Zvcm1hdHRpbmdDb250ZXh0cy9pbmxpbmUvZGlzcGxheS9Jbmxp bmVEaXNwbGF5TGluZUJ1aWxkZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2Zvcm1hdHRp bmdDb250ZXh0cy9pbmxpbmUvZGlzcGxheS9JbmxpbmVEaXNwbGF5TGluZUJ1aWxkZXIuY3BwCmlu ZGV4IDJlN2NmMzI3NzllMGFkYTU3OWEyYjRjNTIxNTJkMDkwNWExOTA0YzAuLjI2MWM5NTFjNTE5 MDczYmU2NzBkOWJiNWY3ZmM1ZmNkYzMxNmJkOTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L2xheW91dC9mb3JtYXR0aW5nQ29udGV4dHMvaW5saW5lL2Rpc3BsYXkvSW5saW5lRGlzcGxheUxp bmVCdWlsZGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvZm9ybWF0dGluZ0NvbnRl eHRzL2lubGluZS9kaXNwbGF5L0lubGluZURpc3BsYXlMaW5lQnVpbGRlci5jcHAKQEAgLTM1LDE5 ICszNSwxMCBAQCBJbmxpbmVEaXNwbGF5TGluZUJ1aWxkZXI6OklubGluZURpc3BsYXlMaW5lQnVp bGRlcihjb25zdCBJbmxpbmVGb3JtYXR0aW5nQ29udGV4dAogewogfQogCi1JbmxpbmVEaXNwbGF5 OjpMaW5lIElubGluZURpc3BsYXlMaW5lQnVpbGRlcjo6YnVpbGQoY29uc3QgTGluZUJ1aWxkZXI6 OkxpbmVDb250ZW50JiBsaW5lQ29udGVudCwgY29uc3QgTGluZUJveCYgbGluZUJveCwgSW5saW5l TGF5b3V0VW5pdCBsaW5lQm94TG9naWNhbEhlaWdodCwgc2l6ZV90IGxpbmVJbmRleCkKK0lubGlu ZURpc3BsYXlMaW5lQnVpbGRlcjo6RW5jbG9zaW5nTGluZUdlb21ldHJ5IElubGluZURpc3BsYXlM aW5lQnVpbGRlcjo6Y29sbGVjdEVuY2xvc2luZ0xpbmVHZW9tZXRyeShjb25zdCBMaW5lQm94JiBs aW5lQm94LCBjb25zdCBJbmxpbmVSZWN0JiBsaW5lQm94UmVjdCkgY29uc3QKIHsKLSAgICBhdXRv JiByb290U3R5bGUgPSBsaW5lSW5kZXggPyByb290KCkuZmlyc3RMaW5lU3R5bGUoKSA6IHJvb3Qo KS5zdHlsZSgpOwotICAgIGF1dG8gdmlzdWFsTGVmdCA9IGxpbmVDb250ZW50LmxpbmVMb2dpY2Fs VG9wTGVmdC54KCk7Ci0gICAgaWYgKCFyb290U3R5bGUuaXNMZWZ0VG9SaWdodERpcmVjdGlvbigp KSB7Ci0gICAgICAgIC8vIGh0dHBzOi8vZHJhZnRzLmNzc3dnLm9yZy9jc3MtdGV4dC8jdGV4dC1p bmRlbnQtcHJvcGVydHkKLSAgICAgICAgLy8gU2luY2UgdGV4dC1pbmRlbnQgb25seSBpbml0aWF0 ZXMgbWFyZ2luIHN0YXJ0LCB3ZSBqdXN0IG5lZWQgdG8gcHVsbCB0aGUgbGluZWJveCBiYWNrIHRv IHRoZSBsZWZ0LgotICAgICAgICB2aXN1YWxMZWZ0IC09IGxpbmVDb250ZW50LmxpbmVNYXJnaW5T dGFydDsKLSAgICB9Ci0gICAgLy8gRklYTUU6IFVzZSBwaHlzaWNhbCBnZW9tZXRyeSBoZXJlLgot ICAgIGF1dG8gbGluZUJveFJlY3QgPSBJbmxpbmVSZWN0IHsgbGluZUNvbnRlbnQubGluZUxvZ2lj YWxUb3BMZWZ0LnkoKSwgdmlzdWFsTGVmdCwgbGluZUNvbnRlbnQubGluZUxvZ2ljYWxXaWR0aCwg bGluZUJveExvZ2ljYWxIZWlnaHQgfTsKLSAgICBhdXRvIHNjcm9sbGFibGVPdmVyZmxvd1JlY3Qg PSBsaW5lQm94UmVjdDsKICAgICBhdXRvJiByb290SW5saW5lQm94ID0gbGluZUJveC5yb290SW5s aW5lQm94KCk7CisgICAgYXV0byBzY3JvbGxhYmxlT3ZlcmZsb3dSZWN0ID0gbGluZUJveFJlY3Q7 CiAgICAgYXV0byBlbmNsb3NpbmdUb3BBbmRCb3R0b20gPSBJbmxpbmVEaXNwbGF5OjpMaW5lOjpF bmNsb3NpbmdUb3BBbmRCb3R0b20geyBsaW5lQm94UmVjdC50b3AoKSArIHJvb3RJbmxpbmVCb3gu bG9naWNhbFRvcCgpLCBsaW5lQm94UmVjdC50b3AoKSArIHJvb3RJbmxpbmVCb3gubG9naWNhbEJv dHRvbSgpIH07CiAKICAgICBmb3IgKGF1dG8mIGlubGluZUxldmVsQm94IDogbGluZUJveC5ub25S b290SW5saW5lTGV2ZWxCb3hlcygpKSB7CkBAIC03OSw5ICs3MCwyNiBAQCBJbmxpbmVEaXNwbGF5 OjpMaW5lIElubGluZURpc3BsYXlMaW5lQnVpbGRlcjo6YnVpbGQoY29uc3QgTGluZUJ1aWxkZXI6 OkxpbmVDb250ZQogICAgICAgICBlbmNsb3NpbmdUb3BBbmRCb3R0b20udG9wID0gc3RkOjptaW4o ZW5jbG9zaW5nVG9wQW5kQm90dG9tLnRvcCwgYm9yZGVyQm94LnRvcCgpKTsKICAgICAgICAgZW5j bG9zaW5nVG9wQW5kQm90dG9tLmJvdHRvbSA9IHN0ZDo6bWF4KGVuY2xvc2luZ1RvcEFuZEJvdHRv bS5ib3R0b20sIGJvcmRlckJveC5ib3R0b20oKSk7CiAgICAgfQorICAgIHJldHVybiB7IGVuY2xv c2luZ1RvcEFuZEJvdHRvbSwgc2Nyb2xsYWJsZU92ZXJmbG93UmVjdCB9OworfQorCitJbmxpbmVE aXNwbGF5OjpMaW5lIElubGluZURpc3BsYXlMaW5lQnVpbGRlcjo6YnVpbGQoY29uc3QgTGluZUJ1 aWxkZXI6OkxpbmVDb250ZW50JiBsaW5lQ29udGVudCwgY29uc3QgTGluZUJveCYgbGluZUJveCwg SW5saW5lTGF5b3V0VW5pdCBsaW5lQm94TG9naWNhbEhlaWdodCwgc2l6ZV90IGxpbmVJbmRleCkg Y29uc3QKK3sKKyAgICBhdXRvJiByb290U3R5bGUgPSBsaW5lSW5kZXggPyByb290KCkuZmlyc3RM aW5lU3R5bGUoKSA6IHJvb3QoKS5zdHlsZSgpOworICAgIGF1dG8gbGluZUJveFZpc3VhbExlZnQg PSBsaW5lQ29udGVudC5saW5lTG9naWNhbFRvcExlZnQueCgpOworICAgIGlmICghcm9vdFN0eWxl LmlzTGVmdFRvUmlnaHREaXJlY3Rpb24oKSkgeworICAgICAgICAvLyBodHRwczovL2RyYWZ0cy5j c3N3Zy5vcmcvY3NzLXRleHQvI3RleHQtaW5kZW50LXByb3BlcnR5CisgICAgICAgIC8vIFNpbmNl IHRleHQtaW5kZW50IG9ubHkgaW5pdGlhdGVzIG1hcmdpbiBzdGFydCwgd2UganVzdCBuZWVkIHRv IHB1bGwgdGhlIGxpbmVib3ggYmFjayB0byB0aGUgbGVmdC4KKyAgICAgICAgbGluZUJveFZpc3Vh bExlZnQgLT0gbGluZUNvbnRlbnQubGluZU1hcmdpblN0YXJ0OworICAgIH0KKyAgICAvLyBGSVhN RTogVXNlIHBoeXNpY2FsIGdlb21ldHJ5IGhlcmUuCisgICAgYXV0byBsaW5lQm94UmVjdCA9IElu bGluZVJlY3QgeyBsaW5lQ29udGVudC5saW5lTG9naWNhbFRvcExlZnQueSgpLCBsaW5lQm94Vmlz dWFsTGVmdCwgbGluZUNvbnRlbnQubGluZUxvZ2ljYWxXaWR0aCwgbGluZUJveExvZ2ljYWxIZWln aHQgfTsKKyAgICBhdXRvIGVuY2xvc2luZ0xpbmVHZW9tZXRyeSA9IGNvbGxlY3RFbmNsb3NpbmdM aW5lR2VvbWV0cnkobGluZUJveCwgbGluZUJveFJlY3QpOworCisgICAgYXV0byYgcm9vdElubGlu ZUJveCA9IGxpbmVCb3gucm9vdElubGluZUJveCgpOwogICAgIHJldHVybiBJbmxpbmVEaXNwbGF5 OjpMaW5lIHsgbGluZUJveFJlY3QKLSAgICAgICAgLCBzY3JvbGxhYmxlT3ZlcmZsb3dSZWN0Ci0g ICAgICAgICwgZW5jbG9zaW5nVG9wQW5kQm90dG9tCisgICAgICAgICwgZW5jbG9zaW5nTGluZUdl b21ldHJ5LnNjcm9sbGFibGVPdmVyZmxvd1JlY3QKKyAgICAgICAgLCBlbmNsb3NpbmdMaW5lR2Vv bWV0cnkuZW5jbG9zaW5nVG9wQW5kQm90dG9tCiAgICAgICAgICwgcm9vdElubGluZUJveC5sb2dp Y2FsVG9wKCkgKyByb290SW5saW5lQm94LmJhc2VsaW5lKCkKICAgICAgICAgLCBsaW5lQm94LnJv b3RJbmxpbmVCb3hBbGlnbm1lbnRPZmZzZXQoKSArIHJvb3RJbmxpbmVCb3gubG9naWNhbExlZnQo KQogICAgICAgICAsIHJvb3RJbmxpbmVCb3gubG9naWNhbFdpZHRoKCkKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL2xheW91dC9mb3JtYXR0aW5nQ29udGV4dHMvaW5saW5lL2Rpc3BsYXkvSW5s aW5lRGlzcGxheUxpbmVCdWlsZGVyLmggYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvZm9ybWF0dGlu Z0NvbnRleHRzL2lubGluZS9kaXNwbGF5L0lubGluZURpc3BsYXlMaW5lQnVpbGRlci5oCmluZGV4 IDczNWI5OTI5MGI1MWJiYjE2NmMxN2E1MTYyNmU1MDk0ZmUxYzgxZjIuLjBjMjY1NmJkZTVkZDlk N2UwNzRjMTdiNTgxZTgyYjBjZjkwY2QzMWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xh eW91dC9mb3JtYXR0aW5nQ29udGV4dHMvaW5saW5lL2Rpc3BsYXkvSW5saW5lRGlzcGxheUxpbmVC dWlsZGVyLmgKKysrIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2Zvcm1hdHRpbmdDb250ZXh0cy9p bmxpbmUvZGlzcGxheS9JbmxpbmVEaXNwbGF5TGluZUJ1aWxkZXIuaApAQCAtNDAsOSArNDAsMTUg QEAgY2xhc3MgSW5saW5lRGlzcGxheUxpbmVCdWlsZGVyIHsKIHB1YmxpYzoKICAgICBJbmxpbmVE aXNwbGF5TGluZUJ1aWxkZXIoY29uc3QgSW5saW5lRm9ybWF0dGluZ0NvbnRleHQmKTsKIAotICAg IElubGluZURpc3BsYXk6OkxpbmUgYnVpbGQoY29uc3QgTGluZUJ1aWxkZXI6OkxpbmVDb250ZW50 JiwgY29uc3QgTGluZUJveCYsIElubGluZUxheW91dFVuaXQgbGluZUJveExvZ2ljYWxIZWlnaHQs IHNpemVfdCBsaW5lSW5kZXgpOworICAgIElubGluZURpc3BsYXk6OkxpbmUgYnVpbGQoY29uc3Qg TGluZUJ1aWxkZXI6OkxpbmVDb250ZW50JiwgY29uc3QgTGluZUJveCYsIElubGluZUxheW91dFVu aXQgbGluZUJveExvZ2ljYWxIZWlnaHQsIHNpemVfdCBsaW5lSW5kZXgpIGNvbnN0OwogCiBwcml2 YXRlOgorICAgIHN0cnVjdCBFbmNsb3NpbmdMaW5lR2VvbWV0cnkgeworICAgICAgICBJbmxpbmVE aXNwbGF5OjpMaW5lOjpFbmNsb3NpbmdUb3BBbmRCb3R0b20gZW5jbG9zaW5nVG9wQW5kQm90dG9t OworICAgICAgICBJbmxpbmVSZWN0IHNjcm9sbGFibGVPdmVyZmxvd1JlY3Q7CisgICAgfTsKKyAg ICBFbmNsb3NpbmdMaW5lR2VvbWV0cnkgY29sbGVjdEVuY2xvc2luZ0xpbmVHZW9tZXRyeShjb25z dCBMaW5lQm94JiwgY29uc3QgSW5saW5lUmVjdCYgbGluZUJveFJlY3QpIGNvbnN0OworCiAgICAg Y29uc3QgSW5saW5lRm9ybWF0dGluZ0NvbnRleHQmIGZvcm1hdHRpbmdDb250ZXh0KCkgY29uc3Qg eyByZXR1cm4gbV9pbmxpbmVGb3JtYXR0aW5nQ29udGV4dDsgfQogICAgIGNvbnN0IEJveCYgcm9v dCgpIGNvbnN0IHsgcmV0dXJuIGZvcm1hdHRpbmdDb250ZXh0KCkucm9vdCgpOyB9CiAgICAgTGF5 b3V0U3RhdGUmIGxheW91dFN0YXRlKCkgY29uc3QgeyByZXR1cm4gZm9ybWF0dGluZ0NvbnRleHQo KS5sYXlvdXRTdGF0ZSgpOyB9Cg==