234521 2021-12-20 12:39:52 -0800 Add some missing API availability macros around some WebXR SPI 2021-12-20 14:17:15 -0800 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 wenson_hsieh wenson_hsieh adachan dino graouts thorton webkit-bug-importer oldest_to_newest 1825689 0 wenson_hsieh 2021-12-20 12:39:52 -0800 In WKUIDelegatePrivate.h 1825702 1 447625 wenson_hsieh 2021-12-20 12:52:56 -0800 Created attachment 447625 Patch 1825723 2 447625 wenson_hsieh 2021-12-20 13:43:43 -0800 Comment on attachment 447625 Patch Thanks for the review! 1825739 3 ews-feeder 2021-12-20 14:16:05 -0800 Committed r287279 (245435@main): <https://commits.webkit.org/245435@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 447625. 1825740 4 webkit-bug-importer 2021-12-20 14:17:15 -0800 <rdar://problem/86740338> 447625 2021-12-20 12:52:56 -0800 2021-12-20 14:16:07 -0800 Patch bug-234521-20211220125255.patch text/plain 7077 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjg3MjcyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDk0OTU1MTlmZTk5YzNjZDFl Y2U0MTI2NjI0MjdiODAxYmFmZWRlZDguLmI2ZWVkZTA4YmRiY2Q1NmE5ZDAxYWZkMjZiYjJiMmIz ODRiZTA0NDIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMjEtMTItMjAgIFdlbnNvbiBI c2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CisKKyAgICAgICAgQWRkIHNvbWUgbWlzc2lu ZyBBUEkgYXZhaWxhYmlsaXR5IG1hY3JvcyBhcm91bmQgc29tZSBXZWJYUiBTUEkKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNDUyMQorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBzb21lIG1pc3Npbmcg QVBJIGF2YWlsYWJpbGl0eSBtYWNyb3MgYXJvdW5kIHNvbWUgV2ViWFItcmVsYXRlZCBTUEkgdGhh dCB3YXMgaW50cm9kdWNlZCBpbiByMjg2MzE4LgorICAgICAgICBBbHNvIHJlbW92ZSBhIGZldyB1 bm5lY2Vzc2FyeSBgUExBVEZPUk0oQ09DT0EpYCBjb21waWxlLXRpbWUgZ3VhcmRzLCBhbmQgYWRk IGEgbWlzc2luZyBgI2ltcG9ydGAgdG8gZml4IHRoZQorICAgICAgICBub24tdW5pZmllZCBidWls ZC4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvQ29jb2EvV0tVSURlbGVnYXRlUHJpdmF0ZS5o OgorICAgICAgICAqIFVJUHJvY2Vzcy9Db2NvYS9QbGF0Zm9ybVhSQ29vcmRpbmF0b3IubW06Cisg ICAgICAgICogVUlQcm9jZXNzL0NvY29hL1VJRGVsZWdhdGUuaDoKKyAgICAgICAgKiBVSVByb2Nl c3MvQ29jb2EvVUlEZWxlZ2F0ZS5tbToKKyAgICAgICAgKFdlYktpdDo6VUlEZWxlZ2F0ZTo6c2V0 RGVsZWdhdGUpOgorCiAyMDIxLTEyLTIwICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNv bT4KIAogICAgICAgICBJbXByb3ZlIFVzZXJNZWRpYVBlcm1pc3Npb25SZXF1ZXN0TWFuYWdlclBy b3h5IGxvZ2dpbmcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2Nv YS9XS1VJRGVsZWdhdGVQcml2YXRlLmggYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29j b2EvV0tVSURlbGVnYXRlUHJpdmF0ZS5oCmluZGV4IDQwNzAxNGQ5MzU0MGFjMTU4ZGRlMTk1Y2Qw MjgwMjk1MmNkNzFhZWYuLjBiZjIwZDk3NDNjNDk5ZGEzMjIyYTdkNDU0ZDRhZmZjNDIwYmIxMWEg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1VJRGVsZWdh dGVQcml2YXRlLmgKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL1dLVUlE ZWxlZ2F0ZVByaXZhdGUuaApAQCAtOTIsNyArOTIsNyBAQCB0eXBlZGVmIE5TX0VOVU0oTlNJbnRl Z2VyLCBfV0tYUlNlc3Npb25Nb2RlKSB7CiAgICAgX1dLWFJTZXNzaW9uTW9kZUlubGluZSwKICAg ICBfV0tYUlNlc3Npb25Nb2RlSW1tZXJzaXZlVnIsCiAgICAgX1dLWFJTZXNzaW9uTW9kZUltbWVy c2l2ZUFyLAotfTsKK30gV0tfQVBJX0FWQUlMQUJMRShtYWNvcyhXS19NQUNfVEJBKSwgaW9zKFdL X0lPU19UQkEpKTsKIAogdHlwZWRlZiBOU19PUFRJT05TKE5TVUludGVnZXIsIF9XS1hSU2Vzc2lv bkZlYXR1cmVGbGFncykgewogICAgIF9XS1hSU2Vzc2lvbkZlYXR1cmVGbGFnc05vbmUgPSAwLApA QCAtMTAxLDcgKzEwMSw3IEBAIHR5cGVkZWYgTlNfT1BUSU9OUyhOU1VJbnRlZ2VyLCBfV0tYUlNl c3Npb25GZWF0dXJlRmxhZ3MpIHsKICAgICBfV0tYUlNlc3Npb25GZWF0dXJlRmxhZ3NSZWZlcmVu Y2VTcGFjZVR5cGVMb2NhbEZsb29yID0gMSA8PCAyLAogICAgIF9XS1hSU2Vzc2lvbkZlYXR1cmVG bGFnc1JlZmVyZW5jZVNwYWNlVHlwZUJvdW5kZWRGbG9vciA9IDEgPDwgMywKICAgICBfV0tYUlNl c3Npb25GZWF0dXJlRmxhZ3NSZWZlcmVuY2VTcGFjZVR5cGVVbmJvdW5kZWQgPSAxIDw8IDQsCi19 OworfSBXS19BUElfQVZBSUxBQkxFKG1hY29zKFdLX01BQ19UQkEpLCBpb3MoV0tfSU9TX1RCQSkp OwogCiBAcHJvdG9jb2wgV0tVSURlbGVnYXRlUHJpdmF0ZSA8V0tVSURlbGVnYXRlPgogCkBAIC0x NzUsNyArMTc1LDcgQEAgc3RydWN0IFVJRWRnZUluc2V0czsKIC0gKHZvaWQpX3dlYlZpZXdEaWRF bmFibGVJbnNwZWN0b3JCcm93c2VyRG9tYWluOihXS1dlYlZpZXcgKil3ZWJWaWV3IFdLX0FQSV9B VkFJTEFCTEUobWFjb3MoMTIuMCksIGlvcygxNS4wKSk7CiAtICh2b2lkKV93ZWJWaWV3RGlkRGlz YWJsZUluc3BlY3RvckJyb3dzZXJEb21haW46KFdLV2ViVmlldyAqKXdlYlZpZXcgV0tfQVBJX0FW QUlMQUJMRShtYWNvcygxMi4wKSwgaW9zKDE1LjApKTsKIAotLSAodm9pZClfd2ViVmlldzooV0tX ZWJWaWV3ICopd2ViVmlldyByZXF1ZXN0UGVybWlzc2lvbkZvclhSU2Vzc2lvbk9yaWdpbjooTlNT dHJpbmcgKilvcmlnaW5TdHJpbmcgbW9kZTooX1dLWFJTZXNzaW9uTW9kZSltb2RlIGdyYW50ZWRG ZWF0dXJlczooX1dLWFJTZXNzaW9uRmVhdHVyZUZsYWdzKWdyYW50ZWRGZWF0dXJlcyBjb25zZW50 UmVxdWlyZWRGZWF0dXJlczooX1dLWFJTZXNzaW9uRmVhdHVyZUZsYWdzKWNvbnNlbnRSZXF1aXJl ZEZlYXR1cmVzIGNvbnNlbnRPcHRpb25hbEZlYXR1cmVzOihfV0tYUlNlc3Npb25GZWF0dXJlRmxh Z3MpY29uc2VudE9wdGlvbmFsRmVhdHVyZXMgY29tcGxldGlvbkhhbmRsZXI6KHZvaWQgKF4pKF9X S1hSU2Vzc2lvbkZlYXR1cmVGbGFncykpY29tcGxldGlvbkhhbmRsZXI7CistICh2b2lkKV93ZWJW aWV3OihXS1dlYlZpZXcgKil3ZWJWaWV3IHJlcXVlc3RQZXJtaXNzaW9uRm9yWFJTZXNzaW9uT3Jp Z2luOihOU1N0cmluZyAqKW9yaWdpblN0cmluZyBtb2RlOihfV0tYUlNlc3Npb25Nb2RlKW1vZGUg Z3JhbnRlZEZlYXR1cmVzOihfV0tYUlNlc3Npb25GZWF0dXJlRmxhZ3MpZ3JhbnRlZEZlYXR1cmVz IGNvbnNlbnRSZXF1aXJlZEZlYXR1cmVzOihfV0tYUlNlc3Npb25GZWF0dXJlRmxhZ3MpY29uc2Vu dFJlcXVpcmVkRmVhdHVyZXMgY29uc2VudE9wdGlvbmFsRmVhdHVyZXM6KF9XS1hSU2Vzc2lvbkZl YXR1cmVGbGFncyljb25zZW50T3B0aW9uYWxGZWF0dXJlcyBjb21wbGV0aW9uSGFuZGxlcjoodm9p ZCAoXikoX1dLWFJTZXNzaW9uRmVhdHVyZUZsYWdzKSljb21wbGV0aW9uSGFuZGxlciBXS19BUElf QVZBSUxBQkxFKG1hY29zKFdLX01BQ19UQkEpLCBpb3MoV0tfSU9TX1RCQSkpOwogLSAodm9pZClf d2ViVmlldzooV0tXZWJWaWV3ICopd2ViVmlldyBzdGFydFhSU2Vzc2lvbldpdGhDb21wbGV0aW9u SGFuZGxlcjoodm9pZCAoXikoaWQpKWNvbXBsZXRpb25IYW5kbGVyIFdLX0FQSV9BVkFJTEFCTEUo bWFjb3MoMTIuMCksIGlvcygxNS4wKSk7CiAtICh2b2lkKV93ZWJWaWV3OihXS1dlYlZpZXcgKil3 ZWJWaWV3IHJlcXVlc3ROb3RpZmljYXRpb25QZXJtaXNzaW9uRm9yU2VjdXJpdHlPcmlnaW46KFdL U2VjdXJpdHlPcmlnaW4gKilzZWN1cml0eU9yaWdpbiBkZWNpc2lvbkhhbmRsZXI6KHZvaWQgKF4p KEJPT0wpKWRlY2lzaW9uSGFuZGxlciBXS19BUElfQVZBSUxBQkxFKG1hY29zKDEwLjEzLjQpLCBp b3MoV0tfSU9TX1RCQSkpOwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9D b2NvYS9QbGF0Zm9ybVhSQ29vcmRpbmF0b3IubW0gYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9D b2NvYS9QbGF0Zm9ybVhSQ29vcmRpbmF0b3IubW0KaW5kZXggMzZiYjE2MGJiZWE0OWY5ZWQ4MGQx NTUwMTYwZjgzNTUyZDEzY2E4My4uYjNlYjk5ZTVlZTkwYTJlOWM2MDNmZGE1Yjg4ZTg1ZjUxMjE1 YTU1MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQ29jb2EvUGxhdGZvcm1Y UkNvb3JkaW5hdG9yLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0NvY29hL1BsYXRm b3JtWFJDb29yZGluYXRvci5tbQpAQCAtMjUsNiArMjUsNyBAQAogCiAjaW1wb3J0ICJjb25maWcu aCIKICNpbXBvcnQgIlBsYXRmb3JtWFJDb29yZGluYXRvci5oIgorI2ltcG9ydCAiUGxhdGZvcm1Y UlN5c3RlbS5oIgogCiAjaWYgRU5BQkxFKFdFQlhSKSAmJiBVU0UoQVBQTEVfSU5URVJOQUxfU0RL KQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9Db2NvYS9VSURlbGVnYXRl LmggYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9Db2NvYS9VSURlbGVnYXRlLmgKaW5kZXggODdj ZjI0ZjE4ZWJiMGFhYjk1NzU2ODEwMjMyMTA5ZmJhMDc1YjEwZC4uZDYwNzRkYzMzNmM5YmY5NGQx ZjhhM2M3NjI4ZWFlNWY4ZjVjZmMzZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nl c3MvQ29jb2EvVUlEZWxlZ2F0ZS5oCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0NvY29h L1VJRGVsZWdhdGUuaApAQCAtMTc0LDcgKzE3NCw3IEBAIHByaXZhdGU6CiAgICAgICAgIHZvaWQg ZGlkRW5hYmxlSW5zcGVjdG9yQnJvd3NlckRvbWFpbihXZWJQYWdlUHJveHkmKSBmaW5hbDsKICAg ICAgICAgdm9pZCBkaWREaXNhYmxlSW5zcGVjdG9yQnJvd3NlckRvbWFpbihXZWJQYWdlUHJveHkm KSBmaW5hbDsKIAotI2lmIEVOQUJMRShXRUJYUikgJiYgUExBVEZPUk0oQ09DT0EpCisjaWYgRU5B QkxFKFdFQlhSKQogICAgICAgICB2b2lkIHJlcXVlc3RQZXJtaXNzaW9uT25YUlNlc3Npb25GZWF0 dXJlcyhXZWJQYWdlUHJveHkmLCBjb25zdCBXZWJDb3JlOjpTZWN1cml0eU9yaWdpbkRhdGEmLCBQ bGF0Zm9ybVhSOjpTZXNzaW9uTW9kZSwgY29uc3QgUGxhdGZvcm1YUjo6RGV2aWNlOjpGZWF0dXJl TGlzdCYgLyogZ3JhbnRlZCAqLywgY29uc3QgUGxhdGZvcm1YUjo6RGV2aWNlOjpGZWF0dXJlTGlz dCYgLyogY29uc2VudFJlcXVpcmVkICovLCBjb25zdCBQbGF0Zm9ybVhSOjpEZXZpY2U6OkZlYXR1 cmVMaXN0JiAvKiBjb25zZW50T3B0aW9uYWwgKi8sIENvbXBsZXRpb25IYW5kbGVyPHZvaWQoc3Rk OjpvcHRpb25hbDxQbGF0Zm9ybVhSOjpEZXZpY2U6OkZlYXR1cmVMaXN0PiYmKT4mJikgZmluYWw7 CiAgICAgICAgIHZvaWQgc3RhcnRYUlNlc3Npb24oV2ViUGFnZVByb3h5JiwgQ29tcGxldGlvbkhh bmRsZXI8dm9pZChSZXRhaW5QdHI8aWQ+KT4mJikgZmluYWw7CiAjZW5kaWYKQEAgLTI2OCw3ICsy NjgsNyBAQCBwcml2YXRlOgogI2VuZGlmCiAgICAgICAgIGJvb2wgd2ViVmlld0RpZEVuYWJsZUlu c3BlY3RvckJyb3dzZXJEb21haW4gOiAxOwogICAgICAgICBib29sIHdlYlZpZXdEaWREaXNhYmxl SW5zcGVjdG9yQnJvd3NlckRvbWFpbiA6IDE7Ci0jaWYgRU5BQkxFKFdFQlhSKSAmJiBQTEFURk9S TShDT0NPQSkKKyNpZiBFTkFCTEUoV0VCWFIpCiAgICAgICAgIGJvb2wgd2ViVmlld1JlcXVlc3RQ ZXJtaXNzaW9uRm9yWFJTZXNzaW9uT3JpZ2luTW9kZUFuZEZlYXR1cmVzV2l0aENvbXBsZXRpb25I YW5kbGVyOiAxOwogICAgICAgICBib29sIHdlYlZpZXdTdGFydFhSU2Vzc2lvbldpdGhDb21wbGV0 aW9uSGFuZGxlciA6IDE7CiAjZW5kaWYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9j ZXNzL0NvY29hL1VJRGVsZWdhdGUubW0gYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9Db2NvYS9V SURlbGVnYXRlLm1tCmluZGV4IGVhYTEwYjU0NGVmMzRjMGRjODY0N2Q2Y2U5MTE1NjkyMjZhOWI2 NGUuLmUzNzNmZDE2ZWI1MzkyMzEwYzE5MDE4ZmQ1ZTY1MWQyZmUwM2NjZTYgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0NvY29hL1VJRGVsZWdhdGUubW0KKysrIGIvU291cmNl L1dlYktpdC9VSVByb2Nlc3MvQ29jb2EvVUlEZWxlZ2F0ZS5tbQpAQCAtMTkzLDcgKzE5Myw3IEBA IHZvaWQgVUlEZWxlZ2F0ZTo6c2V0RGVsZWdhdGUoaWQgPFdLVUlEZWxlZ2F0ZT4gZGVsZWdhdGUp CiAgICAgbV9kZWxlZ2F0ZU1ldGhvZHMud2ViVmlld0RpZEVuYWJsZUluc3BlY3RvckJyb3dzZXJE b21haW4gPSBbZGVsZWdhdGUgcmVzcG9uZHNUb1NlbGVjdG9yOkBzZWxlY3Rvcihfd2ViVmlld0Rp ZEVuYWJsZUluc3BlY3RvckJyb3dzZXJEb21haW46KV07CiAgICAgbV9kZWxlZ2F0ZU1ldGhvZHMu d2ViVmlld0RpZERpc2FibGVJbnNwZWN0b3JCcm93c2VyRG9tYWluID0gW2RlbGVnYXRlIHJlc3Bv bmRzVG9TZWxlY3RvcjpAc2VsZWN0b3IoX3dlYlZpZXdEaWREaXNhYmxlSW5zcGVjdG9yQnJvd3Nl ckRvbWFpbjopXTsKIAotI2lmIEVOQUJMRShXRUJYUikgJiYgUExBVEZPUk0oQ09DT0EpCisjaWYg RU5BQkxFKFdFQlhSKQogICAgIG1fZGVsZWdhdGVNZXRob2RzLndlYlZpZXdSZXF1ZXN0UGVybWlz c2lvbkZvclhSU2Vzc2lvbk9yaWdpbk1vZGVBbmRGZWF0dXJlc1dpdGhDb21wbGV0aW9uSGFuZGxl ciA9IFtkZWxlZ2F0ZSByZXNwb25kc1RvU2VsZWN0b3I6QHNlbGVjdG9yKF93ZWJWaWV3OnJlcXVl c3RQZXJtaXNzaW9uRm9yWFJTZXNzaW9uT3JpZ2luOm1vZGU6Z3JhbnRlZEZlYXR1cmVzOmNvbnNl bnRSZXF1aXJlZEZlYXR1cmVzOmNvbnNlbnRPcHRpb25hbEZlYXR1cmVzOmNvbXBsZXRpb25IYW5k bGVyOildOwogICAgIG1fZGVsZWdhdGVNZXRob2RzLndlYlZpZXdTdGFydFhSU2Vzc2lvbldpdGhD b21wbGV0aW9uSGFuZGxlciA9IFtkZWxlZ2F0ZSByZXNwb25kc1RvU2VsZWN0b3I6QHNlbGVjdG9y KF93ZWJWaWV3OnN0YXJ0WFJTZXNzaW9uV2l0aENvbXBsZXRpb25IYW5kbGVyOildOwogI2VuZGlm CkBAIC0xNjg1LDcgKzE2ODUsNyBAQCB2b2lkIFVJRGVsZWdhdGU6OlVJQ2xpZW50OjpkaWREaXNh YmxlSW5zcGVjdG9yQnJvd3NlckRvbWFpbihXZWJQYWdlUHJveHkmKQogICAgIFtkZWxlZ2F0ZSBf d2ViVmlld0RpZERpc2FibGVJbnNwZWN0b3JCcm93c2VyRG9tYWluOm1fdWlEZWxlZ2F0ZS0+bV93 ZWJWaWV3LmdldCgpLmdldCgpXTsKIH0KIAotI2lmIEVOQUJMRShXRUJYUikgJiYgUExBVEZPUk0o Q09DT0EpCisjaWYgRU5BQkxFKFdFQlhSKQogc3RhdGljIF9XS1hSU2Vzc2lvbk1vZGUgdG9XS1hS U2Vzc2lvbk1vZGUoUGxhdGZvcm1YUjo6U2Vzc2lvbk1vZGUgbW9kZSkKIHsKICAgICBzd2l0Y2gg KG1vZGUpIHsK