<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>234510</bug_id>
          
          <creation_ts>2021-12-20 06:29:05 -0800</creation_ts>
          <short_desc>Stop assuming WPT is a reftest based on existence of -ref.html file</short_desc>
          <delta_ts>2022-01-11 09:03:55 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>Safari 14</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=203784</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Tim Nguyen (:ntim)">ntim</reporter>
          <assigned_to name="Tim Nguyen (:ntim)">ntim</assigned_to>
          <cc>darin</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>glenn</cc>
    
    <cc>gsnedders</cc>
    
    <cc>jbedard</cc>
    
    <cc>rego</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>youennf</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1825590</commentid>
    <comment_count>0</comment_count>
    <who name="Tim Nguyen (:ntim)">ntim</who>
    <bug_when>2021-12-20 06:29:05 -0800</bug_when>
    <thetext>Only the presence of &lt;link rel=&quot;match&quot;&gt;/&lt;link rel=&quot;mismatch&quot;&gt; indicates a test is a reftest. The script should not assume that the existence of a similarly named file with a `-ref.html` suffix means that the original test file is reftest.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1825594</commentid>
    <comment_count>1</comment_count>
    <who name="Tim Nguyen (:ntim)">ntim</who>
    <bug_when>2021-12-20 07:04:08 -0800</bug_when>
    <thetext>https://github.com/web-platform-tests/wpt/blob/22f29564bb82b407aeaf6507c8efffdbd51b9974/tools/manifest/sourcefile.py#L1065</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1825596</commentid>
    <comment_count>2</comment_count>
      <attachid>447601</attachid>
    <who name="Tim Nguyen (:ntim)">ntim</who>
    <bug_when>2021-12-20 07:05:58 -0800</bug_when>
    <thetext>Created attachment 447601
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1825600</commentid>
    <comment_count>3</comment_count>
      <attachid>447601</attachid>
    <who name="Manuel Rego Casasnovas">rego</who>
    <bug_when>2021-12-20 07:19:00 -0800</bug_when>
    <thetext>Comment on attachment 447601
Patch

Why this was added initially? Are we going to be missing any test now (or they were actually just being imported but not working fine)?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1825607</commentid>
    <comment_count>4</comment_count>
    <who name="Tim Nguyen (:ntim)">ntim</who>
    <bug_when>2021-12-20 07:48:02 -0800</bug_when>
    <thetext>(In reply to Manuel Rego Casasnovas from comment #3)
&gt; Comment on attachment 447601 [details]
&gt; Patch
&gt; 
&gt; Why this was added initially? Are we going to be missing any test now (or
&gt; they were actually just being imported but not working fine)?

Blame links to: https://github.com/WebKit/WebKit/commit/fe8645cb599fd89729602a5c992f1fa93a88f5d7

Maybe it was useful before?

Anyway, this is troublesome for the top-layer-position tests:

https://github.com/web-platform-tests/wpt/tree/master/html/semantics/interactive-elements/the-dialog-element

where we have:

top-layer-position-ref.html
top-layer-position-relative.html
top-layer-position-static.html
top-layer-position.html

The ref is for the relative &amp; static tests, not the plain one.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1825609</commentid>
    <comment_count>5</comment_count>
      <attachid>447601</attachid>
    <who name="Sam Sneddon [:gsnedders]">gsnedders</who>
    <bug_when>2021-12-20 08:02:00 -0800</bug_when>
    <thetext>Comment on attachment 447601
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=447601&amp;action=review

(non-reviewer r-)

&gt; Tools/Scripts/webkitpy/w3c/test_parser.py:-124
&gt; -        elif self.is_wpt_reftest():

Removing this changes the semantics of everything that follows; notably this means things can get picked up as manual tests now when previously they were excluded for having `-ref` in the name.

Compare this with https://github.com/web-platform-tests/wpt/blob/22f29564bb82b407aeaf6507c8efffdbd51b9974/tools/manifest/sourcefile.py#L1041 where certain tests are excluded from the possibility of being picked up as manual tests as a result of this.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1825616</commentid>
    <comment_count>6</comment_count>
      <attachid>447605</attachid>
    <who name="Tim Nguyen (:ntim)">ntim</who>
    <bug_when>2021-12-20 08:31:38 -0800</bug_when>
    <thetext>Created attachment 447605
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1825628</commentid>
    <comment_count>7</comment_count>
      <attachid>447605</attachid>
    <who name="Sam Sneddon [:gsnedders]">gsnedders</who>
    <bug_when>2021-12-20 09:02:10 -0800</bug_when>
    <thetext>Comment on attachment 447605
Patch

This looks good, aside from the lack of tests in test_parser_unittest.py for this behaviour (which we really ought to have!).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1825651</commentid>
    <comment_count>8</comment_count>
    <who name="Tim Nguyen (:ntim)">ntim</who>
    <bug_when>2021-12-20 11:03:57 -0800</bug_when>
    <thetext>Committed r287267 (245423@trunk): &lt;https://commits.webkit.org/245423@trunk&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1825653</commentid>
    <comment_count>9</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2021-12-20 11:04:16 -0800</bug_when>
    <thetext>&lt;rdar://problem/86732196&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1825655</commentid>
    <comment_count>10</comment_count>
    <who name="Tim Nguyen (:ntim)">ntim</who>
    <bug_when>2021-12-20 11:05:07 -0800</bug_when>
    <thetext>(In reply to Sam Sneddon [:gsnedders] from comment #7)
&gt; Comment on attachment 447605 [details]
&gt; Patch
&gt; 
&gt; This looks good, aside from the lack of tests in test_parser_unittest.py for
&gt; this behaviour (which we really ought to have!).

I added tests in the patch I landed: https://commits.webkit.org/r287267</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>447601</attachid>
            <date>2021-12-20 07:05:58 -0800</date>
            <delta_ts>2021-12-20 08:31:34 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-234510-20211220160557.patch</filename>
            <type>text/plain</type>
            <size>3017</size>
            <attacher name="Tim Nguyen (:ntim)">ntim</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjg3MjU4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg
Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNjNkMzMwN2M5MDY4MzY3M2U2ZjI5ZmY5YTk5YTAxMjRk
MjI1MDY5NS4uNDU3ZjZjNTA0ZTZkZWY2NjQ5NTFiZmRhZTE5MWMwYzkzYmRiY2NjZSAxMDA2NDQK
LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIz
IEBACisyMDIxLTEyLTIwICBUaW0gTmd1eWVuICA8bnRpbUBhcHBsZS5jb20+CisKKyAgICAgICAg
U3RvcCBhc3N1bWluZyBXUFQgaXMgYSByZWZ0ZXN0IGJhc2VkIG9uIGV4aXN0ZW5jZSBvZiAtcmVm
Lmh0bWwgZmlsZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/
aWQ9MjM0NTEwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg
ICAgT25seSB0aGUgcHJlc2VuY2Ugb2YgPGxpbmsgcmVsPSJtYXRjaCI+LzxsaW5rIHJlbD0ibWlz
bWF0Y2giPiBpbmRpY2F0ZXMgYSB0ZXN0IGlzIGEgcmVmdGVzdC4gVGhlIHNjcmlwdAorICAgICAg
ICBzaG91bGQgbm90IGFzc3VtZSB0aGF0IHRoZSBleGlzdGVuY2Ugb2YgYSBzaW1pbGFybHkgbmFt
ZWQgZmlsZSB3aXRoIGEgYC1yZWYuaHRtbGAgc3VmZml4IG1lYW5zIHRoYXQgdGhlCisgICAgICAg
IG9yaWdpbmFsIHRlc3QgZmlsZSBpcyByZWZ0ZXN0LgorCisgICAgICAgIEhlcmUncyBob3cgdXBz
dHJlYW0gV1BUIGRldGVjdHMgcmVmdGVzdHM6CisgICAgICAgIGh0dHBzOi8vZ2l0aHViLmNvbS93
ZWItcGxhdGZvcm0tdGVzdHMvd3B0L2Jsb2IvMjJmMjk1NjRiYjgyYjQwN2FlYWY2NTA3YzhlZmZm
ZGJkNTFiOTk3NC90b29scy9tYW5pZmVzdC9zb3VyY2VmaWxlLnB5I0wxMDY1CisKKyAgICAgICAg
KiBTY3JpcHRzL3dlYmtpdHB5L3czYy90ZXN0X3BhcnNlci5weToKKyAgICAgICAgKFRlc3RQYXJz
ZXIuYW5hbHl6ZV90ZXN0KToKKyAgICAgICAgKFRlc3RQYXJzZXIuZnV6enlfbWV0YWRhdGEpOgor
ICAgICAgICAoVGVzdFBhcnNlci5wb3RlbnRpYWxfcmVmX2ZpbGVuYW1lKTogRGVsZXRlZC4KKyAg
ICAgICAgKFRlc3RQYXJzZXIuaXNfd3B0X3JlZnRlc3QpOiBEZWxldGVkLgorCiAyMDIxLTEyLTIw
ICBUaW0gTmd1eWVuICA8bnRpbUBhcHBsZS5jb20+CiAKICAgICAgICAgRml4IFRvb2xzL1Njcmlw
dHMvd2Via2l0cHkvdzNjL3Rlc3RfaW1wb3J0ZXIucHkKZGlmZiAtLWdpdCBhL1Rvb2xzL1Njcmlw
dHMvd2Via2l0cHkvdzNjL3Rlc3RfcGFyc2VyLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS93
M2MvdGVzdF9wYXJzZXIucHkKaW5kZXggZTRmODdhMzFlODFmZWYxYmNkYzU3YTg0ZWJjZmQwNmFl
NDRjZTI2Yi4uZDgxNTQxMjJjZWI1YWM4NWFmOTNkZWVjNzFiZGZiMTI5ZDk2ZGIxZSAxMDA3NTUK
LS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS93M2MvdGVzdF9wYXJzZXIucHkKKysrIGIvVG9v
bHMvU2NyaXB0cy93ZWJraXRweS93M2MvdGVzdF9wYXJzZXIucHkKQEAgLTEyMCwxMCArMTIwLDYg
QEAgY2xhc3MgVGVzdFBhcnNlcihvYmplY3QpOgogICAgICAgICAgICAgICAgICAgICByZWZlcmVu
Y2VfcmVscGF0aCA9IHNlbGYuZmlsZXN5c3RlbS5yZWxwYXRoKHNlbGYuZmlsZXN5c3RlbS5kaXJu
YW1lKHNlbGYuZmlsZW5hbWUpLCBzZWxmLmZpbGVzeXN0ZW0uZGlybmFtZShyZWZfZmlsZSkpICsg
c2VsZi5maWxlc3lzdGVtLnNlcAogICAgICAgICAgICAgICAgICAgICB0ZXN0X2luZm9bJ3JlZmVy
ZW5jZV9zdXBwb3J0X2luZm8nXSA9IHsncmVmZXJlbmNlX3JlbHBhdGgnOiByZWZlcmVuY2VfcmVs
cGF0aCwgJ2ZpbGVzJzogcmVmZXJlbmNlX3N1cHBvcnRfZmlsZXN9CiAKLSAgICAgICAgIyBub3Qg
YWxsIHJlZmVyZW5jZSB0ZXN0cyBoYXZlIGEgPGxpbmsgcmVsPSdtYXRjaCc+IGVsZW1lbnQgaW4g
V1BUIHJlcG8KLSAgICAgICAgZWxpZiBzZWxmLmlzX3dwdF9yZWZ0ZXN0KCk6Ci0gICAgICAgICAg
ICB0ZXN0X2luZm8gPSB7J3Rlc3QnOiBzZWxmLmZpbGVuYW1lLCAncmVmZXJlbmNlJzogc2VsZi5w
b3RlbnRpYWxfcmVmX2ZpbGVuYW1lKCl9Ci0gICAgICAgICAgICB0ZXN0X2luZm9bJ3JlZmVyZW5j
ZV9zdXBwb3J0X2luZm8nXSA9IHt9CiAgICAgICAgICMgd2UgY2hlY2sgZm9yIHdwdCBtYW51YWwg
dGVzdCBiZWZvcmUgY2hlY2tpbmcgZm9yIGpzdGVzdCwgYXMgc29tZSBXUFQgbWFudWFsIHRlc3Rz
IGNhbiBiZSBjbGFzc2lmaWVkIGFzIENTUyBKUyB0ZXN0cwogICAgICAgICBlbGlmIHNlbGYuaXNf
d3B0X21hbnVhbHRlc3QoKToKICAgICAgICAgICAgIHRlc3RfaW5mbyA9IHsndGVzdCc6IHNlbGYu
ZmlsZW5hbWUsICdtYW51YWx0ZXN0JzogVHJ1ZX0KQEAgLTIzNywxNSArMjMzLDYgQEAgY2xhc3Mg
VGVzdFBhcnNlcihvYmplY3QpOgogCiAgICAgICAgIHJldHVybiByZXN1bHQKIAotICAgIGRlZiBw
b3RlbnRpYWxfcmVmX2ZpbGVuYW1lKHNlbGYpOgotICAgICAgICBwYXJ0cyA9IHNlbGYuZmlsZXN5
c3RlbS5zcGxpdGV4dChzZWxmLmZpbGVuYW1lKQotICAgICAgICByZXR1cm4gcGFydHNbMF0gKyAn
LXJlZicgKyBwYXJ0c1sxXQotCi0gICAgZGVmIGlzX3dwdF9yZWZ0ZXN0KHNlbGYpOgotICAgICAg
ICAiIiJSZXR1cm5zIHdoZXRoZXIgdGhlIHRlc3QgaXMgYSByZWYgdGVzdCBhY2NvcmRpbmcgV1BU
IHJ1bGVzIChpLmUuIGZpbGUgaGFzIGEgLXJlZi5odG1sIGNvdW50ZXJwYXJ0KS4iIiIKLSAgICAg
ICAgcGFydHMgPSBzZWxmLmZpbGVzeXN0ZW0uc3BsaXRleHQoc2VsZi5maWxlbmFtZSkKLSAgICAg
ICAgcmV0dXJuICBzZWxmLmZpbGVzeXN0ZW0uaXNmaWxlKHNlbGYucG90ZW50aWFsX3JlZl9maWxl
bmFtZSgpKQotCiAgICAgZGVmIHN1cHBvcnRfZmlsZXMoc2VsZiwgZG9jKToKICAgICAgICAgIiIi
IFNlYXJjaGVzIHRoZSBmaWxlIGZvciBhbGwgcGF0aHMgc3BlY2lmaWVkIGluIHVybCgpJ3MsIGhy
ZWYgb3Igc3JjIGF0dHJpYnV0ZXMuIiIiCiAgICAgICAgIHN1cHBvcnRfZmlsZXMgPSBbXQo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>447605</attachid>
            <date>2021-12-20 08:31:38 -0800</date>
            <delta_ts>2021-12-20 09:56:22 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-234510-20211220173137.patch</filename>
            <type>text/plain</type>
            <size>4142</size>
            <attacher name="Tim Nguyen (:ntim)">ntim</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjg3MjU4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg
Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNjNkMzMwN2M5MDY4MzY3M2U2ZjI5ZmY5YTk5YTAxMjRk
MjI1MDY5NS4uMTA0ODQwYmJkMzIzZjFiMDFjZmNhY2ZjYjI1NGNiOTY3NDVmNmM0ZiAxMDA2NDQK
LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0
IEBACisyMDIxLTEyLTIwICBUaW0gTmd1eWVuICA8bnRpbUBhcHBsZS5jb20+CisKKyAgICAgICAg
U3RvcCBhc3N1bWluZyBXUFQgaXMgYSByZWZ0ZXN0IGJhc2VkIG9uIGV4aXN0ZW5jZSBvZiAtcmVm
Lmh0bWwgZmlsZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/
aWQ9MjM0NTEwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg
ICAgT25seSB0aGUgcHJlc2VuY2Ugb2YgPGxpbmsgcmVsPSJtYXRjaCI+LzxsaW5rIHJlbD0ibWlz
bWF0Y2giPiBpbmRpY2F0ZXMgYSB0ZXN0IGlzIGEgcmVmdGVzdC4gVGhlIHNjcmlwdAorICAgICAg
ICBzaG91bGQgbm90IGFzc3VtZSB0aGF0IHRoZSBleGlzdGVuY2Ugb2YgYSBzaW1pbGFybHkgbmFt
ZWQgZmlsZSB3aXRoIGEgYC1yZWYuaHRtbGAgc3VmZml4IG1lYW5zIHRoYXQgdGhlCisgICAgICAg
IG9yaWdpbmFsIHRlc3QgZmlsZSBpcyByZWZ0ZXN0LgorCisgICAgICAgIEhlcmUncyBob3cgdXBz
dHJlYW0gV1BUIGRldGVjdHMgcmVmdGVzdHM6CisgICAgICAgIGh0dHBzOi8vZ2l0aHViLmNvbS93
ZWItcGxhdGZvcm0tdGVzdHMvd3B0L2Jsb2IvMjJmMjk1NjRiYjgyYjQwN2FlYWY2NTA3YzhlZmZm
ZGJkNTFiOTk3NC90b29scy9tYW5pZmVzdC9zb3VyY2VmaWxlLnB5I0wxMDY1CisKKyAgICAgICAg
KiBTY3JpcHRzL3dlYmtpdHB5L3czYy90ZXN0X3BhcnNlci5weToKKyAgICAgICAgKFRlc3RQYXJz
ZXIuYW5hbHl6ZV90ZXN0KToKKyAgICAgICAgKFRlc3RQYXJzZXIuZnV6enlfbWV0YWRhdGEpOgor
ICAgICAgICAoVGVzdFBhcnNlci5pc19yZWZlcmVuY2VfZmlsZW5hbWUpOgorICAgICAgICAoVGVz
dFBhcnNlci5wb3RlbnRpYWxfcmVmX2ZpbGVuYW1lKTogRGVsZXRlZC4KKyAgICAgICAgKFRlc3RQ
YXJzZXIuaXNfd3B0X3JlZnRlc3QpOiBEZWxldGVkLgorCiAyMDIxLTEyLTIwICBUaW0gTmd1eWVu
ICA8bnRpbUBhcHBsZS5jb20+CiAKICAgICAgICAgRml4IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkv
dzNjL3Rlc3RfaW1wb3J0ZXIucHkKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkv
dzNjL3Rlc3RfcGFyc2VyLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS93M2MvdGVzdF9wYXJz
ZXIucHkKaW5kZXggZTRmODdhMzFlODFmZWYxYmNkYzU3YTg0ZWJjZmQwNmFlNDRjZTI2Yi4uYTA5
NjVlYTJmYzYyYWQ2NjAyZWMyZmMzNjQ4ZThlOTRlOWUyNzVlZiAxMDA3NTUKLS0tIGEvVG9vbHMv
U2NyaXB0cy93ZWJraXRweS93M2MvdGVzdF9wYXJzZXIucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93
ZWJraXRweS93M2MvdGVzdF9wYXJzZXIucHkKQEAgLTEyMCwxNiArMTIwLDEyIEBAIGNsYXNzIFRl
c3RQYXJzZXIob2JqZWN0KToKICAgICAgICAgICAgICAgICAgICAgcmVmZXJlbmNlX3JlbHBhdGgg
PSBzZWxmLmZpbGVzeXN0ZW0ucmVscGF0aChzZWxmLmZpbGVzeXN0ZW0uZGlybmFtZShzZWxmLmZp
bGVuYW1lKSwgc2VsZi5maWxlc3lzdGVtLmRpcm5hbWUocmVmX2ZpbGUpKSArIHNlbGYuZmlsZXN5
c3RlbS5zZXAKICAgICAgICAgICAgICAgICAgICAgdGVzdF9pbmZvWydyZWZlcmVuY2Vfc3VwcG9y
dF9pbmZvJ10gPSB7J3JlZmVyZW5jZV9yZWxwYXRoJzogcmVmZXJlbmNlX3JlbHBhdGgsICdmaWxl
cyc6IHJlZmVyZW5jZV9zdXBwb3J0X2ZpbGVzfQogCi0gICAgICAgICMgbm90IGFsbCByZWZlcmVu
Y2UgdGVzdHMgaGF2ZSBhIDxsaW5rIHJlbD0nbWF0Y2gnPiBlbGVtZW50IGluIFdQVCByZXBvCi0g
ICAgICAgIGVsaWYgc2VsZi5pc193cHRfcmVmdGVzdCgpOgotICAgICAgICAgICAgdGVzdF9pbmZv
ID0geyd0ZXN0Jzogc2VsZi5maWxlbmFtZSwgJ3JlZmVyZW5jZSc6IHNlbGYucG90ZW50aWFsX3Jl
Zl9maWxlbmFtZSgpfQotICAgICAgICAgICAgdGVzdF9pbmZvWydyZWZlcmVuY2Vfc3VwcG9ydF9p
bmZvJ10gPSB7fQogICAgICAgICAjIHdlIGNoZWNrIGZvciB3cHQgbWFudWFsIHRlc3QgYmVmb3Jl
IGNoZWNraW5nIGZvciBqc3Rlc3QsIGFzIHNvbWUgV1BUIG1hbnVhbCB0ZXN0cyBjYW4gYmUgY2xh
c3NpZmllZCBhcyBDU1MgSlMgdGVzdHMKLSAgICAgICAgZWxpZiBzZWxmLmlzX3dwdF9tYW51YWx0
ZXN0KCk6CisgICAgICAgIGVsaWYgc2VsZi5pc193cHRfbWFudWFsdGVzdCgpIGFuZCBub3Qgc2Vs
Zi5pc19yZWZlcmVuY2VfZmlsZW5hbWUoKToKICAgICAgICAgICAgIHRlc3RfaW5mbyA9IHsndGVz
dCc6IHNlbGYuZmlsZW5hbWUsICdtYW51YWx0ZXN0JzogVHJ1ZX0KICAgICAgICAgZWxpZiBzZWxm
LmlzX2pzdGVzdCgpOgogICAgICAgICAgICAgdGVzdF9pbmZvID0geyd0ZXN0Jzogc2VsZi5maWxl
bmFtZSwgJ2pzdGVzdCc6IFRydWV9Ci0gICAgICAgIGVsaWYgJy1yZWYnIGluIHNlbGYuZmlsZW5h
bWUgb3IgJ3JlZmVyZW5jZScgaW4gc2VsZi5maWxlbmFtZToKKyAgICAgICAgZWxpZiBzZWxmLmlz
X3JlZmVyZW5jZV9maWxlbmFtZSgpOgogICAgICAgICAgICAgdGVzdF9pbmZvID0geydyZWZlcmVu
Y2VmaWxlJzogc2VsZi5maWxlbmFtZX0KICAgICAgICAgZWxpZiBzZWxmLm9wdGlvbnNbJ2FsbCdd
IGlzIFRydWU6CiAgICAgICAgICAgICB0ZXN0X2luZm8gPSB7J3Rlc3QnOiBzZWxmLmZpbGVuYW1l
fQpAQCAtMTY4LDYgKzE2NCwxMiBAQCBjbGFzcyBUZXN0UGFyc2VyKG9iamVjdCk6CiAKICAgICAg
ICAgcmV0dXJuIEZhbHNlCiAKKyAgICBkZWYgaXNfcmVmZXJlbmNlX2ZpbGVuYW1lKHNlbGYpOgor
ICAgICAgICAjIEZyb20gdG9vbHMvbWFuaWZlc3Qvc291cmNlZmlsZS5weSBpbiBXUFQgcmVwb3Np
dG9yeQorICAgICAgICAjIGh0dHBzOi8vZ2l0aHViLmNvbS93ZWItcGxhdGZvcm0tdGVzdHMvd3B0
L2Jsb2IvMjJmMjk1NjRiYjgyYjQwN2FlYWY2NTA3YzhlZmZmZGJkNTFiOTk3NC90b29scy9tYW5p
ZmVzdC9zb3VyY2VmaWxlLnB5I0w0MDUKKyAgICAgICAgcmVmZXJlbmNlX2ZpbGVfcmUgPSByZS5j
b21waWxlKHInKF58W1wtX10pKG5vdCk/cmVmWzAtOV0qKFtcLV9dfCQpJykKKyAgICAgICAgcmV0
dXJuICIvcmVmZXJlbmNlLyIgaW4gc2VsZi5maWxlbmFtZSBvciBib29sKHJlZmVyZW5jZV9maWxl
X3JlLnNlYXJjaChzZWxmLmZpbGVuYW1lKSkKKwogICAgIGRlZiBpc19zbG93X3Rlc3Qoc2VsZik6
CiAgICAgICAgIHJldHVybiBhbnkoW21hdGNoLm5hbWUgPT0gJ21ldGEnIGFuZCBtYXRjaFsnbmFt
ZSddID09ICd0aW1lb3V0JyBmb3IgbWF0Y2ggaW4gc2VsZi50ZXN0X2RvYy5maW5kQWxsKGNvbnRl
bnQ9J2xvbmcnKV0pCiAKQEAgLTIzNywxNSArMjM5LDYgQEAgY2xhc3MgVGVzdFBhcnNlcihvYmpl
Y3QpOgogCiAgICAgICAgIHJldHVybiByZXN1bHQKIAotICAgIGRlZiBwb3RlbnRpYWxfcmVmX2Zp
bGVuYW1lKHNlbGYpOgotICAgICAgICBwYXJ0cyA9IHNlbGYuZmlsZXN5c3RlbS5zcGxpdGV4dChz
ZWxmLmZpbGVuYW1lKQotICAgICAgICByZXR1cm4gcGFydHNbMF0gKyAnLXJlZicgKyBwYXJ0c1sx
XQotCi0gICAgZGVmIGlzX3dwdF9yZWZ0ZXN0KHNlbGYpOgotICAgICAgICAiIiJSZXR1cm5zIHdo
ZXRoZXIgdGhlIHRlc3QgaXMgYSByZWYgdGVzdCBhY2NvcmRpbmcgV1BUIHJ1bGVzIChpLmUuIGZp
bGUgaGFzIGEgLXJlZi5odG1sIGNvdW50ZXJwYXJ0KS4iIiIKLSAgICAgICAgcGFydHMgPSBzZWxm
LmZpbGVzeXN0ZW0uc3BsaXRleHQoc2VsZi5maWxlbmFtZSkKLSAgICAgICAgcmV0dXJuICBzZWxm
LmZpbGVzeXN0ZW0uaXNmaWxlKHNlbGYucG90ZW50aWFsX3JlZl9maWxlbmFtZSgpKQotCiAgICAg
ZGVmIHN1cHBvcnRfZmlsZXMoc2VsZiwgZG9jKToKICAgICAgICAgIiIiIFNlYXJjaGVzIHRoZSBm
aWxlIGZvciBhbGwgcGF0aHMgc3BlY2lmaWVkIGluIHVybCgpJ3MsIGhyZWYgb3Igc3JjIGF0dHJp
YnV0ZXMuIiIiCiAgICAgICAgIHN1cHBvcnRfZmlsZXMgPSBbXQo=
</data>
<flag name="review"
          id="473284"
          type_id="1"
          status="+"
          setter="darin"
    />
          </attachment>
      

    </bug>

</bugzilla>