234503 2021-12-19 22:14:57 -0800 [Win] MSVC reports "DumpRenderTree.cpp(633): error C2362: initialization of 'length' is skipped by 'goto exit'" with /std:c++20 2022-01-04 22:55:13 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 233448 1 fujii fujii darin don.olmstead ross.kirsling webkit-bug-importer oldest_to_newest 1825537 0 fujii 2021-12-19 22:14:57 -0800 [Win] MSVC reports "DumpRenderTree.cpp(633): error C2362: initialization of 'length' is skipped by 'goto exit'" with /std:c++20 > Tools\DumpRenderTree\win\DumpRenderTree.cpp(633): error C2362: initialization of 'length' is skipped by 'goto exit' > Tools\DumpRenderTree\win\DumpRenderTree.cpp(611): note: see declaration of 'length' > Tools\DumpRenderTree\win\DumpRenderTree.cpp(633): note: see declaration of 'exit' 1825538 1 447583 fujii 2021-12-19 22:18:37 -0800 Created attachment 447583 Patch 1825694 2 447621 fujii 2021-12-20 12:46:44 -0800 Created attachment 447621 Patch r287297 1825865 3 447621 fujii 2021-12-20 20:52:29 -0800 Comment on attachment 447621 Patch r287297 Clearing flags on attachment: 447621 Committed r287297 (245449@trunk): <https://commits.webkit.org/245449@trunk> 1825866 4 fujii 2021-12-20 20:52:33 -0800 All reviewed patches have been landed. Closing bug. 1825867 5 webkit-bug-importer 2021-12-20 20:53:16 -0800 <rdar://problem/86752706> 1825917 6 447621 darin 2021-12-21 01:20:34 -0800 Comment on attachment 447621 Patch r287297 View in context: https://bugs.webkit.org/attachment.cgi?id=447621&action=review > Tools/DumpRenderTree/win/DumpRenderTree.cpp:597 > + SAFEARRAY* arraryPtr; "array" is good, but "arrary" not so good > Tools/DumpRenderTree/win/DumpRenderTree.cpp:605 > + std::unique_ptr<SAFEARRAY, decltype(deleter)> array(arraryPtr, deleter); I suspect we can rely on deduction guides and just write std::unique_ptr here without the template arguments. 1825945 7 fujii 2021-12-21 02:27:23 -0800 Reopened. 1826167 8 447766 fujii 2021-12-21 17:05:13 -0800 Created attachment 447766 Patch 1828188 9 447766 fujii 2022-01-04 22:53:10 -0800 Comment on attachment 447766 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=447766&action=review > Tools/DumpRenderTree/win/DumpRenderTree.cpp:602 > + if (SUCCEEDED(::SafeArrayUnlock(arrayPtr))) This code has another bug. I'm going to fix this typo and the bug in the following ticket. Bug 234870 – [Win][DumpRenderTree] dumpHistoryItem leaks a SafeArray 447583 2021-12-19 22:18:37 -0800 2021-12-20 12:46:32 -0800 Patch bug-234503-20211220151836.patch text/plain 3063 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjg3MjUzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNzQ3OTIwOWQ2YjI1YzVkNWUzNTFhMzhhMzE4Y2IwZDlm MjU2MzdhMS4uZDJjY2U1MWZmNzc2MGFjNzU3YjFlM2JkZWRkNTczMTVkM2NjY2E1NCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDIxLTEyLTE5ICBGdWppaSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29t PgorCisgICAgICAgIFtXaW5dIE1TVkMgcmVwb3J0cyAiRHVtcFJlbmRlclRyZWUuY3BwKDYzMyk6 IGVycm9yIEMyMzYyOiBpbml0aWFsaXphdGlvbiBvZiAnbGVuZ3RoJyBpcyBza2lwcGVkIGJ5ICdn b3RvIGV4aXQnIiB3aXRoIC9zdGQ6YysrMjAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTIzNDUwMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogRHVtcFJlbmRlclRyZWUvd2luL0R1bXBSZW5kZXJUcmVlLmNw cDoKKyAgICAgICAgKGR1bXBIaXN0b3J5SXRlbSk6IFJlaW1wbGVtZW50ZWQgd2l0aG91dCBnb3Rv IHN0YXRlbWVudHMuCisKIDIwMjEtMTItMTggIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5z ZW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBbTW9udGVyZXldIFRlc3RXZWJLaXRBUEkuUHJpdmF0 ZUNsaWNrTWVhc3VyZW1lbnQuRGFlbW9uKiB0ZXN0cyB0aW1pbmcgb3V0OiBGYWlsZWQgdG8gY29u bmVjdCB0byBtYWNoIHNlcnZpY2Ugb3JnLndlYmtpdC5wY210ZXN0ZGFlbW9uLnNlcnZpY2UKZGlm ZiAtLWdpdCBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL3dpbi9EdW1wUmVuZGVyVHJlZS5jcHAgYi9U b29scy9EdW1wUmVuZGVyVHJlZS93aW4vRHVtcFJlbmRlclRyZWUuY3BwCmluZGV4IDRkNzM5Yjc2 YTQ4MjZmZDA5ZTc5YTFlN2YxZDZkOTQ0ZDM1YzA0MjguLjQ3NGUyOThiNzE5YmVjN2EwMDc1MDFh NGVmOTA4NTMyNDUzMWM4MTEgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL3dpbi9E dW1wUmVuZGVyVHJlZS5jcHAKKysrIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvd2luL0R1bXBSZW5k ZXJUcmVlLmNwcApAQCAtNTk4LDI4ICs1OTgsMzQgQEAgc3RhdGljIHZvaWQgZHVtcEhpc3RvcnlJ dGVtKElXZWJIaXN0b3J5SXRlbSogaXRlbSwgaW50IGluZGVudCwgYm9vbCBjdXJyZW50KQogICAg IGlmIChGQUlMRUQoaXRlbVByaXZhdGUtPmNoaWxkcmVuKCZraWRzQ291bnQsICZhcnJQdHIpKSB8 fCAha2lkc0NvdW50KQogICAgICAgICByZXR1cm47CiAKKyAgICBhdXRvIGFyckRlbGV0ZXIgPSBb XShTQUZFQVJSQVkqIGFyclB0cikgeworICAgICAgICBpZiAoYXJyUHRyICYmIFNVQ0NFRURFRCg6 OlNhZmVBcnJheVVubG9jayhhcnJQdHIpKSkKKyAgICAgICAgICAgIDo6U2FmZUFycmF5RGVzdHJv eShhcnJQdHIpOworICAgIH07CisgICAgc3RkOjp1bmlxdWVfcHRyPFNBRkVBUlJBWSwgZGVjbHR5 cGUoYXJyRGVsZXRlcik+IGFycihhcnJQdHIpOworCiAgICAgVmVjdG9yPENPTVB0cjxJVW5rbm93 bj4gPiBraWRzVmVjdG9yOwogCiAgICAgTE9ORyBsb3dlckJvdW5kOwotICAgIGlmIChGQUlMRUQo OjpTYWZlQXJyYXlHZXRMQm91bmQoYXJyUHRyLCAxLCAmbG93ZXJCb3VuZCkpKQotICAgICAgICBn b3RvIGV4aXQ7CisgICAgaWYgKEZBSUxFRCg6OlNhZmVBcnJheUdldExCb3VuZChhcnIuZ2V0KCks IDEsICZsb3dlckJvdW5kKSkpCisgICAgICAgIHJldHVybjsKIAogICAgIExPTkcgdXBwZXJCb3Vu ZDsKLSAgICBpZiAoRkFJTEVEKDo6U2FmZUFycmF5R2V0VUJvdW5kKGFyclB0ciwgMSwgJnVwcGVy Qm91bmQpKSkKLSAgICAgICAgZ290byBleGl0OworICAgIGlmIChGQUlMRUQoOjpTYWZlQXJyYXlH ZXRVQm91bmQoYXJyLmdldCgpLCAxLCAmdXBwZXJCb3VuZCkpKQorICAgICAgICByZXR1cm47CiAK ICAgICBMT05HIGxlbmd0aCA9IHVwcGVyQm91bmQgLSBsb3dlckJvdW5kICsgMTsKICAgICBpZiAo IWxlbmd0aCkKLSAgICAgICAgZ290byBleGl0OworICAgICAgICByZXR1cm47CiAgICAgQVNTRVJU KGxlbmd0aCA9PSBraWRzQ291bnQpOwogCiAgICAgSVVua25vd24qKiBzYWZlQXJyYXlEYXRhOwot ICAgIGlmIChGQUlMRUQoOjpTYWZlQXJyYXlBY2Nlc3NEYXRhKGFyclB0ciwgKHZvaWQqKikmc2Fm ZUFycmF5RGF0YSkpKQotICAgICAgICBnb3RvIGV4aXQ7CisgICAgaWYgKEZBSUxFRCg6OlNhZmVB cnJheUFjY2Vzc0RhdGEoYXJyLmdldCgpLCAodm9pZCoqKSZzYWZlQXJyYXlEYXRhKSkpCisgICAg ICAgIHJldHVybjsKIAogICAgIGZvciAoaW50IGkgPSAwOyBpIDwgbGVuZ3RoOyArK2kpCiAgICAg ICAgIGtpZHNWZWN0b3IuYXBwZW5kKHNhZmVBcnJheURhdGFbaV0pOwotICAgIDo6U2FmZUFycmF5 VW5hY2Nlc3NEYXRhKGFyclB0cik7CisgICAgOjpTYWZlQXJyYXlVbmFjY2Vzc0RhdGEoYXJyLmdl dCgpKTsKIAogICAgIC8vIG11c3Qgc29ydCB0byBlbGltaW5hdGUgYXJiaXRyYXJ5IHJlc3VsdCBv cmRlcmluZyB3aGljaCBkZWZlYXRzIHJlcHJvZHVjaWJsZSB0ZXN0aW5nCiAgICAgcXNvcnQoa2lk c1ZlY3Rvci5kYXRhKCksIGtpZHNDb3VudCwgc2l6ZW9mKGtpZHNWZWN0b3JbMF0pLCBjb21wYXJl SGlzdG9yeUl0ZW1zKTsKQEAgLTYyOSwxMCArNjM1LDYgQEAgc3RhdGljIHZvaWQgZHVtcEhpc3Rv cnlJdGVtKElXZWJIaXN0b3J5SXRlbSogaXRlbSwgaW50IGluZGVudCwgYm9vbCBjdXJyZW50KQog ICAgICAgICBraWRzVmVjdG9yW2ldLT5RdWVyeUludGVyZmFjZSgmaXRlbSk7CiAgICAgICAgIGR1 bXBIaXN0b3J5SXRlbShpdGVtLmdldCgpLCBpbmRlbnQgKyA0LCBmYWxzZSk7CiAgICAgfQotCi1l eGl0OgotICAgIGlmIChhcnJQdHIgJiYgU1VDQ0VFREVEKDo6U2FmZUFycmF5VW5sb2NrKGFyclB0 cikpKQotICAgICAgICA6OlNhZmVBcnJheURlc3Ryb3koYXJyUHRyKTsKIH0KIAogc3RhdGljIHZv aWQgZHVtcEJhY2tGb3J3YXJkTGlzdChJV2ViVmlldyogd2ViVmlldykK 447621 2021-12-20 12:46:44 -0800 2022-01-04 22:54:04 -0800 Patch r287297 bug-234503-20211221054643.patch text/plain 3209 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjg3MjcyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZTBkMzA5OTQyMjBjZTRjNmVkZGJmOWM1MWVmOWFhZTNi MDQxOTQ2NS4uMDE5MDU5YTRiMmQxYjA1OGQ3MmY0MzkyNmI1ODE0YWFkNGU1MWEyMCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDIxLTEyLTIwICBGdWppaSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29t PgorCisgICAgICAgIFtXaW5dIE1TVkMgcmVwb3J0cyAiRHVtcFJlbmRlclRyZWUuY3BwKDYzMyk6 IGVycm9yIEMyMzYyOiBpbml0aWFsaXphdGlvbiBvZiAnbGVuZ3RoJyBpcyBza2lwcGVkIGJ5ICdn b3RvIGV4aXQnIiB3aXRoIC9zdGQ6YysrMjAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTIzNDUwMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogRHVtcFJlbmRlclRyZWUvd2luL0R1bXBSZW5kZXJUcmVlLmNw cDoKKyAgICAgICAgKGR1bXBIaXN0b3J5SXRlbSk6IFJlbW92ZWQgZ290byBzdGF0ZW1lbnRzLiBV c2Ugc3RkOjp1bmlxdWVfcHRyIGZvciBTQUZFQVJSQVkuCisKIDIwMjEtMTItMjAgIFRpbSBOZ3V5 ZW4gIDxudGltQGFwcGxlLmNvbT4KIAogICAgICAgICBTdG9wIGFzc3VtaW5nIFdQVCBpcyBhIHJl ZnRlc3QgYmFzZWQgb24gZXhpc3RlbmNlIG9mIC1yZWYuaHRtbCBmaWxlCmRpZmYgLS1naXQgYS9U b29scy9EdW1wUmVuZGVyVHJlZS93aW4vRHVtcFJlbmRlclRyZWUuY3BwIGIvVG9vbHMvRHVtcFJl bmRlclRyZWUvd2luL0R1bXBSZW5kZXJUcmVlLmNwcAppbmRleCA0ZDczOWI3NmE0ODI2ZmQwOWU3 OWExZTdmMWQ2ZDk0NGQzNWMwNDI4Li45ZTBkNTRlZGQxNWM0NzU3ZGU0MTI4MGRlZTQyOWM3NmI3 YmJhODQ5IDEwMDY0NAotLS0gYS9Ub29scy9EdW1wUmVuZGVyVHJlZS93aW4vRHVtcFJlbmRlclRy ZWUuY3BwCisrKyBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL3dpbi9EdW1wUmVuZGVyVHJlZS5jcHAK QEAgLTU5NCwzMiArNTk0LDM4IEBAIHN0YXRpYyB2b2lkIGR1bXBIaXN0b3J5SXRlbShJV2ViSGlz dG9yeUl0ZW0qIGl0ZW0sIGludCBpbmRlbnQsIGJvb2wgY3VycmVudCkKICAgICBmcHV0YygnXG4n LCB0ZXN0UmVzdWx0KTsKIAogICAgIHVuc2lnbmVkIGtpZHNDb3VudDsKLSAgICBTQUZFQVJSQVkq IGFyclB0cjsKLSAgICBpZiAoRkFJTEVEKGl0ZW1Qcml2YXRlLT5jaGlsZHJlbigma2lkc0NvdW50 LCAmYXJyUHRyKSkgfHwgIWtpZHNDb3VudCkKKyAgICBTQUZFQVJSQVkqIGFycmFyeVB0cjsKKyAg ICBpZiAoRkFJTEVEKGl0ZW1Qcml2YXRlLT5jaGlsZHJlbigma2lkc0NvdW50LCAmYXJyYXJ5UHRy KSkgfHwgIWtpZHNDb3VudCkKICAgICAgICAgcmV0dXJuOwogCisgICAgYXV0byBkZWxldGVyID0g W10oU0FGRUFSUkFZKiBhcnJhcnlQdHIpIHsKKyAgICAgICAgaWYgKGFycmFyeVB0ciAmJiBTVUND RUVERUQoOjpTYWZlQXJyYXlVbmxvY2soYXJyYXJ5UHRyKSkpCisgICAgICAgICAgICA6OlNhZmVB cnJheURlc3Ryb3koYXJyYXJ5UHRyKTsKKyAgICB9OworICAgIHN0ZDo6dW5pcXVlX3B0cjxTQUZF QVJSQVksIGRlY2x0eXBlKGRlbGV0ZXIpPiBhcnJheShhcnJhcnlQdHIsIGRlbGV0ZXIpOworCiAg ICAgVmVjdG9yPENPTVB0cjxJVW5rbm93bj4gPiBraWRzVmVjdG9yOwogCiAgICAgTE9ORyBsb3dl ckJvdW5kOwotICAgIGlmIChGQUlMRUQoOjpTYWZlQXJyYXlHZXRMQm91bmQoYXJyUHRyLCAxLCAm bG93ZXJCb3VuZCkpKQotICAgICAgICBnb3RvIGV4aXQ7CisgICAgaWYgKEZBSUxFRCg6OlNhZmVB cnJheUdldExCb3VuZChhcnJheS5nZXQoKSwgMSwgJmxvd2VyQm91bmQpKSkKKyAgICAgICAgcmV0 dXJuOwogCiAgICAgTE9ORyB1cHBlckJvdW5kOwotICAgIGlmIChGQUlMRUQoOjpTYWZlQXJyYXlH ZXRVQm91bmQoYXJyUHRyLCAxLCAmdXBwZXJCb3VuZCkpKQotICAgICAgICBnb3RvIGV4aXQ7Cisg ICAgaWYgKEZBSUxFRCg6OlNhZmVBcnJheUdldFVCb3VuZChhcnJheS5nZXQoKSwgMSwgJnVwcGVy Qm91bmQpKSkKKyAgICAgICAgcmV0dXJuOwogCiAgICAgTE9ORyBsZW5ndGggPSB1cHBlckJvdW5k IC0gbG93ZXJCb3VuZCArIDE7CiAgICAgaWYgKCFsZW5ndGgpCi0gICAgICAgIGdvdG8gZXhpdDsK KyAgICAgICAgcmV0dXJuOwogICAgIEFTU0VSVChsZW5ndGggPT0ga2lkc0NvdW50KTsKIAogICAg IElVbmtub3duKiogc2FmZUFycmF5RGF0YTsKLSAgICBpZiAoRkFJTEVEKDo6U2FmZUFycmF5QWNj ZXNzRGF0YShhcnJQdHIsICh2b2lkKiopJnNhZmVBcnJheURhdGEpKSkKLSAgICAgICAgZ290byBl eGl0OworICAgIGlmIChGQUlMRUQoOjpTYWZlQXJyYXlBY2Nlc3NEYXRhKGFycmF5LmdldCgpLCAo dm9pZCoqKSZzYWZlQXJyYXlEYXRhKSkpCisgICAgICAgIHJldHVybjsKIAogICAgIGZvciAoaW50 IGkgPSAwOyBpIDwgbGVuZ3RoOyArK2kpCiAgICAgICAgIGtpZHNWZWN0b3IuYXBwZW5kKHNhZmVB cnJheURhdGFbaV0pOwotICAgIDo6U2FmZUFycmF5VW5hY2Nlc3NEYXRhKGFyclB0cik7CisgICAg OjpTYWZlQXJyYXlVbmFjY2Vzc0RhdGEoYXJyYXkuZ2V0KCkpOwogCiAgICAgLy8gbXVzdCBzb3J0 IHRvIGVsaW1pbmF0ZSBhcmJpdHJhcnkgcmVzdWx0IG9yZGVyaW5nIHdoaWNoIGRlZmVhdHMgcmVw cm9kdWNpYmxlIHRlc3RpbmcKICAgICBxc29ydChraWRzVmVjdG9yLmRhdGEoKSwga2lkc0NvdW50 LCBzaXplb2Yoa2lkc1ZlY3RvclswXSksIGNvbXBhcmVIaXN0b3J5SXRlbXMpOwpAQCAtNjI5LDEw ICs2MzUsNiBAQCBzdGF0aWMgdm9pZCBkdW1wSGlzdG9yeUl0ZW0oSVdlYkhpc3RvcnlJdGVtKiBp dGVtLCBpbnQgaW5kZW50LCBib29sIGN1cnJlbnQpCiAgICAgICAgIGtpZHNWZWN0b3JbaV0tPlF1 ZXJ5SW50ZXJmYWNlKCZpdGVtKTsKICAgICAgICAgZHVtcEhpc3RvcnlJdGVtKGl0ZW0uZ2V0KCks IGluZGVudCArIDQsIGZhbHNlKTsKICAgICB9Ci0KLWV4aXQ6Ci0gICAgaWYgKGFyclB0ciAmJiBT VUNDRUVERUQoOjpTYWZlQXJyYXlVbmxvY2soYXJyUHRyKSkpCi0gICAgICAgIDo6U2FmZUFycmF5 RGVzdHJveShhcnJQdHIpOwogfQogCiBzdGF0aWMgdm9pZCBkdW1wQmFja0ZvcndhcmRMaXN0KElX ZWJWaWV3KiB3ZWJWaWV3KQo= 447766 2021-12-21 17:05:13 -0800 2022-01-04 22:53:22 -0800 Patch bug-234503-20211222100512.patch text/plain 2062 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjg3MzMzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZDUzOTQ4Y2RkNGQzYTllZmNiYWMzNmI3YWExYjE5MTIw ZGVkNmM3OC4uNTg3NDhlZmY4YWU5NDlkM2VjOWIyNDZiNmRiNzQ4Mjg1NzNlM2I3MCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDIxLTEyLTIxICBGdWppaSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29t PgorCisgICAgICAgIFtXaW5dIE1TVkMgcmVwb3J0cyAiRHVtcFJlbmRlclRyZWUuY3BwKDYzMyk6 IGVycm9yIEMyMzYyOiBpbml0aWFsaXphdGlvbiBvZiAnbGVuZ3RoJyBpcyBza2lwcGVkIGJ5ICdn b3RvIGV4aXQnIiB3aXRoIC9zdGQ6YysrMjAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTIzNDUwMworICAgICAgICA8cmRhcjovL3Byb2JsZW0vODY3NTI3 MDY+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBE dW1wUmVuZGVyVHJlZS93aW4vRHVtcFJlbmRlclRyZWUuY3BwOgorICAgICAgICAoZHVtcEhpc3Rv cnlJdGVtKTogRml4ZWQgYSB0eXBvICdhcnJhcnknLiBSZW1vdmVkIGFuIHVubmVjZXNzYXJ5Cisg ICAgICAgIGNvbmRpdGlvbiBjaGVja2luZyBhIHBvaW50ZXIgaW4gdGhlIGN1c3RvbSBkZWxldGVy LgorCiAyMDIxLTEyLTIxICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgog CiAgICAgICAgIEFsbG93IGEgd2F5IHRvIHNwZWNpZnkgYSBjdXN0b20gcGl4ZWwgdG9sZXJhbmNl IGluIGEgcmVmIHRlc3QKZGlmZiAtLWdpdCBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL3dpbi9EdW1w UmVuZGVyVHJlZS5jcHAgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS93aW4vRHVtcFJlbmRlclRyZWUu Y3BwCmluZGV4IDllMGQ1NGVkZDE1YzQ3NTdkZTQxMjgwZGVlNDI5Yzc2YjdiYmE4NDkuLjZlYmU4 ZjMwMmIxM2E1NTBkNzQxNzM3YmYwYTRhNjJlYjQ2YWNhOTEgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0R1 bXBSZW5kZXJUcmVlL3dpbi9EdW1wUmVuZGVyVHJlZS5jcHAKKysrIGIvVG9vbHMvRHVtcFJlbmRl clRyZWUvd2luL0R1bXBSZW5kZXJUcmVlLmNwcApAQCAtNTk0LDE1ICs1OTQsMTUgQEAgc3RhdGlj IHZvaWQgZHVtcEhpc3RvcnlJdGVtKElXZWJIaXN0b3J5SXRlbSogaXRlbSwgaW50IGluZGVudCwg Ym9vbCBjdXJyZW50KQogICAgIGZwdXRjKCdcbicsIHRlc3RSZXN1bHQpOwogCiAgICAgdW5zaWdu ZWQga2lkc0NvdW50OwotICAgIFNBRkVBUlJBWSogYXJyYXJ5UHRyOwotICAgIGlmIChGQUlMRUQo aXRlbVByaXZhdGUtPmNoaWxkcmVuKCZraWRzQ291bnQsICZhcnJhcnlQdHIpKSB8fCAha2lkc0Nv dW50KQorICAgIFNBRkVBUlJBWSogYXJyYXlQdHI7CisgICAgaWYgKEZBSUxFRChpdGVtUHJpdmF0 ZS0+Y2hpbGRyZW4oJmtpZHNDb3VudCwgJmFycmF5UHRyKSkgfHwgIWtpZHNDb3VudCkKICAgICAg ICAgcmV0dXJuOwogCi0gICAgYXV0byBkZWxldGVyID0gW10oU0FGRUFSUkFZKiBhcnJhcnlQdHIp IHsKLSAgICAgICAgaWYgKGFycmFyeVB0ciAmJiBTVUNDRUVERUQoOjpTYWZlQXJyYXlVbmxvY2so YXJyYXJ5UHRyKSkpCi0gICAgICAgICAgICA6OlNhZmVBcnJheURlc3Ryb3koYXJyYXJ5UHRyKTsK KyAgICBhdXRvIGRlbGV0ZXIgPSBbXShTQUZFQVJSQVkqIGFycmF5UHRyKSB7CisgICAgICAgIGlm IChTVUNDRUVERUQoOjpTYWZlQXJyYXlVbmxvY2soYXJyYXlQdHIpKSkKKyAgICAgICAgICAgIDo6 U2FmZUFycmF5RGVzdHJveShhcnJheVB0cik7CiAgICAgfTsKLSAgICBzdGQ6OnVuaXF1ZV9wdHI8 U0FGRUFSUkFZLCBkZWNsdHlwZShkZWxldGVyKT4gYXJyYXkoYXJyYXJ5UHRyLCBkZWxldGVyKTsK KyAgICBzdGQ6OnVuaXF1ZV9wdHI8U0FGRUFSUkFZLCBkZWNsdHlwZShkZWxldGVyKT4gYXJyYXko YXJyYXlQdHIsIGRlbGV0ZXIpOwogCiAgICAgVmVjdG9yPENPTVB0cjxJVW5rbm93bj4gPiBraWRz VmVjdG9yOwogCg==