234501 2021-12-19 20:41:48 -0800 [Win] MSVC reports "COMVariantSetter.h(133): error C2760: syntax error: unexpected token 'identifier', expected ';'" with /std:c++20 2021-12-20 11:59:17 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 233448 1 fujii fujii don.olmstead webkit-bug-importer oldest_to_newest 1825527 0 fujii 2021-12-19 20:41:48 -0800 [Win] MSVC reports "COMVariantSetter.h(133): error C2760: syntax error: unexpected token 'identifier', expected ';'" with /std:c++20 > Source\WebKitLegacy\win\COMVariantSetter.h(133): error C2760: syntax error: unexpected token 'identifier', expected ';' > Source\WebKitLegacy\win\COMVariantSetter.h(140): note: see reference to class template instantiation 'COMVariantSetter<WTF::Vector<T,0,WTF::CrashOnOverflow,16,WTF::VectorMalloc>>' being compiled 1825528 1 447577 fujii 2021-12-19 20:46:40 -0800 Created attachment 447577 Patch 1825673 2 447577 fujii 2021-12-20 11:58:44 -0800 Comment on attachment 447577 Patch Clearing flags on attachment: 447577 Committed r287269 (245425@trunk): <https://commits.webkit.org/245425@trunk> 1825674 3 fujii 2021-12-20 11:58:48 -0800 All reviewed patches have been landed. Closing bug. 1825675 4 webkit-bug-importer 2021-12-20 11:59:17 -0800 <rdar://problem/86734480> 447577 2021-12-19 20:46:40 -0800 2021-12-20 11:58:44 -0800 Patch bug-234501-20211220134639.patch text/plain 3215 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjg3MjUyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0TGVn YWN5L3dpbi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0TGVnYWN5L3dpbi9DaGFuZ2VMb2cKaW5k ZXggNDZmYWZlMWZiOWIwNGY3YzBkZGE5M2FlYTlhMGQ3MjMyNjU5MWY4OC4uMTM5MjYxMWI1ZDFl NjBkYzMzMzkwNThlYWU3MGU0OWRiZTcxOTUzNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdExl Z2FjeS93aW4vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXRMZWdhY3kvd2luL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE5IEBACisyMDIxLTEyLTE5ICBGdWppaSBIaXJvbm9yaSAgPEhpcm9ub3Jp LkZ1amlpQHNvbnkuY29tPgorCisgICAgICAgIFtXaW5dIE1TVkMgcmVwb3J0cyAiQ09NVmFyaWFu dFNldHRlci5oKDEzMyk6IGVycm9yIEMyNzYwOiBzeW50YXggZXJyb3I6IHVuZXhwZWN0ZWQgdG9r ZW4gJ2lkZW50aWZpZXInLCBleHBlY3RlZCAnOyciIHdpdGggL3N0ZDpjKysyMAorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjM0NTAxCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgPiBTb3VyY2VcV2ViS2l0TGVn YWN5XHdpblxDT01WYXJpYW50U2V0dGVyLmgoMTMzKTogZXJyb3IgQzI3NjA6IHN5bnRheCBlcnJv cjogdW5leHBlY3RlZCB0b2tlbiAnaWRlbnRpZmllcicsIGV4cGVjdGVkICc7JworICAgICAgICA+ IFNvdXJjZVxXZWJLaXRMZWdhY3lcd2luXENPTVZhcmlhbnRTZXR0ZXIuaCgxNDApOiBub3RlOiBz ZWUgcmVmZXJlbmNlIHRvIGNsYXNzIHRlbXBsYXRlIGluc3RhbnRpYXRpb24gJ0NPTVZhcmlhbnRT ZXR0ZXI8V1RGOjpWZWN0b3I8VCwwLFdURjo6Q3Jhc2hPbk92ZXJmbG93LDE2LFdURjo6VmVjdG9y TWFsbG9jPj4nIGJlaW5nIGNvbXBpbGVkCisKKyAgICAgICAgQ09NVmFyaWFudCBzaG91bGQgYmUg dXNlZCBhZnRlciBkZWZpbmVkLgorCisgICAgICAgICogQ09NVmFyaWFudFNldHRlci5oOgorICAg ICAgICAoQ09NVmFyaWFudFNldHRlcjxWZWN0b3I8VD4+KTogTW92ZWQgYWZ0ZXIgdGhlIENPTVZh cmlhbnQKKyAgICAgICAgZGVmaW5pdGlvbi4KKwogMjAyMS0xMi0xOSAgV2Vuc29uIEhzaWVoICA8 d2Vuc29uX2hzaWVoQGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQgY2xpZW50IGxheWVyIHBsdW1i aW5nIGZvciBjbGFzc2lmeWluZyBtb2RhbCBjb250YWluZXIgY29udHJvbHMKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXRMZWdhY3kvd2luL0NPTVZhcmlhbnRTZXR0ZXIuaCBiL1NvdXJjZS9XZWJL aXRMZWdhY3kvd2luL0NPTVZhcmlhbnRTZXR0ZXIuaAppbmRleCAwZjFhYjFkODY1MmJlZDIwOWYx ZWM4YmQzOGQ2NTU2M2E4MDgwNmUyLi5iNzllMWZhYjQwZjcxMzNiZmI5ZGIwYWYyZTdhMjQwM2Ew YjAyNzg5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0TGVnYWN5L3dpbi9DT01WYXJpYW50U2V0 dGVyLmgKKysrIGIvU291cmNlL1dlYktpdExlZ2FjeS93aW4vQ09NVmFyaWFudFNldHRlci5oCkBA IC0xMjEsMjQgKzEyMSw2IEBAIHRlbXBsYXRlPHR5cGVuYW1lIFQ+IHN0cnVjdCBDT01WYXJpYW50 U2V0dGVyPENPTVB0cjxUPiA+IDogQ09NVmFyaWFudFNldHRlckJhc2U8CiAgICAgfQogfTsKIAot dGVtcGxhdGU8dHlwZW5hbWUgVD4gc3RydWN0IENPTVZhcmlhbnRTZXR0ZXI8VmVjdG9yPFQ+PiA6 IENPTVZhcmlhbnRTZXR0ZXJCYXNlPFZlY3RvcjxUPj4gewotICAgIHN0YXRpYyBjb25zdCBWQVJU WVBFIFZhcmlhbnRUeXBlID0gVlRfQVJSQVkgfCBDT01WYXJpYW50U2V0dGVyPFQ+OjpWYXJpYW50 VHlwZTsKLQotICAgIHN0YXRpYyB2b2lkIHNldFZhcmlhbnQoVkFSSUFOVCogdmFyaWFudCwgY29u c3QgVmVjdG9yPFQ+JiB2YWx1ZSkKLSAgICB7Ci0gICAgICAgIEFTU0VSVChWX1ZUKHZhcmlhbnQp ID09IFZUX0VNUFRZKTsKLQotICAgICAgICBTQUZFQVJSQVkqIHNhZmVBcnJheSA9IDo6U2FmZUFy cmF5Q3JlYXRlVmVjdG9yKENPTVZhcmlhbnRTZXR0ZXI8VD46OlZhcmlhbnRUeXBlLCAwLCB2YWx1 ZS5zaXplKCkpOwotICAgICAgICBmb3IgKExPTkcgaSA9IDA7IGkgPCB2YWx1ZS5zaXplKCk7ICsr aSkgewotICAgICAgICAgICAgQ09NVmFyaWFudCBpdGVtKHZhbHVlW2ldKTsKLSAgICAgICAgICAg IDo6U2FmZUFycmF5UHV0RWxlbWVudChzYWZlQXJyYXksICZpLCAmaXRlbSk7Ci0gICAgICAgIH0K LQotICAgICAgICBWX1ZUKHZhcmlhbnQpID0gVmFyaWFudFR5cGU7Ci0gICAgICAgIFZfQVJSQVko dmFyaWFudCkgPSBzYWZlQXJyYXk7Ci0gICAgfQotfTsKLQogdGVtcGxhdGU8dHlwZW5hbWUgQ09N VHlwZSwgdHlwZW5hbWUgVW5kZXJseWluZ1R5cGU+CiBzdHJ1Y3QgQ09NSVVua25vd25WYXJpYW50 U2V0dGVyIDogQ09NVmFyaWFudFNldHRlckJhc2U8VW5kZXJseWluZ1R5cGU+CiB7CkBAIC0yMjAs NCArMjAyLDIyIEBAIHRlbXBsYXRlPD4gc3RydWN0IENPTVZhcmlhbnRTZXR0ZXI8Q09NVmFyaWFu dD4KICAgICB9CiB9OwogCit0ZW1wbGF0ZTx0eXBlbmFtZSBUPiBzdHJ1Y3QgQ09NVmFyaWFudFNl dHRlcjxWZWN0b3I8VD4+IDogQ09NVmFyaWFudFNldHRlckJhc2U8VmVjdG9yPFQ+PiB7CisgICAg c3RhdGljIGNvbnN0IFZBUlRZUEUgVmFyaWFudFR5cGUgPSBWVF9BUlJBWSB8IENPTVZhcmlhbnRT ZXR0ZXI8VD46OlZhcmlhbnRUeXBlOworCisgICAgc3RhdGljIHZvaWQgc2V0VmFyaWFudChWQVJJ QU5UKiB2YXJpYW50LCBjb25zdCBWZWN0b3I8VD4mIHZhbHVlKQorICAgIHsKKyAgICAgICAgQVNT RVJUKFZfVlQodmFyaWFudCkgPT0gVlRfRU1QVFkpOworCisgICAgICAgIFNBRkVBUlJBWSogc2Fm ZUFycmF5ID0gOjpTYWZlQXJyYXlDcmVhdGVWZWN0b3IoQ09NVmFyaWFudFNldHRlcjxUPjo6VmFy aWFudFR5cGUsIDAsIHZhbHVlLnNpemUoKSk7CisgICAgICAgIGZvciAoTE9ORyBpID0gMDsgaSA8 IHZhbHVlLnNpemUoKTsgKytpKSB7CisgICAgICAgICAgICBDT01WYXJpYW50IGl0ZW0odmFsdWVb aV0pOworICAgICAgICAgICAgOjpTYWZlQXJyYXlQdXRFbGVtZW50KHNhZmVBcnJheSwgJmksICZp dGVtKTsKKyAgICAgICAgfQorCisgICAgICAgIFZfVlQodmFyaWFudCkgPSBWYXJpYW50VHlwZTsK KyAgICAgICAgVl9BUlJBWSh2YXJpYW50KSA9IHNhZmVBcnJheTsKKyAgICB9Cit9OworCiAjZW5k aWYgLy8gQ09NVmFyaWFudFNldHRlcgo=