234488 2021-12-19 11:38:23 -0800 Preferences that read from NSUserDefaults need to be initialied from platformInitializeStore() 2021-12-22 14:36:08 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified ASSIGNED https://bugs.webkit.org/show_bug.cgi?id=234456 InRadar P2 Normal --- 234620 1 simon.fraser simon.fraser commit-queue sam simon.fraser webkit-bug-importer oldest_to_newest 1825460 0 simon.fraser 2021-12-19 11:38:23 -0800 Preferences that read from NSUserDefaults need to be initialied from platformInitializeStore() 1825461 1 447553 simon.fraser 2021-12-19 11:40:20 -0800 Created attachment 447553 Patch 1825790 2 447553 sam 2021-12-20 15:55:56 -0800 Comment on attachment 447553 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=447553&action=review > Source/WebKit/UIProcess/Cocoa/WebPreferencesCocoa.mm:143 > +void WebPreferences::initializePlatformDependentPreferences() I don't think platform dependent is the right name, since everything in this file is platform dependent. Perhaps platformInitializeProcessStateDependentPreferences()? > Source/WebKit/UIProcess/Cocoa/WebPreferencesCocoa.mm:154 > + m_store.setBoolValueForKey(WebPreferencesKey::scrollAnimatorEnabledKey(), [[NSUserDefaults standardUserDefaults] boolForKey:@"NSScrollAnimationEnabled"]); I think you want to wrap this in #if PLATFORM(MAC)? 1826343 3 simon.fraser 2021-12-22 10:49:16 -0800 https://trac.webkit.org/changeset/287364/webkit 1826344 4 webkit-bug-importer 2021-12-22 10:50:17 -0800 <rdar://problem/86817858> 1826404 5 commit-queue 2021-12-22 14:30:13 -0800 Re-opened since this is blocked by bug 234620 447553 2021-12-19 11:40:20 -0800 2021-12-20 15:56:23 -0800 Patch bug-234488-20211219114020.patch text/plain 6736 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjg3MjQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGUyM2YzZmM2YjMxNjU0NTZiMjA3MWQ1 N2VjYjllYjA1NWMwZDg1MTguLmEwOTlkY2ZmNDBlZmRiMjc2ODIxNzFmOTVmMDE2ZmQ2NDQwZDlk MDcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjEtMTItMTkgIFNpbW9uIEZyYXNlciAgPHNpbW9u LmZyYXNlckBhcHBsZS5jb20+CisKKyAgICAgICAgUHJlZmVyZW5jZXMgdGhhdCByZWFkIGZyb20g TlNVc2VyRGVmYXVsdHMgbmVlZCB0byBiZSBpbml0aWFsaWVkIGZyb20gcGxhdGZvcm1Jbml0aWFs aXplU3RvcmUoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjM0NDg4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgSGF2aW5nIHRoZSBkZWZhdWx0IHZhbHVlIGZvciBhIHByZWZlcmVuY2UgcmVhZCBmcm9tIE5T VXNlckRlZmF1bHRzIGNhbiBjYXVzZSBpc3N1ZXMKKyAgICAgICAgaWYgdGhlIFVJUHJvY2VzcyBh bmQgV2ViUHJvY2VzcyB2YWx1ZXMgZG9uJ3QgbWF0Y2guIEluc3RlYWQsIGhhdmUgcGxhdGZvcm1J bml0aWFsaXplU3RvcmUoKQorICAgICAgICBleHBsaWNpdGx5IGFkZCB2YWx1ZXMgZm9yIHRoZXNl IGtleXM7IHRoaXMgaXMgZG9uZSBmb3Igc2Nyb2xsQW5pbWF0b3JFbmFibGVkS2V5LgorCisgICAg ICAgICogU2NyaXB0cy9QcmVmZXJlbmNlcy9XZWJQcmVmZXJlbmNlcy55YW1sOgorCiAyMDIxLTEy LTE4ICBEYXJpbiBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KIAogICAgICAgICBIYXNoIHRhYmxl cywgcmVhZC93cml0ZSwgYW5kIGhlYXAgbWVtb3J5IGFyZSB1c2VkIHVubmVjZXNzYXJpbHksIHdo aWNoIG1heSBodXJ0IHBlcmZvcm1hbmNlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0NoYW5n ZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDE0NDJjZmExZTc5NmRiMjNjMjg0 MDE2ZGEyMDYxMWEzZTVjZWEyNjAuLmUyOTkxYmVlMWY2OTAyYjQ3YzY5NmE1M2U0MzRhYzg2NjU4 MDRkYzEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9X ZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMjEtMTItMTkgIFNpbW9uIEZyYXNl ciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CisKKyAgICAgICAgUHJlZmVyZW5jZXMgdGhhdCBy ZWFkIGZyb20gTlNVc2VyRGVmYXVsdHMgbmVlZCB0byBiZSBpbml0aWFsaWVkIGZyb20gcGxhdGZv cm1Jbml0aWFsaXplU3RvcmUoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjM0NDg4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgSGF2aW5nIHRoZSBkZWZhdWx0IHZhbHVlIGZvciBhIHByZWZlcmVuY2UgcmVh ZCBmcm9tIE5TVXNlckRlZmF1bHRzIGNhbiBjYXVzZSBpc3N1ZXMKKyAgICAgICAgaWYgdGhlIFVJ UHJvY2VzcyBhbmQgV2ViUHJvY2VzcyB2YWx1ZXMgZG9uJ3QgbWF0Y2guIEluc3RlYWQsIGhhdmUg cGxhdGZvcm1Jbml0aWFsaXplU3RvcmUoKQorICAgICAgICBleHBsaWNpdGx5IGFkZCB2YWx1ZXMg Zm9yIHRoZXNlIGtleXM7IHRoaXMgaXMgZG9uZSBmb3Igc2Nyb2xsQW5pbWF0b3JFbmFibGVkS2V5 LgorCisgICAgICAgICogVUlQcm9jZXNzL0NvY29hL1dlYlByZWZlcmVuY2VzQ29jb2EubW06Cisg ICAgICAgIChXZWJLaXQ6OldlYlByZWZlcmVuY2VzOjppbml0aWFsaXplUGxhdGZvcm1EZXBlbmRl bnRQcmVmZXJlbmNlcyk6CisgICAgICAgIChXZWJLaXQ6OldlYlByZWZlcmVuY2VzOjpwbGF0Zm9y bUluaXRpYWxpemVTdG9yZSk6CisgICAgICAgICogVUlQcm9jZXNzL1dlYlByZWZlcmVuY2VzLmNw cDoKKyAgICAgICAgKFdlYktpdDo6V2ViUHJlZmVyZW5jZXM6OmluaXRpYWxpemVQbGF0Zm9ybURl cGVuZGVudFByZWZlcmVuY2VzKToKKyAgICAgICAgKiBVSVByb2Nlc3MvV2ViUHJlZmVyZW5jZXMu aDoKKwogMjAyMS0xMi0xOCAgRGFyaW4gQWRsZXIgIDxkYXJpbkBhcHBsZS5jb20+CiAKICAgICAg ICAgSGFzaCB0YWJsZXMsIHJlYWQvd3JpdGUsIGFuZCBoZWFwIG1lbW9yeSBhcmUgdXNlZCB1bm5l Y2Vzc2FyaWx5LCB3aGljaCBtYXkgaHVydCBwZXJmb3JtYW5jZQpkaWZmIC0tZ2l0IGEvU291cmNl L1dURi9TY3JpcHRzL1ByZWZlcmVuY2VzL1dlYlByZWZlcmVuY2VzLnlhbWwgYi9Tb3VyY2UvV1RG L1NjcmlwdHMvUHJlZmVyZW5jZXMvV2ViUHJlZmVyZW5jZXMueWFtbAppbmRleCBmZWI1YTgwZTBh MjdmMTJlNTU3NzU4MmMzYWJkY2YzYzkxOTMyYjFkLi5jMzFiY2ZmMmE3ZDIyMzBhYjljNjJhOTMx ZjgwMDRiZjE4MDI3YzMyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL1NjcmlwdHMvUHJlZmVyZW5j ZXMvV2ViUHJlZmVyZW5jZXMueWFtbAorKysgYi9Tb3VyY2UvV1RGL1NjcmlwdHMvUHJlZmVyZW5j ZXMvV2ViUHJlZmVyZW5jZXMueWFtbApAQCAtMTg5Myw3ICsxODkzLDcgQEAgU2Nyb2xsQW5pbWF0 b3JFbmFibGVkOgogICAgICAgIlBMQVRGT1JNKEdUSykgfHwgUExBVEZPUk0oV1BFKSI6IHRydWUK ICAgICAgIGRlZmF1bHQ6IGZhbHNlCiAgICAgV2ViS2l0OgotICAgICAgIlBMQVRGT1JNKE1BQyki OiBXZWJLaXQ6OmRlZmF1bHRTY3JvbGxBbmltYXRvckVuYWJsZWQoKQorICAgICAgIyBQTEFURk9S TShNQUMpIGluaXRpYWxpemVzIHRoZSB2YWx1ZSBpbiBpbml0aWFsaXplUGxhdGZvcm1EZXBlbmRl bnRQcmVmZXJlbmNlcwogICAgICAgIlBMQVRGT1JNKEdUSykgfHwgUExBVEZPUk0oV1BFKSI6IHRy dWUKICAgICAgIGRlZmF1bHQ6IGZhbHNlCiAgICAgV2ViQ29yZToKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQvVUlQcm9jZXNzL0NvY29hL1dlYlByZWZlcmVuY2VzQ29jb2EubW0gYi9Tb3VyY2Uv V2ViS2l0L1VJUHJvY2Vzcy9Db2NvYS9XZWJQcmVmZXJlbmNlc0NvY29hLm1tCmluZGV4IGNlN2Fj YTNjZWRlOGE1MjM5MzY0ZDQxODA1NjYzYmFlNzM1YTNlNTQuLjBlNjBkNDJlODE3OGE5OTVmNWQ1 NGM3YzM1Y2M3ZDMwNjJiY2Y5YmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNz L0NvY29hL1dlYlByZWZlcmVuY2VzQ29jb2EubW0KKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nl c3MvQ29jb2EvV2ViUHJlZmVyZW5jZXNDb2NvYS5tbQpAQCAtMTQwLDE4ICsxNDAsMjUgQEAgc3Rh dGljIHZvaWQgc2V0RGVidWdVSW50MzJWYWx1ZUlmSW5Vc2VyRGVmYXVsdHMoY29uc3QgU3RyaW5n JiBpZGVudGlmaWVyLCBjb25zdAogICAgIHN0b3JlLnNldFVJbnQzMlZhbHVlRm9yS2V5KGtleSwg W29iamVjdCB1bnNpZ25lZEludGVnZXJWYWx1ZV0pOwogfQogCi12b2lkIFdlYlByZWZlcmVuY2Vz OjpwbGF0Zm9ybUluaXRpYWxpemVTdG9yZSgpCit2b2lkIFdlYlByZWZlcmVuY2VzOjppbml0aWFs aXplUGxhdGZvcm1EZXBlbmRlbnRQcmVmZXJlbmNlcygpCiB7Ci0gICAgQGF1dG9yZWxlYXNlcG9v bCB7CiAjaWYgRU5BQkxFKE1FRElBX1NUUkVBTSkKLSAgICAgICAgLy8gTk9URTogVGhpcyBpcyBz ZXQgaGVyZSwgYW5kIGRvZXMgbm90IHNldHRpbmcgdGhlIGRlZmF1bHQgdXNpbmcgdGhlICdkZWZh dWx0VmFsdWUnIG1lY2hhbmlzbSwgYmVjYXVzZSB0aGUKLSAgICAgICAgLy8gJ2RlZmF1bHRWYWx1 ZScgbXVzdCBiZSB0aGUgc2FtZSBpbiBib3RoIHRoZSBVSVByb2Nlc3MgYW5kIFdlYlByb2Nlc3Ms IHdoaWNoIG1heSBub3QgYmUgdHJ1ZSBmb3IgYXVkaW8KLSAgICAgICAgLy8gYW5kIHZpZGVvIGNh cHR1cmUgc3RhdGUgYXMgdGhlIFdlYlByb2Nlc3MgaXMgbm90IGVudGl0bGVkIHRvIHVzZSB0aGUg Y2FtZXJhIG9yIG1pY3JvcGhvbmUgYnkgZGVmYXVsdC4KLSAgICAgICAgLy8gSWYgb3RoZXIgcHJl ZmVyZW5jZXMgbmVlZCB0byBkeW5hbWljYWxseSBzZXQgdGhlIGluaXRpYWwgdmFsdWUgYmFzZWQg b24gaG9zdCBhcHAgc3RhdGUsIHdlIHNob3VsZCBleHRlbmRlZAotICAgICAgICAvLyB0aGUgZGVj bGFyYXRpdmUgZm9ybWF0IHJhdGhlciB0aGFuIGFkZGluZyBtb3JlIHNwZWNpYWwgY2FzZXMgaGVy ZS4KLSAgICAgICAgbV9zdG9yZS5zZXRCb29sVmFsdWVGb3JLZXkoV2ViUHJlZmVyZW5jZXNLZXk6 Om1lZGlhRGV2aWNlc0VuYWJsZWRLZXkoKSwgVXNlck1lZGlhUGVybWlzc2lvblJlcXVlc3RNYW5h Z2VyUHJveHk6OnBlcm1pdHRlZFRvQ2FwdHVyZUF1ZGlvKCkgfHwgVXNlck1lZGlhUGVybWlzc2lv blJlcXVlc3RNYW5hZ2VyUHJveHk6OnBlcm1pdHRlZFRvQ2FwdHVyZVZpZGVvKCkpOworICAgIC8v IE5PVEU6IFRoaXMgaXMgc2V0IGhlcmUsIGFuZCBkb2VzIG5vdCBzZXQgdGhlIGRlZmF1bHQgdXNp bmcgdGhlICdkZWZhdWx0VmFsdWUnIG1lY2hhbmlzbSwgYmVjYXVzZSB0aGUKKyAgICAvLyAnZGVm YXVsdFZhbHVlJyBtdXN0IGJlIHRoZSBzYW1lIGluIGJvdGggdGhlIFVJUHJvY2VzcyBhbmQgV2Vi UHJvY2Vzcywgd2hpY2ggbWF5IG5vdCBiZSB0cnVlIGZvciBhdWRpbworICAgIC8vIGFuZCB2aWRl byBjYXB0dXJlIHN0YXRlIGFzIHRoZSBXZWJQcm9jZXNzIGlzIG5vdCBlbnRpdGxlZCB0byB1c2Ug dGhlIGNhbWVyYSBvciBtaWNyb3Bob25lIGJ5IGRlZmF1bHQuCisgICAgLy8gSWYgb3RoZXIgcHJl ZmVyZW5jZXMgbmVlZCB0byBkeW5hbWljYWxseSBzZXQgdGhlIGluaXRpYWwgdmFsdWUgYmFzZWQg b24gaG9zdCBhcHAgc3RhdGUsIHdlIHNob3VsZCBleHRlbmRlZAorICAgIC8vIHRoZSBkZWNsYXJh dGl2ZSBmb3JtYXQgcmF0aGVyIHRoYW4gYWRkaW5nIG1vcmUgc3BlY2lhbCBjYXNlcyBoZXJlLgor ICAgIG1fc3RvcmUuc2V0Qm9vbFZhbHVlRm9yS2V5KFdlYlByZWZlcmVuY2VzS2V5OjptZWRpYURl dmljZXNFbmFibGVkS2V5KCksIFVzZXJNZWRpYVBlcm1pc3Npb25SZXF1ZXN0TWFuYWdlclByb3h5 OjpwZXJtaXR0ZWRUb0NhcHR1cmVBdWRpbygpIHx8IFVzZXJNZWRpYVBlcm1pc3Npb25SZXF1ZXN0 TWFuYWdlclByb3h5OjpwZXJtaXR0ZWRUb0NhcHR1cmVWaWRlbygpKTsKICNlbmRpZgogCisgICAg bV9zdG9yZS5zZXRCb29sVmFsdWVGb3JLZXkoV2ViUHJlZmVyZW5jZXNLZXk6OnNjcm9sbEFuaW1h dG9yRW5hYmxlZEtleSgpLCBbW05TVXNlckRlZmF1bHRzIHN0YW5kYXJkVXNlckRlZmF1bHRzXSBi b29sRm9yS2V5OkAiTlNTY3JvbGxBbmltYXRpb25FbmFibGVkIl0pOworfQorCit2b2lkIFdlYlBy ZWZlcmVuY2VzOjpwbGF0Zm9ybUluaXRpYWxpemVTdG9yZSgpCit7CisgICAgQGF1dG9yZWxlYXNl cG9vbCB7CisgICAgICAgIGluaXRpYWxpemVQbGF0Zm9ybURlcGVuZGVudFByZWZlcmVuY2VzKCk7 CisKICNkZWZpbmUgSU5JVElBTElaRV9ERUJVR19QUkVGRVJFTkNFX0ZST01fTlNVU0VSREVGQVVM VFMoS2V5VXBwZXIsIEtleUxvd2VyLCBUeXBlTmFtZSwgVHlwZSwgRGVmYXVsdFZhbHVlLCBIdW1h blJlYWRhYmxlTmFtZSwgSHVtYW5SZWFkYWJsZURlc2NyaXB0aW9uKSBcCiAgICAgICAgIHNldERl YnVnIyNUeXBlTmFtZSMjVmFsdWVJZkluVXNlckRlZmF1bHRzKG1faWRlbnRpZmllciwgbV9rZXlQ cmVmaXgsIG1fZ2xvYmFsRGVidWdLZXlQcmVmaXgsIFdlYlByZWZlcmVuY2VzS2V5OjpLZXlMb3dl ciMjS2V5KCksIG1fc3RvcmUpOwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vz cy9XZWJQcmVmZXJlbmNlcy5jcHAgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQcmVmZXJl bmNlcy5jcHAKaW5kZXggOGI2N2YwZDE3ZGM4YTY5OGVjNDQ3MmRlZjRhNWViMzMyMzBjOWI1NS4u MWEyNThmN2Q2ODllNjUxZmI1YjhhZmYxZDk2MDlkZTU4YjIyZDQxMSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUHJlZmVyZW5jZXMuY3BwCisrKyBiL1NvdXJjZS9XZWJL aXQvVUlQcm9jZXNzL1dlYlByZWZlcmVuY2VzLmNwcApAQCAtMjI4LDYgKzIyOCwxMCBAQCB2b2lk IFdlYlByZWZlcmVuY2VzOjpwbGF0Zm9ybUluaXRpYWxpemVTdG9yZSgpCiAjZW5kaWYKIAogI2lm ICFQTEFURk9STShDT0NPQSkKK3ZvaWQgV2ViUHJlZmVyZW5jZXM6OmluaXRpYWxpemVQbGF0Zm9y bURlcGVuZGVudFByZWZlcmVuY2VzKCkKK3sKK30KKwogdm9pZCBXZWJQcmVmZXJlbmNlczo6cGxh dGZvcm1VcGRhdGVTdHJpbmdWYWx1ZUZvcktleShjb25zdCBTdHJpbmcmLCBjb25zdCBTdHJpbmcm KQogewogICAgIG5vdEltcGxlbWVudGVkKCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJ UHJvY2Vzcy9XZWJQcmVmZXJlbmNlcy5oIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUHJl ZmVyZW5jZXMuaAppbmRleCA5Mzc0M2NiMDBkNDMwYmMzYTgzODU5NzBmNWI1YTBlMGNlMTgyZGZl Li4xMmIzYWNjZTFlYjliYjQyZmVhYWMxYzgzNGMwYmE5ZWIwMDU3ODMzIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQcmVmZXJlbmNlcy5oCisrKyBiL1NvdXJjZS9XZWJL aXQvVUlQcm9jZXNzL1dlYlByZWZlcmVuY2VzLmgKQEAgLTg5LDYgKzg5LDcgQEAgcHVibGljOgog CiBwcml2YXRlOgogICAgIHZvaWQgcGxhdGZvcm1Jbml0aWFsaXplU3RvcmUoKTsKKyAgICB2b2lk IGluaXRpYWxpemVQbGF0Zm9ybURlcGVuZGVudFByZWZlcmVuY2VzKCk7CiAKICAgICB2b2lkIHVw ZGF0ZSgpOwogCg==