234487 2021-12-19 10:41:20 -0800 Running layout tests sometimes throws an AssertionError in python2.7/multiprocessing 2022-01-05 07:42:50 -0800 1 1 1 Unclassified WebKit Tools / Tests Safari Technology Preview Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser jbedard ap jbedard simon.fraser webkit-bug-importer oldest_to_newest 1825451 0 simon.fraser 2021-12-19 10:41:20 -0800 On 21D29a, iMac Pro, webkit r287227: OpenSource % wkquicktests LayoutTests/fast/scrolling Using port 'mac-monterey-wk2' Test configuration: <monterey, x86_64, debug> Placing test results in /Volumes/Data/Development/system/webkit/OpenSource/WebKitBuild/Debug/layout-test-results Using Debug build Pixel tests disabled Regular timeout: 30000, slow test timeout: 150000 Command line: /Volumes/Data/Development/system/webkit/OpenSource/WebKitBuild/Debug/WebKitTestRunner - Found 317 tests; running 203, skipping 114. Verbose baseline search path: platform/mac-monterey-wk2 -> platform/mac-monterey -> platform/mac-wk2 -> platform/mac -> platform/wk2 -> generic Baseline search path: platform/mac-wk2 -> platform/mac -> platform/wk2 -> generic Running 203 tests Running 4 WebKitTestRunners in parallel. worker/0 starting worker/1 starting worker/2 starting worker/3 starting worker/3 stopping worker/1 stopping worker/2 stopping worker/0 stopping AssertionError raised: Traceback (most recent call last): File "/Volumes/Data/Development/system/webkit/OpenSource/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 92, in main run_details = run(port, options, args, stderr) File "/Volumes/Data/Development/system/webkit/OpenSource/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 495, in run run_details = manager.run(args) File "/Volumes/Data/Development/system/webkit/OpenSource/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py", line 413, in run temp_initial_results, temp_retry_results, temp_enabled_pixel_tests_in_retry = self._run_test_subset(test_inputs, device_type=device_type) File "/Volumes/Data/Development/system/webkit/OpenSource/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py", line 487, in _run_test_subset initial_results = self._run_tests(test_inputs, self._options.repeat_each, self._options.iterations, int(self._options.child_processes), retrying=False, device_type=device_type) File "/Volumes/Data/Development/system/webkit/OpenSource/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py", line 566, in _run_tests return self._runner.run_tests(self._expectations[device_type], new_test_inputs, num_workers, retrying, device_type) File "/Volumes/Data/Development/system/webkit/OpenSource/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py", line 172, in run_tests ), teardown=teardown_shard, File "/Volumes/Data/Development/system/webkit/OpenSource/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/task_pool.py", line 388, in __enter__ worker.start() File "/Volumes/Data/Development/system/webkit/OpenSource/Tools/Scripts/webkitpy/common/interrupt_debugging.py", line 74, in handler with StackTraceFileContext(output_file=output_file) as file: File "/Volumes/Data/Development/system/webkit/OpenSource/Tools/Scripts/webkitpy/common/interrupt_debugging.py", line 55, in __enter__ _log.critical('Stack trace saved to {}'.format(self.file_name)) File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/logging/__init__.py", line 1219, in critical self._log(CRITICAL, msg, args, **kwargs) File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/logging/__init__.py", line 1293, in _log self.handle(record) File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/logging/__init__.py", line 1303, in handle self.callHandlers(record) File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/logging/__init__.py", line 1343, in callHandlers hdlr.handle(record) File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/logging/__init__.py", line 766, in handle self.emit(record) File "/Volumes/Data/Development/system/webkit/OpenSource/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/task_pool.py", line 186, in emit self._queue.send(_Log(record)) File "/Volumes/Data/Development/system/webkit/OpenSource/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/task_pool.py", line 142, in send return self.outgoing.put(object) File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/multiprocessing/queues.py", line 100, in put assert not self._closed AssertionError All 203 tests ran as expected. 1826875 1 webkit-bug-importer 2021-12-26 10:42:16 -0800 <rdar://problem/86919726> 1827938 2 448294 jbedard 2022-01-04 07:36:52 -0800 Created attachment 448294 Patch 1827939 3 jbedard 2022-01-04 07:39:25 -0800 So, this is because we have a function triggered on process exit, which looks like it's happening after we tear down the message queues. I think the answer is to log an error when we encounter this problem instead of throwing an exception. We might be able to trigger the callbacks early, but I'm a bit concerned about our ability to do that reliably. 1828274 4 ews-feeder 2022-01-05 07:42:47 -0800 Committed r287614 (245741@main): <https://commits.webkit.org/245741@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 448294. 448294 2022-01-04 07:36:52 -0800 2022-01-05 07:42:49 -0800 Patch bug-234487-20220104073651.patch text/plain 2908 jbedard U3VidmVyc2lvbiBSZXZpc2lvbjogMjg3NTY2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYWJiNTIxNjUxYWFkYzRjNGVkMmI4NTZiOGIwYjA2ZTc1 OWE4NGY3Zi4uMjVlZDM5ZDBkYTRiY2I1MzU2NjE0ZDg5ZDAzYTlhNDdkOTg5YzA5OCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDIyLTAxLTA0ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNvbT4KKwor ICAgICAgICBSdW5uaW5nIGxheW91dCB0ZXN0cyBzb21ldGltZXMgdGhyb3dzIGFuIEFzc2VydGlv bkVycm9yIGluIHB5dGhvbjIuNy9tdWx0aXByb2Nlc3NpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNDQ4NworCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy9saWJyYXJpZXMvd2Via2l0Y29y ZXB5L3NldHVwLnB5OiBCdW1wIHZlcnNpb24uCisgICAgICAgICogU2NyaXB0cy9saWJyYXJpZXMv d2Via2l0Y29yZXB5L3dlYmtpdGNvcmVweS9fX2luaXRfXy5weTogRGl0dG8uCisgICAgICAgICog U2NyaXB0cy9saWJyYXJpZXMvd2Via2l0Y29yZXB5L3dlYmtpdGNvcmVweS90YXNrX3Bvb2wucHk6 CisgICAgICAgIChfQmlEaXJlY3Rpb25hbFF1ZXVlLnNlbmQpOiBMb2cgZmFpbGVkIHF1ZXVlIHB1 dC4KKwogMjAyMi0wMS0wMyAgU2FtIFdlaW5pZyAgPHdlaW5pZ0BhcHBsZS5jb20+CiAKICAgICAg ICAgQWRkIHJlc29sdmVkL3VucmVzb2x2ZWQgY29sb3IgdHlwZSBhY2Nlc3NvcnMgdG8gcmVxdWly ZSB1c2VycyB0byBiZSBleHBsaWNpdCBhYm91dCB3aGV0aGVyIHRoZXkgd2lsbCBoYW5kbGUgbWlz c2luZy9ub25lIGNvbG9yIGNvbXBvbmVudHMKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvbGli cmFyaWVzL3dlYmtpdGNvcmVweS9zZXR1cC5weSBiL1Rvb2xzL1NjcmlwdHMvbGlicmFyaWVzL3dl YmtpdGNvcmVweS9zZXR1cC5weQppbmRleCBhNGEzNmQyM2EwMDU1OWE2NjAwY2IxMWVlNGNkN2Mw ZGJmM2I3NWRmLi44MGRhYzcyZGE3NWIwNjBmM2UzNzExMmFlNWI2MTNjZmRmOGZiZGNhIDEwMDY0 NAotLS0gYS9Ub29scy9TY3JpcHRzL2xpYnJhcmllcy93ZWJraXRjb3JlcHkvc2V0dXAucHkKKysr IGIvVG9vbHMvU2NyaXB0cy9saWJyYXJpZXMvd2Via2l0Y29yZXB5L3NldHVwLnB5CkBAIC0zMCw3 ICszMCw3IEBAIGRlZiByZWFkbWUoKToKIAogc2V0dXAoCiAgICAgbmFtZT0nd2Via2l0Y29yZXB5 JywKLSAgICB2ZXJzaW9uPScwLjEyLjQnLAorICAgIHZlcnNpb249JzAuMTIuNScsCiAgICAgZGVz Y3JpcHRpb249J0xpYnJhcnkgY29udGFpbmluZyB2YXJpb3VzIFB5dGhvbiBzdXBwb3J0IGNsYXNz ZXMgYW5kIGZ1bmN0aW9ucy4nLAogICAgIGxvbmdfZGVzY3JpcHRpb249cmVhZG1lKCksCiAgICAg Y2xhc3NpZmllcnM9WwpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy9saWJyYXJpZXMvd2Via2l0 Y29yZXB5L3dlYmtpdGNvcmVweS9fX2luaXRfXy5weSBiL1Rvb2xzL1NjcmlwdHMvbGlicmFyaWVz L3dlYmtpdGNvcmVweS93ZWJraXRjb3JlcHkvX19pbml0X18ucHkKaW5kZXggODBkM2Y4NGYxNTNm MWI3Yjg1YzkyMDg1NWFiYzhhOWRhYmUwZTgyMS4uYjcxOGVmZTMxNTYzOGU0OGI5ZjE4Y2E5YzE4 YmVjMzJlZDExMzAwOSAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy9saWJyYXJpZXMvd2Via2l0 Y29yZXB5L3dlYmtpdGNvcmVweS9fX2luaXRfXy5weQorKysgYi9Ub29scy9TY3JpcHRzL2xpYnJh cmllcy93ZWJraXRjb3JlcHkvd2Via2l0Y29yZXB5L19faW5pdF9fLnB5CkBAIC00NCw3ICs0NCw3 IEBAIGZyb20gd2Via2l0Y29yZXB5LmNhbGxfYnlfbmVlZCBpbXBvcnQgQ2FsbEJ5TmVlZAogZnJv bSB3ZWJraXRjb3JlcHkuZWRpdG9yIGltcG9ydCBFZGl0b3IKIGZyb20gd2Via2l0Y29yZXB5LmZp bGVfbG9jayBpbXBvcnQgRmlsZUxvY2sKIAotdmVyc2lvbiA9IFZlcnNpb24oMCwgMTIsIDQpCit2 ZXJzaW9uID0gVmVyc2lvbigwLCAxMiwgNSkKIAogZnJvbSB3ZWJraXRjb3JlcHkuYXV0b2luc3Rh bGwgaW1wb3J0IFBhY2thZ2UsIEF1dG9JbnN0YWxsCiBpZiBzeXMudmVyc2lvbl9pbmZvID4gKDMs IDApOgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy9saWJyYXJpZXMvd2Via2l0Y29yZXB5L3dl YmtpdGNvcmVweS90YXNrX3Bvb2wucHkgYi9Ub29scy9TY3JpcHRzL2xpYnJhcmllcy93ZWJraXRj b3JlcHkvd2Via2l0Y29yZXB5L3Rhc2tfcG9vbC5weQppbmRleCBmMjY3MzE5MDhmNWU1YmExNzkz OGFlMjkwYzdjMGNkMWFiZjQ0MTE1Li4zOGJkYTY2MmNmNGFlODJhNjVkY2E4OTNlM2JlNDg0YWM3 MmVkOTkxIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL2xpYnJhcmllcy93ZWJraXRjb3JlcHkv d2Via2l0Y29yZXB5L3Rhc2tfcG9vbC5weQorKysgYi9Ub29scy9TY3JpcHRzL2xpYnJhcmllcy93 ZWJraXRjb3JlcHkvd2Via2l0Y29yZXB5L3Rhc2tfcG9vbC5weQpAQCAtMTM5LDYgKzEzOSw5IEBA IGNsYXNzIF9CaURpcmVjdGlvbmFsUXVldWUob2JqZWN0KToKICAgICAgICAgc2VsZi5pbmNvbWlu ZyA9IGluY29taW5nIG9yIG11bHRpcHJvY2Vzc2luZy5RdWV1ZSgpCiAKICAgICBkZWYgc2VuZChz ZWxmLCBvYmplY3QpOgorICAgICAgICBpZiBzZWxmLm91dGdvaW5nLl9jbG9zZWQ6CisgICAgICAg ICAgICBzeXMuc3RkZXJyLndyaXRlKCdDYW5ub3Qgc2VuZCBtZXNzYWdlIHRvIGNsb3NlZCBxdWV1 ZVxuJykKKyAgICAgICAgICAgIHJldHVybiBGYWxzZQogICAgICAgICByZXR1cm4gc2VsZi5vdXRn b2luZy5wdXQob2JqZWN0KQogCiAgICAgZGVmIHJlY2VpdmUoc2VsZiwgYmxvY2tpbmc9VHJ1ZSk6 Cg==