234483 2021-12-18 17:26:56 -0800 Keyboard shortcut to scroll to top when already at the top of the page moves to the bottom 2021-12-19 10:45:21 -0800 1 1 1 Unclassified WebKit Scrolling WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser simon.fraser dino simon.fraser webkit-bug-importer oldest_to_newest 1825399 0 simon.fraser 2021-12-18 17:26:56 -0800 Keyboard shortcut to scroll to top when already at the top of the page moves to the bottom 1825400 1 447538 simon.fraser 2021-12-18 17:30:47 -0800 Created attachment 447538 Patch 1825444 2 447538 dino 2021-12-19 08:41:09 -0800 Comment on attachment 447538 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=447538&action=review > LayoutTests/fast/scrolling/keyboard-scrolling-home.html:19 > + await UIHelper.keyDown("home"); > + await UIHelper.renderingUpdate(); > + > + shouldBeZero("window.scrollY"); > + finishJSTest(); > + } > + > + window.addEventListener('load', () => { > + runTest(); > + }, false); screwy indentation 1825454 3 simon.fraser 2021-12-19 10:44:14 -0800 https://trac.webkit.org/changeset/287241/webkit 1825455 4 webkit-bug-importer 2021-12-19 10:45:21 -0800 <rdar://problem/86696197> 447538 2021-12-18 17:30:47 -0800 2021-12-19 08:41:09 -0800 Patch bug-234483-20211218173046.patch text/plain 6794 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjg3MjI4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzg3Yjg5Yjg1NTIyZjQy ZTcxN2JkYjYxMDQxYWIxZjQ5ZTcxOTU2ZC4uMzFjZjlhNjU0MGNiZDE5ZDI2MzA3YmNiMGM5YzFj MDc1ODMwNTJlMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI3IEBACisyMDIxLTEyLTE4ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIEtleWJvYXJkIHNo b3J0Y3V0IHRvIHNjcm9sbCB0byB0b3Agd2hlbiBhbHJlYWR5IGF0IHRoZSB0b3Agb2YgdGhlIHBh Z2UgbW92ZXMgdG8gdGhlIGJvdHRvbQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MjM0NDgzCisgICAgICAgIDxyZGFyOi8vODY2MjgyNjA+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisgICAgICAgIAorICAgICAgICBJZiB0aGUg cGFnZSB3YXMgc2Nyb2xsZWQgdG8gdGhlIHRvcCBhbmQgYW4gInVwIiBrZXlib2FyZCBzY3JvbGwg aGFwcGVuZWQsCisgICAgICAgIFNjcm9sbEFuaW1hdG9yOjpzaW5nbGVBeGlzU2Nyb2xsKCkgd291 bGQgdHJpZ2dlciBhbiB1bmNsYW1wZWQgc2Nyb2xsIHdpdGggYSBuZWdhdGl2ZSBkZWx0YSwKKyAg ICAgICAgd2hpY2ggZmVkIGludG8gU2Nyb2xsQW5pbWF0aW9uU21vb3RoOjpzdGFydEFuaW1hdGVk U2Nyb2xsVG9EZXN0aW5hdGlvbigpIGFuZCB3b3VsZCByZXN1bHQgaW4KKyAgICAgICAgYW4gYW5p bWF0aW9uIHdpdGggYSB6ZXJvIGR1cmF0aW9uLCB3aGljaCByZXN1bHRlZCBpbiBOYU5zIGluIGFu aW1hdGVTY3JvbGwoKS4KKworICAgICAgICBGaXggYnkgZG9pbmcgY2xhbXBpbmcgaW4gU2Nyb2xs QW5pbWF0b3I6OnNpbmdsZUF4aXNTY3JvbGwoKSBhbmQgcHJvdGVjdGluZyBhZ2FpbnN0CisgICAg ICAgIGFuaW1hdGlvbnMgd2l0aCB6ZXJvIGRlbGF5IGluIFNjcm9sbEFuaW1hdGlvblNtb290aC4K KworICAgICAgICBUZXN0OiBmYXN0L3Njcm9sbGluZy9rZXlib2FyZC1zY3JvbGxpbmctaG9tZS5o dG1sCisKKyAgICAgICAgKiBwbGF0Zm9ybS9TY3JvbGxBbmltYXRpb25TbW9vdGguY3BwOgorICAg ICAgICAoV2ViQ29yZTo6U2Nyb2xsQW5pbWF0aW9uU21vb3RoOjpzdGFydEFuaW1hdGVkU2Nyb2xs VG9EZXN0aW5hdGlvbik6CisgICAgICAgIChXZWJDb3JlOjpTY3JvbGxBbmltYXRpb25TbW9vdGg6 OnJldGFyZ2V0QWN0aXZlQW5pbWF0aW9uKToKKyAgICAgICAgKiBwbGF0Zm9ybS9TY3JvbGxBbmlt YXRvci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTY3JvbGxBbmltYXRvcjo6c2luZ2xlQXhpc1Nj cm9sbCk6CisKIDIwMjEtMTItMTcgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5j b20+CiAKICAgICAgICAgUmVhZCB0aGUgZGVmYXVsdCB2YWx1ZSBvZiB0aGUgU2Nyb2xsQW5pbWF0 b3JFbmFibGVkIHNldHRpbmcgZnJvbSBOU1VzZXJEZWZhdWx0cwpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vU2Nyb2xsQW5pbWF0aW9uU21vb3RoLmNwcCBiL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL1Njcm9sbEFuaW1hdGlvblNtb290aC5jcHAKaW5kZXggMDY4ZmY1Mjk5NTU0 MmNiNzcxY2M0MTliNzM5YzZlMjNiY2EzMjhlMy4uYTk4YjIzMGQwODQwZTE0YTQ4MzJkNWQ0MGZl OTI3YTRkNTUxYmU5MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vU2Nyb2xs QW5pbWF0aW9uU21vb3RoLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9TY3JvbGxB bmltYXRpb25TbW9vdGguY3BwCkBAIC01MCwxNSArNTAsMTggQEAgU2Nyb2xsQW5pbWF0aW9uU21v b3RoOjp+U2Nyb2xsQW5pbWF0aW9uU21vb3RoKCkgPSBkZWZhdWx0OwogCiBib29sIFNjcm9sbEFu aW1hdGlvblNtb290aDo6c3RhcnRBbmltYXRlZFNjcm9sbFRvRGVzdGluYXRpb24oY29uc3QgRmxv YXRQb2ludCYgZnJvbU9mZnNldCwgY29uc3QgRmxvYXRQb2ludCYgZGVzdGluYXRpb25PZmZzZXQp CiB7Ci0gICAgaWYgKCFpc0FjdGl2ZSgpICYmIGZyb21PZmZzZXQgPT0gZGVzdGluYXRpb25PZmZz ZXQpCi0gICAgICAgIHJldHVybiBmYWxzZTsKLQogICAgIGF1dG8gZXh0ZW50cyA9IG1fY2xpZW50 LnNjcm9sbEV4dGVudHNGb3JBbmltYXRpb24oKnRoaXMpOwogCi0gICAgbV9zdGFydFRpbWUgPSBN b25vdG9uaWNUaW1lOjpub3coKTsKICAgICBtX2N1cnJlbnRPZmZzZXQgPSBtX3N0YXJ0T2Zmc2V0 ID0gZnJvbU9mZnNldDsKICAgICBtX2Rlc3RpbmF0aW9uT2Zmc2V0ID0gZGVzdGluYXRpb25PZmZz ZXQuY29uc3RyYWluZWRCZXR3ZWVuKGV4dGVudHMubWluaW11bVNjcm9sbE9mZnNldCgpLCBleHRl bnRzLm1heGltdW1TY3JvbGxPZmZzZXQoKSk7CisKKyAgICBpZiAoIWlzQWN0aXZlKCkgJiYgZnJv bU9mZnNldCA9PSBtX2Rlc3RpbmF0aW9uT2Zmc2V0KQorICAgICAgICByZXR1cm4gZmFsc2U7CisK ICAgICBtX2R1cmF0aW9uID0gZHVyYXRpb25Gcm9tRGlzdGFuY2UobV9kZXN0aW5hdGlvbk9mZnNl dCAtIG1fc3RhcnRPZmZzZXQpOworICAgIGlmICghbV9kdXJhdGlvbikKKyAgICAgICAgcmV0dXJu IGZhbHNlOworCiAgICAgZG93bmNhc3Q8Q3ViaWNCZXppZXJUaW1pbmdGdW5jdGlvbj4oKm1fdGlt aW5nRnVuY3Rpb24pLnNldFRpbWluZ0Z1bmN0aW9uUHJlc2V0KEN1YmljQmV6aWVyVGltaW5nRnVu Y3Rpb246OlRpbWluZ0Z1bmN0aW9uUHJlc2V0OjpFYXNlSW5PdXQpOwogCiAgICAgaWYgKCFpc0Fj dGl2ZSgpKQpAQCAtODEsNyArODQsNyBAQCBib29sIFNjcm9sbEFuaW1hdGlvblNtb290aDo6cmV0 YXJnZXRBY3RpdmVBbmltYXRpb24oY29uc3QgRmxvYXRQb2ludCYgbmV3T2Zmc2V0KQogICAgIGRv d25jYXN0PEN1YmljQmV6aWVyVGltaW5nRnVuY3Rpb24+KCptX3RpbWluZ0Z1bmN0aW9uKS5zZXRU aW1pbmdGdW5jdGlvblByZXNldChDdWJpY0JlemllclRpbWluZ0Z1bmN0aW9uOjpUaW1pbmdGdW5j dGlvblByZXNldDo6RWFzZU91dCk7CiAgICAgbV90aW1pbmdGdW5jdGlvbiA9IEN1YmljQmV6aWVy VGltaW5nRnVuY3Rpb246OmNyZWF0ZShDdWJpY0JlemllclRpbWluZ0Z1bmN0aW9uOjpUaW1pbmdG dW5jdGlvblByZXNldDo6RWFzZU91dCk7CiAKLSAgICBpZiAobV9jdXJyZW50T2Zmc2V0ID09IG1f ZGVzdGluYXRpb25PZmZzZXQpCisgICAgaWYgKG1fY3VycmVudE9mZnNldCA9PSBtX2Rlc3RpbmF0 aW9uT2Zmc2V0IHx8ICFtX2R1cmF0aW9uKQogICAgICAgICByZXR1cm4gZmFsc2U7CiAKICAgICBy ZXR1cm4gdHJ1ZTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1Njcm9sbEFu aW1hdG9yLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1Njcm9sbEFuaW1hdG9yLmNwcApp bmRleCBhYjI5NDkyYjkyMzMwYmI5MzJkOWEzMWNkMGM0NmVlZThlOTEzYzkwLi5kYjliM2FmYjFm YWUwYmZmNWJmOWExZWQxNTJiNDIyYTRhZmRjOTg0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9TY3JvbGxBbmltYXRvci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vU2Nyb2xsQW5pbWF0b3IuY3BwCkBAIC03Niw2ICs3NiwxMyBAQCBib29sIFNjcm9sbEFuaW1h dG9yOjpzaW5nbGVBeGlzU2Nyb2xsKFNjcm9sbEV2ZW50QXhpcyBheGlzLCBmbG9hdCBzY3JvbGxE ZWx0YSwgTwogICAgICAgICBhdXRvIG5ld09mZnNldE9uQXhpcyA9IG1fc2Nyb2xsQ29udHJvbGxl ci5hZGp1c3RlZFNjcm9sbERlc3RpbmF0aW9uKGF4aXMsIG5ld09mZnNldCwgdmVsb2NpdHksIHZh bHVlRm9yQXhpcyhjdXJyZW50T2Zmc2V0LCBheGlzKSk7CiAgICAgICAgIG5ld09mZnNldCA9IHNl dFZhbHVlRm9yQXhpcyhuZXdPZmZzZXQsIGF4aXMsIG5ld09mZnNldE9uQXhpcyk7CiAgICAgICAg IGRlbHRhID0gbmV3T2Zmc2V0IC0gY3VycmVudE9mZnNldDsKKyAgICB9IGVsc2UgeworICAgICAg ICBhdXRvIG5ld1Bvc2l0aW9uID0gbV9jdXJyZW50UG9zaXRpb24gKyBkZWx0YTsKKyAgICAgICAg bmV3UG9zaXRpb24gPSBuZXdQb3NpdGlvbi5jb25zdHJhaW5lZEJldHdlZW4oc2Nyb2xsYWJsZUFy ZWEoKS5taW5pbXVtU2Nyb2xsUG9zaXRpb24oKSwgc2Nyb2xsYWJsZUFyZWEoKS5tYXhpbXVtU2Ny b2xsUG9zaXRpb24oKSk7CisgICAgICAgIGlmIChuZXdQb3NpdGlvbiA9PSBtX2N1cnJlbnRQb3Np dGlvbikKKyAgICAgICAgICAgIHJldHVybiBmYWxzZTsKKworICAgICAgICBkZWx0YSA9IG5ld1Bv c2l0aW9uIC0gbV9jdXJyZW50UG9zaXRpb247CiAgICAgfQogCiAgICAgaWYgKG1fc2Nyb2xsYWJs ZUFyZWEuc2Nyb2xsQW5pbWF0b3JFbmFibGVkKCkgJiYgIWJlaGF2aW9yLmNvbnRhaW5zKFNjcm9s bEJlaGF2aW9yOjpOZXZlckFuaW1hdGUpKSB7CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggY2Y1YjA3NDFiODk1NDNmODBkMDg5 MjgyZGI1M2I2MDNiNDZjM2JmYS4uNTViMjAzZDM0YmI0MjNiMzQyMGFjMTYxNzUwNTUxN2Y1N2Qz YjdiOSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDIxLTEyLTE4ICBTaW1vbiBGcmFzZXIgIDxz aW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIEtleWJvYXJkIHNob3J0Y3V0IHRvIHNj cm9sbCB0byB0b3Agd2hlbiBhbHJlYWR5IGF0IHRoZSB0b3Agb2YgdGhlIHBhZ2UgbW92ZXMgdG8g dGhlIGJvdHRvbQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjM0NDgzCisgICAgICAgIDxyZGFyOi8vODY2MjgyNjA+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBmYXN0L3Njcm9sbGluZy9rZXlib2FyZC1z Y3JvbGxpbmctaG9tZS1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3Qvc2Nyb2xs aW5nL2tleWJvYXJkLXNjcm9sbGluZy1ob21lLmh0bWw6IEFkZGVkLgorCiAyMDIxLTEyLTE3ICBT aW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFJlYWQgdGhl IGRlZmF1bHQgdmFsdWUgb2YgdGhlIFNjcm9sbEFuaW1hdG9yRW5hYmxlZCBzZXR0aW5nIGZyb20g TlNVc2VyRGVmYXVsdHMKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3Qvc2Nyb2xsaW5nL2tl eWJvYXJkLXNjcm9sbGluZy1ob21lLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Zhc3Qvc2Ny b2xsaW5nL2tleWJvYXJkLXNjcm9sbGluZy1ob21lLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2Rl IDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi44 ZTQwMTQ1YjAzMDYxYWJhYzgwNGE2YTNjMzk1ZWZjMTkxMzhhMWIzCi0tLSAvZGV2L251bGwKKysr IGIvTGF5b3V0VGVzdHMvZmFzdC9zY3JvbGxpbmcva2V5Ym9hcmQtc2Nyb2xsaW5nLWhvbWUtZXhw ZWN0ZWQudHh0CkBAIC0wLDAgKzEsNSBAQAorUEFTUyB3aW5kb3cuc2Nyb2xsWSBpcyAwCitQQVNT IHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCisKK1RFU1QgQ09NUExFVEUKK1Njcm9sbGluZyB2 aWEgdGhlICJIb21lIiBrZXkgc2hvdWxkIGxlYXZlIHRoaXMgcGFnZSBhdCB0aGUgdG9wLgpkaWZm IC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9zY3JvbGxpbmcva2V5Ym9hcmQtc2Nyb2xsaW5nLWhv bWUuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3Qvc2Nyb2xsaW5nL2tleWJvYXJkLXNjcm9sbGluZy1o b21lLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMC4uOTJmMDkyMDdlNDdhNmY5MWIyYjJlMjkwNTllYTM3ODVkYjJh ZDdkYwotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3Qvc2Nyb2xsaW5nL2tleWJv YXJkLXNjcm9sbGluZy1ob21lLmh0bWwKQEAgLTAsMCArMSwzMSBAQAorPCFET0NUWVBFIGh0bWw+ Cis8aHRtbD4KKzxoZWFkPgorICAgIDxzY3JpcHQgc3JjPSIuLi8uLi9yZXNvdXJjZXMvdWktaGVs cGVyLmpzIj48L3NjcmlwdD4KKyAgICA8c2NyaXB0IHNyYz0iLi4vLi4vcmVzb3VyY2VzL2pzLXRl c3QtcHJlLmpzIj48L3NjcmlwdD4KKyAgICA8c2NyaXB0PgorICAgICAgICBqc1Rlc3RJc0FzeW5j ID0gdHJ1ZTsKKyAgICAgICAgYXN5bmMgZnVuY3Rpb24gcnVuVGVzdCgpCisgICAgICAgIHsKKyAg ICAgICAgICAgIGF3YWl0IFVJSGVscGVyLmtleURvd24oImhvbWUiKTsKKwkJCWF3YWl0IFVJSGVs cGVyLnJlbmRlcmluZ1VwZGF0ZSgpOworCQkJCisJCQlzaG91bGRCZVplcm8oIndpbmRvdy5zY3Jv bGxZIik7CisJCQlmaW5pc2hKU1Rlc3QoKTsKKyAgICAgICAgfQorCQkKKwkJd2luZG93LmFkZEV2 ZW50TGlzdGVuZXIoJ2xvYWQnLCAoKSA9PiB7CisJCQlydW5UZXN0KCk7CisJCX0sIGZhbHNlKTsK KyAgICA8L3NjcmlwdD4KKyAgICA8c3R5bGU+CisJCWJvZHkgeworCQkJaGVpZ2h0OiAzMDAwcHg7 CisJCX0KKyAgICA8L3N0eWxlPgorPC9oZWFkPgorPGJvZHk+CisJU2Nyb2xsaW5nIHZpYSB0aGUg IkhvbWUiIGtleSBzaG91bGQgbGVhdmUgdGhpcyBwYWdlIGF0IHRoZSB0b3AuCisgICAgPHNjcmlw dCBzcmM9Ii4uLy4uL3Jlc291cmNlcy9qcy10ZXN0LXBvc3QuanMiPjwvc2NyaXB0PgorPC9ib2R5 PgorPC9odG1sPgo=