234480 2021-12-18 13:11:19 -0800 Fix Tools/Scripts/webkitpy/w3c/test_importer.py 2021-12-20 02:57:16 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ntim ntim ews-watchlist glenn jbedard rego webkit-bug-importer oldest_to_newest 1825374 0 ntim 2021-12-18 13:11:19 -0800 ntim @ OpenSource ⚡️ import-w3c-tests -t web-platform-tests/html/semantics/interactive-elements/the-dialog-element/ Downloading W3C test repositories Fetching https://github.com/web-platform-tests/wpt.git... Checking out revision origin/master Scanning /Volumes/Data/Code/Safari/OpenSource/WebKitBuild/w3c-tests/to-be-imported/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/... Traceback (most recent call last): File "/Volumes/Data/Code/Safari/OpenSource/Tools/Scripts/import-w3c-tests", line 35, in <module> sys.exit(test_importer.main(sys.argv[1:], sys.stdout, sys.stderr)) File "/Volumes/Data/Code/Safari/OpenSource/Tools/Scripts/webkitpy/w3c/test_importer.py", line 98, in main test_importer.do_import() File "/Volumes/Data/Code/Safari/OpenSource/Tools/Scripts/webkitpy/w3c/test_importer.py", line 209, in do_import self.find_importable_tests(self.filesystem.join(self.source_directory, test_path)) File "/Volumes/Data/Code/Safari/OpenSource/Tools/Scripts/webkitpy/w3c/test_importer.py", line 352, in find_importable_tests if test_info['type'] == 'mismatch': KeyError: 'type' 1825375 1 447530 ntim 2021-12-18 13:14:51 -0800 Created attachment 447530 Patch 1825545 2 447530 rego 2021-12-20 00:16:03 -0800 Comment on attachment 447530 Patch r=me, thanks for the fix. This seems to be failing for this test: http://wpt.live/html/semantics/interactive-elements/the-dialog-element/top-layer-position.html Should we add some kind of unit test to avoid breaking this again in the future? 1825556 3 ntim 2021-12-20 02:13:56 -0800 (In reply to Manuel Rego Casasnovas from comment #2) > Comment on attachment 447530 [details] > Patch > > r=me, thanks for the fix. > > This seems to be failing for this test: > http://wpt.live/html/semantics/interactive-elements/the-dialog-element/top- > layer-position.html > Should we add some kind of unit test to avoid breaking this again in the > future? A test would be ideal, though this type of bug is also easily noticeable (I first noticed it importing the whole css/ directory). 1825561 4 ews-feeder 2021-12-20 02:56:53 -0800 Committed r287257 (245413@main): <https://commits.webkit.org/245413@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 447530. 1825562 5 webkit-bug-importer 2021-12-20 02:57:16 -0800 <rdar://problem/86716802> 447530 2021-12-18 13:14:51 -0800 2021-12-20 02:56:54 -0800 Patch bug-234480-20211218221450.patch text/plain 1491 ntim U3VidmVyc2lvbiBSZXZpc2lvbjogMjg3MjI3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYTQyY2QxYWI0MjAzYzlhMmMwNDNlZTA4ZWFiYzFmNDY5 NzQyZDk1Yi4uODk4YWQwODg5ZGYzODVjMWEzMDMwZDk1ZjE1MzE4NjFiZmFmYzQ2MCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDIxLTEyLTE4ICBUaW0gTmd1eWVuICA8bnRpbUBhcHBsZS5jb20+CisKKyAgICAgICAg Rml4IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvdzNjL3Rlc3RfaW1wb3J0ZXIucHkKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNDQ4MAorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRw eS93M2MvdGVzdF9pbXBvcnRlci5weToKKyAgICAgICAgKFRlc3RJbXBvcnRlci5maW5kX2ltcG9y dGFibGVfdGVzdHMpOgorCiAyMDIxLTEyLTE3ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJA YXBwbGUuY29tPgogCiAgICAgICAgIFJlbmFtZSBNb2NrU2Nyb2xsQW5pbWF0b3JFbmFibGVkIHRv IE1vY2tTY3JvbGxiYXJzQ29udHJvbGxlckVuYWJsZWQKZGlmZiAtLWdpdCBhL1Rvb2xzL1Njcmlw dHMvd2Via2l0cHkvdzNjL3Rlc3RfaW1wb3J0ZXIucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5 L3czYy90ZXN0X2ltcG9ydGVyLnB5CmluZGV4IGM3MzQ0YTc2NmNkYzVmYzlmODU0YzRiNDVlYTU3 ZGYzZGY3MWY0N2QuLjYxOGVmM2JiY2U0YTc4MDMxMzlkN2EzZWM4YThkOTAyMDBkMGU2NTcgMTAw NjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdzNjL3Rlc3RfaW1wb3J0ZXIucHkKKysr IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS93M2MvdGVzdF9pbXBvcnRlci5weQpAQCAtMzQ5LDcg KzM0OSw3IEBAIGNsYXNzIFRlc3RJbXBvcnRlcihvYmplY3QpOgogICAgICAgICAgICAgICAgICAg ICAjIFVzaW5nIGEgbmFtaW5nIGNvbnZlbnRpb24gY3JlYXRlcyBkdXBsaWNhdGUgY29waWVzIG9m IHRoZQogICAgICAgICAgICAgICAgICAgICAjIHJlZmVyZW5jZSBmaWxlcy4KICAgICAgICAgICAg ICAgICAgICAgcmVmX2ZpbGUgPSBzZWxmLmZpbGVzeXN0ZW0uc3BsaXRleHQodGVzdF9iYXNlbmFt ZSlbMF0gKyAnLWV4cGVjdGVkJwotICAgICAgICAgICAgICAgICAgICBpZiB0ZXN0X2luZm9bJ3R5 cGUnXSA9PSAnbWlzbWF0Y2gnOgorICAgICAgICAgICAgICAgICAgICBpZiAndHlwZScgaW4gdGVz dF9pbmZvIGFuZCB0ZXN0X2luZm9bJ3R5cGUnXSA9PSAnbWlzbWF0Y2gnOgogICAgICAgICAgICAg ICAgICAgICAgICAgcmVmX2ZpbGUgKz0gJy1taXNtYXRjaCcKICAgICAgICAgICAgICAgICAgICAg cmVmX2ZpbGUgKz0gc2VsZi5maWxlc3lzdGVtLnNwbGl0ZXh0KHRlc3RfaW5mb1sncmVmZXJlbmNl J10pWzFdCiAK