234478 2021-12-18 11:26:55 -0800 [libpas] Do not compile libpas for 64-bit watchOS to save ~6 MB per architecture 2021-12-18 16:22:40 -0800 1 1 1 Unclassified WebKit bmalloc WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 234416 234481 1 ddkilzer ddkilzer ggaren nham webkit-bug-importer ysuzuki oldest_to_newest 1825358 0 ddkilzer 2021-12-18 11:26:55 -0800 Do not compile libpas for watchOS arm64e to save 6.15 MB. <rdar://85620647> 1825359 1 ddkilzer 2021-12-18 11:28:44 -0800 Also going to disable it for tvOS to save space as it's not currently used there to my knowledge. 1825379 2 ddkilzer 2021-12-18 14:48:43 -0800 Commit r287175 enabled libpas on all iOS family 64-bit architectures: [libpas] Enable libpas on ARM64 Darwin platforms (ARM64E is already enabled) https://bugs.webkit.org/show_bug.cgi?id=234416 https://commits.webkit.org/r287175 But the core of bmalloc itself is still compiled into the build, which means 64-bit watchOS architectures now consume an additional ~6 MB for libpas. 1825380 3 447532 ddkilzer 2021-12-18 14:49:36 -0800 Created attachment 447532 Patch v1 1825381 4 447532 ysuzuki 2021-12-18 14:55:53 -0800 Comment on attachment 447532 Patch v1 r=me 1825388 5 ysuzuki 2021-12-18 15:32:05 -0800 Does watchOS include ARM64E slice? I thought it is only having ARM64_32 and ARMv7k. 1825389 6 ddkilzer 2021-12-18 15:44:18 -0800 (In reply to Yusuke Suzuki from comment #5) > Does watchOS include ARM64E slice? I thought it is only having ARM64_32 and > ARMv7k. Yes, watchOS has three slices, including arm64e. 1825390 7 447532 ddkilzer 2021-12-18 15:44:48 -0800 Comment on attachment 447532 Patch v1 Adding cq+ since all Apple platforms have built. 1825394 8 ews-feeder 2021-12-18 16:22:38 -0800 Committed r287233 (245393@main): <https://commits.webkit.org/245393@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 447532. 447532 2021-12-18 14:49:36 -0800 2021-12-18 16:22:39 -0800 Patch v1 bug-234478-20211218144935.patch text/plain 1468 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjg3MjI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvYm1hbGxvYy9D aGFuZ2VMb2cgYi9Tb3VyY2UvYm1hbGxvYy9DaGFuZ2VMb2cKaW5kZXggNTc0ZmZkN2Y2MWFjYjdk MWYwNzEyMTVhODQ2M2JkZGM3ZjY1OGQ5Mi4uNGM1MWU2YzQ4ZTA3N2NhZWNiODNlYjc2MTdiODE2 Zjc4N2FiZDZiMCAxMDA2NDQKLS0tIGEvU291cmNlL2JtYWxsb2MvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9ibWFsbG9jL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIxLTEyLTE4ICBEYXZp ZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CisKKyAgICAgICAgW2xpYnBhc10gRG8gbm90 IGNvbXBpbGUgbGlicGFzIGZvciA2NC1iaXQgd2F0Y2hPUyB0byBzYXZlIH42IE1CIHBlciBhcmNo aXRlY3R1cmUKKyAgICAgICAgPGh0dHBzOi8vd2Via2l0Lm9yZy9iLzIzNDQ3OD4KKyAgICAgICAg PHJkYXI6Ly9wcm9ibGVtLzg1NjIwNjQ3PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogYm1hbGxvYy9CUGxhdGZvcm0uaDoKKyAgICAgICAgKEJFTkFC TEVfTElCUEFTKToKKyAgICAgICAgLSBEaXNhYmxlIGxpYnBhcyBvbiA2NC1iaXQgd2F0Y2hPUy4K KwogMjAyMS0xMi0xNyAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29tPgogCiAgICAg ICAgIFVucmV2aWV3ZWQsIHBhc19wcm9iYWJpbGlzdGljX2d1YXJkX21hbGxvY19hbGxvY2F0b3Iu YyBpcyBicm9rZW4gd2hlbiBMSUJQQVMgaXMgbm90IGVuYWJsZWQKZGlmZiAtLWdpdCBhL1NvdXJj ZS9ibWFsbG9jL2JtYWxsb2MvQlBsYXRmb3JtLmggYi9Tb3VyY2UvYm1hbGxvYy9ibWFsbG9jL0JQ bGF0Zm9ybS5oCmluZGV4IGU4NDlhNTJiMzM0ZDdkMjFhMGMyYjVkMzFlOWQ2NWJmNWU0MjRhOTUu LmJhNWI5YjkzZjJmOWZkZDMwNGFmMGYxNWQ4MzQ0ODJmYzczMTcyYzIgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9ibWFsbG9jL2JtYWxsb2MvQlBsYXRmb3JtLmgKKysrIGIvU291cmNlL2JtYWxsb2MvYm1h bGxvYy9CUGxhdGZvcm0uaApAQCAtMzI0LDcgKzMyNCw3IEBACiAKIC8qIEJFTkFCTEUoTElCUEFT KSBpcyBlbmFibGluZyBsaWJwYXMgYnVpbGQuIEJ1dCB0aGlzIGRvZXMgbm90IG1lYW4gd2UgdXNl IGxpYnBhcyBmb3IgYm1hbGxvYyByZXBsYWNlbWVudC4gKi8KICNpZiAhZGVmaW5lZChCRU5BQkxF X0xJQlBBUykKLSNpZiBCQ1BVKEFERFJFU1M2NCkgJiYgKEJPUyhEQVJXSU4pIHx8IChCT1MoTElO VVgpICYmICFCUExBVEZPUk0oR1RLKSAmJiAhQlBMQVRGT1JNKFdQRSkpKQorI2lmIEJDUFUoQURE UkVTUzY0KSAmJiAoKEJPUyhEQVJXSU4pICYmICFCT1MoV0FUQ0hPUykpIHx8IChCT1MoTElOVVgp ICYmICFCUExBVEZPUk0oR1RLKSAmJiAhQlBMQVRGT1JNKFdQRSkpKQogI2RlZmluZSBCRU5BQkxF X0xJQlBBUyAxCiAjZWxzZQogI2RlZmluZSBCRU5BQkxFX0xJQlBBUyAwCg==