23445 2009-01-20 20:33:45 -0800 Copying certain hidden text causes a crash 2009-03-29 19:21:45 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED http://www.reddit.com/r/apple/comments/7r3xu/how_to_crash_safari_1_select_text_from_a_comment/ InRadar, NeedsReduction P2 Normal --- 1 tom darin ianh mrowe oldest_to_newest 106423 0 tom 2009-01-20 20:33:45 -0800 1) Login to reddit.com and visit a comments page 2) Select the text of a comment 3) Click the "[-]" widget for the selected comment to hide it 4) Try to copy the hidden text via keyboard shortcut or menu Note this only works if you're logged into reddit.com 106424 1 mrowe 2009-01-20 20:34:40 -0800 <rdar://problem/6512520> 112514 2 mrowe 2009-03-05 19:15:13 -0800 *** Bug 24414 has been marked as a duplicate of this bug. *** 115771 3 darin 2009-03-29 17:21:11 -0700 Darn, I wanted to work on this bug, but I don't have a reddit.com account. I guess I'll have to make one. 115772 4 darin 2009-03-29 17:39:02 -0700 There are two aspects to this bug: 1) When the end points of the range are no longer rendered due to display: none, it would be good to update the selection so it doesn't include the invisible stuff. 2) When we actually run the createMarkup algorithm it would be best not to crash. I have a fix for (2) done. Next I'll make a regression test. Then I'll fix (1) as well. 115773 5 29052 darin 2009-03-29 18:24:49 -0700 Created attachment 29052 patch 115776 6 darin 2009-03-29 19:21:20 -0700 (In reply to comment #4) > 1) When the end points of the range are no longer rendered due to display: > none, it would be good to update the selection so it doesn't include the > invisible stuff. I decided not to fix this at this time. I'm not sure what behavior we want for this. 115777 7 darin 2009-03-29 19:21:45 -0700 http://trac.webkit.org/changeset/42096 29052 2009-03-29 18:24:49 -0700 2009-03-29 18:29:37 -0700 patch CopyDisplayNonePatch.txt text/plain 4980 darin SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0MjA5NCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTggQEAKKzIwMDktMDMtMjkgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEJ1ZyAy MzQ0NTogQ29weWluZyBjZXJ0YWluIGhpZGRlbiB0ZXh0IGNhdXNlcyBhIGNyYXNoCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzQ0NQorICAgICAgICBy ZGFyOi8vcHJvYmxlbS82NTEyNTIwCisKKyAgICAgICAgVGVzdDogZWRpdGluZy9wYXN0ZWJvYXJk L2NvcHktZGlzcGxheS1ub25lLmh0bWwKKworICAgICAgICAqIGVkaXRpbmcvbWFya3VwLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OmNyZWF0ZU1hcmt1cCk6IEFkZGVkIGEgY2hlY2sgZm9yIHRoZSBj YXNlIHdoZXJlIGFkanVzdGluZyB0aGUgc3RhcnQgbm9kZSBtb3ZlcworICAgICAgICB0aGUgc3Rh cnQgb2YgdGhlIHNlbGVjdGlvbiBwYXN0IHRoZSBlbmQgb2YgdGhlIHJhbmdlIGVudGlyZWx5LiBJ ZiB3ZSB0cnkgdG8gaXRlcmF0ZSB3ZSdsbAorICAgICAgICBuZXZlciBoaXQgdGhlIGVuZCBvZiB0 aGUgcmFuZ2UgYW5kIHdpbGwgcHJvYmFibHkgY3Jhc2ggaXRlcmF0aW5nIHRoZSByZXN0IG9mIHRo ZSBkb2N1bWVudC4KKwogMjAwOS0wMy0yOSAgRGFyaW4gQWRsZXIgIDxkYXJpbkBhcHBsZS5jb20+ CiAKICAgICAgICAgRml4IGJ1aWxkIGFnYWluLgpJbmRleDogV2ViQ29yZS9lZGl0aW5nL21hcmt1 cC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9lZGl0aW5nL21hcmt1cC5jcHAJKHJldmlzaW9u IDQyMDkwKQorKysgV2ViQ29yZS9lZGl0aW5nL21hcmt1cC5jcHAJKHdvcmtpbmcgY29weSkKQEAg LTc5OCwxNCArNzk4LDIwIEBAIFN0cmluZyBjcmVhdGVNYXJrdXAoY29uc3QgUmFuZ2UqIHJhbmdl LCAKIAogICAgICAgICBtYXJrdXBzLmFwcGVuZChpbnRlcmNoYW5nZU5ld2xpbmVTdHJpbmcpOwog ICAgICAgICBzdGFydE5vZGUgPSB2aXNpYmxlU3RhcnQubmV4dCgpLmRlZXBFcXVpdmFsZW50KCku bm9kZSgpOworCisgICAgICAgIGlmIChSYW5nZTo6Y29tcGFyZUJvdW5kYXJ5UG9pbnRzKHN0YXJ0 Tm9kZSwgMCwgcGFzdEVuZCwgMCkgPj0gMCkgeworICAgICAgICAgICAgaWYgKGRlbGV0ZUJ1dHRv bikKKyAgICAgICAgICAgICAgICBkZWxldGVCdXR0b24tPmVuYWJsZSgpOworICAgICAgICAgICAg cmV0dXJuIGludGVyY2hhbmdlTmV3bGluZVN0cmluZzsKKyAgICAgICAgfQogICAgIH0KIAogICAg IE5vZGUqIG5leHQ7CiAgICAgZm9yIChOb2RlKiBuID0gc3RhcnROb2RlOyBuICE9IHBhc3RFbmQ7 IG4gPSBuZXh0KSB7Ci0gICAgCi0gICAgICAgIC8vIEFjY29yZGluZyB0byA8cmRhcjovL3Byb2Js ZW0vNTczMDY2OD4sIGl0IGlzIHBvc3NpYmxlIGZvciBuIHRvIGJsb3cgcGFzdCBwYXN0RW5kIGFu ZCBiZWNvbWUgbnVsbCBoZXJlLiAgVGhpcyAKLSAgICAgICAgLy8gc2hvdWxkbid0IGJlIHBvc3Np YmxlLiAgVGhpcyBudWxsIGNoZWNrIHdpbGwgcHJldmVudCBjcmFzaGVzIChidXQgY3JlYXRlIHRv byBtdWNoIG1hcmt1cCkgYW5kIHRoZSBBU1NFUlQgd2lsbCAKLSAgICAgICAgLy8gaG9wZWZ1bGx5 IGxlYWQgdXMgdG8gdW5kZXJzdGFuZGluZyB0aGUgcHJvYmxlbS4KKyAgICAgICAgLy8gQWNjb3Jk aW5nIHRvIDxyZGFyOi8vcHJvYmxlbS81NzMwNjY4PiwgaXQgaXMgcG9zc2libGUgZm9yIG4gdG8g YmxvdworICAgICAgICAvLyBwYXN0IHBhc3RFbmQgYW5kIGJlY29tZSBudWxsIGhlcmUuIFRoaXMg c2hvdWxkbid0IGJlIHBvc3NpYmxlLgorICAgICAgICAvLyBUaGlzIG51bGwgY2hlY2sgd2lsbCBw cmV2ZW50IGNyYXNoZXMgKGJ1dCBjcmVhdGUgdG9vIG11Y2ggbWFya3VwKQorICAgICAgICAvLyBh bmQgdGhlIEFTU0VSVCB3aWxsIGhvcGVmdWxseSBsZWFkIHVzIHRvIHVuZGVyc3RhbmRpbmcgdGhl IHByb2JsZW0uCiAgICAgICAgIEFTU0VSVChuKTsKICAgICAgICAgaWYgKCFuKQogICAgICAgICAg ICAgYnJlYWs7CkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiA0MjA5NCkKKysrIExheW91dFRlc3RzL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDA5LTAzLTI5ICBEYXJpbiBB ZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBCdWcgMjM0NDU6IENvcHlpbmcgY2VydGFpbiBoaWRkZW4gdGV4dCBj YXVzZXMgYSBjcmFzaAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjM0NDUKKyAgICAgICAgcmRhcjovL3Byb2JsZW0vNjUxMjUyMAorCisgICAgICAgICog ZWRpdGluZy9wYXN0ZWJvYXJkL2NvcHktZGlzcGxheS1ub25lLWV4cGVjdGVkLnR4dDogQWRkZWQu CisgICAgICAgICogZWRpdGluZy9wYXN0ZWJvYXJkL2NvcHktZGlzcGxheS1ub25lLmh0bWw6IEFk ZGVkLgorCiAyMDA5LTAzLTI5ICBEYXJpbiBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KIAogICAg ICAgICBSZXZpZXdlZCBieSBDYW1lcm9uIFp3YXJpY2guCkluZGV4OiBMYXlvdXRUZXN0cy9lZGl0 aW5nL3Bhc3RlYm9hcmQvY29weS1kaXNwbGF5LW5vbmUtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIExheW91dFRlc3RzL2VkaXRpbmcvcGFzdGVib2FyZC9jb3B5LWRpc3BsYXktbm9uZS1leHBl Y3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9lZGl0aW5nL3Bhc3RlYm9hcmQv Y29weS1kaXNwbGF5LW5vbmUtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDYg QEAKK1RoaXMgdGVzdHMgdG8gbWFrZSBzdXJlIGEgY29weSBhZnRlciBtYWtpbmcgdGhlIHNlbGVj dGlvbiBkaXNwbGF5OiBub25lIGRvZXMgbm90IGhpdCBhbiBhc3NlcnRpb24uCisKK1BBU1NFRAor CitUaGlzIGlzIHRleHQgYmVmb3JlIHRoZSB0ZXN0IHBhcmFncmFwaC4KK1RoaXMgaXMgdGhlIHBh cmFncmFwaCBhZnRlciB0aGUgaGlkZGVuIG9uZS4KClByb3BlcnR5IGNoYW5nZXMgb246IExheW91 dFRlc3RzL2VkaXRpbmcvcGFzdGVib2FyZC9jb3B5LWRpc3BsYXktbm9uZS1leHBlY3RlZC50eHQK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpOYW1lOiBzdm46ZW9sLXN0eWxlCiAgICsgbmF0aXZlCgpJbmRleDogTGF5b3V0 VGVzdHMvZWRpdGluZy9wYXN0ZWJvYXJkL2NvcHktZGlzcGxheS1ub25lLmh0bWwKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gTGF5b3V0VGVzdHMvZWRpdGluZy9wYXN0ZWJvYXJkL2NvcHktZGlzcGxheS1ub25lLmh0 bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9lZGl0aW5nL3Bhc3RlYm9hcmQvY29weS1k aXNwbGF5LW5vbmUuaHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwyMyBAQAorPGhlYWQ+Cis8 c2NyaXB0PgorZnVuY3Rpb24gcnVuVGVzdCgpCit7CisgICAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0 Q29udHJvbGxlcikKKyAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOwor ICAgIHZhciBwYXJhZ3JhcGggPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgicGFyYWdyYXBoIik7 CisgICAgdmFyIHRleHROb2RlID0gcGFyYWdyYXBoLmZpcnN0Q2hpbGQ7CisgICAgdmFyIHJhbmdl ID0gZG9jdW1lbnQuY3JlYXRlUmFuZ2UoKTsKKyAgICByYW5nZS5zZXRTdGFydCh0ZXh0Tm9kZSwg MjQpCisgICAgcmFuZ2Uuc2V0RW5kKHRleHROb2RlLCAyOCkKKyAgICBnZXRTZWxlY3Rpb24oKS5h ZGRSYW5nZShyYW5nZSk7CisgICAgcGFyYWdyYXBoLnNldEF0dHJpYnV0ZSgic3R5bGUiLCAiZGlz cGxheTogbm9uZSIpOworICAgIGRvY3VtZW50LmV4ZWNDb21tYW5kKCJDb3B5Iik7CisgICAgZG9j dW1lbnQuZ2V0RWxlbWVudEJ5SWQoIm1lc3NhZ2UiKS5maXJzdENoaWxkLmRhdGEgPSAiUEFTU0VE IjsKK30KKzwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHkgb25sb2FkPSJydW5UZXN0KCkiPgorPHA+ VGhpcyB0ZXN0cyB0byBtYWtlIHN1cmUgYSBjb3B5IGFmdGVyIG1ha2luZyB0aGUgc2VsZWN0aW9u IGRpc3BsYXk6IG5vbmUgZG9lcyBub3QgaGl0IGFuIGFzc2VydGlvbi48L3A+Cis8cCBpZD0ibWVz c2FnZSI+VEVTVCBOT1QgQ09NUExFVEU8L3A+Cis8ZGl2PlRoaXMgaXMgdGV4dCBiZWZvcmUgdGhl IHRlc3QgcGFyYWdyYXBoLiA8cCBpZD0icGFyYWdyYXBoIj5UaGlzIHBhcmFncmFwaCB3aWxsIGJl IGhpZGRlbiBhbmQgdGhlbiBjb3BpZWQuPC9wPjwvZGl2PjxwPlRoaXMgaXMgdGhlIHBhcmFncmFw aCBhZnRlciB0aGUgaGlkZGVuIG9uZS48L3A+Cis8L2JvZHk+CgpQcm9wZXJ0eSBjaGFuZ2VzIG9u OiBMYXlvdXRUZXN0cy9lZGl0aW5nL3Bhc3RlYm9hcmQvY29weS1kaXNwbGF5LW5vbmUuaHRtbApf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCk5hbWU6IHN2bjptaW1lLXR5cGUKICAgKyB0ZXh0L2h0bWwKTmFtZTogc3ZuOmVv bC1zdHlsZQogICArIG5hdGl2ZQoK