23442 2009-01-20 17:30:50 -0800 Structure property table deleted offset maps are being leaked. 2009-01-20 18:16:54 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED InRadar P1 Normal --- 1 barraclough barraclough ddkilzer oldest_to_newest 106411 0 barraclough 2009-01-20 17:30:50 -0800 Probably shouldn't be doing that. 106412 1 26879 barraclough 2009-01-20 17:34:16 -0800 Created attachment 26879 The patch 106414 2 26879 oliver 2009-01-20 17:52:43 -0800 Comment on attachment 26879 The patch r-, i think PropertyMapHashTable::deletedOffsets and m_propertyTable should both just be OwnPtrs so we don't need to explicitly free them 106415 3 26879 oliver 2009-01-20 17:53:29 -0800 Comment on attachment 26879 The patch r=me, i take that back, i see why they're not now 106416 4 barraclough 2009-01-20 17:54:02 -0800 Sending JavaScriptCore/ChangeLog Sending JavaScriptCore/runtime/Structure.cpp Transmitting file data .. Committed revision 40076. 106418 5 barraclough 2009-01-20 17:55:09 -0800 Erm, r=me from bdash in channel, r+ on bug by Oliver... so, reviewed by both! 106419 6 ddkilzer 2009-01-20 18:16:54 -0800 <rdar://problem/6503608> 26879 2009-01-20 17:34:16 -0800 2009-01-20 17:53:29 -0800 The patch patch.leak.txt text/plain 1031 barraclough SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDQwMDc1 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDktMDEt MjAgIEdhdmluIEJhcnJhY2xvdWdoICA8YmFycmFjbG91Z2hAYXBwbGUuY29tPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFN0cnVjdHVyZSBwcm9wZXJ0 eSB0YWJsZSBkZWxldGVkIG9mZnNldCBtYXBzIGFyZSBiZWluZyBsZWFrZWQuCisgICAgICAgIFBy b2JhYmx5IHNob3VsZG4ndCBiZSBkb2luZyB0aGF0LgorCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzQ0MgorCisgICAgICAgICogcnVudGltZS9TdHJ1 Y3R1cmUuY3BwOgorICAgICAgICAoSlNDOjpTdHJ1Y3R1cmU6On5TdHJ1Y3R1cmUpOgorCiAyMDA5 LTAxLTIwICBPbGl2ZXIgSHVudCAgPG9saXZlckBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChidWlsZCBmaXgpLgpJbmRleDogcnVudGltZS9TdHJ1Y3R1cmUuY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIHJ1bnRpbWUvU3RydWN0dXJlLmNwcAkocmV2aXNpb24gNDAwNDkpCisrKyBy dW50aW1lL1N0cnVjdHVyZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE3OCw2ICsxNzgsOCBAQCBT dHJ1Y3R1cmU6On5TdHJ1Y3R1cmUoKQogICAgICAgICAgICAgaWYgKFVTdHJpbmc6OlJlcCoga2V5 ID0gbV9wcm9wZXJ0eVRhYmxlLT5lbnRyaWVzKClbaV0ua2V5KQogICAgICAgICAgICAgICAgIGtl eS0+ZGVyZWYoKTsKICAgICAgICAgfQorCisgICAgICAgIGRlbGV0ZSBtX3Byb3BlcnR5VGFibGUt PmRlbGV0ZWRPZmZzZXRzOwogICAgICAgICBmYXN0RnJlZShtX3Byb3BlcnR5VGFibGUpOwogICAg IH0KIAo=