234412 2021-12-16 17:29:29 -0800 REGRESSION(r287138) [GLIB] Build failure with GCC 8 and 9 in std::array to Span conversion 2021-12-16 23:51:08 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=234350 InRadar P2 Normal --- 1 lmoura clopez aboxhall andresg_22 apinheiro bugs-noreply cfleizach clopez darin dmazzoni ews-watchlist jcraig jdiggs rbuis samuel_white sam webkit-bug-importer oldest_to_newest 1824921 0 447403 lmoura 2021-12-16 17:29:29 -0800 Created attachment 447403 Example that fails with GCC-9 and builds with GCC-10 Attached minimal example built with snippets from Span.h and its usage in AccessibilityRenderObject.cpp (Link to compiler explorer: https://godbolt.org/z/qxTK1qdda) Minimum GCC working version: gcc 10 Minimum CLANG working version: clang 7 List of C++ features supported by GCC: https://gcc.gnu.org/projects/cxx-status.html List of C++ GCC 10 changes: https://gcc.gnu.org/gcc-10/changes.html#cxx Link to build job of the first failure: https://build.webkit.org/#/builders/46/builds/9542 ../../Source/WebCore/accessibility/AccessibilityRenderObject.cpp: In member function ‘virtual bool WebCore::AccessibilityRenderObject::inheritsPresentationalRole() const’: ../../Source/WebCore/accessibility/AccessibilityRenderObject.cpp:3222:22: error: no match for ‘operator=’ (operand types are ‘WTF::Span<const WTF::LazyNeverDestroyed<const WebCore::HTMLQualifiedName>* const>’ and ‘const std::array<WTF::LazyNeverDestroyed<const WebCore::HTMLQualifiedName>*, 3>’) parentTags = listItemParents; ^~~~~~~~~~~~~~~ In file included from WTF/Headers/wtf/Vector.h:37, from WTF/Headers/wtf/Threading.h:48, from WTF/Headers/wtf/WeakPtr.h:31, from WTF/Headers/wtf/text/TextStream.h:33, from WTF/Headers/wtf/ObjectIdentifier.h:32, from ../../Source/WebCore/page/FrameIdentifier.h:28, from ../../Source/WebCore/loader/FrameLoaderClient.h:32, from ../../Source/WebCore/accessibility/AccessibilityObjectInterface.h:30, from ../../Source/WebCore/accessibility/AccessibilityObject.h:32, from ../../Source/WebCore/accessibility/AccessibilityMockObject.h:28, from ../../Source/WebCore/accessibility/AccessibilityMockObject.cpp:27, from WebCore/DerivedSources/unified-sources/UnifiedSource-aba958d6-3.cpp:1: WTF/Headers/wtf/Span.h:289:21: note: candidate: ‘constexpr WTF::Span<_Tp, 18446744073709551615>& WTF::Span<_Tp, 18446744073709551615>::operator=(const WTF::Span<_Tp, 18446744073709551615>&) [with _Tp = const WTF::LazyNeverDestroyed<const WebCore::HTMLQualifiedName>* const]’ constexpr Span& operator=(const Span&) noexcept = default; ^~~~~~~~ WTF/Headers/wtf/Span.h:289:21: note: no known conversion for argument 1 from ‘const std::array<WTF::LazyNeverDestroyed<const WebCore::HTMLQualifiedName>*, 3>’ to ‘const WTF::Span<const WTF::LazyNeverDestroyed<const WebCore::HTMLQualifiedName>* const>&’ In file included from WebCore/DerivedSources/unified-sources/UnifiedSource-aba958d6-3.cpp:5: 1824939 1 clopez 2021-12-16 18:32:17 -0800 GCC 8 also fails with the same error than GCC 9 (GCC 8 is still supported) The example builds fine with "-std=c++17" on GCC-10 but not on 9 and 10. And according to https://gcc.gnu.org/projects/cxx-status.html GCC 8 already has full support for C++-17 So maybe this is a bug on the compiler, hard to tell. 1824941 2 darin 2021-12-16 18:35:22 -0800 Would be nice to find a workaround too. 1824945 3 clopez 2021-12-16 18:40:26 -0800 This info is maybe useful, Clang 6 fails with the same error (or very similar). $ clang++-6.0 -std=c++17 span_gcc.cpp span_gcc.cpp:211:10: error: no viable overloaded '=' span = arr; ~~~~ ^ ~~~ span_gcc.cpp:150:21: note: candidate function not viable: no known conversion from 'const std::array<int *, 3>' to 'const Span<const int *const, 18446744073709551615>' for 1st argument constexpr Span& operator=(const Span&) noexcept = default; ^ 1 error generated. And clang++-7 builds it fine 1824959 4 447413 clopez 2021-12-16 19:42:17 -0800 Created attachment 447413 Patch 1824992 5 ews-feeder 2021-12-16 22:02:30 -0800 Committed r287173 (245343@main): <https://commits.webkit.org/245343@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 447413. 1824993 6 webkit-bug-importer 2021-12-16 22:03:20 -0800 <rdar://problem/86614849> 447403 2021-12-16 17:29:29 -0800 2021-12-16 17:29:29 -0800 Example that fails with GCC-9 and builds with GCC-10 span_gcc.cpp text/x-c++src 8881 lmoura I2luY2x1ZGUgPGFycmF5PgojaW5jbHVkZSA8dHlwZV90cmFpdHM+CiNpbmNsdWRlIDxjc3RkZGVm PgojaW5jbHVkZSA8bGltaXRzPgoKaW5saW5lIGNvbnN0ZXhwciBzdGQ6OnNpemVfdCBkeW5hbWlj X2V4dGVudCA9IHN0ZDo6bnVtZXJpY19saW1pdHM8c3RkOjpzaXplX3Q+OjptYXgoKTsKdGVtcGxh dGUgPHR5cGVuYW1lIF9UcCwgc3RkOjpzaXplX3QgX0V4dGVudCA9IGR5bmFtaWNfZXh0ZW50PiBj bGFzcyBTcGFuOwoKCnRlbXBsYXRlIDxjbGFzcyBfVHA+CnN0cnVjdCBfX2lzX3NwYW5faW1wbCA6 IHB1YmxpYyBzdGQ6OmZhbHNlX3R5cGUge307Cgp0ZW1wbGF0ZSA8Y2xhc3MgX1RwLCBzdGQ6OnNp emVfdCBfRXh0ZW50PgpzdHJ1Y3QgX19pc19zcGFuX2ltcGw8U3BhbjxfVHAsIF9FeHRlbnQ+PiA6 IHB1YmxpYyBzdGQ6OnRydWVfdHlwZSB7fTsKCnRlbXBsYXRlIDxjbGFzcyBfVHA+CnN0cnVjdCBf X2lzX3NwYW4gOiBwdWJsaWMgX19pc19zcGFuX2ltcGw8c3RkOjpyZW1vdmVfY3ZfdDxfVHA+PiB7 fTsKCnRlbXBsYXRlIDxjbGFzcyBfVHA+CnN0cnVjdCBfX2lzX3N0ZF9hcnJheV9pbXBsIDogcHVi bGljIHN0ZDo6ZmFsc2VfdHlwZSB7fTsKCnRlbXBsYXRlIDxjbGFzcyBfVHAsIHN0ZDo6c2l6ZV90 IF9Tej4Kc3RydWN0IF9faXNfc3RkX2FycmF5X2ltcGw8c3RkOjphcnJheTxfVHAsIF9Tej4+IDog cHVibGljIHN0ZDo6dHJ1ZV90eXBlIHt9OwoKdGVtcGxhdGUgPGNsYXNzIF9UcD4Kc3RydWN0IF9f aXNfc3RkX2FycmF5IDogcHVibGljIF9faXNfc3RkX2FycmF5X2ltcGw8c3RkOjpyZW1vdmVfY3Zf dDxfVHA+PiB7fTsKCnRlbXBsYXRlIDxjbGFzcyBfVHAsIGNsYXNzIF9FbGVtZW50VHlwZSwgY2xh c3MgPSB2b2lkPgpzdHJ1Y3QgX19pc19zcGFuX2NvbXBhdGlibGVfY29udGFpbmVyIDogcHVibGlj IHN0ZDo6ZmFsc2VfdHlwZSB7fTsKCnRlbXBsYXRlIDxjbGFzcyBfVHAsIGNsYXNzIF9FbGVtZW50 VHlwZT4Kc3RydWN0IF9faXNfc3Bhbl9jb21wYXRpYmxlX2NvbnRhaW5lcjxfVHAsIF9FbGVtZW50 VHlwZSwKICAgICAgICBzdGQ6OnZvaWRfdDwKICAgICAgICAvLyBpcyBub3QgYSBzcGVjaWFsaXph dGlvbiBvZiBTcGFuCiAgICAgICAgICAgIHR5cGVuYW1lIHN0ZDo6ZW5hYmxlX2lmPCFfX2lzX3Nw YW48X1RwPjo6dmFsdWUsIHN0ZDo6bnVsbHB0cl90Pjo6dHlwZSwKICAgICAgICAvLyBpcyBub3Qg YSBzcGVjaWFsaXphdGlvbiBvZiBhcnJheQogICAgICAgICAgICB0eXBlbmFtZSBzdGQ6OmVuYWJs ZV9pZjwhX19pc19zdGRfYXJyYXk8X1RwPjo6dmFsdWUsIHN0ZDo6bnVsbHB0cl90Pjo6dHlwZSwK ICAgICAgICAvLyBzZDo6aXNfYXJyYXlfdjxDb250YWluZXI+IGlzIGZhbHNlLAogICAgICAgICAg ICB0eXBlbmFtZSBzdGQ6OmVuYWJsZV9pZjwhc3RkOjppc19hcnJheV92PF9UcD4sIHN0ZDo6bnVs bHB0cl90Pjo6dHlwZSwKICAgICAgICAvLyBzdGQ6OmRhdGEoY29udCkgYW5kIHN0ZDo6c2l6ZShj b250KSBhcmUgd2VsbCBmb3JtZWQKICAgICAgICAgICAgZGVjbHR5cGUoc3RkOjpkYXRhKHN0ZDo6 ZGVjbHZhbDxfVHA+KCkpKSwKICAgICAgICAgICAgZGVjbHR5cGUoc3RkOjpzaXplKHN0ZDo6ZGVj bHZhbDxfVHA+KCkpKSwKICAgICAgICAvLyByZW1vdmVfcG9pbnRlcl90PGRlY2x0eXBlKGRhdGEo Y29udCkpPigqKVtdIGlzIGNvbnZlcnRpYmxlIHRvIEVsZW1lbnRUeXBlKCopW10KICAgICAgICAg ICAgdHlwZW5hbWUgc3RkOjplbmFibGVfaWY8CiAgICAgICAgICAgICAgICBzdGQ6OmlzX2NvbnZl cnRpYmxlX3Y8c3RkOjpyZW1vdmVfcG9pbnRlcl90PGRlY2x0eXBlKHN0ZDo6ZGF0YShzdGQ6OmRl Y2x2YWw8X1RwICY+KCkpKT4oKilbXSwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg X0VsZW1lbnRUeXBlKCopW10+LAogICAgICAgICAgICAgICAgc3RkOjpudWxscHRyX3Q+Ojp0eXBl CiAgICAgICAgPj4KICAgIDogcHVibGljIHN0ZDo6dHJ1ZV90eXBlIHt9OwoKdGVtcGxhdGU8Y2xh c3MgX1RwLCBzdGQ6OnNpemVfdCBfRXh0ZW50PgpjbGFzcyBTcGFuIHsKICAgIHVzaW5nIGVsZW1l bnRfdHlwZSAgICAgICAgICAgPSBfVHA7CiAgICB1c2luZyB2YWx1ZV90eXBlICAgICAgICAgICAg ID0gc3RkOjpyZW1vdmVfY3ZfdDxfVHA+OwogICAgdXNpbmcgc2l6ZV90eXBlICAgICAgICAgICAg ICA9IHN0ZDo6c2l6ZV90OwogICAgdXNpbmcgZGlmZmVyZW5jZV90eXBlICAgICAgICA9IHN0ZDo6 cHRyZGlmZl90OwogICAgdXNpbmcgcG9pbnRlciAgICAgICAgICAgICAgICA9IF9UcCAqOwogICAg dXNpbmcgY29uc3RfcG9pbnRlciAgICAgICAgICA9IGNvbnN0IF9UcCAqOwogICAgdXNpbmcgcmVm ZXJlbmNlICAgICAgICAgICAgICA9IF9UcCAmOwogICAgdXNpbmcgY29uc3RfcmVmZXJlbmNlICAg ICAgICA9IGNvbnN0IF9UcCAmOwogICAgc3RhdGljIGNvbnN0ZXhwciBzaXplX3R5cGUgZXh0ZW50 ID0gX0V4dGVudDsKcHVibGljOgogICAgLy8gdGVtcGxhdGUgPGNsYXNzIF9PdGhlckVsZW1lbnRU eXBlLCBzdGQ6OnNpemVfdCBfU3osCiAgICAvLyAgICAgICAgICAgc3RkOjplbmFibGVfaWZfdDxz dGQ6OmlzX2NvbnZlcnRpYmxlX3Y8X090aGVyRWxlbWVudFR5cGUoKilbXSwgZWxlbWVudF90eXBl ICgqKVtdPiwgc3RkOjpudWxscHRyX3Q+ID0gbnVsbHB0cj4KICAgIC8vIGNvbnN0ZXhwciBTcGFu KHN0ZDo6YXJyYXk8X090aGVyRWxlbWVudFR5cGUsIF9Tej4mIF9fYXJyKSBub2V4Y2VwdCA6IF9f ZGF0YXtfX2Fyci5kYXRhKCl9LCBfX3NpemV7X1N6fSB7fQoKICAgIC8vIHRlbXBsYXRlIDxjbGFz cyBfT3RoZXJFbGVtZW50VHlwZSwgc3RkOjpzaXplX3QgX1N6LAogICAgLy8gICAgICAgICAgIHN0 ZDo6ZW5hYmxlX2lmX3Q8c3RkOjppc19jb252ZXJ0aWJsZV92PGNvbnN0IF9PdGhlckVsZW1lbnRU eXBlKCopW10sIGVsZW1lbnRfdHlwZSAoKilbXT4sIHN0ZDo6bnVsbHB0cl90PiA9IG51bGxwdHI+ CiAgICAvLyBjb25zdGV4cHIgU3Bhbihjb25zdCBzdGQ6OmFycmF5PF9PdGhlckVsZW1lbnRUeXBl LCBfU3o+JiBfX2Fycikgbm9leGNlcHQgOiBfX2RhdGF7X19hcnIuZGF0YSgpfSwgX19zaXple19T en0ge30KCiAgICAgICAgdGVtcGxhdGUgPHN0ZDo6c2l6ZV90IF9TeiA9IF9FeHRlbnQsIHN0ZDo6 ZW5hYmxlX2lmX3Q8X1N6ID09IDAsIHN0ZDo6bnVsbHB0cl90PiA9IG51bGxwdHI+CiAgICAgY29u c3RleHByIFNwYW4oKSBub2V4Y2VwdCA6IF9fZGF0YXtudWxscHRyfSB7fQoKICAgIGNvbnN0ZXhw ciBTcGFuICAgICAgICAgICAoY29uc3QgU3BhbiYpIG5vZXhjZXB0ID0gZGVmYXVsdDsKICAgIGNv bnN0ZXhwciBTcGFuJiBvcGVyYXRvcj0oY29uc3QgU3BhbiYpIG5vZXhjZXB0ID0gZGVmYXVsdDsK CiAgICAgY29uc3RleHByIGV4cGxpY2l0IFNwYW4ocG9pbnRlciBfX3B0ciwgc2l6ZV90eXBlIF9f Y291bnQpIDogX19kYXRhe19fcHRyfQogICAgICAgIHsgKHZvaWQpX19jb3VudDsgIH0KICAgICBj b25zdGV4cHIgZXhwbGljaXQgU3Bhbihwb2ludGVyIF9fZiwgcG9pbnRlciBfX2wpIDogX19kYXRh e19fZn0KICAgICAgICB7ICh2b2lkKV9fbDsgICAgIF9XVEZfTElCQ1BQX0FTU0VSVChfRXh0ZW50 ID09IHN0ZDo6ZGlzdGFuY2UoX19mLCBfX2wpLCAic2l6ZSBtaXNtYXRjaCBpbiBTcGFuJ3MgY29u c3RydWN0b3IgKHB0ciwgcHRyKSIpOyB9CgogICAgIGNvbnN0ZXhwciBTcGFuKGVsZW1lbnRfdHlw ZSAoJl9fYXJyKVtfRXh0ZW50XSkgICAgICAgICAgbm9leGNlcHQgOiBfX2RhdGF7X19hcnJ9IHt9 CgogICAgdGVtcGxhdGUgPGNsYXNzIF9PdGhlckVsZW1lbnRUeXBlLAogICAgICAgICAgICAgIHN0 ZDo6ZW5hYmxlX2lmX3Q8c3RkOjppc19jb252ZXJ0aWJsZV92PF9PdGhlckVsZW1lbnRUeXBlKCop W10sIGVsZW1lbnRfdHlwZSAoKilbXT4sIHN0ZDo6bnVsbHB0cl90PiA9IG51bGxwdHI+CiAgICAK ICAgIGNvbnN0ZXhwciBTcGFuKHN0ZDo6YXJyYXk8X090aGVyRWxlbWVudFR5cGUsIF9FeHRlbnQ+ JiBfX2Fycikgbm9leGNlcHQgOiBfX2RhdGF7X19hcnIuZGF0YSgpfSB7fQoKICAgIHRlbXBsYXRl IDxjbGFzcyBfT3RoZXJFbGVtZW50VHlwZSwKICAgICAgICAgICAgICBzdGQ6OmVuYWJsZV9pZl90 PHN0ZDo6aXNfY29udmVydGlibGVfdjxjb25zdCBfT3RoZXJFbGVtZW50VHlwZSgqKVtdLCBlbGVt ZW50X3R5cGUgKCopW10+LCBzdGQ6Om51bGxwdHJfdD4gPSBudWxscHRyPgogICAgCiAgICBjb25z dGV4cHIgU3Bhbihjb25zdCBzdGQ6OmFycmF5PF9PdGhlckVsZW1lbnRUeXBlLCBfRXh0ZW50PiYg X19hcnIpIG5vZXhjZXB0IDogX19kYXRhe19fYXJyLmRhdGEoKX0ge30KCiAgICB0ZW1wbGF0ZSA8 Y2xhc3MgX0NvbnRhaW5lcj4KICAgIAogICAgICAgIGNvbnN0ZXhwciBleHBsaWNpdCBTcGFuKCAg ICAgIF9Db250YWluZXImIF9fYywKICAgICAgICAgICAgc3RkOjplbmFibGVfaWZfdDxfX2lzX3Nw YW5fY29tcGF0aWJsZV9jb250YWluZXI8X0NvbnRhaW5lciwgX1RwPjo6dmFsdWUsIHN0ZDo6bnVs bHB0cl90PiA9IG51bGxwdHIpCiAgICAgICAgOiBfX2RhdGF7c3RkOjpkYXRhKF9fYyl9IHsKICAg ICAgICB9CgogICAgdGVtcGxhdGUgPGNsYXNzIF9Db250YWluZXI+CiAgICAgICAgY29uc3RleHBy IGV4cGxpY2l0IFNwYW4oY29uc3QgX0NvbnRhaW5lciYgX19jLAogICAgICAgICAgICBzdGQ6OmVu YWJsZV9pZl90PF9faXNfc3Bhbl9jb21wYXRpYmxlX2NvbnRhaW5lcjxjb25zdCBfQ29udGFpbmVy LCBfVHA+Ojp2YWx1ZSwgc3RkOjpudWxscHRyX3Q+ID0gbnVsbHB0cikKICAgICAgICA6IF9fZGF0 YXtzdGQ6OmRhdGEoX19jKX0gewogICAgICAgIH0KCiAgICB0ZW1wbGF0ZSA8Y2xhc3MgX090aGVy RWxlbWVudFR5cGU+CiAgICAgICAgY29uc3RleHByIFNwYW4oY29uc3QgU3BhbjxfT3RoZXJFbGVt ZW50VHlwZSwgX0V4dGVudD4mIF9fb3RoZXIsCiAgICAgICAgICAgICAgICAgICAgICAgc3RkOjpl bmFibGVfaWZfdDwKICAgICAgICAgICAgICAgICAgICAgICAgICBzdGQ6OmlzX2NvbnZlcnRpYmxl X3Y8X090aGVyRWxlbWVudFR5cGUoKilbXSwgZWxlbWVudF90eXBlICgqKVtdPiwKICAgICAgICAg ICAgICAgICAgICAgICAgICBzdGQ6Om51bGxwdHJfdD4gPSBudWxscHRyKQogICAgICAgIDogX19k YXRhe19fb3RoZXIuZGF0YSgpfSB7fQoKICAgIHRlbXBsYXRlIDxjbGFzcyBfT3RoZXJFbGVtZW50 VHlwZT4KICAgICAgICBjb25zdGV4cHIgZXhwbGljaXQgU3Bhbihjb25zdCBTcGFuPF9PdGhlckVs ZW1lbnRUeXBlPiYgX19vdGhlciwKICAgICAgICAgICAgICAgICAgICAgICBzdGQ6OmVuYWJsZV9p Zl90PAogICAgICAgICAgICAgICAgICAgICAgICAgIHN0ZDo6aXNfY29udmVydGlibGVfdjxfT3Ro ZXJFbGVtZW50VHlwZSgqKVtdLCBlbGVtZW50X3R5cGUgKCopW10+LAogICAgICAgICAgICAgICAg ICAgICAgICAgIHN0ZDo6bnVsbHB0cl90PiA9IG51bGxwdHIpIG5vZXhjZXB0CiAgICAgICAgOiBf X2RhdGF7X19vdGhlci5kYXRhKCl9IHsgX1dURl9MSUJDUFBfQVNTRVJUKF9FeHRlbnQgPT0gX19v dGhlci5zaXplKCksICJzaXplIG1pc21hdGNoIGluIFNwYW4ncyBjb25zdHJ1Y3RvciAob3RoZXIg U3BhbikiKTsgfQoKCiAgICBTcGFuKCkge30KICAgIHZvaWQqIF9fZGF0YTsKICAgIHNpemVfdCBf X3NpemU7Cn07Cgp0ZW1wbGF0ZSA8dHlwZW5hbWUgX1RwPgpjbGFzcyBTcGFuPF9UcCwgZHluYW1p Y19leHRlbnQ+IHsKcHJpdmF0ZToKCnB1YmxpYzoKLy8gIGNvbnN0YW50cyBhbmQgdHlwZXMKICAg IHVzaW5nIGVsZW1lbnRfdHlwZSAgICAgICAgICAgPSBfVHA7CiAgICB1c2luZyB2YWx1ZV90eXBl ICAgICAgICAgICAgID0gc3RkOjpyZW1vdmVfY3ZfdDxfVHA+OwogICAgdXNpbmcgc2l6ZV90eXBl ICAgICAgICAgICAgICA9IHN0ZDo6c2l6ZV90OwogICAgdXNpbmcgZGlmZmVyZW5jZV90eXBlICAg ICAgICA9IHN0ZDo6cHRyZGlmZl90OwogICAgdXNpbmcgcG9pbnRlciAgICAgICAgICAgICAgICA9 IF9UcCAqOwogICAgdXNpbmcgY29uc3RfcG9pbnRlciAgICAgICAgICA9IGNvbnN0IF9UcCAqOwog ICAgdXNpbmcgcmVmZXJlbmNlICAgICAgICAgICAgICA9IF9UcCAmOwogICAgdXNpbmcgY29uc3Rf cmVmZXJlbmNlICAgICAgICA9IGNvbnN0IF9UcCAmOwogICAgdXNpbmcgaXRlcmF0b3IgICAgICAg ICAgICAgICA9IHBvaW50ZXI7CiAgICB1c2luZyByZXZlcnNlX2l0ZXJhdG9yICAgICAgID0gc3Rk OjpyZXZlcnNlX2l0ZXJhdG9yPGl0ZXJhdG9yPjsKCiAgICBzdGF0aWMgY29uc3RleHByIHNpemVf dHlwZSBleHRlbnQgPSBkeW5hbWljX2V4dGVudDsKCi8vIFtzcGFuLmNvbnNdLCBTcGFuIGNvbnN0 cnVjdG9ycywgY29weSwgYXNzaWdubWVudCwgYW5kIGRlc3RydWN0b3IKICAgICBjb25zdGV4cHIg U3BhbigpIG5vZXhjZXB0IDogX19kYXRhe251bGxwdHJ9LCBfX3NpemV7MH0ge30KCiAgICBjb25z dGV4cHIgU3BhbiAgICAgICAgICAgKGNvbnN0IFNwYW4mKSBub2V4Y2VwdCA9IGRlZmF1bHQ7CiAg ICBjb25zdGV4cHIgU3BhbiYgb3BlcmF0b3I9KGNvbnN0IFNwYW4mKSBub2V4Y2VwdCA9IGRlZmF1 bHQ7CgogICAgIGNvbnN0ZXhwciBTcGFuKHBvaW50ZXIgX19wdHIsIHNpemVfdHlwZSBfX2NvdW50 KSA6IF9fZGF0YXtfX3B0cn0sIF9fc2l6ZXtfX2NvdW50fSB7fQogICAgIGNvbnN0ZXhwciBTcGFu KHBvaW50ZXIgX19mLCBwb2ludGVyIF9fbCkgOiBfX2RhdGF7X19mfSwgX19zaXple3N0YXRpY19j YXN0PHN0ZDo6c2l6ZV90PihzdGQ6OmRpc3RhbmNlKF9fZiwgX19sKSl9IHt9CgogICAgdGVtcGxh dGUgPHN0ZDo6c2l6ZV90IF9Tej4KICAgIAogICAgY29uc3RleHByIFNwYW4oZWxlbWVudF90eXBl ICgmX19hcnIpW19Tel0pICAgICAgICAgIG5vZXhjZXB0IDogX19kYXRhe19fYXJyfSwgX19zaXpl e19Ten0ge30KCiAgICB0ZW1wbGF0ZSA8Y2xhc3MgX090aGVyRWxlbWVudFR5cGUsIHN0ZDo6c2l6 ZV90IF9TeiwKICAgICAgICAgICAgICBzdGQ6OmVuYWJsZV9pZl90PHN0ZDo6aXNfY29udmVydGli bGVfdjxfT3RoZXJFbGVtZW50VHlwZSgqKVtdLCBlbGVtZW50X3R5cGUgKCopW10+LCBzdGQ6Om51 bGxwdHJfdD4gPSBudWxscHRyPgogICAgCiAgICBjb25zdGV4cHIgU3BhbihzdGQ6OmFycmF5PF9P dGhlckVsZW1lbnRUeXBlLCBfU3o+JiBfX2Fycikgbm9leGNlcHQgOiBfX2RhdGF7X19hcnIuZGF0 YSgpfSwgX19zaXple19Ten0ge30KCiAgICB0ZW1wbGF0ZSA8Y2xhc3MgX090aGVyRWxlbWVudFR5 cGUsIHN0ZDo6c2l6ZV90IF9TeiwKICAgICAgICAgICAgICBzdGQ6OmVuYWJsZV9pZl90PHN0ZDo6 aXNfY29udmVydGlibGVfdjxjb25zdCBfT3RoZXJFbGVtZW50VHlwZSgqKVtdLCBlbGVtZW50X3R5 cGUgKCopW10+LCBzdGQ6Om51bGxwdHJfdD4gPSBudWxscHRyPgogICAgCiAgICBjb25zdGV4cHIg U3Bhbihjb25zdCBzdGQ6OmFycmF5PF9PdGhlckVsZW1lbnRUeXBlLCBfU3o+JiBfX2Fycikgbm9l eGNlcHQgOiBfX2RhdGF7X19hcnIuZGF0YSgpfSwgX19zaXple19Ten0ge30KCiAgICB0ZW1wbGF0 ZSA8Y2xhc3MgX0NvbnRhaW5lcj4KICAgIAogICAgICAgIGNvbnN0ZXhwciBTcGFuKCAgICAgIF9D b250YWluZXImIF9fYywKICAgICAgICAgICAgc3RkOjplbmFibGVfaWZfdDxfX2lzX3NwYW5fY29t cGF0aWJsZV9jb250YWluZXI8X0NvbnRhaW5lciwgX1RwPjo6dmFsdWUsIHN0ZDo6bnVsbHB0cl90 PiA9IG51bGxwdHIpCiAgICAgICAgOiBfX2RhdGF7c3RkOjpkYXRhKF9fYyl9LCBfX3NpemV7KHNp emVfdHlwZSkgc3RkOjpzaXplKF9fYyl9IHt9CgogICAgdGVtcGxhdGUgPGNsYXNzIF9Db250YWlu ZXI+CiAgICAKICAgICAgICBjb25zdGV4cHIgU3Bhbihjb25zdCBfQ29udGFpbmVyJiBfX2MsCiAg ICAgICAgICAgIHN0ZDo6ZW5hYmxlX2lmX3Q8X19pc19zcGFuX2NvbXBhdGlibGVfY29udGFpbmVy PGNvbnN0IF9Db250YWluZXIsIF9UcD46OnZhbHVlLCBzdGQ6Om51bGxwdHJfdD4gPSBudWxscHRy KQogICAgICAgIDogX19kYXRhe3N0ZDo6ZGF0YShfX2MpfSwgX19zaXpleyhzaXplX3R5cGUpIHN0 ZDo6c2l6ZShfX2MpfSB7fQoKCiAgICB0ZW1wbGF0ZSA8Y2xhc3MgX090aGVyRWxlbWVudFR5cGUs IHN0ZDo6c2l6ZV90IF9PdGhlckV4dGVudD4KICAgIAogICAgICAgIGNvbnN0ZXhwciBTcGFuKGNv bnN0IFNwYW48X090aGVyRWxlbWVudFR5cGUsIF9PdGhlckV4dGVudD4mIF9fb3RoZXIsCiAgICAg ICAgICAgICAgICAgICAgICAgc3RkOjplbmFibGVfaWZfdDwKICAgICAgICAgICAgICAgICAgICAg ICAgICBzdGQ6OmlzX2NvbnZlcnRpYmxlX3Y8X090aGVyRWxlbWVudFR5cGUoKilbXSwgZWxlbWVu dF90eXBlICgqKVtdPiwKICAgICAgICAgICAgICAgICAgICAgICAgICBzdGQ6Om51bGxwdHJfdD4g PSBudWxscHRyKSBub2V4Y2VwdAogICAgICAgIDogX19kYXRhe19fb3RoZXIuZGF0YSgpfSwgX19z aXple19fb3RoZXIuc2l6ZSgpfSB7fQoKCiAgICBwb2ludGVyICAgX19kYXRhOwogICAgc2l6ZV90 eXBlIF9fc2l6ZTsKfTsKCnRlbXBsYXRlPGNsYXNzIF9UcCwgc3RkOjpzaXplX3QgX1N6PgogICAg U3BhbihzdGQ6OmFycmF5PF9UcCwgX1N6PiYpIC0+IFNwYW48X1RwLCBfU3o+OwoKdGVtcGxhdGU8 Y2xhc3MgX1RwLCBzdGQ6OnNpemVfdCBfU3o+CiAgICBTcGFuKGNvbnN0IHN0ZDo6YXJyYXk8X1Rw LCBfU3o+JikgLT4gU3Bhbjxjb25zdCBfVHAsIF9Tej47CgoKaW50IGEgPSAzOwppbnQgYiA9IDQ7 CmludCBjID0gMDsKCnNpemVfdCB1c2VfaXQoKSB7CiAgICBTcGFuPGNvbnN0IGludCogY29uc3Q+ IHNwYW47CgogICAgc3RhdGljIGNvbnN0ZXhwciBzdGQ6OmFycmF5IGFyciA9IHsmYSwgJmIsICZj fTsKCiAgICBzcGFuID0gYXJyOwoKICAgIHJldHVybiBzcGFuLl9fc2l6ZTsKfQ== 447413 2021-12-16 19:42:17 -0800 2021-12-16 23:51:08 -0800 Patch bug-234412-20211217034215.patch text/plain 1789 clopez U3VidmVyc2lvbiBSZXZpc2lvbjogMjg3MTY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2YyNDgyNmRiYmIyNTRm ZDVjNjUyYTAwNzQ4YjMyOTJkMmJiZTA2Yy4uNDM0MzM2MmFmYjY3NDc0NWYxMTE5NzBkYjIyZmE3 YjYwYzk0YWE3YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIxLTEyLTE2ICBDYXJs b3MgQWxiZXJ0byBMb3BleiBQZXJleiAgPGNsb3BlekBpZ2FsaWEuY29tPgorCisgICAgICAgIFJF R1JFU1NJT04ocjI4NzEzOCkgW0dMSUJdIEJ1aWxkIGZhaWx1cmUgd2l0aCBHQ0MgOCBhbmQgOSBp biBzdGQ6OmFycmF5IHRvIFNwYW4gY29udmVyc2lvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjM0NDEyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgR0NDIDwgMTAgYW5kIENsYW5nIDwgNyBoYXZlIHByb2Js ZW1zIGRvaW5nIHRoZSBjb252ZXJzaW9uIG9mIHRoZSB2YWx1ZSBpZiBpdHMgbWFya2VkIGNvbnN0 LgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgaXMgYSBidWlsZCBmaXguCisKKyAgICAgICAgKiBh Y2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlSZW5kZXJPYmplY3QuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6QWNjZXNzaWJpbGl0eVJlbmRlck9iamVjdDo6aW5oZXJpdHNQcmVzZW50YXRpb25hbFJv bGUgY29uc3QpOgorCiAyMDIxLTEyLTE2ICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2Vu QHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmVtb3ZlIG1vcmUgTlBBUEkgcGx1Z2luIGNvZGUKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eVJlbmRl ck9iamVjdC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlS ZW5kZXJPYmplY3QuY3BwCmluZGV4IGNjNzlkZWIyMzFkZmYyN2VhOTI1NWU0YWVjOTc0OTc4NmMw YjRmMWUuLjMwNmNhMzc1ZTEyYjA1MzNkMGNkMjc5ODQ0ODU4ZmVjNjlhNzcxNDcgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eVJlbmRlck9iamVj dC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5UmVu ZGVyT2JqZWN0LmNwcApAQCAtMzIxNCw3ICszMjE0LDcgQEAgYm9vbCBBY2Nlc3NpYmlsaXR5UmVu ZGVyT2JqZWN0Ojppbmhlcml0c1ByZXNlbnRhdGlvbmFsUm9sZSgpIGNvbnN0CiAgICAgLy8gdGhv c2UgY2hpbGQgZWxlbWVudHMgYXJlIGFsc28gcHJlc2VudGF0aW9uYWwuIEZvciBleGFtcGxlLCA8 bGk+IGJlY29tZXMgcHJlc2VudGF0aW9uYWwgZnJvbSA8dWw+LgogICAgIC8vIGh0dHA6Ly93d3cu dzMub3JnL1dBSS9QRi9hcmlhL2NvbXBsZXRlI3ByZXNlbnRhdGlvbgogCi0gICAgU3Bhbjxjb25z dCBMYXp5TmV2ZXJEZXN0cm95ZWQ8Y29uc3QgSFRNTFF1YWxpZmllZE5hbWU+KiBjb25zdD4gcGFy ZW50VGFnczsKKyAgICBTcGFuPExhenlOZXZlckRlc3Ryb3llZDxjb25zdCBIVE1MUXVhbGlmaWVk TmFtZT4qIGNvbnN0PiBwYXJlbnRUYWdzOwogICAgIHN3aXRjaCAocm9sZVZhbHVlKCkpIHsKICAg ICBjYXNlIEFjY2Vzc2liaWxpdHlSb2xlOjpMaXN0SXRlbToKICAgICBjYXNlIEFjY2Vzc2liaWxp dHlSb2xlOjpMaXN0TWFya2VyOiB7Cg==