234402 2021-12-16 11:55:24 -0800 [JSC] only emit pointer validation for ARM64E 2021-12-16 13:08:17 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 caitp caitp ews-watchlist keith_miller mark.lam msaboff saam tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1824831 0 caitp 2021-12-16 11:55:24 -0800 [JSC] only emit save/restore register for JIT thunks on ARM64 1824833 1 447378 caitp 2021-12-16 11:58:13 -0800 Created attachment 447378 Patch 1824836 2 447378 ysuzuki 2021-12-16 12:02:49 -0800 Comment on attachment 447378 Patch r=me if EWS is green. Probably need to have UNUSED_PARAM for parameters. 1824837 3 447378 mark.lam 2021-12-16 12:04:45 -0800 Comment on attachment 447378 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=447378&action=review > Source/JavaScriptCore/ChangeLog:3 > + [JSC] only emit save/restore register for JIT thunks on ARM64 A better description is “Only emit pointer validation for ARM64E.” > Source/JavaScriptCore/jit/ThunkGenerators.cpp:163 > +#endif You’ll need to add UNUSED_PARAM for the arguments that are not used for non-ARM64E ports. 1824838 4 447378 mark.lam 2021-12-16 12:06:02 -0800 Comment on attachment 447378 Patch Oops, didn’t mean to negate Yusuke’s r+. But please apply the fixes. 1824840 5 caitp 2021-12-16 12:11:22 -0800 (In reply to Mark Lam from comment #3) > Comment on attachment 447378 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=447378&action=review > > > Source/JavaScriptCore/ChangeLog:3 > > + [JSC] only emit save/restore register for JIT thunks on ARM64 > > A better description is “Only emit pointer validation for ARM64E.” > > > Source/JavaScriptCore/jit/ThunkGenerators.cpp:163 > > +#endif > > You’ll need to add UNUSED_PARAM for the arguments that are not used for > non-ARM64E ports. Done and done, just waiting on EWS 1824841 6 447382 caitp 2021-12-16 12:23:29 -0800 Created attachment 447382 Patch for landing 1824857 7 ews-feeder 2021-12-16 13:07:00 -0800 Committed r287154 (245332@main): <https://commits.webkit.org/245332@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 447382. 1824858 8 webkit-bug-importer 2021-12-16 13:08:17 -0800 <rdar://problem/86591795> 447378 2021-12-16 11:58:13 -0800 2021-12-16 12:23:57 -0800 Patch bug-234402-20211216195812.patch text/plain 1596 caitp U3VidmVyc2lvbiBSZXZpc2lvbjogMjg3MTQ3CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAw YjZhODBiNmIwOTI0YzIyZGQ5YTI0NTQwZGE0ZjdkMTRlMTAyMjgwLi40YTA1OTE5ODA3NTIzOTIz ZjA5YWM0MTQxNzZmYWQ1NDI5NjBhZWQyIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMyBAQAorMjAyMS0xMi0xNiAgQ2FpdGxpbiBQb3R0ZXIgIDxjYWl0cEBpZ2FsaWEuY29t PgorCisgICAgICAgIFtKU0NdIG9ubHkgZW1pdCBzYXZlL3Jlc3RvcmUgcmVnaXN0ZXIgZm9yIEpJ VCB0aHVua3Mgb24gQVJNNjQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTIzNDQwMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogaml0L1RodW5rR2VuZXJhdG9ycy5jcHA6CisgICAgICAgIChKU0M6OmVtaXRQ b2ludGVyVmFsaWRhdGlvbik6CisKIDIwMjEtMTItMTYgIE1pY2hhZWwgU2Fib2ZmICA8bXNhYm9m ZkBhcHBsZS5jb20+CiAKICAgICAgICAgQ3JlYXRlIHN5bWxpbmtzIHBvaW50aW5nIHRvIGFsdGVy bmF0ZSByb290IGZyYW1ld29yayBsb2NhdGlvbnMKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9qaXQvVGh1bmtHZW5lcmF0b3JzLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9q aXQvVGh1bmtHZW5lcmF0b3JzLmNwcAppbmRleCA4ZWI1N2MwOTdiMzBiYjY5YzlhMmVhYWRhYzgz OWYzYmVkZTJjNjk3Li4xOTJhNDQyOTcxNmZmMzBmMWE0Y2Y5MTZjMjIyOTU0MmU2MjYyMmMyIDEw MDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L1RodW5rR2VuZXJhdG9ycy5jcHAK KysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9UaHVua0dlbmVyYXRvcnMuY3BwCkBAIC0x NDgsNiArMTQ4LDcgQEAgTWFjcm9Bc3NlbWJsZXJDb2RlUmVmPEpJVFRodW5rUHRyVGFnPiBjaGVj a0V4Y2VwdGlvbkdlbmVyYXRvcihWTSYgdm0pCiB0ZW1wbGF0ZTx0eXBlbmFtZSBUYWdUeXBlPgog aW5saW5lIHZvaWQgZW1pdFBvaW50ZXJWYWxpZGF0aW9uKENDYWxsSGVscGVycyYgaml0LCBHUFJS ZWcgcG9pbnRlckdQUiwgVGFnVHlwZSB0YWcpCiB7CisjaWYgQ1BVKEFSTTY0RSkKICAgICBpZiAo IUFTU0VSVF9FTkFCTEVEKQogICAgICAgICByZXR1cm47CiAgICAgaWYgKCFPcHRpb25zOjp1c2VK SVRDYWdlKCkpIHsKQEAgLTE1OSw2ICsxNjAsNyBAQCBpbmxpbmUgdm9pZCBlbWl0UG9pbnRlclZh bGlkYXRpb24oQ0NhbGxIZWxwZXJzJiBqaXQsIEdQUlJlZyBwb2ludGVyR1BSLCBUYWdUeXBlCiAg ICAgICAgIGppdC52YWxpZGF0ZVVudGFnZ2VkUHRyKHBvaW50ZXJHUFIpOwogICAgICAgICBqaXQu cG9wVG9SZXN0b3JlKHBvaW50ZXJHUFIpOwogICAgIH0KKyNlbmRpZgogfQogCiAvLyBXZSB3aWxs IGp1bXAgaGVyZSBpZiB0aGUgSklUIGNvZGUgdHJpZXMgdG8gbWFrZSBhIGNhbGwsIGJ1dCB0aGUK 447382 2021-12-16 12:23:29 -0800 2021-12-16 13:07:02 -0800 Patch for landing bug-234402-20211216202328.patch text/plain 1809 caitp U3VidmVyc2lvbiBSZXZpc2lvbjogMjg3MTQ3CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAw YjZhODBiNmIwOTI0YzIyZGQ5YTI0NTQwZGE0ZjdkMTRlMTAyMjgwLi45MWZjOTc1NjAzYmY3MjZh NTYwOWNlMzM4MzIyYmJhOTA3MWYwOTliIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAyMS0xMi0xNiAgQ2FpdGxpbiBQb3R0ZXIgIDxjYWl0cEBpZ2FsaWEuY29t PgorCisgICAgICAgIFtKU0NdIG9ubHkgZW1pdCBwb2ludGVyIHZhbGlkYXRpb24gZm9yIEFSTTY0 RQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjM0NDAy CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgWXVzdWtlIFN1enVraSBhbmQgTWFyayBMYW0uCisKKyAg ICAgICAgSklUIHRodW5rcyBubyBsb25nZXIgZW1pdCBgcHVzaCA8cmVnPjsgcG9wIDxyZWc+O2Ag b24KKyAgICAgICAgbm9uLUFSTTY0RSBhcmNoZXMgd2l0aCB0aGUgZW1pdFBvaW50ZXJWYWxpZGF0 aW9uIG1hY3JvLgorCisgICAgICAgICogaml0L1RodW5rR2VuZXJhdG9ycy5jcHA6CisgICAgICAg IChKU0M6OmVtaXRQb2ludGVyVmFsaWRhdGlvbik6CisKIDIwMjEtMTItMTYgIE1pY2hhZWwgU2Fi b2ZmICA8bXNhYm9mZkBhcHBsZS5jb20+CiAKICAgICAgICAgQ3JlYXRlIHN5bWxpbmtzIHBvaW50 aW5nIHRvIGFsdGVybmF0ZSByb290IGZyYW1ld29yayBsb2NhdGlvbnMKZGlmZiAtLWdpdCBhL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvVGh1bmtHZW5lcmF0b3JzLmNwcCBiL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9qaXQvVGh1bmtHZW5lcmF0b3JzLmNwcAppbmRleCA4ZWI1N2MwOTdiMzBiYjY5 YzlhMmVhYWRhYzgzOWYzYmVkZTJjNjk3Li4wZmMyY2JhNzg3YjQwNWIyYzAyM2I3MjVmZjRhMjJi ZDc2MjZjZWExIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L1RodW5rR2Vu ZXJhdG9ycy5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9UaHVua0dlbmVyYXRv cnMuY3BwCkBAIC0xNDgsNiArMTQ4LDcgQEAgTWFjcm9Bc3NlbWJsZXJDb2RlUmVmPEpJVFRodW5r UHRyVGFnPiBjaGVja0V4Y2VwdGlvbkdlbmVyYXRvcihWTSYgdm0pCiB0ZW1wbGF0ZTx0eXBlbmFt ZSBUYWdUeXBlPgogaW5saW5lIHZvaWQgZW1pdFBvaW50ZXJWYWxpZGF0aW9uKENDYWxsSGVscGVy cyYgaml0LCBHUFJSZWcgcG9pbnRlckdQUiwgVGFnVHlwZSB0YWcpCiB7CisjaWYgQ1BVKEFSTTY0 RSkKICAgICBpZiAoIUFTU0VSVF9FTkFCTEVEKQogICAgICAgICByZXR1cm47CiAgICAgaWYgKCFP cHRpb25zOjp1c2VKSVRDYWdlKCkpIHsKQEAgLTE1OSw2ICsxNjAsMTEgQEAgaW5saW5lIHZvaWQg ZW1pdFBvaW50ZXJWYWxpZGF0aW9uKENDYWxsSGVscGVycyYgaml0LCBHUFJSZWcgcG9pbnRlckdQ UiwgVGFnVHlwZQogICAgICAgICBqaXQudmFsaWRhdGVVbnRhZ2dlZFB0cihwb2ludGVyR1BSKTsK ICAgICAgICAgaml0LnBvcFRvUmVzdG9yZShwb2ludGVyR1BSKTsKICAgICB9CisjZWxzZQorICAg IFVOVVNFRF9QQVJBTShqaXQpOworICAgIFVOVVNFRF9QQVJBTShwb2ludGVyR1BSKTsKKyAgICBV TlVTRURfUEFSQU0odGFnKTsKKyNlbmRpZgogfQogCiAvLyBXZSB3aWxsIGp1bXAgaGVyZSBpZiB0 aGUgSklUIGNvZGUgdHJpZXMgdG8gbWFrZSBhIGNhbGwsIGJ1dCB0aGUK