234399 2021-12-16 10:27:50 -0800 [JSC][32bit] Fix undefined behavior causing miscompilation with clang 13 on ARM 2021-12-20 06:25:17 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mikhail mikhail darin ews-watchlist keith_miller mark.lam msaboff saam tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1824805 0 mikhail 2021-12-16 10:27:50 -0800 [JSC][32bit] Fix undefined behavior causing misscompilation with clang 13 on ARM 1824810 1 447369 mikhail 2021-12-16 10:35:20 -0800 Created attachment 447369 Patch 1824812 2 447370 mikhail 2021-12-16 10:37:50 -0800 Created attachment 447370 Patch 1824815 3 447373 mikhail 2021-12-16 10:48:17 -0800 Created attachment 447373 Patch 1824866 4 447373 ysuzuki 2021-12-16 13:34:03 -0800 Comment on attachment 447373 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=447373&action=review > Source/JavaScriptCore/runtime/MathCommon.h:224 > { > - // Note: Strictly speaking this is an undefined behavior. > - return static_cast<int32_t>(value) == value; > + return canBeInt32(value) && !(!value && std::signbit(value)); // false for -0.0 > } This needs to be super fast. I think we should inline canBeInt32's code here, and use !asInt32 instead of !value. 1825057 5 447451 mikhail 2021-12-17 05:51:29 -0800 Created attachment 447451 Patch 1825409 6 447451 ysuzuki 2021-12-18 21:54:03 -0800 Comment on attachment 447451 Patch r=me 1825411 7 ews-feeder 2021-12-18 22:31:50 -0800 Committed r287235 (245395@main): <https://commits.webkit.org/245395@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 447451. 1825412 8 webkit-bug-importer 2021-12-18 22:32:19 -0800 <rdar://problem/86678800> 1825493 9 darin 2021-12-19 15:50:23 -0800 I prefer std::isfinite for checks like this. 1825494 10 darin 2021-12-19 15:51:02 -0800 (In reply to Darin Adler from comment #9) > I prefer std::isfinite for checks like this. Unless it is slower than calling both std::isnan and std::isinf. And if it is, then they should really fix that! 1825589 11 mikhail 2021-12-20 06:25:17 -0800 (In reply to Darin Adler from comment #10) > (In reply to Darin Adler from comment #9) > > I prefer std::isfinite for checks like this. > > Unless it is slower than calling both std::isnan and std::isinf. And if it > is, then they should really fix that! Humm, I think it's a good idea to benchmark that, we can even compare the two approaches against using fpclassify. 447369 2021-12-16 10:35:20 -0800 2021-12-16 10:37:46 -0800 Patch bug-234399-20211216183518.patch text/plain 2370 mikhail U3VidmVyc2lvbiBSZXZpc2lvbjogMjg3MDc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA3 MmU1OWI2NzcwNTY0MGFiMzBiMGUyNjlmMmRhN2FkYzNjZmZmOTcwLi4xMjNkMjYxOGU4ZWJiODg2 MDljOTliNzIxZjc5M2I2YzRmYTQzMWI0IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMiBAQAorMjAyMS0xMi0xNiAgTWlraGFpbCBSLiBHYWRlbGhhICA8bWlraGFpbEBpZ2Fs aWEuY29tPgorCisgICAgICAgIFtKU0NdWzMyYml0XSBGaXggdW5kZWZpbmVkIGJlaGF2aW9yIGNh dXNpbmcgbWlzc2NvbXBpbGF0aW9uIHdpdGggY2xhbmcgMTMgb24gQVJNCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzQzOTkKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDb21waWxpbmcgSlNDIHdpdGggY2xh bmcgMTMgb24gQVJNdjcgb24gbGludXggd2FzIGJyb2tlbiBiZWNhdXNlIGNsYW5nCisgICAgICAg IHdhcyBtYXJraW5nIHRoZSBjb25zdGFudCBJbmZpbml0eSBhcyBwb2lzb24gZHVyaW5nIGNvbnN0 YW50IGZvbGRpbmcsIGlmCisgICAgICAgIGVpdGhlciAtTzIgb3IgLU8zIHdlcmUgdXNlZCwgY2F1 c2luZyB0aGUgY29uc3RhbnQgdG8gbm90IGJlaW5nCisgICAgICAgIGluaXRpYWxpemVkLgorCisg ICAgICAgIFRoaXMgcGF0Y2ggcmVtb3ZlcyB0aGUgdW5kZWZpbmVkIGJlaGF2aW91ciBieSBwcmV2 ZW50aW5nIHRoZQorICAgICAgICBzdGF0aWNfY2FzdCB0byBpbnQzMl90IGlmIHRoZSBkb3VibGUg aXMgZWl0aGVyIGluZiBvciBOYU4uCisKKyAgICAgICAgKiBydW50aW1lL01hdGhDb21tb24uaDoK KyAgICAgICAgKEpTQzo6Y2FuQmVJbnQzMik6CisgICAgICAgIChKU0M6OmNhbkJlU3RyaWN0SW50 MzIpOgorCiAyMDIxLTEyLTE0ICBSb3NzIEtpcnNsaW5nICA8cm9zcy5raXJzbGluZ0Bzb255LmNv bT4KIAogICAgICAgICBbSlNDXSBPcEluc3RhbmNlb2ZDdXN0b20gc2hvdWxkIGJlIGluIENvbW1v blNsb3dQYXRocwpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvTWF0 aENvbW1vbi5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvTWF0aENvbW1vbi5oCmlu ZGV4IDRhYzNkZDk1MzZmOGQyMjQyZTY0ZWRhNjc0NDYyYWU3YWY1NTYzOTEuLjYyMjUyOWRmNmRh M2NmYzE4MjFkODBhMmU0YTZmZTFjZDNiODA1MjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9ydW50aW1lL01hdGhDb21tb24uaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv cnVudGltZS9NYXRoQ29tbW9uLmgKQEAgLTIxMSwxNyArMjExLDE2IEBAIGlubGluZSBzdGQ6Om9w dGlvbmFsPGRvdWJsZT4gc2FmZVJlY2lwcm9jYWxGb3JEaXZCeUNvbnN0KGRvdWJsZSBjb25zdGFu dCkKICAgICByZXR1cm4gcmVjaXByb2NhbDsKIH0KIAotQUxXQVlTX0lOTElORSBib29sIGNhbkJl U3RyaWN0SW50MzIoZG91YmxlIHZhbHVlKQorQUxXQVlTX0lOTElORSBib29sIGNhbkJlSW50MzIo ZG91YmxlIHZhbHVlKQogewotICAgIC8vIE5vdGU6IHdoaWxlIHRoaXMgYmVoYXZpb3IgaXMgdW5k ZWZpbmVkIGZvciBOYU4gYW5kIGluZiwgdGhlIHN1YnNlcXVlbnQgc3RhdGVtZW50IHdpbGwgY2F0 Y2ggdGhlc2UgY2FzZXMuCi0gICAgY29uc3QgaW50MzJfdCBhc0ludDMyID0gc3RhdGljX2Nhc3Q8 aW50MzJfdD4odmFsdWUpOwotICAgIHJldHVybiAhKGFzSW50MzIgIT0gdmFsdWUgfHwgKCFhc0lu dDMyICYmIHN0ZDo6c2lnbmJpdCh2YWx1ZSkpKTsgLy8gdHJ1ZSBmb3IgLTAuMAorICAgIGlmIChz dGQ6OmlzaW5mKHZhbHVlKSB8fCBzdGQ6OmlzbmFuKHZhbHVlKSkKKyAgICAgICAgcmV0dXJuIGZh bHNlOworICAgIHJldHVybiBzdGF0aWNfY2FzdDxpbnQzMl90Pih2YWx1ZSkgPT0gdmFsdWU7CiB9 CiAKLUFMV0FZU19JTkxJTkUgYm9vbCBjYW5CZUludDMyKGRvdWJsZSB2YWx1ZSkKK0FMV0FZU19J TkxJTkUgYm9vbCBjYW5CZVN0cmljdEludDMyKGRvdWJsZSB2YWx1ZSkKIHsKLSAgICAvLyBOb3Rl OiBTdHJpY3RseSBzcGVha2luZyB0aGlzIGlzIGFuIHVuZGVmaW5lZCBiZWhhdmlvci4KLSAgICBy ZXR1cm4gc3RhdGljX2Nhc3Q8aW50MzJfdD4odmFsdWUpID09IHZhbHVlOworICAgIHJldHVybiBj YW5CZUludDMyKHZhbHVlKSAmJiAhKCF2YWx1ZSAmJiBzdGQ6OnNpZ25iaXQodmFsdWUpKTsgLy8g dHJ1ZSBmb3IgLTAuMAogfQogCiBleHRlcm4gIkMiIHsK 447370 2021-12-16 10:37:50 -0800 2021-12-16 10:48:12 -0800 Patch bug-234399-20211216183749.patch text/plain 2369 mikhail U3VidmVyc2lvbiBSZXZpc2lvbjogMjg3MDc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA3 MmU1OWI2NzcwNTY0MGFiMzBiMGUyNjlmMmRhN2FkYzNjZmZmOTcwLi5lMTQ1MjQ4NjQyMzZiMTlk ZTIwOGU3MWMxYTNmNjYwNmUwZGY3YTRjIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMiBAQAorMjAyMS0xMi0xNiAgTWlraGFpbCBSLiBHYWRlbGhhICA8bWlraGFpbEBpZ2Fs aWEuY29tPgorCisgICAgICAgIFtKU0NdWzMyYml0XSBGaXggdW5kZWZpbmVkIGJlaGF2aW9yIGNh dXNpbmcgbWlzY29tcGlsYXRpb24gd2l0aCBjbGFuZyAxMyBvbiBBUk0KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNDM5OQorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENvbXBpbGluZyBKU0Mgd2l0aCBjbGFu ZyAxMyBvbiBBUk12NyBvbiBsaW51eCB3YXMgYnJva2VuIGJlY2F1c2UgY2xhbmcKKyAgICAgICAg d2FzIG1hcmtpbmcgdGhlIGNvbnN0YW50IEluZmluaXR5IGFzIHBvaXNvbiBkdXJpbmcgY29uc3Rh bnQgZm9sZGluZywgaWYKKyAgICAgICAgZWl0aGVyIC1PMiBvciAtTzMgd2VyZSB1c2VkLCBjYXVz aW5nIHRoZSBjb25zdGFudCB0byBub3QgYmVpbmcKKyAgICAgICAgaW5pdGlhbGl6ZWQuCisKKyAg ICAgICAgVGhpcyBwYXRjaCByZW1vdmVzIHRoZSB1bmRlZmluZWQgYmVoYXZpb3VyIGJ5IHByZXZl bnRpbmcgdGhlCisgICAgICAgIHN0YXRpY19jYXN0IHRvIGludDMyX3QgaWYgdGhlIGRvdWJsZSBp cyBlaXRoZXIgaW5mIG9yIE5hTi4KKworICAgICAgICAqIHJ1bnRpbWUvTWF0aENvbW1vbi5oOgor ICAgICAgICAoSlNDOjpjYW5CZUludDMyKToKKyAgICAgICAgKEpTQzo6Y2FuQmVTdHJpY3RJbnQz Mik6CisKIDIwMjEtMTItMTQgIFJvc3MgS2lyc2xpbmcgIDxyb3NzLmtpcnNsaW5nQHNvbnkuY29t PgogCiAgICAgICAgIFtKU0NdIE9wSW5zdGFuY2VvZkN1c3RvbSBzaG91bGQgYmUgaW4gQ29tbW9u U2xvd1BhdGhzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9NYXRo Q29tbW9uLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9NYXRoQ29tbW9uLmgKaW5k ZXggNGFjM2RkOTUzNmY4ZDIyNDJlNjRlZGE2NzQ0NjJhZTdhZjU1NjM5MS4uNjIyNTI5ZGY2ZGEz Y2ZjMTgyMWQ4MGEyZTRhNmZlMWNkM2I4MDUyNyAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3Jp cHRDb3JlL3J1bnRpbWUvTWF0aENvbW1vbi5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9y dW50aW1lL01hdGhDb21tb24uaApAQCAtMjExLDE3ICsyMTEsMTYgQEAgaW5saW5lIHN0ZDo6b3B0 aW9uYWw8ZG91YmxlPiBzYWZlUmVjaXByb2NhbEZvckRpdkJ5Q29uc3QoZG91YmxlIGNvbnN0YW50 KQogICAgIHJldHVybiByZWNpcHJvY2FsOwogfQogCi1BTFdBWVNfSU5MSU5FIGJvb2wgY2FuQmVT dHJpY3RJbnQzMihkb3VibGUgdmFsdWUpCitBTFdBWVNfSU5MSU5FIGJvb2wgY2FuQmVJbnQzMihk b3VibGUgdmFsdWUpCiB7Ci0gICAgLy8gTm90ZTogd2hpbGUgdGhpcyBiZWhhdmlvciBpcyB1bmRl ZmluZWQgZm9yIE5hTiBhbmQgaW5mLCB0aGUgc3Vic2VxdWVudCBzdGF0ZW1lbnQgd2lsbCBjYXRj aCB0aGVzZSBjYXNlcy4KLSAgICBjb25zdCBpbnQzMl90IGFzSW50MzIgPSBzdGF0aWNfY2FzdDxp bnQzMl90Pih2YWx1ZSk7Ci0gICAgcmV0dXJuICEoYXNJbnQzMiAhPSB2YWx1ZSB8fCAoIWFzSW50 MzIgJiYgc3RkOjpzaWduYml0KHZhbHVlKSkpOyAvLyB0cnVlIGZvciAtMC4wCisgICAgaWYgKHN0 ZDo6aXNpbmYodmFsdWUpIHx8IHN0ZDo6aXNuYW4odmFsdWUpKQorICAgICAgICByZXR1cm4gZmFs c2U7CisgICAgcmV0dXJuIHN0YXRpY19jYXN0PGludDMyX3Q+KHZhbHVlKSA9PSB2YWx1ZTsKIH0K IAotQUxXQVlTX0lOTElORSBib29sIGNhbkJlSW50MzIoZG91YmxlIHZhbHVlKQorQUxXQVlTX0lO TElORSBib29sIGNhbkJlU3RyaWN0SW50MzIoZG91YmxlIHZhbHVlKQogewotICAgIC8vIE5vdGU6 IFN0cmljdGx5IHNwZWFraW5nIHRoaXMgaXMgYW4gdW5kZWZpbmVkIGJlaGF2aW9yLgotICAgIHJl dHVybiBzdGF0aWNfY2FzdDxpbnQzMl90Pih2YWx1ZSkgPT0gdmFsdWU7CisgICAgcmV0dXJuIGNh bkJlSW50MzIodmFsdWUpICYmICEoIXZhbHVlICYmIHN0ZDo6c2lnbmJpdCh2YWx1ZSkpOyAvLyB0 cnVlIGZvciAtMC4wCiB9CiAKIGV4dGVybiAiQyIgewo= 447373 2021-12-16 10:48:17 -0800 2021-12-17 05:51:24 -0800 Patch bug-234399-20211216184815.patch text/plain 2370 mikhail U3VidmVyc2lvbiBSZXZpc2lvbjogMjg3MDc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA3 MmU1OWI2NzcwNTY0MGFiMzBiMGUyNjlmMmRhN2FkYzNjZmZmOTcwLi5lMTQ1MjQ4NjQyMzZiMTlk ZTIwOGU3MWMxYTNmNjYwNmUwZGY3YTRjIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMiBAQAorMjAyMS0xMi0xNiAgTWlraGFpbCBSLiBHYWRlbGhhICA8bWlraGFpbEBpZ2Fs aWEuY29tPgorCisgICAgICAgIFtKU0NdWzMyYml0XSBGaXggdW5kZWZpbmVkIGJlaGF2aW9yIGNh dXNpbmcgbWlzY29tcGlsYXRpb24gd2l0aCBjbGFuZyAxMyBvbiBBUk0KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNDM5OQorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENvbXBpbGluZyBKU0Mgd2l0aCBjbGFu ZyAxMyBvbiBBUk12NyBvbiBsaW51eCB3YXMgYnJva2VuIGJlY2F1c2UgY2xhbmcKKyAgICAgICAg d2FzIG1hcmtpbmcgdGhlIGNvbnN0YW50IEluZmluaXR5IGFzIHBvaXNvbiBkdXJpbmcgY29uc3Rh bnQgZm9sZGluZywgaWYKKyAgICAgICAgZWl0aGVyIC1PMiBvciAtTzMgd2VyZSB1c2VkLCBjYXVz aW5nIHRoZSBjb25zdGFudCB0byBub3QgYmVpbmcKKyAgICAgICAgaW5pdGlhbGl6ZWQuCisKKyAg ICAgICAgVGhpcyBwYXRjaCByZW1vdmVzIHRoZSB1bmRlZmluZWQgYmVoYXZpb3VyIGJ5IHByZXZl bnRpbmcgdGhlCisgICAgICAgIHN0YXRpY19jYXN0IHRvIGludDMyX3QgaWYgdGhlIGRvdWJsZSBp cyBlaXRoZXIgaW5mIG9yIE5hTi4KKworICAgICAgICAqIHJ1bnRpbWUvTWF0aENvbW1vbi5oOgor ICAgICAgICAoSlNDOjpjYW5CZUludDMyKToKKyAgICAgICAgKEpTQzo6Y2FuQmVTdHJpY3RJbnQz Mik6CisKIDIwMjEtMTItMTQgIFJvc3MgS2lyc2xpbmcgIDxyb3NzLmtpcnNsaW5nQHNvbnkuY29t PgogCiAgICAgICAgIFtKU0NdIE9wSW5zdGFuY2VvZkN1c3RvbSBzaG91bGQgYmUgaW4gQ29tbW9u U2xvd1BhdGhzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9NYXRo Q29tbW9uLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9NYXRoQ29tbW9uLmgKaW5k ZXggNGFjM2RkOTUzNmY4ZDIyNDJlNjRlZGE2NzQ0NjJhZTdhZjU1NjM5MS4uODE5ZjUzYTQ5MmI0 ZDRiMzQ4MTQwNGRjYmFiYTgxZGQ4YmZjODA5MSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3Jp cHRDb3JlL3J1bnRpbWUvTWF0aENvbW1vbi5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9y dW50aW1lL01hdGhDb21tb24uaApAQCAtMjExLDE3ICsyMTEsMTYgQEAgaW5saW5lIHN0ZDo6b3B0 aW9uYWw8ZG91YmxlPiBzYWZlUmVjaXByb2NhbEZvckRpdkJ5Q29uc3QoZG91YmxlIGNvbnN0YW50 KQogICAgIHJldHVybiByZWNpcHJvY2FsOwogfQogCi1BTFdBWVNfSU5MSU5FIGJvb2wgY2FuQmVT dHJpY3RJbnQzMihkb3VibGUgdmFsdWUpCitBTFdBWVNfSU5MSU5FIGJvb2wgY2FuQmVJbnQzMihk b3VibGUgdmFsdWUpCiB7Ci0gICAgLy8gTm90ZTogd2hpbGUgdGhpcyBiZWhhdmlvciBpcyB1bmRl ZmluZWQgZm9yIE5hTiBhbmQgaW5mLCB0aGUgc3Vic2VxdWVudCBzdGF0ZW1lbnQgd2lsbCBjYXRj aCB0aGVzZSBjYXNlcy4KLSAgICBjb25zdCBpbnQzMl90IGFzSW50MzIgPSBzdGF0aWNfY2FzdDxp bnQzMl90Pih2YWx1ZSk7Ci0gICAgcmV0dXJuICEoYXNJbnQzMiAhPSB2YWx1ZSB8fCAoIWFzSW50 MzIgJiYgc3RkOjpzaWduYml0KHZhbHVlKSkpOyAvLyB0cnVlIGZvciAtMC4wCisgICAgaWYgKHN0 ZDo6aXNpbmYodmFsdWUpIHx8IHN0ZDo6aXNuYW4odmFsdWUpKQorICAgICAgICByZXR1cm4gZmFs c2U7CisgICAgcmV0dXJuIHN0YXRpY19jYXN0PGludDMyX3Q+KHZhbHVlKSA9PSB2YWx1ZTsKIH0K IAotQUxXQVlTX0lOTElORSBib29sIGNhbkJlSW50MzIoZG91YmxlIHZhbHVlKQorQUxXQVlTX0lO TElORSBib29sIGNhbkJlU3RyaWN0SW50MzIoZG91YmxlIHZhbHVlKQogewotICAgIC8vIE5vdGU6 IFN0cmljdGx5IHNwZWFraW5nIHRoaXMgaXMgYW4gdW5kZWZpbmVkIGJlaGF2aW9yLgotICAgIHJl dHVybiBzdGF0aWNfY2FzdDxpbnQzMl90Pih2YWx1ZSkgPT0gdmFsdWU7CisgICAgcmV0dXJuIGNh bkJlSW50MzIodmFsdWUpICYmICEoIXZhbHVlICYmIHN0ZDo6c2lnbmJpdCh2YWx1ZSkpOyAvLyBm YWxzZSBmb3IgLTAuMAogfQogCiBleHRlcm4gIkMiIHsK 447451 2021-12-17 05:51:29 -0800 2021-12-18 22:31:51 -0800 Patch bug-234399-20211217135127.patch text/plain 2170 mikhail U3VidmVyc2lvbiBSZXZpc2lvbjogMjg3MDc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA3 MmU1OWI2NzcwNTY0MGFiMzBiMGUyNjlmMmRhN2FkYzNjZmZmOTcwLi5lMTQ1MjQ4NjQyMzZiMTlk ZTIwOGU3MWMxYTNmNjYwNmUwZGY3YTRjIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMiBAQAorMjAyMS0xMi0xNiAgTWlraGFpbCBSLiBHYWRlbGhhICA8bWlraGFpbEBpZ2Fs aWEuY29tPgorCisgICAgICAgIFtKU0NdWzMyYml0XSBGaXggdW5kZWZpbmVkIGJlaGF2aW9yIGNh dXNpbmcgbWlzY29tcGlsYXRpb24gd2l0aCBjbGFuZyAxMyBvbiBBUk0KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNDM5OQorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENvbXBpbGluZyBKU0Mgd2l0aCBjbGFu ZyAxMyBvbiBBUk12NyBvbiBsaW51eCB3YXMgYnJva2VuIGJlY2F1c2UgY2xhbmcKKyAgICAgICAg d2FzIG1hcmtpbmcgdGhlIGNvbnN0YW50IEluZmluaXR5IGFzIHBvaXNvbiBkdXJpbmcgY29uc3Rh bnQgZm9sZGluZywgaWYKKyAgICAgICAgZWl0aGVyIC1PMiBvciAtTzMgd2VyZSB1c2VkLCBjYXVz aW5nIHRoZSBjb25zdGFudCB0byBub3QgYmVpbmcKKyAgICAgICAgaW5pdGlhbGl6ZWQuCisKKyAg ICAgICAgVGhpcyBwYXRjaCByZW1vdmVzIHRoZSB1bmRlZmluZWQgYmVoYXZpb3VyIGJ5IHByZXZl bnRpbmcgdGhlCisgICAgICAgIHN0YXRpY19jYXN0IHRvIGludDMyX3QgaWYgdGhlIGRvdWJsZSBp cyBlaXRoZXIgaW5mIG9yIE5hTi4KKworICAgICAgICAqIHJ1bnRpbWUvTWF0aENvbW1vbi5oOgor ICAgICAgICAoSlNDOjpjYW5CZUludDMyKToKKyAgICAgICAgKEpTQzo6Y2FuQmVTdHJpY3RJbnQz Mik6CisKIDIwMjEtMTItMTQgIFJvc3MgS2lyc2xpbmcgIDxyb3NzLmtpcnNsaW5nQHNvbnkuY29t PgogCiAgICAgICAgIFtKU0NdIE9wSW5zdGFuY2VvZkN1c3RvbSBzaG91bGQgYmUgaW4gQ29tbW9u U2xvd1BhdGhzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9NYXRo Q29tbW9uLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9NYXRoQ29tbW9uLmgKaW5k ZXggNGFjM2RkOTUzNmY4ZDIyNDJlNjRlZGE2NzQ0NjJhZTdhZjU1NjM5MS4uY2E1YjM5NGVlYTdi MjZiOTE0NWZmODI2NWM2ZGU2ZjNlMTMyZjYyYSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3Jp cHRDb3JlL3J1bnRpbWUvTWF0aENvbW1vbi5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9y dW50aW1lL01hdGhDb21tb24uaApAQCAtMjEzLDE0ICsyMTMsMTYgQEAgaW5saW5lIHN0ZDo6b3B0 aW9uYWw8ZG91YmxlPiBzYWZlUmVjaXByb2NhbEZvckRpdkJ5Q29uc3QoZG91YmxlIGNvbnN0YW50 KQogCiBBTFdBWVNfSU5MSU5FIGJvb2wgY2FuQmVTdHJpY3RJbnQzMihkb3VibGUgdmFsdWUpCiB7 Ci0gICAgLy8gTm90ZTogd2hpbGUgdGhpcyBiZWhhdmlvciBpcyB1bmRlZmluZWQgZm9yIE5hTiBh bmQgaW5mLCB0aGUgc3Vic2VxdWVudCBzdGF0ZW1lbnQgd2lsbCBjYXRjaCB0aGVzZSBjYXNlcy4K KyAgICBpZiAoc3RkOjppc2luZih2YWx1ZSkgfHwgc3RkOjppc25hbih2YWx1ZSkpCisgICAgICAg IHJldHVybiBmYWxzZTsKICAgICBjb25zdCBpbnQzMl90IGFzSW50MzIgPSBzdGF0aWNfY2FzdDxp bnQzMl90Pih2YWx1ZSk7CiAgICAgcmV0dXJuICEoYXNJbnQzMiAhPSB2YWx1ZSB8fCAoIWFzSW50 MzIgJiYgc3RkOjpzaWduYml0KHZhbHVlKSkpOyAvLyB0cnVlIGZvciAtMC4wCiB9CiAKIEFMV0FZ U19JTkxJTkUgYm9vbCBjYW5CZUludDMyKGRvdWJsZSB2YWx1ZSkKIHsKLSAgICAvLyBOb3RlOiBT dHJpY3RseSBzcGVha2luZyB0aGlzIGlzIGFuIHVuZGVmaW5lZCBiZWhhdmlvci4KKyAgICBpZiAo c3RkOjppc2luZih2YWx1ZSkgfHwgc3RkOjppc25hbih2YWx1ZSkpCisgICAgICAgIHJldHVybiBm YWxzZTsKICAgICByZXR1cm4gc3RhdGljX2Nhc3Q8aW50MzJfdD4odmFsdWUpID09IHZhbHVlOwog fQogCg==