234396 2021-12-16 09:54:17 -0800 Rename forEachFrameFromMainFrame to forEachFrame 2021-12-16 11:25:05 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 23424 1 bfulgham bfulgham bfulgham darin ggaren simon.fraser webkit-bug-importer oldest_to_newest 1824793 0 bfulgham 2021-12-16 09:54:17 -0800 Follow-up to Bug 234324: Darin and Simon: "I agree with Simon: The core functions themselves need not mention the "main frame". They iterate all frames and all documents. The role of the main frame is an unimportant implementation detail that should not be in the function names. We should immediately rename forEachFrameFromMainFrame to just forEachFrame. The odd function out is forEachDocumentFromMainFrame, and it’s something we should intend to remove (see below)." This patch does that renaming. 1824794 1 webkit-bug-importer 2021-12-16 09:55:35 -0800 <rdar://problem/86581926> 1824800 2 447367 bfulgham 2021-12-16 10:03:13 -0800 Created attachment 447367 Patch 1824808 3 447367 ggaren 2021-12-16 10:33:54 -0800 Comment on attachment 447367 Patch r=me 1824824 4 ews-feeder 2021-12-16 11:25:00 -0800 Committed r287147 (245330@main): <https://commits.webkit.org/245330@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 447367. 447367 2021-12-16 10:03:13 -0800 2021-12-16 11:25:03 -0800 Patch bug-234396-20211216100312.patch text/plain 2781 bfulgham U3VidmVyc2lvbiBSZXZpc2lvbjogMjg3MTQyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2NlMmY5YjkwNDI2NGY3 ZmUxZDQ0MWJiYWYyZjgzMzI1YjZlYzFkOS4uYzA4YzAxNWJhYWNhOTI0MDhkOWIwMWEzYWNiN2Nm MmRmYmQ2YmM2YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDIxLTEyLTE2ICBCcmVu dCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFJlbmFtZSBmb3JFYWNo RnJhbWVGcm9tTWFpbkZyYW1lIHRvIGZvckVhY2hGcmFtZQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjM0Mzk2CisgICAgICAgIDxyZGFyOi8vcHJvYmxl bS84NjU4MTkyNj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBGb2xsb3ctdXAgdG8gcjI4NzExMDogU3dpdGNoIG1ldGhvZCBuYW1pbmcgdG8gbWF0Y2gg J2ZvckVhY2hEb2N1bWVudCcuCisKKyAgICAgICAgKiBwYWdlL1BhZ2UuY3BwOgorICAgICAgICAo V2ViQ29yZTo6UGFnZTo6flBhZ2UpOgorICAgICAgICAoV2ViQ29yZTo6UGFnZTo6bm90aWZ5VG9J bmplY3RVc2VyU2NyaXB0cyk6CisgICAgICAgIChXZWJDb3JlOjpQYWdlOjpmb3JFYWNoRnJhbWUp OgorICAgICAgICAoV2ViQ29yZTo6UGFnZTo6Zm9yRWFjaEZyYW1lRnJvbU1haW5GcmFtZSk6IERl bGV0ZWQuCisgICAgICAgICogcGFnZS9QYWdlLmg6CisKIDIwMjEtMTItMTYgIEFsYW4gQnVqdGFz ICA8emFsYW5AYXBwbGUuY29tPgogCiAgICAgICAgIFtMRkNdW0lGQ10gU2ltcGxlIFJUTCBjb250 ZW50IG1heSBuZWVkIHZpc3VhbCByZW9yZGVyaW5nCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9wYWdlL1BhZ2UuY3BwIGIvU291cmNlL1dlYkNvcmUvcGFnZS9QYWdlLmNwcAppbmRleCA0ZjJm MGQ3NjlhZWQwOWFjYmYzMmIwYTYzNzJjMTNmMDMzZjEyMDEwLi5iNWI5ZGY5OWQ4ZGQ2OWNkNjgy NDFhNzE0NTc1YzY5YTllZTlhZWFjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL1Bh Z2UuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUGFnZS5jcHAKQEAgLTQwNyw3ICs0MDcs NyBAQCBQYWdlOjp+UGFnZSgpCiAKICAgICBtX2luc3BlY3RvckNvbnRyb2xsZXItPmluc3BlY3Rl ZFBhZ2VEZXN0cm95ZWQoKTsKIAotICAgIGZvckVhY2hGcmFtZUZyb21NYWluRnJhbWUoW10gKEZy YW1lJiBmcmFtZSkgeworICAgIGZvckVhY2hGcmFtZShbXSAoRnJhbWUmIGZyYW1lKSB7CiAgICAg ICAgIGZyYW1lLndpbGxEZXRhY2hQYWdlKCk7CiAgICAgICAgIGZyYW1lLmRldGFjaEZyb21QYWdl KCk7CiAgICAgfSk7CkBAIC0yOTkxLDcgKzI5OTEsNyBAQCB2b2lkIFBhZ2U6Om5vdGlmeVRvSW5q ZWN0VXNlclNjcmlwdHMoKQogewogICAgIG1faGFzQmVlbk5vdGlmaWVkVG9JbmplY3RVc2VyU2Ny aXB0cyA9IHRydWU7CiAKLSAgICBmb3JFYWNoRnJhbWVGcm9tTWFpbkZyYW1lKFtdIChGcmFtZSYg ZnJhbWUpIHsKKyAgICBmb3JFYWNoRnJhbWUoW10gKEZyYW1lJiBmcmFtZSkgewogICAgICAgICBm cmFtZS5pbmplY3RVc2VyU2NyaXB0c0F3YWl0aW5nTm90aWZpY2F0aW9uKCk7CiAgICAgfSk7CiB9 CkBAIC0zNDMyLDcgKzM0MzIsNyBAQCB2b2lkIFBhZ2U6OmZvckVhY2hNZWRpYUVsZW1lbnQoY29u c3QgRnVuY3Rpb248dm9pZChIVE1MTWVkaWFFbGVtZW50Jik+JiBmdW5jdG9yKQogI2VuZGlmCiB9 CiAKLXZvaWQgUGFnZTo6Zm9yRWFjaEZyYW1lRnJvbU1haW5GcmFtZShjb25zdCBGdW5jdGlvbjx2 b2lkKEZyYW1lJik+JiBmdW5jdG9yKQordm9pZCBQYWdlOjpmb3JFYWNoRnJhbWUoY29uc3QgRnVu Y3Rpb248dm9pZChGcmFtZSYpPiYgZnVuY3RvcikKIHsKICAgICBWZWN0b3I8UmVmPEZyYW1lPj4g ZnJhbWVzOwogICAgIGZvciAoYXV0byogZnJhbWUgPSAmbWFpbkZyYW1lKCk7IGZyYW1lOyBmcmFt ZSA9IGZyYW1lLT50cmVlKCkudHJhdmVyc2VOZXh0KCkpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9wYWdlL1BhZ2UuaCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUGFnZS5oCmluZGV4IDJlZWUy NGM0ZDg5ODhmZGY1NjFmMDA0MjllNjI2NGYwYTExYmQ3YTguLmQ2ZDVhZTJjNTY2NDRlMjUzODk4 YTA0YTBmOWNiM2NjYWE1MzZhZjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUGFn ZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUGFnZS5oCkBAIC04OTMsNyArODkzLDcgQEAg cHVibGljOgogICAgIFdFQkNPUkVfRVhQT1JUIHZvaWQgZm9yRWFjaERvY3VtZW50KGNvbnN0IEZ1 bmN0aW9uPHZvaWQoRG9jdW1lbnQmKT4mKSBjb25zdDsKICAgICB2b2lkIGZvckVhY2hNZWRpYUVs ZW1lbnQoY29uc3QgRnVuY3Rpb248dm9pZChIVE1MTWVkaWFFbGVtZW50Jik+Jik7CiAgICAgc3Rh dGljIHZvaWQgZm9yRWFjaERvY3VtZW50RnJvbU1haW5GcmFtZShjb25zdCBGcmFtZSYsIGNvbnN0 IEZ1bmN0aW9uPHZvaWQoRG9jdW1lbnQmKT4mKTsKLSAgICB2b2lkIGZvckVhY2hGcmFtZUZyb21N YWluRnJhbWUoY29uc3QgRnVuY3Rpb248dm9pZChGcmFtZSYpPiYpOworICAgIHZvaWQgZm9yRWFj aEZyYW1lKGNvbnN0IEZ1bmN0aW9uPHZvaWQoRnJhbWUmKT4mKTsKIAogICAgIGJvb2wgc2hvdWxk RGlzYWJsZUNvcnNGb3JSZXF1ZXN0VG8oY29uc3QgVVJMJikgY29uc3Q7CiAK