234371 2021-12-15 16:00:50 -0800 [ANGLE] "WARN: driver_utils.cpp:169 (rx::GetVendorString):! Unimplemented: rx::GetVendorString" on WinCairo debug testing bot 2021-12-17 13:41:19 -0800 1 1 1 Unclassified WebKit ANGLE WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 fujii fujii dino ews-watchlist geofflang gman jonahr kbr kkinnunen kondapallykalyan kpiddington webkit-bug-importer oldest_to_newest 1824571 0 fujii 2021-12-15 16:00:50 -0800 After r286603 updated ANGLE, WinCairo debug testing bot is observing annoying warning message for all WebGL tessts. WinCairo-64-bit-WKL-Debug-Tests https://build.webkit.org/#/builders/32/builds/1384/steps/11/logs/stdio 14:28:24.558 6820 webgl/2.0.0/conformance/uniforms/uniform-values-per-program.html passed 14:28:25.391 6820 worker/0 webgl/2.0.y/conformance2/context/constants-and-properties-2.html output stderr lines: 14:28:25.391 6820 WARN: driver_utils.cpp:169 (rx::GetVendorString): ! Unimplemented: rx::GetVendorString(..\..\Source\ThirdParty\ANGLE\src\libANGLE\renderer\driver_utils.cpp:169) 14:28:25.391 6820 WARN: driver_utils.cpp:169 (rx::GetVendorString): ! Unimplemented: rx::GetVendorString(..\..\Source\ThirdParty\ANGLE\src\libANGLE\renderer\driver_utils.cpp:169) 14:28:25.392 6820 TestRunner::notifyDone() called unexpectedly. 14:28:25.392 6820 webgl/2.0.y/conformance2/context/constants-and-properties-2.html passed 14:28:26.488 6820 worker/0 webgl/2.0.y/conformance2/vertex_arrays/vertex-array-object.html output stderr lines: 14:28:26.488 6820 WARN: driver_utils.cpp:169 (rx::GetVendorString): ! Unimplemented: rx::GetVendorString(..\..\Source\ThirdParty\ANGLE\src\libANGLE\renderer\driver_utils.cpp:169) 14:28:26.488 6820 WARN: driver_utils.cpp:169 (rx::GetVendorString): ! Unimplemented: rx::GetVendorString(..\..\Source\ThirdParty\ANGLE\src\libANGLE\renderer\driver_utils.cpp:169) 14:28:26.488 6820 TestRunner::notifyDone() called unexpectedly. Surprisingly, I don't see this warning on my PC. Is this depending on a GPU driver? 1824576 1 fujii 2021-12-15 16:24:22 -0800 I'm observing the same problem on the internal testing bot. dxdiag.exe reports: Vendor ID: 0x1414 Card name: VMware SVGA 3D Manufacturer: VMware, Inc. Chip type: VMware Virtual SVGA 3D Graphics Adapter This is the result of my PC: Vendor ID: 0x1002 Card name: AMD Radeon Pro WX 2100 Manufacturer: Advanced Micro Devices, Inc. Chip type: AMD FirePro SDI (0x6995) 1824579 2 fujii 2021-12-15 16:35:33 -0800 Mozilla has the following code. https://hg.mozilla.org/mozilla-central/file/tip/widget/GfxDriverInfo.cpp > DECLARE_VENDOR_ID(Microsoft, "0x1414") 1824589 3 kbr 2021-12-15 16:52:01 -0800 Please feel free to propose a patch against WebKit's copy of ANGLE 1824590 4 kbr 2021-12-15 16:52:36 -0800 (oops, didn't mean to submit that comment as is) ...and we'll be happy to help you upstream it to the ANGLE repository. 1824928 5 fujii 2021-12-16 18:02:31 -0800 Unfortunately, dxdiag.exe doesn't work in the WinCairo-64-bit-WKL-Debug-Tests container. So, I created a simple program and compiled it in the container. The vendor ID is also 0x1414. https://gist.github.com/fujii/72df773fe7fa11fd7459755f184cee6a 1824972 6 447420 fujii 2021-12-16 21:02:29 -0800 Created attachment 447420 Patch 1824973 7 ews-watchlist 2021-12-16 21:03:31 -0800 Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE 1825164 8 447420 kbr 2021-12-17 12:53:39 -0800 Comment on attachment 447420 Patch Seems fine. r+ 1825172 9 ews-feeder 2021-12-17 13:40:26 -0800 Committed r287204 (245371@main): <https://commits.webkit.org/245371@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 447420. 1825173 10 webkit-bug-importer 2021-12-17 13:41:19 -0800 <rdar://problem/86648972> 447420 2021-12-16 21:02:29 -0800 2021-12-17 13:40:28 -0800 Patch bug-234371-20211217140228.patch text/plain 3204 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjg3MTY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9BTkdMRS9DaGFuZ2VMb2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cKaW5k ZXggYmI2Yzg2YjU5MDk2NDFhZGU4ZWFhMDUxMGYyOWRiMTNhYzNiOThiMC4uMDczNmMxNjljZmYw YjkzZjkyMDIzODlhOWY4ZWM5MzVkNWVkZTU4MCAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFy dHkvQU5HTEUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDIxIEBACisyMDIxLTEyLTE2ICBGdWppaSBIaXJvbm9yaSAgPEhpcm9ub3Jp LkZ1amlpQHNvbnkuY29tPgorCisgICAgICAgIFtBTkdMRV0gIldBUk46IGRyaXZlcl91dGlscy5j cHA6MTY5IChyeDo6R2V0VmVuZG9yU3RyaW5nKTohIFVuaW1wbGVtZW50ZWQ6IHJ4OjpHZXRWZW5k b3JTdHJpbmciIG9uIFdpbkNhaXJvIGRlYnVnIHRlc3RpbmcgYm90CisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzQzNzEKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZnRlciByMjg2NjAzIHVwZGF0ZWQgQU5H TEUsIFdpbkNhaXJvIGRlYnVnIHRlc3RpbmcgYm90IHdhcworICAgICAgICBvYnNlcnZpbmcgYW5u b3lpbmcgd2FybmluZyBtZXNzYWdlIGZvciBhbGwgV2ViR0wgdGVzc3RzLgorICAgICAgICA+IFdB Uk46IGRyaXZlcl91dGlscy5jcHA6MTY5IChyeDo6R2V0VmVuZG9yU3RyaW5nKTogCSEgVW5pbXBs ZW1lbnRlZDogcng6OkdldFZlbmRvclN0cmluZyguLlwuLlxTb3VyY2VcVGhpcmRQYXJ0eVxBTkdM RVxzcmNcbGliQU5HTEVccmVuZGVyZXJcZHJpdmVyX3V0aWxzLmNwcDoxNjkpCisKKyAgICAgICAg VGhlIHZlbmRvciBJRCB3YXMgMHgxNDE0IChNaWNyb3NvZnQpLgorICAgICAgICA8aHR0cHM6Ly9w Y2lzaWcuY29tL21lbWJlcnNoaXAvbWVtYmVyLWNvbXBhbmllcz4KKworICAgICAgICAqIHNyYy9s aWJBTkdMRS9yZW5kZXJlci9kcml2ZXJfdXRpbHMuY3BwOgorICAgICAgICAocng6OkdldFZlbmRv clN0cmluZyk6IEFkZGVkIG1vcmUgdmVuZG9yIHN0cmluZ3MgZm9yIHZlbmRvciBJRHMuCisgICAg ICAgICogc3JjL2xpYkFOR0xFL3JlbmRlcmVyL2RyaXZlcl91dGlscy5oOiBBZGRlZCBWRU5ET1Jf SURfTUlDUk9TT0ZULgorCiAyMDIxLTEyLTE2ICBKb2huIEN1bm5pbmdoYW0gIDxqb2huY3Vubmlu Z2hhbUBhcHBsZS5jb20+CiAKICAgICAgICAgQWRkIHN1cHBvcnQgdG8gYXR0cmlidXRlIG93bmVy c2hpcCBvZiBBTkdMRSBNZXRhbCdzIHJlc291cmNlcwpkaWZmIC0tZ2l0IGEvU291cmNlL1RoaXJk UGFydHkvQU5HTEUvc3JjL2xpYkFOR0xFL3JlbmRlcmVyL2RyaXZlcl91dGlscy5jcHAgYi9Tb3Vy Y2UvVGhpcmRQYXJ0eS9BTkdMRS9zcmMvbGliQU5HTEUvcmVuZGVyZXIvZHJpdmVyX3V0aWxzLmNw cAppbmRleCBkYWI4ODY4ZTllM2NmYzBmM2JhNzI4NmJkMDYzNjRmYTdiMGIzYzU1Li5iZDk3NTNh MTM4MTI3ODM0NGUyOWYyOTg3ZjliYzM5MWQzZTI4NGI0IDEwMDY0NAotLS0gYS9Tb3VyY2UvVGhp cmRQYXJ0eS9BTkdMRS9zcmMvbGliQU5HTEUvcmVuZGVyZXIvZHJpdmVyX3V0aWxzLmNwcAorKysg Yi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9zcmMvbGliQU5HTEUvcmVuZGVyZXIvZHJpdmVyX3V0 aWxzLmNwcApAQCAtMTQ2LDYgKzE0Niw4IEBAIGNvbnN0IGNoYXIgKkdldFZlbmRvclN0cmluZyh1 aW50MzJfdCB2ZW5kb3JJZCkKICAgICAgICAgICAgIHJldHVybiAiQVJNIjsKICAgICAgICAgY2Fz ZSBWRU5ET1JfSURfQVBQTEU6CiAgICAgICAgICAgICByZXR1cm4gIkFwcGxlIjsKKyAgICAgICAg Y2FzZSBWRU5ET1JfSURfTUlDUk9TT0ZUOgorICAgICAgICAgICAgcmV0dXJuICJNaWNyb3NvZnQi OwogICAgICAgICBjYXNlIFZFTkRPUl9JRF9CUk9BRENPTToKICAgICAgICAgICAgIHJldHVybiAi QnJvYWRjb20iOwogICAgICAgICBjYXNlIFZFTkRPUl9JRF9HT09HTEU6CkBAIC0xNjAsNiArMTYy LDEyIEBAIGNvbnN0IGNoYXIgKkdldFZlbmRvclN0cmluZyh1aW50MzJfdCB2ZW5kb3JJZCkKICAg ICAgICAgICAgIHJldHVybiAiSW1hZ2luYXRpb24gVGVjaG5vbG9naWVzIjsKICAgICAgICAgY2Fz ZSBWRU5ET1JfSURfUVVBTENPTU06CiAgICAgICAgICAgICByZXR1cm4gIlF1YWxjb21tIjsKKyAg ICAgICAgY2FzZSBWRU5ET1JfSURfU0FNU1VORzoKKyAgICAgICAgICAgIHJldHVybiAiU2Ftc3Vu ZyI7CisgICAgICAgIGNhc2UgVkVORE9SX0lEX1ZNV0FSRToKKyAgICAgICAgICAgIHJldHVybiAi Vk13YXJlIjsKKyAgICAgICAgY2FzZSBWRU5ET1JfSURfVklWQU5URToKKyAgICAgICAgICAgIHJl dHVybiAiVml2YW50ZSI7CiAgICAgICAgIGNhc2UgMHhiYTVlYmExMTogIC8vIE1vY2sgdmVuZG9y IElEIHVzZWQgZm9yIHRlc3RzLgogICAgICAgICAgICAgcmV0dXJuICJUZXN0IjsKICAgICAgICAg Y2FzZSAwOgpkaWZmIC0tZ2l0IGEvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvc3JjL2xpYkFOR0xF L3JlbmRlcmVyL2RyaXZlcl91dGlscy5oIGIvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvc3JjL2xp YkFOR0xFL3JlbmRlcmVyL2RyaXZlcl91dGlscy5oCmluZGV4IDM4MmE4YmVjYTY2Y2YyYWFhNzcx ZDJlN2FmMjZmNmI1OGI5Nzk4Y2YuLjQwNjI5ZTVkMzQ3MTc1NDEzMjQwOTk0YjNjZDM1ZDU1ZWZj YmM5YWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL3NyYy9saWJBTkdMRS9y ZW5kZXJlci9kcml2ZXJfdXRpbHMuaAorKysgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9zcmMv bGliQU5HTEUvcmVuZGVyZXIvZHJpdmVyX3V0aWxzLmgKQEAgLTIxLDYgKzIxLDcgQEAgZW51bSBW ZW5kb3JJRCA6IHVpbnQzMl90CiAgICAgVkVORE9SX0lEX0FNRCAgICAgPSAweDEwMDIsCiAgICAg VkVORE9SX0lEX0FQUExFICAgPSAweDEwNkIsCiAgICAgVkVORE9SX0lEX0FSTSAgICAgPSAweDEz QjUsCisgICAgVkVORE9SX0lEX01JQ1JPU09GVCA9IDB4MTQxNCwKICAgICAvLyBCcm9hZGNvbSBk ZXZpY2VzIHdvbid0IHVzZSBQQ0ksIGJ1dCB0aGlzIGlzIHRoZWlyIFZ1bGthbiB2ZW5kb3IgaWQu CiAgICAgVkVORE9SX0lEX0JST0FEQ09NID0gMHgxNEU0LAogICAgIFZFTkRPUl9JRF9HT09HTEUg ICA9IDB4MUFFMCwK