234356 2021-12-15 11:21:37 -0800 REGRESSION (r287068): [macOS arm64] TestWebKitAPI.GraphicsContextGLCocoaTest.UnrecycledDisplayBuffersNoLeaks is failing 2021-12-17 16:36:47 -0800 1 1 1 Unclassified WebKit ANGLE WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=234391 InRadar P2 Normal --- 233328 234317 1 ryanhaddad kkinnunen dino ews-watchlist johncunningham kbr kkinnunen koivisto kondapallykalyan kpiddington webkit-bot-watchers-bugzilla webkit-bug-importer oldest_to_newest 1824440 0 ryanhaddad 2021-12-15 11:21:37 -0800 TestWebKitAPI.GraphicsContextGLCocoaTest.UnrecycledDisplayBuffersNoLeaks is failing on arm64 macOS bots after https://trac.webkit.org/changeset/287068/webkit, x86 bots are not affected. TestWebKitAPI.GraphicsContextGLCocoaTest.UnrecycledDisplayBuffersNoLeaks /Volumes/Data/worker/monterey-release/build/Tools/TestWebKitAPI/Tests/WebCore/cocoa/TestGraphicsContextGLCocoa.mm:242 Value of: memoryFootprintChangedBy(lastFootprint, footprintChange, footprintError) Actual: false (Footprint changed by 827590144. Expected at most 0+-157286400) Expected: true https://results.webkit.org/?suite=api-tests&test=TestWebKitAPI.GraphicsContextGLCocoaTest.UnrecycledDisplayBuffersNoLeaks 1824441 1 webkit-bug-importer 2021-12-15 11:21:49 -0800 <rdar://problem/86533892> 1824475 2 kbr 2021-12-15 12:00:22 -0800 To be clear: that commit was the ANGLE roll to 2021-12-14 in Bug 234317. We'd strongly prefer to not revert that roll. Is there any indication what might have caused this? 1824495 3 ryanhaddad 2021-12-15 12:41:28 -0800 (In reply to Kenneth Russell from comment #2) > To be clear: that commit was the ANGLE roll to 2021-12-14 in Bug 234317. > > We'd strongly prefer to not revert that roll. Is there any indication what > might have caused this? Kyle is investigating. 1824497 4 kkinnunen 2021-12-15 12:43:02 -0800 I cannot attend to it until tomorrow. If it's a problem, naming it DISABLED_Unrecycled.. would skip it temporarily 1824727 5 447348 kkinnunen 2021-12-16 05:37:51 -0800 Created attachment 447348 Patch 1824728 6 ews-watchlist 2021-12-16 05:39:14 -0800 Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE 1824886 7 447348 kpiddington 2021-12-16 14:50:54 -0800 Comment on attachment 447348 Patch LGTM, great catch. 1824942 8 kbr 2021-12-16 18:38:50 -0800 Amazing work Kimmo tracking this down! r+ from me as well. 1824943 9 kbr 2021-12-16 18:39:13 -0800 Filed https://bugs.chromium.org/p/angleproject/issues/detail?id=6829 about upstreaming this to ANGLE. I'll help with that. 1825036 10 ews-feeder 2021-12-17 03:18:13 -0800 kpiddington@apple.com does not have reviewer permissions according to https://raw.githubusercontent.com/WebKit/WebKit/main/metadata/contributors.json. Rejecting attachment 447348 from commit queue. 1825037 11 447348 koivisto 2021-12-17 03:21:06 -0800 Comment on attachment 447348 Patch rs=me, actual review by Kyle Piddington 1825041 12 ews-feeder 2021-12-17 04:00:36 -0800 Committed r287178 (245347@main): <https://commits.webkit.org/245347@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 447348. 1825254 13 kbr 2021-12-17 16:36:47 -0800 For bookkeeping purposes, the new test was added under Bug 233328. 447348 2021-12-16 05:37:51 -0800 2021-12-17 04:00:38 -0800 Patch bug-234356-20211216153749.patch text/plain 4240 kkinnunen U3VidmVyc2lvbiBSZXZpc2lvbjogMjg3MDk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9BTkdMRS9DaGFuZ2VMb2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cKaW5k ZXggNTViNjIyOGMyODlkNTA5M2VmM2IzMmU2MjJjOWZiMmUyMjA4NGNkMS4uNmE3NjcwN2VjZmM1 MDBhN2I1YzcwODdiY2M5NzRkNWZkYTZmMzJjMCAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFy dHkvQU5HTEUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDIyIEBACisyMDIxLTEyLTE2ICBLaW1tbyBLaW5udW5lbiAgPGtraW5udW5l bkBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTiAocjI4NzA2OCk6IFttYWNPUyBhcm02 NF0gVGVzdFdlYktpdEFQSS5HcmFwaGljc0NvbnRleHRHTENvY29hVGVzdC5VbnJlY3ljbGVkRGlz cGxheUJ1ZmZlcnNOb0xlYWtzIGlzIGZhaWxpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNDM1NgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vODY1 MzM4OTI+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg QXZvaWQgbGVha2luZyBNVExUZXh0dXJlIGluc3RhbmNlcyBmb3IgcmVuZGVyIHRhcmdldHMuIExl YWsgd291bGQgaGFwcGVuIHRocm91Z2gKKyAgICAgICAgdGVtcG9yYXJ5IHJlbmRlciBwYXNzIGRl c2NyaXB0b3IgdGhhdCB3b3VsZCByZWYgdGhlIHJlbmRlciB0YXJnZXQgdGV4dHVyZS4KKyAgICAg ICAgVGhlIGRlc2NyaXB0b3Igd2FzIGNyZWF0ZWQgd2l0aG91dCBhdXRvcmVsZWFzZXBvb2wgaW4g Y2FsbCBzdGFjay4KKyAgICAgICAgQWxzbyBmaXhlcyB0aGUgZXJyb3Igc3RyaW5nIGxlYWtzLgor CisgICAgICAgIFVucmVjeWNsZWREaXNwbGF5QnVmZmVyc05vTGVha3Mgd291bGQgcmVwb3J0IGxl YWtzIG9mIGlvc3VyZmFjZS1iYWNrZWQKKyAgICAgICAgR3JhcGhpY3NDb250ZXh0R0wgZGVmYXVs dCBmcmFtZWJ1ZmZlciBib3VuZCB0ZXh0dXJlcyBpZiBnbENsZWFyIHdhcyBjYWxsZWQuCisKKyAg ICAgICAgKiBzcmMvbGliQU5HTEUvcmVuZGVyZXIvbWV0YWwvQ29udGV4dE10bC5tbToKKyAgICAg ICAgKHJ4OjpDb250ZXh0TXRsOjpnZXRSZW5kZXJQYXNzQ29tbWFuZEVuY29kZXIpOgorCiAyMDIx LTEyLTE1ICBEZWFuIEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KIAogICAgICAgICBbQU5HTEVd IGNsYW5nIHdpdGggLVd1bmtub3duLXdhcm5pbmctb3B0aW9uIHdpbGwgZmFpbCBvbiAtV3dlYWst dGVtcGxhdGUtdnRhYmxlcwpkaWZmIC0tZ2l0IGEvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvc3Jj L2xpYkFOR0xFL3JlbmRlcmVyL21ldGFsL0NvbnRleHRNdGwubW0gYi9Tb3VyY2UvVGhpcmRQYXJ0 eS9BTkdMRS9zcmMvbGliQU5HTEUvcmVuZGVyZXIvbWV0YWwvQ29udGV4dE10bC5tbQppbmRleCAz OWU1Y2Q5NzQxNGRjNTZhNDhlZDYwYThlMzU5NmE3YjhhZWVmYTQzLi41M2JlYjZhYTUyNzhmMWE3 NWFkMGRkNTQ4YTRiZjkwZWRjNDcwNzg0IDEwMDY0NAotLS0gYS9Tb3VyY2UvVGhpcmRQYXJ0eS9B TkdMRS9zcmMvbGliQU5HTEUvcmVuZGVyZXIvbWV0YWwvQ29udGV4dE10bC5tbQorKysgYi9Tb3Vy Y2UvVGhpcmRQYXJ0eS9BTkdMRS9zcmMvbGliQU5HTEUvcmVuZGVyZXIvbWV0YWwvQ29udGV4dE10 bC5tbQpAQCAtMTU4NiwyMyArMTU4NiwyNiBAQCBtdGw6OlJlbmRlckNvbW1hbmRFbmNvZGVyICpD b250ZXh0TXRsOjpnZXRSZW5kZXJQYXNzQ29tbWFuZEVuY29kZXIoY29uc3QgbXRsOjpSZQogICAg IGNvbnN0IG10bDo6Q29udGV4dERldmljZSAmbWV0YWxEZXZpY2UgPSBnZXRNZXRhbERldmljZSgp OwogICAgIGlmIChtdGw6OkRldmljZUhhc01heGltdW1SZW5kZXJUYXJnZXRTaXplKG1ldGFsRGV2 aWNlKSkKICAgICB7Ci0gICAgICAgIE1UTFJlbmRlclBhc3NEZXNjcmlwdG9yICpvYmpDRGVzYyA9 IFtNVExSZW5kZXJQYXNzRGVzY3JpcHRvciByZW5kZXJQYXNzRGVzY3JpcHRvcl07Ci0gICAgICAg IGRlc2MuY29udmVydFRvTWV0YWxEZXNjKG9iakNEZXNjKTsKLSAgICAgICAgTlNVSW50ZWdlciBt YXhTaXplID0gbXRsOjpHZXRNYXhSZW5kZXJUYXJnZXRTaXplRm9yRGV2aWNlSW5CeXRlcyhtZXRh bERldmljZSk7Ci0gICAgICAgIE5TVUludGVnZXIgcmVuZGVyVGFyZ2V0U2l6ZSA9Ci0gICAgICAg ICAgICBDb21wdXRlVG90YWxTaXplVXNlZEZvck1UTFJlbmRlclBhc3NEZXNjcmlwdG9yKG9iakNE ZXNjLCB0aGlzLCBtZXRhbERldmljZSk7Ci0gICAgICAgIGlmIChyZW5kZXJUYXJnZXRTaXplID4g bWF4U2l6ZSkKKyAgICAgICAgQU5HTEVfTVRMX09CSkNfU0NPUEUKICAgICAgICAgeworICAgICAg ICAgICAgTVRMUmVuZGVyUGFzc0Rlc2NyaXB0b3IgKm9iakNEZXNjID0gW01UTFJlbmRlclBhc3NE ZXNjcmlwdG9yIHJlbmRlclBhc3NEZXNjcmlwdG9yXTsKKyAgICAgICAgICAgIGRlc2MuY29udmVy dFRvTWV0YWxEZXNjKG9iakNEZXNjKTsKKyAgICAgICAgICAgIE5TVUludGVnZXIgbWF4U2l6ZSA9 IG10bDo6R2V0TWF4UmVuZGVyVGFyZ2V0U2l6ZUZvckRldmljZUluQnl0ZXMobWV0YWxEZXZpY2Up OworICAgICAgICAgICAgTlNVSW50ZWdlciByZW5kZXJUYXJnZXRTaXplID0KKyAgICAgICAgICAg ICAgICBDb21wdXRlVG90YWxTaXplVXNlZEZvck1UTFJlbmRlclBhc3NEZXNjcmlwdG9yKG9iakNE ZXNjLCB0aGlzLCBtZXRhbERldmljZSk7CisgICAgICAgICAgICBpZiAocmVuZGVyVGFyZ2V0U2l6 ZSA+IG1heFNpemUpCisgICAgICAgICAgICB7CiAKLSAgICAgICAgICAgIE5TU3RyaW5nICplcnJv clN0cmluZyA9Ci0gICAgICAgICAgICAgICAgW05TU3RyaW5nIHN0cmluZ1dpdGhGb3JtYXQ6QCJU aGlzIHNldCBvZiByZW5kZXIgdGFyZ2V0cyByZXF1aXJlcyAlbHUgYnl0ZXMgb2YgIgotICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIEAicGl4ZWwgc3RvcmFnZS4gVGhp cyBkZXZpY2Ugc3VwcG9ydHMgJWx1IGJ5dGVzLiIsCi0gICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgKHVuc2lnbmVkIGxvbmcpcmVuZGVyVGFyZ2V0U2l6ZSwgKHVuc2ln bmVkIGxvbmcpbWF4U2l6ZV07Ci0gICAgICAgICAgICBOU0Vycm9yICplcnIgPSBbTlNFcnJvciBl cnJvcldpdGhEb21haW46QCJNVExWYWxpZGF0aW9uRXJyb3IiCi0gICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvZGU6LTEKLSAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICB1c2VySW5mbzpAe05TTG9jYWxpemVkRGVzY3JpcHRpb25L ZXkgOiBlcnJvclN0cmluZ31dOwotICAgICAgICAgICAgdGhpcy0+aGFuZGxlRXJyb3IoZXJyLCBf X0ZJTEVfXywgQU5HTEVfRlVOQ1RJT04sIF9fTElORV9fKTsKLSAgICAgICAgICAgIHJldHVybiBu aWw7CisgICAgICAgICAgICAgICAgTlNTdHJpbmcgKmVycm9yU3RyaW5nID0gW05TU3RyaW5nCisg ICAgICAgICAgICAgICAgICAgIHN0cmluZ1dpdGhGb3JtYXQ6QCJUaGlzIHNldCBvZiByZW5kZXIg dGFyZ2V0cyByZXF1aXJlcyAlbHUgYnl0ZXMgb2YgIgorICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIEAicGl4ZWwgc3RvcmFnZS4gVGhpcyBkZXZpY2Ugc3VwcG9ydHMgJWx1IGJ5 dGVzLiIsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKHVuc2lnbmVkIGxv bmcpcmVuZGVyVGFyZ2V0U2l6ZSwgKHVuc2lnbmVkIGxvbmcpbWF4U2l6ZV07CisgICAgICAgICAg ICAgICAgTlNFcnJvciAqZXJyICAgICAgICAgID0gW05TRXJyb3IgZXJyb3JXaXRoRG9tYWluOkAi TVRMVmFsaWRhdGlvbkVycm9yIgorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgY29kZTotMQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICB1c2VySW5mbzpAe05TTG9jYWxpemVkRGVzY3JpcHRpb25LZXkgOiBlcnJv clN0cmluZ31dOworICAgICAgICAgICAgICAgIHRoaXMtPmhhbmRsZUVycm9yKGVyciwgX19GSUxF X18sIEFOR0xFX0ZVTkNUSU9OLCBfX0xJTkVfXyk7CisgICAgICAgICAgICAgICAgcmV0dXJuIG5p bDsKKyAgICAgICAgICAgIH0KICAgICAgICAgfQogICAgIH0KICAgICByZXR1cm4gJm1SZW5kZXJF bmNvZGVyLnJlc3RhcnQoZGVzYyk7Cg==