234355 2021-12-15 10:59:16 -0800 Clear AXObjectCache::m_notificationsToPost after moving in notificationPostTimerFired. 2022-01-06 06:41:27 -0800 1 1 1 Unclassified WebKit Accessibility WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 andresg_22 andresg_22 aboxhall andresg_22 apinheiro cfleizach darin dmazzoni ews-watchlist jcraig jdiggs samuel_white webkit-bug-importer oldest_to_newest 1824433 0 andresg_22 2021-12-15 10:59:16 -0800 Clear AXObjectCache::m_notificationsToPost after moving in notificationPostTimerFired. 1824434 1 webkit-bug-importer 2021-12-15 10:59:29 -0800 <rdar://problem/86532703> 1824437 2 447261 andresg_22 2021-12-15 11:06:36 -0800 Created attachment 447261 Patch 1824444 3 447261 cfleizach 2021-12-15 11:34:50 -0800 Comment on attachment 447261 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=447261&action=review > Source/WebCore/ChangeLog:10 > + extra new line 1824655 4 447316 andresg_22 2021-12-15 19:25:42 -0800 Created attachment 447316 Patch 1824656 5 andresg_22 2021-12-15 19:28:19 -0800 (In reply to chris fleizach from comment #3) > Comment on attachment 447261 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=447261&action=review > > > Source/WebCore/ChangeLog:10 > > + > > extra new line Fixed. Also found another instance of this problem with m_passwordNotificationsToPost. 1824777 6 ews-feeder 2021-12-16 09:01:08 -0800 Committed r287139 (245323@main): <https://commits.webkit.org/245323@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 447316. 1824864 7 447316 darin 2021-12-16 13:26:22 -0800 Comment on attachment 447316 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=447316&action=review > Source/WebCore/accessibility/AXObjectCache.cpp:1085 > auto notifications = WTFMove(m_notificationsToPost); > + m_notificationsToPost.clear(); The best idiom for this sort of thing is: auto notifications = std::exchange(m_notificationsToPost, { }); 1828598 8 andresg_22 2022-01-06 06:41:27 -0800 (In reply to Darin Adler from comment #7) > Comment on attachment 447316 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=447316&action=review > > > Source/WebCore/accessibility/AXObjectCache.cpp:1085 > > auto notifications = WTFMove(m_notificationsToPost); > > + m_notificationsToPost.clear(); > > The best idiom for this sort of thing is: > > auto notifications = std::exchange(m_notificationsToPost, { }); Thanks, corrected in https://bugs.webkit.org/show_bug.cgi?id=234919. 447261 2021-12-15 11:06:36 -0800 2021-12-15 19:25:38 -0800 Patch bug-234355-20211215140635.patch text/plain 1849 andresg_22 U3VidmVyc2lvbiBSZXZpc2lvbjogMjg2ODQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzBjOTg2ZDgyNjE5Y2I4 MjlkNmUyYjY4NTI4ZWZkZWY5YTliZjZhYi4uMzBhOWE5Mjc2YjNhMmIyZDYzMTVhZjk1YWZkMWU5 MGU1NzM1ZTU1OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDIxLTEyLTE1ICBBbmRy ZXMgR29uemFsZXogIDxhbmRyZXNnXzIyQGFwcGxlLmNvbT4KKworICAgICAgICBDbGVhciBBWE9i amVjdENhY2hlOjptX25vdGlmaWNhdGlvbnNUb1Bvc3QgYWZ0ZXIgbW92aW5nIGluIG5vdGlmaWNh dGlvblBvc3RUaW1lckZpcmVkLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjM0MzU1CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS84NjUzMjcwMz4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDb3ZlcmVkIGJ5 IGV4aXN0aW5nIHRlc3RzLgorCisKKyAgICAgICAgVGhpcyBtZW1lYmVyIHZhcmlhYmxlIG11c3Qg YmUgY2xlYXIgYWZ0ZXIgbW92aW5nIGl0cyByZXNvdXJjZXMgdG8gYQorICAgICAgICBsb2NhbCB2 YXJpYWJsZSwgb3RoZXJ3aXNlIHRoaXMgbWF5IGNhdXNlIHVuZGVmaW5lZCBiZWhhdmlvci4KKwor ICAgICAgICAqIGFjY2Vzc2liaWxpdHkvQVhPYmplY3RDYWNoZS5jcHA6CisgICAgICAgIChXZWJD b3JlOjpBWE9iamVjdENhY2hlOjpub3RpZmljYXRpb25Qb3N0VGltZXJGaXJlZCk6CisKIDIwMjEt MTItMTAgIEFsYW4gQnVqdGFzICA8emFsYW5AYXBwbGUuY29tPgogCiAgICAgICAgIFtMRkNdW0lG Q10gRW5hYmxlIGJpZGkgaGFuZGxpbmcgZm9yIGNvbnRlbnQgd2l0aCBpbmxpbmUgYm94ZXMKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQVhPYmplY3RDYWNoZS5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FYT2JqZWN0Q2FjaGUuY3BwCmluZGV4IDNi ZjM4ODNkZDZhNjBkZjk1YWY4ZGQ3YzY4Yzk2NGNlMzVmNGY2MzQuLjY2OGFiYWExOGVkMTg5OWIx YTNmMTg2OWFhOGY3OWM3ZmQwMDc0ZDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vz c2liaWxpdHkvQVhPYmplY3RDYWNoZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJp bGl0eS9BWE9iamVjdENhY2hlLmNwcApAQCAtMTA4Miw2ICsxMDgyLDcgQEAgdm9pZCBBWE9iamVj dENhY2hlOjpub3RpZmljYXRpb25Qb3N0VGltZXJGaXJlZCgpCiAgICAgLy8gSW4gdGVzdHMsIHBv c3Rpbmcgbm90aWZpY2F0aW9ucyBoYXMgYSB0ZW5kZW5jeSB0byBpbW1lZGlhdGVseSBxdWV1ZSB1 cCBvdGhlciBub3RpZmljYXRpb25zLCB3aGljaCBjYW4gbGVhZCB0byB1bmV4cGVjdGVkIGJlaGF2 aW9yCiAgICAgLy8gd2hlbiB0aGUgbm90aWZpY2F0aW9uIGxpc3QgaXMgY2xlYXJlZCBhdCB0aGUg ZW5kLiBJbnN0ZWFkIGNvcHkgdGhpcyBsaXN0IGF0IHRoZSBzdGFydC4KICAgICBhdXRvIG5vdGlm aWNhdGlvbnMgPSBXVEZNb3ZlKG1fbm90aWZpY2F0aW9uc1RvUG9zdCk7CisgICAgbV9ub3RpZmlj YXRpb25zVG9Qb3N0LmNsZWFyKCk7CiAKICAgICAvLyBGaWx0ZXIgb3V0IHRoZSBub3RpZmljYXRp b25zIHRoYXQgYXJlIG5vdCBnb2luZyB0byBiZSBwb3N0ZWQgdG8gcGxhdGZvcm0gY2xpZW50cy4K ICAgICBWZWN0b3I8c3RkOjpwYWlyPFJlZlB0cjxBWENvcmVPYmplY3Q+LCBBWE5vdGlmaWNhdGlv bj4+IG5vdGlmaWNhdGlvbnNUb1Bvc3Q7Cg== 447316 2021-12-15 19:25:42 -0800 2021-12-16 09:01:09 -0800 Patch bug-234355-20211215222540.patch text/plain 2567 andresg_22 U3VidmVyc2lvbiBSZXZpc2lvbjogMjg2ODQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzBjOTg2ZDgyNjE5Y2I4 MjlkNmUyYjY4NTI4ZWZkZWY5YTliZjZhYi4uMTRmYWFiYjU3ODY2OTU2ZDFkM2E0NTM4ZDU4NDli YWY1YjEwY2VhMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDIxLTEyLTE1ICBBbmRy ZXMgR29uemFsZXogIDxhbmRyZXNnXzIyQGFwcGxlLmNvbT4KKworICAgICAgICBDbGVhciBBWE9i amVjdENhY2hlOjptX25vdGlmaWNhdGlvbnNUb1Bvc3QgYWZ0ZXIgbW92aW5nIGluIG5vdGlmaWNh dGlvblBvc3RUaW1lckZpcmVkLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjM0MzU1CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS84NjUzMjcwMz4KKwor ICAgICAgICBSZXZpZXdlZCBieSBDaHJpcyBGbGVpemFjaC4KKworICAgICAgICBDb3ZlcmVkIGJ5 IGV4aXN0aW5nIHRlc3RzLgorCisgICAgICAgIFRoaXMgbWVtZWJlciB2YXJpYWJsZSBtdXN0IGJl IGNsZWFyIGFmdGVyIG1vdmluZyBpdHMgcmVzb3VyY2VzIHRvIGEKKyAgICAgICAgbG9jYWwgdmFy aWFibGUsIG90aGVyd2lzZSB0aGlzIG1heSBjYXVzZSB1bmRlZmluZWQgYmVoYXZpb3IuCisKKyAg ICAgICAgKiBhY2Nlc3NpYmlsaXR5L0FYT2JqZWN0Q2FjaGUuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6QVhPYmplY3RDYWNoZTo6bm90aWZpY2F0aW9uUG9zdFRpbWVyRmlyZWQpOgorICAgICAgICAo V2ViQ29yZTo6QVhPYmplY3RDYWNoZTo6cGFzc3dvcmROb3RpZmljYXRpb25Qb3N0VGltZXJGaXJl ZCk6CisgICAgICAgIFNhbWUgcHJvYmxlbSBoZXJlIHdpdGggbV9wYXNzd29yZE5vdGlmaWNhdGlv bnNUb1Bvc3QuCisKIDIwMjEtMTItMTAgIEFsYW4gQnVqdGFzICA8emFsYW5AYXBwbGUuY29tPgog CiAgICAgICAgIFtMRkNdW0lGQ10gRW5hYmxlIGJpZGkgaGFuZGxpbmcgZm9yIGNvbnRlbnQgd2l0 aCBpbmxpbmUgYm94ZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkv QVhPYmplY3RDYWNoZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FYT2JqZWN0 Q2FjaGUuY3BwCmluZGV4IDNiZjM4ODNkZDZhNjBkZjk1YWY4ZGQ3YzY4Yzk2NGNlMzVmNGY2MzQu LmFiNzhjYjk4ZTc2YjUxMmM1MzAwNGM4OWQyZWI2NzkzM2ZkYjg2MTUgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQVhPYmplY3RDYWNoZS5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BWE9iamVjdENhY2hlLmNwcApAQCAtMTA4Miw2ICsxMDgy LDcgQEAgdm9pZCBBWE9iamVjdENhY2hlOjpub3RpZmljYXRpb25Qb3N0VGltZXJGaXJlZCgpCiAg ICAgLy8gSW4gdGVzdHMsIHBvc3Rpbmcgbm90aWZpY2F0aW9ucyBoYXMgYSB0ZW5kZW5jeSB0byBp bW1lZGlhdGVseSBxdWV1ZSB1cCBvdGhlciBub3RpZmljYXRpb25zLCB3aGljaCBjYW4gbGVhZCB0 byB1bmV4cGVjdGVkIGJlaGF2aW9yCiAgICAgLy8gd2hlbiB0aGUgbm90aWZpY2F0aW9uIGxpc3Qg aXMgY2xlYXJlZCBhdCB0aGUgZW5kLiBJbnN0ZWFkIGNvcHkgdGhpcyBsaXN0IGF0IHRoZSBzdGFy dC4KICAgICBhdXRvIG5vdGlmaWNhdGlvbnMgPSBXVEZNb3ZlKG1fbm90aWZpY2F0aW9uc1RvUG9z dCk7CisgICAgbV9ub3RpZmljYXRpb25zVG9Qb3N0LmNsZWFyKCk7CiAKICAgICAvLyBGaWx0ZXIg b3V0IHRoZSBub3RpZmljYXRpb25zIHRoYXQgYXJlIG5vdCBnb2luZyB0byBiZSBwb3N0ZWQgdG8g cGxhdGZvcm0gY2xpZW50cy4KICAgICBWZWN0b3I8c3RkOjpwYWlyPFJlZlB0cjxBWENvcmVPYmpl Y3Q+LCBBWE5vdGlmaWNhdGlvbj4+IG5vdGlmaWNhdGlvbnNUb1Bvc3Q7CkBAIC0xMTMzLDYgKzEx MzQsNyBAQCB2b2lkIEFYT2JqZWN0Q2FjaGU6OnBhc3N3b3JkTm90aWZpY2F0aW9uUG9zdFRpbWVy RmlyZWQoKQogICAgIC8vIEluIHRlc3RzLCBwb3N0aW5nIG5vdGlmaWNhdGlvbnMgaGFzIGEgdGVu ZGVuY3kgdG8gaW1tZWRpYXRlbHkgcXVldWUgdXAgb3RoZXIgbm90aWZpY2F0aW9ucywgd2hpY2gg Y2FuIGxlYWQgdG8gdW5leHBlY3RlZCBiZWhhdmlvcgogICAgIC8vIHdoZW4gdGhlIG5vdGlmaWNh dGlvbiBsaXN0IGlzIGNsZWFyZWQgYXQgdGhlIGVuZC4gSW5zdGVhZCBjb3B5IHRoaXMgbGlzdCBh dCB0aGUgc3RhcnQuCiAgICAgYXV0byBub3RpZmljYXRpb25zID0gV1RGTW92ZShtX3Bhc3N3b3Jk Tm90aWZpY2F0aW9uc1RvUG9zdCk7CisgICAgbV9wYXNzd29yZE5vdGlmaWNhdGlvbnNUb1Bvc3Qu Y2xlYXIoKTsKIAogICAgIGZvciAoYXV0byYgbm90aWZpY2F0aW9uIDogbm90aWZpY2F0aW9ucykK ICAgICAgICAgcG9zdFRleHRTdGF0ZUNoYW5nZVBsYXRmb3JtTm90aWZpY2F0aW9uKG5vdGlmaWNh dGlvbi5nZXQoKSwgQVhUZXh0RWRpdFR5cGVJbnNlcnQsICIgIiwgVmlzaWJsZVBvc2l0aW9uKCkp Owo=