234339 2021-12-15 02:04:01 -0800 Make use of PLATFORM(COCOA) in MediaRecorder WebPreference 2021-12-15 08:24:35 -0800 1 1 1 Unclassified WebKit WebRTC WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=231085 InRadar P2 Normal --- 1 youennf youennf cdumez eric.carlson webkit-bug-importer youennf oldest_to_newest 1824289 0 youennf 2021-12-15 02:04:01 -0800 Make use of HAVE(AVASSETWRITERDELEGATE_API) in MediaRecorder WebPreference 1824291 1 youennf 2021-12-15 02:15:33 -0800 <rdar://85432071> 1824292 2 447211 youennf 2021-12-15 02:16:08 -0800 Created attachment 447211 Patch 1824293 3 youennf 2021-12-15 02:17:09 -0800 It is very easy to fall into that disable-feature trap. It seems we should be able to catch these bugs earlier though. 1824326 4 447211 eric.carlson 2021-12-15 05:26:51 -0800 Comment on attachment 447211 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=447211&action=review > Source/WTF/ChangeLog:11 > + Llet's guard MediaRecorder with PLATFORM(COCOA). s/Llet's/Let's/ 1824329 5 447226 youennf 2021-12-15 05:47:39 -0800 Created attachment 447226 Patch for landing 1824338 6 ews-feeder 2021-12-15 06:41:56 -0800 Committed r287072 (245267@main): <https://commits.webkit.org/245267@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 447226. 1824359 7 eric.carlson 2021-12-15 08:24:35 -0800 Caused by r283431 447211 2021-12-15 02:16:08 -0800 2021-12-15 05:47:34 -0800 Patch bug-234339-20211215111606.patch text/plain 1532 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjg2OTM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGVmMGE0OWJjN2U4NTIzYjQwZGVjOWUy MWJhZDllYTNhNzg5OTIxZGUuLmVlYzdmMzgzYWJiMmQxOTMzOWRlMzZlZWM5NGQxYWE3MTI3Yjc4 YzUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMjEtMTItMTUgIFlvdWVubiBGYWJsZXQgIDx5b3Vl bm5AYXBwbGUuY29tPgorCisgICAgICAgIE1ha2UgdXNlIG9mIFBMQVRGT1JNKENPQ09BKSBpbiBN ZWRpYVJlY29yZGVyIFdlYlByZWZlcmVuY2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTIzNDMzOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy9QcmVmZXJlbmNlcy9XZWJQcmVmZXJlbmNlc0V4 cGVyaW1lbnRhbC55YW1sOgorICAgICAgICBIQVZFKEFWQVNTRVRXUklURVJERUxFR0FURSkgaGFz IGJlZW4gcmVtb3ZlZCBmcm9tIFBsYXRmb3JtSGF2ZS5oIGdpdmVuIGl0IHdhcyB0cnVlIG9uIGFs bCBzdXBwb3J0ZWQgcGxhdGZvcm1zLgorICAgICAgICBCdXQgaXQgd2FzIHN0aWxsIHVzZWQgdG8g Z3VhcmQgTWVkaWFSZWNvcmRlciBwcmVmZXJlbmNlLCB0aHVzIE1lZGlhUmVjb3JkZXIgZ290IGRp c2FibGVkIGluYWR2ZXJ0ZW50bHkuCisgICAgICAgIExsZXQncyBndWFyZCBNZWRpYVJlY29yZGVy IHdpdGggUExBVEZPUk0oQ09DT0EpLgorCiAyMDIxLTEyLTExICBEb24gT2xtc3RlYWQgIDxkb24u b2xtc3RlYWRAc29ueS5jb20+CiAKICAgICAgICAgQWRkIGEgc3RkOjpudWxscHRyX3QgY29uc3Ry dWN0b3IgZm9yIFJlZlB0cgpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi9TY3JpcHRzL1ByZWZlcmVu Y2VzL1dlYlByZWZlcmVuY2VzRXhwZXJpbWVudGFsLnlhbWwgYi9Tb3VyY2UvV1RGL1NjcmlwdHMv UHJlZmVyZW5jZXMvV2ViUHJlZmVyZW5jZXNFeHBlcmltZW50YWwueWFtbAppbmRleCAwNDExMWJi NmFkYTI2OWQzNGFjYmYyMTZmMDJjYmE3MWNmNmZmYTMzLi44MmM3ZGJhNDBmNDYzYjc2ODRjZGI2 YWFhNmUxZjE3MmQwNGZjZDdiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL1NjcmlwdHMvUHJlZmVy ZW5jZXMvV2ViUHJlZmVyZW5jZXNFeHBlcmltZW50YWwueWFtbAorKysgYi9Tb3VyY2UvV1RGL1Nj cmlwdHMvUHJlZmVyZW5jZXMvV2ViUHJlZmVyZW5jZXNFeHBlcmltZW50YWwueWFtbApAQCAtODUx LDcgKzg1MSw3IEBAIE1lZGlhUmVjb3JkZXJFbmFibGVkOgogICAgIFdlYktpdExlZ2FjeToKICAg ICAgIGRlZmF1bHQ6IGZhbHNlCiAgICAgV2ViS2l0OgotICAgICAgIkhBVkUoQVZBU1NFVFdSSVRF UkRFTEVHQVRFKSI6IHRydWUKKyAgICAgICJQTEFURk9STShDT0NPQSkiOiB0cnVlCiAgICAgICBk ZWZhdWx0OiBmYWxzZQogICAgIFdlYkNvcmU6CiAgICAgICBkZWZhdWx0OiBmYWxzZQo= 447226 2021-12-15 05:47:39 -0800 2021-12-15 06:57:16 -0800 Patch for landing bug-234339-20211215144737.patch text/plain 1565 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjg3MDY5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGI1OTA1NDAyNGEwNzZjNGQ0ZWI4NzIw OTE5M2UwMjBlYzhkNGM0NzEuLjg3ODEzMDBkMDljOGFjZDdmMTg5MTc1NDIwZjExMzI4MmM3ODQz MzIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMjEtMTItMTUgIFlvdWVubiBGYWJsZXQgIDx5b3Vl bm5AYXBwbGUuY29tPgorCisgICAgICAgIE1ha2UgdXNlIG9mIFBMQVRGT1JNKENPQ09BKSBpbiBN ZWRpYVJlY29yZGVyIFdlYlByZWZlcmVuY2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTIzNDMzOQorCisgICAgICAgIFJldmlld2VkIGJ5IEVyaWMgQ2Fy bHNvbi4KKworICAgICAgICAqIFNjcmlwdHMvUHJlZmVyZW5jZXMvV2ViUHJlZmVyZW5jZXNFeHBl cmltZW50YWwueWFtbDoKKyAgICAgICAgSEFWRShBVkFTU0VUV1JJVEVSREVMRUdBVEUpIGhhcyBi ZWVuIHJlbW92ZWQgZnJvbSBQbGF0Zm9ybUhhdmUuaCBnaXZlbiBpdCB3YXMgdHJ1ZSBvbiBhbGwg c3VwcG9ydGVkIHBsYXRmb3Jtcy4KKyAgICAgICAgQnV0IGl0IHdhcyBzdGlsbCB1c2VkIHRvIGd1 YXJkIE1lZGlhUmVjb3JkZXIgcHJlZmVyZW5jZSwgdGh1cyBNZWRpYVJlY29yZGVyIGdvdCBkaXNh YmxlZCBpbmFkdmVydGVudGx5LgorICAgICAgICBMZXQncyBndWFyZCBNZWRpYVJlY29yZGVyIHdp dGggUExBVEZPUk0oQ09DT0EpLgorCiAyMDIxLTEyLTE0ICBBbGV4IENocmlzdGVuc2VuICA8YWNo cmlzdGVuc2VuQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmVtb3ZlIHByb3BlcnRpZXMgc2V0IGJ5 IE5TVVJMUHJvdG9jb2wgb24gTlNVUkxSZXF1ZXN0IGJlZm9yZSBzZXJpYWxpemluZwpkaWZmIC0t Z2l0IGEvU291cmNlL1dURi9TY3JpcHRzL1ByZWZlcmVuY2VzL1dlYlByZWZlcmVuY2VzRXhwZXJp bWVudGFsLnlhbWwgYi9Tb3VyY2UvV1RGL1NjcmlwdHMvUHJlZmVyZW5jZXMvV2ViUHJlZmVyZW5j ZXNFeHBlcmltZW50YWwueWFtbAppbmRleCBjMjJmOGMyMDg0Mjg0NGUzNDIyZTIwZmJmY2M2N2Ux MGI5ODI2MDYxLi5iNWU4ZDZlYWQyZGE2ODg4YjFmZDI1OTE5NDZiNDlmMTQxZTNjMmQ1IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV1RGL1NjcmlwdHMvUHJlZmVyZW5jZXMvV2ViUHJlZmVyZW5jZXNFeHBl cmltZW50YWwueWFtbAorKysgYi9Tb3VyY2UvV1RGL1NjcmlwdHMvUHJlZmVyZW5jZXMvV2ViUHJl ZmVyZW5jZXNFeHBlcmltZW50YWwueWFtbApAQCAtODUxLDcgKzg1MSw3IEBAIE1lZGlhUmVjb3Jk ZXJFbmFibGVkOgogICAgIFdlYktpdExlZ2FjeToKICAgICAgIGRlZmF1bHQ6IGZhbHNlCiAgICAg V2ViS2l0OgotICAgICAgIkhBVkUoQVZBU1NFVFdSSVRFUkRFTEVHQVRFKSI6IHRydWUKKyAgICAg ICJQTEFURk9STShDT0NPQSkiOiB0cnVlCiAgICAgICBkZWZhdWx0OiBmYWxzZQogICAgIFdlYkNv cmU6CiAgICAgICBkZWZhdWx0OiBmYWxzZQo=