234334 2021-12-14 19:56:11 -0800 AX: Move comment about accessibilityShouldUseUniqueId in WebAccessibilityObjectWrapperMac.mm to the right place 2021-12-15 13:28:13 -0800 1 1 1 Unclassified WebKit Accessibility WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 tyler_w tyler_w aboxhall andresg_22 apinheiro cfleizach dmazzoni ews-watchlist jcraig jdiggs samuel_white webkit-bug-importer oldest_to_newest 1824224 0 tyler_w 2021-12-14 19:56:11 -0800 WebAccessibilityObjectWrapperMac.mm has a long comment about accessibilityShouldUseUniqueId that is next to accessibilityIsIgnored, not accessibilityShouldUseUniqueId. 1824225 1 webkit-bug-importer 2021-12-14 19:56:22 -0800 <rdar://problem/86503027> 1824227 2 447195 tyler_w 2021-12-14 19:57:40 -0800 Created attachment 447195 Patch 1824353 3 447233 tyler_w 2021-12-15 08:08:56 -0800 Created attachment 447233 Patch 1824524 4 ews-feeder 2021-12-15 13:28:09 -0800 Committed r287104 (245293@main): <https://commits.webkit.org/245293@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 447233. 447195 2021-12-14 19:57:40 -0800 2021-12-15 08:08:53 -0800 Patch bug-234334-20211214215739.patch text/plain 3133 tyler_w U3VidmVyc2lvbiBSZXZpc2lvbjogMjg3MDYwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmI3OTRhOGMwYTUzMGVh MGUwNWJkODU0ZTk5ZmNhODQwNmYyMWYzYi4uNWY5MzRiZTE4MzE2Yjg2OGM0ZjY0ZDlkYzBlNWE5 OGJjN2ZjOTczNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIxLTEyLTE0ICBUeWxl ciBXaWxjb2NrICA8dHlsZXJfd0BhcHBsZS5jb20+CisKKyAgICAgICAgQVg6IE1vdmUgY29tbWVu dCBhYm91dCBhY2Nlc3NpYmlsaXR5U2hvdWxkVXNlVW5pcXVlSWQgaW4gV2ViQWNjZXNzaWJpbGl0 eU9iamVjdFdyYXBwZXJNYWMubW0gdG8gdGhlIHJpZ2h0IHBsYWNlCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzQzMzQKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMgKE9PUFMhKS4KKwor ICAgICAgICAqIGFjY2Vzc2liaWxpdHkvbWFjL1dlYkFjY2Vzc2liaWxpdHlPYmplY3RXcmFwcGVy TWFjLm1tOgorICAgICAgICBNb3ZlIGNvbW1lbnQgYWJvdXQgYWNjZXNzaWJpbGl0eVNob3VsZFVz ZVVuaXF1ZUlkIG5leHQgdG8gaXRzCisgICAgICAgIGRlZmludGlvbiByYXRoZXIgdGhhbiBpdHMg Y3VycmVudCBsb2NhdGlvbiBuZXh0IHRvCisgICAgICAgIGFjY2Vzc2liaWxpdHlJc0lnbm9yZWQu CisKIDIwMjEtMTItMTQgIEplYW4tWXZlcyBBdmVuYXJkICA8anlhQGFwcGxlLmNvbT4KIAogICAg ICAgICBTb3VyY2VCdWZmZXJQYXJzZXIgc2hvdWxkIGJlIHVzaW5nIGNvbnRpZ3VvdXMgU2hhcmVk QnVmZmVyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L21hYy9XZWJB Y2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlck1hYy5tbSBiL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2li aWxpdHkvbWFjL1dlYkFjY2Vzc2liaWxpdHlPYmplY3RXcmFwcGVyTWFjLm1tCmluZGV4IDE5M2Rm ZmRjZjYwMDBiZjFiNDVlMzkwZTJlYzQ0NzFmOTI5YjZlNjAuLmVmNmQ2ZWVjMDYwZjA0ODhlMGE0 NGIxMDZlMDhmNmQ5MTRmYmNkYmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2li aWxpdHkvbWFjL1dlYkFjY2Vzc2liaWxpdHlPYmplY3RXcmFwcGVyTWFjLm1tCisrKyBiL1NvdXJj ZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvbWFjL1dlYkFjY2Vzc2liaWxpdHlPYmplY3RXcmFwcGVy TWFjLm1tCkBAIC0zMDA5LDE1ICszMDA5LDYgQEAgQUxMT1dfREVQUkVDQVRFRF9JTVBMRU1FTlRB VElPTlNfRU5ECiAgICAgcmV0dXJuIE5POwogfQogCi0vLyBhY2Nlc3NpYmlsaXR5U2hvdWxkVXNl VW5pcXVlSWQgaXMgYW4gQXBwS2l0IG1ldGhvZCB3ZSBvdmVycmlkZSBzbyB0aGF0Ci0vLyBvYmpl Y3RzIHdpbGwgYmUgZ2l2ZW4gYSB1bmlxdWUgSUQsIGFuZCB0aGVyZWZvcmUgYWxsb3cgQXBwS2l0 IHRvIGtub3cgd2hlbiB0aGV5Ci0vLyBiZWNvbWUgb2Jzb2xldGUgKGUuZy4gd2hlbiB0aGUgdXNl ciBuYXZpZ2F0ZXMgdG8gYSBuZXcgd2ViIHBhZ2UsIG1ha2luZyB0aGlzIG9uZQotLy8gdW5yZW5k ZXJlZCBidXQgbm90IGRlYWxsb2NhdGVkIGJlY2F1c2UgaXQgaXMgaW4gdGhlIGJhY2svZm9yd2Fy ZCBjYWNoZSkuCi0vLyBJdCBpcyBpbXBvcnRhbnQgdG8gY2FsbCBOU0FjY2Vzc2liaWxpdHlVbnJl Z2lzdGVyVW5pcXVlSWRGb3JVSUVsZW1lbnQgaW4gdGhlCi0vLyBhcHByb3ByaWF0ZSBwbGFjZSAo ZS5nLiBkZWFsbG9jKSB0byByZW1vdmUgdGhlc2Ugbm9uLXJldGFpbmVkIHJlZmVyZW5jZXMgZnJv bQotLy8gQXBwS2l0J3MgaWQgbWFwcGluZyB0YWJsZXMuIFdlIGRvIHRoaXMgaW4gZGV0YWNoIGJ5 IGNhbGxpbmcgdW5yZWdpc3RlclVuaXF1ZUlkRm9yVUlFbGVtZW50LgotLy8KLS8vIFJlZ2lzdGVy aW5nIGFuIG9iamVjdCBpcyBhbHNvIHJlcXVpcmVkIGZvciBvYnNlcnZpbmcgbm90aWZpY2F0aW9u cy4gT25seSByZWdpc3RlcmVkIG9iamVjdHMgY2FuIGJlIG9ic2VydmVkLgogQUxMT1dfREVQUkVD QVRFRF9JTVBMRU1FTlRBVElPTlNfQkVHSU4KIC0gKEJPT0wpYWNjZXNzaWJpbGl0eUlzSWdub3Jl ZAogQUxMT1dfREVQUkVDQVRFRF9JTVBMRU1FTlRBVElPTlNfRU5ECkBAIC00MzMxLDYgKzQzMjIs MTUgQEAgQUxMT1dfREVQUkVDQVRFRF9JTVBMRU1FTlRBVElPTlNfRU5ECiAgICAgcmV0dXJuIFlF UzsKIH0KIAorLy8gYWNjZXNzaWJpbGl0eVNob3VsZFVzZVVuaXF1ZUlkIGlzIGFuIEFwcEtpdCBt ZXRob2Qgd2Ugb3ZlcnJpZGUgc28gdGhhdAorLy8gb2JqZWN0cyB3aWxsIGJlIGdpdmVuIGEgdW5p cXVlIElELCBhbmQgdGhlcmVmb3JlIGFsbG93IEFwcEtpdCB0byBrbm93IHdoZW4gdGhleQorLy8g YmVjb21lIG9ic29sZXRlIChlLmcuIHdoZW4gdGhlIHVzZXIgbmF2aWdhdGVzIHRvIGEgbmV3IHdl YiBwYWdlLCBtYWtpbmcgdGhpcyBvbmUKKy8vIHVucmVuZGVyZWQgYnV0IG5vdCBkZWFsbG9jYXRl ZCBiZWNhdXNlIGl0IGlzIGluIHRoZSBiYWNrL2ZvcndhcmQgY2FjaGUpLgorLy8gSXQgaXMgaW1w b3J0YW50IHRvIGNhbGwgTlNBY2Nlc3NpYmlsaXR5VW5yZWdpc3RlclVuaXF1ZUlkRm9yVUlFbGVt ZW50IGluIHRoZQorLy8gYXBwcm9wcmlhdGUgcGxhY2UgKGUuZy4gZGVhbGxvYykgdG8gcmVtb3Zl IHRoZXNlIG5vbi1yZXRhaW5lZCByZWZlcmVuY2VzIGZyb20KKy8vIEFwcEtpdCdzIGlkIG1hcHBp bmcgdGFibGVzLiBXZSBkbyB0aGlzIGluIGRldGFjaCBieSBjYWxsaW5nIHVucmVnaXN0ZXJVbmlx dWVJZEZvclVJRWxlbWVudC4KKy8vCisvLyBSZWdpc3RlcmluZyBhbiBvYmplY3QgaXMgYWxzbyBy ZXF1aXJlZCBmb3Igb2JzZXJ2aW5nIG5vdGlmaWNhdGlvbnMuIE9ubHkgcmVnaXN0ZXJlZCBvYmpl Y3RzIGNhbiBiZSBvYnNlcnZlZC4KIC0gKEJPT0wpYWNjZXNzaWJpbGl0eVNob3VsZFVzZVVuaXF1 ZUlkCiB7CiAgICAgLy8gQWxsIEFYIG9iamVjdCB3cmFwcGVycyBzaG91bGQgdXNlIHVuaXF1ZSBJ RCdzIGJlY2F1c2UgaXQncyBmYXN0ZXIgd2l0aGluIEFwcEtpdCB0byBsb29rIHRoZW0gdXAuCg== 447233 2021-12-15 08:08:56 -0800 2021-12-15 13:28:11 -0800 Patch bug-234334-20211215100855.patch text/plain 3100 tyler_w U3VidmVyc2lvbiBSZXZpc2lvbjogMjg3MDYwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmI3OTRhOGMwYTUzMGVh MGUwNWJkODU0ZTk5ZmNhODQwNmYyMWYzYi4uMTRlODA1MWYyNzAwMzhkN2NjYTIzYzFjMWJmOTI5 ZTIyZWFkZjRkYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIxLTEyLTE0ICBUeWxl ciBXaWxjb2NrICA8dHlsZXJfd0BhcHBsZS5jb20+CisKKyAgICAgICAgQVg6IE1vdmUgY29tbWVu dCBhYm91dCBhY2Nlc3NpYmlsaXR5U2hvdWxkVXNlVW5pcXVlSWQgaW4gV2ViQWNjZXNzaWJpbGl0 eU9iamVjdFdyYXBwZXJNYWMubW0gdG8gdGhlIHJpZ2h0IHBsYWNlCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzQzMzQKKworICAgICAgICBSZXZpZXdl ZCBieSBDaHJpcyBGbGVpemFjaC4KKworICAgICAgICAqIGFjY2Vzc2liaWxpdHkvbWFjL1dlYkFj Y2Vzc2liaWxpdHlPYmplY3RXcmFwcGVyTWFjLm1tOgorICAgICAgICBNb3ZlIGNvbW1lbnQgYWJv dXQgYWNjZXNzaWJpbGl0eVNob3VsZFVzZVVuaXF1ZUlkIG5leHQgdG8gaXRzCisgICAgICAgIGRl ZmludGlvbiByYXRoZXIgdGhhbiBpdHMgY3VycmVudCBsb2NhdGlvbiBuZXh0IHRvCisgICAgICAg IGFjY2Vzc2liaWxpdHlJc0lnbm9yZWQuCisKIDIwMjEtMTItMTQgIEplYW4tWXZlcyBBdmVuYXJk ICA8anlhQGFwcGxlLmNvbT4KIAogICAgICAgICBTb3VyY2VCdWZmZXJQYXJzZXIgc2hvdWxkIGJl IHVzaW5nIGNvbnRpZ3VvdXMgU2hhcmVkQnVmZmVyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9hY2Nlc3NpYmlsaXR5L21hYy9XZWJBY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlck1hYy5tbSBi L1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvbWFjL1dlYkFjY2Vzc2liaWxpdHlPYmplY3RX cmFwcGVyTWFjLm1tCmluZGV4IDE5M2RmZmRjZjYwMDBiZjFiNDVlMzkwZTJlYzQ0NzFmOTI5YjZl NjAuLmVmNmQ2ZWVjMDYwZjA0ODhlMGE0NGIxMDZlMDhmNmQ5MTRmYmNkYmMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvbWFjL1dlYkFjY2Vzc2liaWxpdHlPYmplY3RX cmFwcGVyTWFjLm1tCisrKyBiL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvbWFjL1dlYkFj Y2Vzc2liaWxpdHlPYmplY3RXcmFwcGVyTWFjLm1tCkBAIC0zMDA5LDE1ICszMDA5LDYgQEAgQUxM T1dfREVQUkVDQVRFRF9JTVBMRU1FTlRBVElPTlNfRU5ECiAgICAgcmV0dXJuIE5POwogfQogCi0v LyBhY2Nlc3NpYmlsaXR5U2hvdWxkVXNlVW5pcXVlSWQgaXMgYW4gQXBwS2l0IG1ldGhvZCB3ZSBv dmVycmlkZSBzbyB0aGF0Ci0vLyBvYmplY3RzIHdpbGwgYmUgZ2l2ZW4gYSB1bmlxdWUgSUQsIGFu ZCB0aGVyZWZvcmUgYWxsb3cgQXBwS2l0IHRvIGtub3cgd2hlbiB0aGV5Ci0vLyBiZWNvbWUgb2Jz b2xldGUgKGUuZy4gd2hlbiB0aGUgdXNlciBuYXZpZ2F0ZXMgdG8gYSBuZXcgd2ViIHBhZ2UsIG1h a2luZyB0aGlzIG9uZQotLy8gdW5yZW5kZXJlZCBidXQgbm90IGRlYWxsb2NhdGVkIGJlY2F1c2Ug aXQgaXMgaW4gdGhlIGJhY2svZm9yd2FyZCBjYWNoZSkuCi0vLyBJdCBpcyBpbXBvcnRhbnQgdG8g Y2FsbCBOU0FjY2Vzc2liaWxpdHlVbnJlZ2lzdGVyVW5pcXVlSWRGb3JVSUVsZW1lbnQgaW4gdGhl Ci0vLyBhcHByb3ByaWF0ZSBwbGFjZSAoZS5nLiBkZWFsbG9jKSB0byByZW1vdmUgdGhlc2Ugbm9u LXJldGFpbmVkIHJlZmVyZW5jZXMgZnJvbQotLy8gQXBwS2l0J3MgaWQgbWFwcGluZyB0YWJsZXMu IFdlIGRvIHRoaXMgaW4gZGV0YWNoIGJ5IGNhbGxpbmcgdW5yZWdpc3RlclVuaXF1ZUlkRm9yVUlF bGVtZW50LgotLy8KLS8vIFJlZ2lzdGVyaW5nIGFuIG9iamVjdCBpcyBhbHNvIHJlcXVpcmVkIGZv ciBvYnNlcnZpbmcgbm90aWZpY2F0aW9ucy4gT25seSByZWdpc3RlcmVkIG9iamVjdHMgY2FuIGJl IG9ic2VydmVkLgogQUxMT1dfREVQUkVDQVRFRF9JTVBMRU1FTlRBVElPTlNfQkVHSU4KIC0gKEJP T0wpYWNjZXNzaWJpbGl0eUlzSWdub3JlZAogQUxMT1dfREVQUkVDQVRFRF9JTVBMRU1FTlRBVElP TlNfRU5ECkBAIC00MzMxLDYgKzQzMjIsMTUgQEAgQUxMT1dfREVQUkVDQVRFRF9JTVBMRU1FTlRB VElPTlNfRU5ECiAgICAgcmV0dXJuIFlFUzsKIH0KIAorLy8gYWNjZXNzaWJpbGl0eVNob3VsZFVz ZVVuaXF1ZUlkIGlzIGFuIEFwcEtpdCBtZXRob2Qgd2Ugb3ZlcnJpZGUgc28gdGhhdAorLy8gb2Jq ZWN0cyB3aWxsIGJlIGdpdmVuIGEgdW5pcXVlIElELCBhbmQgdGhlcmVmb3JlIGFsbG93IEFwcEtp dCB0byBrbm93IHdoZW4gdGhleQorLy8gYmVjb21lIG9ic29sZXRlIChlLmcuIHdoZW4gdGhlIHVz ZXIgbmF2aWdhdGVzIHRvIGEgbmV3IHdlYiBwYWdlLCBtYWtpbmcgdGhpcyBvbmUKKy8vIHVucmVu ZGVyZWQgYnV0IG5vdCBkZWFsbG9jYXRlZCBiZWNhdXNlIGl0IGlzIGluIHRoZSBiYWNrL2Zvcndh cmQgY2FjaGUpLgorLy8gSXQgaXMgaW1wb3J0YW50IHRvIGNhbGwgTlNBY2Nlc3NpYmlsaXR5VW5y ZWdpc3RlclVuaXF1ZUlkRm9yVUlFbGVtZW50IGluIHRoZQorLy8gYXBwcm9wcmlhdGUgcGxhY2Ug KGUuZy4gZGVhbGxvYykgdG8gcmVtb3ZlIHRoZXNlIG5vbi1yZXRhaW5lZCByZWZlcmVuY2VzIGZy b20KKy8vIEFwcEtpdCdzIGlkIG1hcHBpbmcgdGFibGVzLiBXZSBkbyB0aGlzIGluIGRldGFjaCBi eSBjYWxsaW5nIHVucmVnaXN0ZXJVbmlxdWVJZEZvclVJRWxlbWVudC4KKy8vCisvLyBSZWdpc3Rl cmluZyBhbiBvYmplY3QgaXMgYWxzbyByZXF1aXJlZCBmb3Igb2JzZXJ2aW5nIG5vdGlmaWNhdGlv bnMuIE9ubHkgcmVnaXN0ZXJlZCBvYmplY3RzIGNhbiBiZSBvYnNlcnZlZC4KIC0gKEJPT0wpYWNj ZXNzaWJpbGl0eVNob3VsZFVzZVVuaXF1ZUlkCiB7CiAgICAgLy8gQWxsIEFYIG9iamVjdCB3cmFw cGVycyBzaG91bGQgdXNlIHVuaXF1ZSBJRCdzIGJlY2F1c2UgaXQncyBmYXN0ZXIgd2l0aGluIEFw cEtpdCB0byBsb29rIHRoZW0gdXAuCg==