234332 2021-12-14 19:39:47 -0800 [GTK][WPE] Build fix for Debian Stable after r287015 2021-12-15 01:11:17 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dpino dpino bugs-noreply nham rniwa webkit-bug-importer oldest_to_newest 1824217 0 dpino 2021-12-14 19:39:47 -0800 [GTK][WPE] Build fix for Debian Stable after r287015 1824218 1 447192 dpino 2021-12-14 19:40:12 -0800 Created attachment 447192 Patch 1824220 2 dpino 2021-12-14 19:44:50 -0800 Debian Stable build bot started failing r287015: https://build.webkit.org/#/builders/46 Compilation error was: ``` In file included from WebCore/DerivedSources/unified-sources/UnifiedSource-cbdfe323-30.cpp:8: ../../Source/WebCore/Modules/push-api/PushMessageCrypto.cpp: In constructor ‘WebCore::PushCrypto::decryptAES128GCMPayload(const WebCore::PushCrypto::ClientKeys&, WTF::Span<const unsigned char, 18446744073709551615>)::KeyInfo::KeyInfo()’: ../../Source/WebCore/Modules/push-api/PushMessageCrypto.cpp:129:12: error: char-array initialized from wide string struct KeyInfo { ^~~~~~~ ../../Source/WebCore/Modules/push-api/PushMessageCrypto.cpp: In function ‘std::optional<WTF::Vector<unsigned char> > WebCore::PushCrypto::decryptAES128GCMPayload(const WebCore::PushCrypto::ClientKeys&, WTF::Span<const unsigned char, 18446744073709551615>)’: ../../Source/WebCore/Modules/push-api/PushMessageCrypto.cpp:137:13: note: synthesized method ‘WebCore::PushCrypto::decryptAES128GCMPayload(const WebCore::PushCrypto::ClientKeys&, WTF::Span<const unsigned char, 18446744073709551615>)::KeyInfo::KeyInfo()’ first required here KeyInfo keyInfo; ^~~~~~~ ../../Source/WebCore/Modules/push-api/PushMessageCrypto.cpp: In constructor ‘WebCore::PushCrypto::decryptAESGCMPayload(const WebCore::PushCrypto::ClientKeys&, WTF::Span<const unsigned char, 18446744073709551615>, WTF::Span<const unsigned char, 18446744073709551615>, WTF::Span<const unsigned char, 18446744073709551615>)::KeyDerivationContext::KeyDerivationContext()’: ../../Source/WebCore/Modules/push-api/PushMessageCrypto.cpp:253:12: error: char-array initialized from wide string struct KeyDerivationContext { ^~~~~~~~~~~~~~~~~~~~ ``` The bot uses GCC 8.3: ``` $ gcc --version gcc (Debian 8.3.0-6) 8.3.0 Copyright (C) 2018 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. ``` 1824222 3 447193 dpino 2021-12-14 19:46:31 -0800 Created attachment 447193 Patch 1824241 4 nham 2021-12-14 21:35:22 -0800 Seems fine to me but I'm not a reviewer. I'll ping someone on the team to give the r+. 1824273 5 ews-feeder 2021-12-15 01:10:47 -0800 Committed r287065 (245260@main): <https://commits.webkit.org/245260@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 447193. 1824274 6 webkit-bug-importer 2021-12-15 01:11:17 -0800 <rdar://problem/86511377> 447192 2021-12-14 19:40:12 -0800 2021-12-14 19:46:27 -0800 Patch bug-234332-20211215114010.patch text/plain 2011 dpino U3VidmVyc2lvbiBSZXZpc2lvbjogMjg3MDYwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmI3OTRhOGMwYTUzMGVh MGUwNWJkODU0ZTk5ZmNhODQwNmYyMWYzYi4uOTlkNjI2OWIzODQxN2Q5ZDlkMTM4Y2EwNmI1MTk5 MTkzMDJmMjllMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIxLTEyLTE0ICBEaWVn byBQaW5vIEdhcmNpYSAgPGRwaW5vQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS11bV1BFXSBC dWlsZCBmaXggZm9yIERlYmlhbiBTdGFibGUgYWZ0ZXIgcjI4NzAxNQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjM0MzMyCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIChPT1BTISkuCisK KyAgICAgICAgKiBNb2R1bGVzL3B1c2gtYXBpL1B1c2hNZXNzYWdlQ3J5cHRvLmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OlB1c2hDcnlwdG86OmRlY3J5cHRBRVMxMjhHQ01QYXlsb2FkKToKKyAgICAg ICAgKFdlYkNvcmU6OlB1c2hDcnlwdG86OmRlY3J5cHRBRVNHQ01QYXlsb2FkKToKKwogMjAyMS0x Mi0xNCAgSmVhbi1ZdmVzIEF2ZW5hcmQgIDxqeWFAYXBwbGUuY29tPgogCiAgICAgICAgIFNvdXJj ZUJ1ZmZlclBhcnNlciBzaG91bGQgYmUgdXNpbmcgY29udGlndW91cyBTaGFyZWRCdWZmZXIKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvcHVzaC1hcGkvUHVzaE1lc3NhZ2VDcnlw dG8uY3BwIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9wdXNoLWFwaS9QdXNoTWVzc2FnZUNyeXB0 by5jcHAKaW5kZXggNGM1OTdkOGU0OTFmNTU0OTJkY2NkZDNhZDk5MWM5YWRjZWYyZDU4Yy4uMThl NmM5YjQyNzQ3YmVjMGRkYWMwYWRkODU4NTcyMzM3MTY3YTdmNiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvTW9kdWxlcy9wdXNoLWFwaS9QdXNoTWVzc2FnZUNyeXB0by5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvTW9kdWxlcy9wdXNoLWFwaS9QdXNoTWVzc2FnZUNyeXB0by5jcHAKQEAgLTEy Nyw3ICsxMjcsNyBAQCBzdGQ6Om9wdGlvbmFsPFZlY3Rvcjx1aW50OF90Pj4gZGVjcnlwdEFFUzEy OEdDTVBheWxvYWQoY29uc3QgQ2xpZW50S2V5cyYgY2xpZW50SwogICAgICAqIElLTSA9IEhNQUMt U0hBLTI1NihQUktfa2V5LCBrZXlfaW5mbyB8fCAweDAxKQogICAgICAqLwogICAgIHN0cnVjdCBL ZXlJbmZvIHsKLSAgICAgICAgdWludDhfdCBsYWJlbFsxNF0gPSB7ICJXZWJQdXNoOiBpbmZvIiB9 OworICAgICAgICBjaGFyIGxhYmVsWzE0XSA9IHsgIldlYlB1c2g6IGluZm8iIH07CiAgICAgICAg IHVpbnQ4X3QgY2xpZW50S2V5W3AyNTZkaFB1YmxpY0tleUxlbmd0aF07CiAgICAgICAgIHVpbnQ4 X3Qgc2VydmVyS2V5W3AyNTZkaFB1YmxpY0tleUxlbmd0aF07CiAgICAgICAgIHVpbnQ4X3QgZW5k ID0gMHgwMTsKQEAgLTI1MSw3ICsyNTEsNyBAQCBzdGQ6Om9wdGlvbmFsPFZlY3Rvcjx1aW50OF90 Pj4gZGVjcnlwdEFFU0dDTVBheWxvYWQoY29uc3QgQ2xpZW50S2V5cyYgY2xpZW50S2V5cwogICAg ICAqIGRlcml2YXRpb24gZnVuY3Rpb25zIGJlbG93IHJlcXVpcmUgdGhhdCB0cmFpbGluZyAweDAx IGJ5dGUuCiAgICAgICovCiAgICAgc3RydWN0IEtleURlcml2YXRpb25Db250ZXh0IHsKLSAgICAg ICAgdWludDhfdCBsYWJlbFs2XSA9IHsgIlAtMjU2IiB9OworICAgICAgICBjaGFyIGxhYmVsWzZd ID0geyAiUC0yNTYiIH07CiAgICAgICAgIHVpbnQ4X3QgY2xpZW50UHVibGljS2V5TGVuZ3RoWzJd ID0geyAwLCAweDQxIH07CiAgICAgICAgIHVpbnQ4X3QgY2xpZW50UHVibGljS2V5W3AyNTZkaFB1 YmxpY0tleUxlbmd0aF07CiAgICAgICAgIHVpbnQ4X3Qgc2VydmVyUHVibGljS2V5TGVuZ3RoWzJd ID0geyAwLCAweDQxIH07Cg== 447193 2021-12-14 19:46:31 -0800 2021-12-15 01:10:49 -0800 Patch bug-234332-20211215114630.patch text/plain 1978 dpino U3VidmVyc2lvbiBSZXZpc2lvbjogMjg3MDYwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmI3OTRhOGMwYTUzMGVh MGUwNWJkODU0ZTk5ZmNhODQwNmYyMWYzYi4uNjkxM2ZhZTU2YzUzNmQxMjZhN2E4ZjIwMjJlZDM5 NjA2ODU3YzUzMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDIxLTEyLTE0ICBEaWVn byBQaW5vIEdhcmNpYSAgPGRwaW5vQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS11bV1BFXSBC dWlsZCBmaXggZm9yIERlYmlhbiBTdGFibGUgYWZ0ZXIgcjI4NzAxNQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjM0MzMyCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBNb2R1bGVzL3B1c2gtYXBpL1B1c2hN ZXNzYWdlQ3J5cHRvLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlB1c2hDcnlwdG86OmRlY3J5cHRB RVMxMjhHQ01QYXlsb2FkKToKKyAgICAgICAgKFdlYkNvcmU6OlB1c2hDcnlwdG86OmRlY3J5cHRB RVNHQ01QYXlsb2FkKToKKwogMjAyMS0xMi0xNCAgSmVhbi1ZdmVzIEF2ZW5hcmQgIDxqeWFAYXBw bGUuY29tPgogCiAgICAgICAgIFNvdXJjZUJ1ZmZlclBhcnNlciBzaG91bGQgYmUgdXNpbmcgY29u dGlndW91cyBTaGFyZWRCdWZmZXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMv cHVzaC1hcGkvUHVzaE1lc3NhZ2VDcnlwdG8uY3BwIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9w dXNoLWFwaS9QdXNoTWVzc2FnZUNyeXB0by5jcHAKaW5kZXggNGM1OTdkOGU0OTFmNTU0OTJkY2Nk ZDNhZDk5MWM5YWRjZWYyZDU4Yy4uMThlNmM5YjQyNzQ3YmVjMGRkYWMwYWRkODU4NTcyMzM3MTY3 YTdmNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9wdXNoLWFwaS9QdXNoTWVz c2FnZUNyeXB0by5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9wdXNoLWFwaS9QdXNo TWVzc2FnZUNyeXB0by5jcHAKQEAgLTEyNyw3ICsxMjcsNyBAQCBzdGQ6Om9wdGlvbmFsPFZlY3Rv cjx1aW50OF90Pj4gZGVjcnlwdEFFUzEyOEdDTVBheWxvYWQoY29uc3QgQ2xpZW50S2V5cyYgY2xp ZW50SwogICAgICAqIElLTSA9IEhNQUMtU0hBLTI1NihQUktfa2V5LCBrZXlfaW5mbyB8fCAweDAx KQogICAgICAqLwogICAgIHN0cnVjdCBLZXlJbmZvIHsKLSAgICAgICAgdWludDhfdCBsYWJlbFsx NF0gPSB7ICJXZWJQdXNoOiBpbmZvIiB9OworICAgICAgICBjaGFyIGxhYmVsWzE0XSA9IHsgIldl YlB1c2g6IGluZm8iIH07CiAgICAgICAgIHVpbnQ4X3QgY2xpZW50S2V5W3AyNTZkaFB1YmxpY0tl eUxlbmd0aF07CiAgICAgICAgIHVpbnQ4X3Qgc2VydmVyS2V5W3AyNTZkaFB1YmxpY0tleUxlbmd0 aF07CiAgICAgICAgIHVpbnQ4X3QgZW5kID0gMHgwMTsKQEAgLTI1MSw3ICsyNTEsNyBAQCBzdGQ6 Om9wdGlvbmFsPFZlY3Rvcjx1aW50OF90Pj4gZGVjcnlwdEFFU0dDTVBheWxvYWQoY29uc3QgQ2xp ZW50S2V5cyYgY2xpZW50S2V5cwogICAgICAqIGRlcml2YXRpb24gZnVuY3Rpb25zIGJlbG93IHJl cXVpcmUgdGhhdCB0cmFpbGluZyAweDAxIGJ5dGUuCiAgICAgICovCiAgICAgc3RydWN0IEtleURl cml2YXRpb25Db250ZXh0IHsKLSAgICAgICAgdWludDhfdCBsYWJlbFs2XSA9IHsgIlAtMjU2IiB9 OworICAgICAgICBjaGFyIGxhYmVsWzZdID0geyAiUC0yNTYiIH07CiAgICAgICAgIHVpbnQ4X3Qg Y2xpZW50UHVibGljS2V5TGVuZ3RoWzJdID0geyAwLCAweDQxIH07CiAgICAgICAgIHVpbnQ4X3Qg Y2xpZW50UHVibGljS2V5W3AyNTZkaFB1YmxpY0tleUxlbmd0aF07CiAgICAgICAgIHVpbnQ4X3Qg c2VydmVyUHVibGljS2V5TGVuZ3RoWzJdID0geyAwLCAweDQxIH07Cg==