234329 2021-12-14 18:11:32 -0800 Actually use adattributiond.entitlements when code signing adattributiond 2021-12-15 13:09:15 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 achristensen achristensen thorton webkit-bug-importer oldest_to_newest 1824203 0 achristensen 2021-12-14 18:11:32 -0800 Actually use adattributiond.entitlements when code signing adattributiond 1824206 1 447187 achristensen 2021-12-14 18:15:51 -0800 Created attachment 447187 Patch 1824207 2 447188 achristensen 2021-12-14 18:17:02 -0800 Created attachment 447188 Patch 1824208 3 447188 thorton 2021-12-14 18:19:50 -0800 Comment on attachment 447188 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=447188&action=review > Source/WebKit/Configurations/adattributiond.xcconfig:34 > +WK_CODE_SIGN_FLAGS_iphoneos = --entitlements $(WK_PROCESSED_XCENT_FILE); Do you not want CODE_SIGN_ENTITLEMENTS instead? 1824244 4 achristensen 2021-12-14 21:50:13 -0800 Using CODE_SIGN_ENTITLEMENTS causes a build failure, something about a dependency problem. I think that is to be used when the entitlements file is in the repo, but here the entitlements file is generated in the temporary directory. 1824510 5 ews-feeder 2021-12-15 13:08:04 -0800 Committed r287100 (245289@main): <https://commits.webkit.org/245289@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 447188. 1824511 6 webkit-bug-importer 2021-12-15 13:09:15 -0800 <rdar://problem/86539150> 447187 2021-12-14 18:15:51 -0800 2021-12-14 18:17:00 -0800 Patch bug-234329-20211214181550.patch text/plain 2234 achristensen U3VidmVyc2lvbiBSZXZpc2lvbjogMjg3MDQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDczNWUzMjY0MjkwMWU1YjY5 MjA0ZGQ5NzUxZGE3NmU5YWVmYWU2ZDkuLjUyYmNlMWUyMzdkNjlkZDRkYjYyNWNiZTZjMjlhMDVi OTZlODdhMzQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMjEtMTItMTQgIEFsZXggQ2hy aXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KKworICAgICAgICBBY3R1YWxseSB1 c2UgYWRhdHRyaWJ1dGlvbmQuZW50aXRsZW1lbnRzIHdoZW4gY29kZSBzaWduaW5nIGFkYXR0cmli dXRpb25kCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0y MzQzMjkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBy MjgzODk3IGdvdCBtZSBzbyBjbG9zZS4gIEkgZ2VuZXJhdGUgdGhlIGVudGl0bGVtZW50cyBhbmQg dGhlIHNhbmRib3ggcHJvZmlsZS4gIE5vdyBJIG5lZWQgdG8gYWN0dWFsbHkgc2lnbiB3aXRoIHRo ZSBlbnRpdGxlbWVudHMuCisgICAgICAgIEkgdmVyaWZpZWQgYnkgYnVpbGRpbmcgdHdvIHJvb3Rz IHRoYXQgYmVmb3JlIHRoaXMgY2hhbmdlLCB0aGUgY29kZXNpZ24gaW52b2NhdGlvbiBsb29rZWQg bGlrZSB0aGlzOgorICAgICAgICAvdXNyL2Jpbi9jb2Rlc2lnbiAtLWZvcmNlIC0tc2lnbiAtIC0t Z2VuZXJhdGUtZW50aXRsZW1lbnQtZGVyIC4uLi9Sb290L1N5c3RlbS9MaWJyYXJ5L0ZyYW1ld29y a3MvV2ViS2l0LmZyYW1ld29yay9EYWVtb25zL2FkYXR0cmlidXRpb25kCisgICAgICAgIGFuZCBh ZnRlciB0aGlzIGNoYW5nZSBpdCBsb29rcyBsaWtlIHRoaXM6CisgICAgICAgIC91c3IvYmluL2Nv ZGVzaWduIC0tZm9yY2UgLS1zaWduIC0gLS1lbnRpdGxlbWVudHMgLi4uL1RlbXBDb250ZW50L09i amVjdHMvV2ViS2l0LmJ1aWxkL2FkYXR0cmlidXRpb25kLmJ1aWxkL2FkYXR0cmlidXRpb25kLmVu dGl0bGVtZW50cworICAgICAgICAgICAgLS1nZW5lcmF0ZS1lbnRpdGxlbWVudC1kZXIgLi4uL1Jv b3QvU3lzdGVtL0xpYnJhcnkvRnJhbWV3b3Jrcy9XZWJLaXQuZnJhbWV3b3JrL0RhZW1vbnMvYWRh dHRyaWJ1dGlvbmQKKworICAgICAgICAqIENvbmZpZ3VyYXRpb25zL2FkYXR0cmlidXRpb25kLnhj Y29uZmlnOgorCiAyMDIxLTEyLTE0ICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdl YmtpdC5vcmc+CiAKICAgICAgICAgQWRkIF9XS0NvbnRlbnRSdWxlTGlzdEFjdGlvbi5yZWRpcmVj dGVkIGFuZCAubW9kaWZpZWRIZWFkZXJzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0NvbmZp Z3VyYXRpb25zL2FkYXR0cmlidXRpb25kLnhjY29uZmlnIGIvU291cmNlL1dlYktpdC9Db25maWd1 cmF0aW9ucy9hZGF0dHJpYnV0aW9uZC54Y2NvbmZpZwppbmRleCBhOTlhYjc0N2U5NGU5ODc3YjRj ZjQ5ZjJlZDFjOWQ5YzBlNzAxYjZjLi5jOTA4NDFhMjE0YTgzM2Y5MGFhNGRkNTkxN2RhZWM3YTNl ODFhM2I5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L0NvbmZpZ3VyYXRpb25zL2FkYXR0cmli dXRpb25kLnhjY29uZmlnCisrKyBiL1NvdXJjZS9XZWJLaXQvQ29uZmlndXJhdGlvbnMvYWRhdHRy aWJ1dGlvbmQueGNjb25maWcKQEAgLTMwLDUgKzMwLDkgQEAgRlJBTUVXT1JLX1NFQVJDSF9QQVRI UyA9ICQoQlVJTFRfUFJPRFVDVFNfRElSKTsKIAogV0tfUFJPQ0VTU0VEX1hDRU5UX0ZJTEU9JChU RU1QX0ZJTEVfRElSKS8kKEZVTExfUFJPRFVDVF9OQU1FKS5lbnRpdGxlbWVudHMKIAorV0tfQ09E RV9TSUdOX0ZMQUdTID0gJChXS19DT0RFX1NJR05fRkxBR1NfJChXS19QTEFURk9STV9OQU1FKSk7 CitXS19DT0RFX1NJR05fRkxBR1NfaXBob25lb3MgPSAtLWVudGl0bGVtZW50cyAkKFdLX1BST0NF U1NFRF9YQ0VOVF9GSUxFKTsKK09USEVSX0NPREVfU0lHTl9GTEFHUyA9ICQoV0tfQ09ERV9TSUdO X0ZMQUdTKTsKKwogSU5TVEFMTF9QQVRIW3Nkaz1pcGhvbmUqXSA9ICQoV0VCS0lUX0ZSQU1FV09S S1NfRElSKS9XZWJLaXQuZnJhbWV3b3JrL0RhZW1vbnM7CiBJTlNUQUxMX1BBVEhbc2RrPW1hY29z eCpdID0gJChXRUJLSVRfRlJBTUVXT1JLU19ESVIpL1dlYktpdC5mcmFtZXdvcmsvVmVyc2lvbnMv QS9EYWVtb25zOwo= 447188 2021-12-14 18:17:02 -0800 2021-12-15 13:08:05 -0800 Patch bug-234329-20211214181701.patch text/plain 2261 achristensen U3VidmVyc2lvbiBSZXZpc2lvbjogMjg3MDQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDczNWUzMjY0MjkwMWU1YjY5 MjA0ZGQ5NzUxZGE3NmU5YWVmYWU2ZDkuLjNlZmIyOWY5Y2YzMWQwM2UxZmI4YTJjODNlNzE4ZDFi ZTk2NDg4ZjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMjEtMTItMTQgIEFsZXggQ2hy aXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KKworICAgICAgICBBY3R1YWxseSB1 c2UgYWRhdHRyaWJ1dGlvbmQuZW50aXRsZW1lbnRzIHdoZW4gY29kZSBzaWduaW5nIGFkYXR0cmli dXRpb25kCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0y MzQzMjkKKyAgICAgICAgPHJkYXI6Ly84NjQyNTc4NT4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICByMjgzODk3IGdvdCBtZSBzbyBjbG9zZS4gIEkgZ2Vu ZXJhdGUgdGhlIGVudGl0bGVtZW50cyBhbmQgdGhlIHNhbmRib3ggcHJvZmlsZS4gIE5vdyBJIG5l ZWQgdG8gYWN0dWFsbHkgc2lnbiB3aXRoIHRoZSBlbnRpdGxlbWVudHMuCisgICAgICAgIEkgdmVy aWZpZWQgYnkgYnVpbGRpbmcgdHdvIHJvb3RzIHRoYXQgYmVmb3JlIHRoaXMgY2hhbmdlLCB0aGUg Y29kZXNpZ24gaW52b2NhdGlvbiBsb29rZWQgbGlrZSB0aGlzOgorICAgICAgICAvdXNyL2Jpbi9j b2Rlc2lnbiAtLWZvcmNlIC0tc2lnbiAtIC0tZ2VuZXJhdGUtZW50aXRsZW1lbnQtZGVyIC4uLi9S b290L1N5c3RlbS9MaWJyYXJ5L0ZyYW1ld29ya3MvV2ViS2l0LmZyYW1ld29yay9EYWVtb25zL2Fk YXR0cmlidXRpb25kCisgICAgICAgIGFuZCBhZnRlciB0aGlzIGNoYW5nZSBpdCBsb29rcyBsaWtl IHRoaXM6CisgICAgICAgIC91c3IvYmluL2NvZGVzaWduIC0tZm9yY2UgLS1zaWduIC0gLS1lbnRp dGxlbWVudHMgLi4uL1RlbXBDb250ZW50L09iamVjdHMvV2ViS2l0LmJ1aWxkL2FkYXR0cmlidXRp b25kLmJ1aWxkL2FkYXR0cmlidXRpb25kLmVudGl0bGVtZW50cworICAgICAgICAgICAgLS1nZW5l cmF0ZS1lbnRpdGxlbWVudC1kZXIgLi4uL1Jvb3QvU3lzdGVtL0xpYnJhcnkvRnJhbWV3b3Jrcy9X ZWJLaXQuZnJhbWV3b3JrL0RhZW1vbnMvYWRhdHRyaWJ1dGlvbmQKKworICAgICAgICAqIENvbmZp Z3VyYXRpb25zL2FkYXR0cmlidXRpb25kLnhjY29uZmlnOgorCiAyMDIxLTEyLTE0ICBBbGV4IENo cmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CiAKICAgICAgICAgQWRkIF9XS0Nv bnRlbnRSdWxlTGlzdEFjdGlvbi5yZWRpcmVjdGVkIGFuZCAubW9kaWZpZWRIZWFkZXJzCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0L0NvbmZpZ3VyYXRpb25zL2FkYXR0cmlidXRpb25kLnhjY29u ZmlnIGIvU291cmNlL1dlYktpdC9Db25maWd1cmF0aW9ucy9hZGF0dHJpYnV0aW9uZC54Y2NvbmZp ZwppbmRleCBhOTlhYjc0N2U5NGU5ODc3YjRjZjQ5ZjJlZDFjOWQ5YzBlNzAxYjZjLi5jOTA4NDFh MjE0YTgzM2Y5MGFhNGRkNTkxN2RhZWM3YTNlODFhM2I5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0L0NvbmZpZ3VyYXRpb25zL2FkYXR0cmlidXRpb25kLnhjY29uZmlnCisrKyBiL1NvdXJjZS9X ZWJLaXQvQ29uZmlndXJhdGlvbnMvYWRhdHRyaWJ1dGlvbmQueGNjb25maWcKQEAgLTMwLDUgKzMw LDkgQEAgRlJBTUVXT1JLX1NFQVJDSF9QQVRIUyA9ICQoQlVJTFRfUFJPRFVDVFNfRElSKTsKIAog V0tfUFJPQ0VTU0VEX1hDRU5UX0ZJTEU9JChURU1QX0ZJTEVfRElSKS8kKEZVTExfUFJPRFVDVF9O QU1FKS5lbnRpdGxlbWVudHMKIAorV0tfQ09ERV9TSUdOX0ZMQUdTID0gJChXS19DT0RFX1NJR05f RkxBR1NfJChXS19QTEFURk9STV9OQU1FKSk7CitXS19DT0RFX1NJR05fRkxBR1NfaXBob25lb3Mg PSAtLWVudGl0bGVtZW50cyAkKFdLX1BST0NFU1NFRF9YQ0VOVF9GSUxFKTsKK09USEVSX0NPREVf U0lHTl9GTEFHUyA9ICQoV0tfQ09ERV9TSUdOX0ZMQUdTKTsKKwogSU5TVEFMTF9QQVRIW3Nkaz1p cGhvbmUqXSA9ICQoV0VCS0lUX0ZSQU1FV09SS1NfRElSKS9XZWJLaXQuZnJhbWV3b3JrL0RhZW1v bnM7CiBJTlNUQUxMX1BBVEhbc2RrPW1hY29zeCpdID0gJChXRUJLSVRfRlJBTUVXT1JLU19ESVIp L1dlYktpdC5mcmFtZXdvcmsvVmVyc2lvbnMvQS9EYWVtb25zOwo=