234266 2021-12-13 14:08:09 -0800 Attachment does not update after markup. 2022-02-10 16:44:29 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 megan_gardner megan_gardner webkit-bug-importer wenson_hsieh oldest_to_newest 1823743 0 megan_gardner 2021-12-13 14:08:09 -0800 Attachment does not update after markup. 1823745 1 447062 megan_gardner 2021-12-13 14:11:20 -0800 Created attachment 447062 Patch 1823749 2 447062 wenson_hsieh 2021-12-13 14:15:26 -0800 Comment on attachment 447062 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=447062&action=review > Source/WebKit/UIProcess/mac/WKSharingServicePickerDelegate.mm:158 > + _menuProxy->page()->didInvalidateDataForAttachment(*apiAttachment.get()); Not new in this patch, but we should weakly capture WebPageProxy here (instead of accessing it through the raw pointer to _menuProxy.) 1823750 3 447062 wenson_hsieh 2021-12-13 14:16:14 -0800 Comment on attachment 447062 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=447062&action=review >> Source/WebKit/UIProcess/mac/WKSharingServicePickerDelegate.mm:158 >> + _menuProxy->page()->didInvalidateDataForAttachment(*apiAttachment.get()); > > Not new in this patch, but we should weakly capture WebPageProxy here (instead of accessing it through the raw pointer to _menuProxy.) (Let's also add a null check for `apiAttachment`, since it's not guaranteed that the attachment ID will map to an actual API::Attachment here) 1823777 4 447068 megan_gardner 2021-12-13 14:35:32 -0800 Created attachment 447068 Patch 1823783 5 447068 wenson_hsieh 2021-12-13 14:39:55 -0800 Comment on attachment 447068 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=447068&action=review > Source/WebKit/UIProcess/mac/WKSharingServicePickerDelegate.mm:166 > [itemProvider loadDataRepresentationForTypeIdentifier:(NSString *)kUTTypeData completionHandler:^(NSData *data, NSError *error) { > + WeakPtr webPage = _menuProxy->page(); > + > + if (!webPage) > + return; > + > if (error) > return; > > - auto apiAttachment = _menuProxy->page()->attachmentForIdentifier(_attachmentID); > + auto apiAttachment = webPage->attachmentForIdentifier(_attachmentID); > + if (!apiAttachment) > + return; > + > auto attachment = wrapper(apiAttachment); > [attachment setData:data newContentType:String(NSPasteboardTypeTIFF)]; > + webPage->didInvalidateDataForAttachment(*apiAttachment.get()); You probably want something like this: ``` WeakPtr weakPage = _menuProxy->page(); [itemProvider loadDataRepresentationForTypeIdentifier:(NSString *)kUTTypeData completionHandler:[weakPage, attachmentID = _attachmentID](NSData *data, NSError *error) { RefPtr webPage = weakPage.get(); if (!webPage) return; if (error) return; auto apiAttachment = webPage->attachmentForIdentifier(attachmentID); if (!apiAttachment) return; auto attachment = wrapper(apiAttachment); [attachment setData:data newContentType:String(NSPasteboardTypeTIFF)]; webPage->didInvalidateDataForAttachment(*apiAttachment.get()); }]; ``` 1823790 6 447072 megan_gardner 2021-12-13 14:54:18 -0800 Created attachment 447072 Patch 1823792 7 447072 wenson_hsieh 2021-12-13 14:57:52 -0800 Comment on attachment 447072 Patch r=mews 1824056 8 ews-feeder 2021-12-14 11:24:18 -0800 Committed r287034 (245234@main): <https://commits.webkit.org/245234@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 447072. 1824057 9 webkit-bug-importer 2021-12-14 11:25:16 -0800 <rdar://problem/86480352> 447062 2021-12-13 14:11:20 -0800 2021-12-13 14:15:26 -0800 Patch bug-234266-20211213141119.patch text/plain 1748 megan_gardner U3VidmVyc2lvbiBSZXZpc2lvbjogMjg2OTYwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDllMDQzNTVlZDBjMmViYTkw NjJjOGMyMDZmYjUwNWQ5OGIwYmJmYjkuLjYzZDQxOTFlMjc1NTgyNjcxMjVkODRiMzY1OGZiMDQ1 ZTBmODYyNWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjEtMTItMTMgIE1lZ2FuIEdh cmRuZXIgIDxtZWdhbl9nYXJkbmVyQGFwcGxlLmNvbT4KKworICAgICAgICBBdHRhY2htZW50IGRv ZXMgbm90IHVwZGF0ZSBhZnRlciBtYXJrdXAuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0yMzQyNjYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBJZiB3ZSBkb24ndCBjYWxsIHRoZSBkZWxpZ2F0ZSB0byBpbmZv cm0gTWFpbCBhYm91dCB0aGUgbmV3IGF0dGFjaG1lbnQgZGF0YSwKKyAgICAgICAgaXQgd2lsbCBu b3QgdXBkYXRlIGFuZCB0aGUgb3JpZ2luYWwgaW1hZ2Ugd2lsbCBiZSBzZW50LgorCisgICAgICAg ICogVUlQcm9jZXNzL21hYy9XS1NoYXJpbmdTZXJ2aWNlUGlja2VyRGVsZWdhdGUubW06CisgICAg ICAgICgtW1dLU2hhcmluZ1NlcnZpY2VQaWNrZXJEZWxlZ2F0ZSBzaGFyaW5nU2VydmljZTpkaWRT aGFyZUl0ZW1zOl0pOgorCiAyMDIxLTEyLTEzICBFbGxpb3R0IFdpbGxpYW1zICA8ZW13QGFwcGxl LmNvbT4KIAogICAgICAgICBEZXBsb3ltZW50IHRhcmdldCBmb3IgbWFjT1MgMTErIGRvZXMgbm90 IGZvbGxvdyBtaW5vciB2ZXJzaW9uIGJ1bXBzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJ UHJvY2Vzcy9tYWMvV0tTaGFyaW5nU2VydmljZVBpY2tlckRlbGVnYXRlLm1tIGIvU291cmNlL1dl YktpdC9VSVByb2Nlc3MvbWFjL1dLU2hhcmluZ1NlcnZpY2VQaWNrZXJEZWxlZ2F0ZS5tbQppbmRl eCBmYmU5OGEwODM5YWRhMWM0MWQ1ZjMyMjFkNDQ5YWRmZmY0ZjIyMDE0Li42Y2Y3NmRjZTFjMDQx OWRlMjFjNzZjZGY3MGU5OWFmMTk3NzJjNzQ4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJ UHJvY2Vzcy9tYWMvV0tTaGFyaW5nU2VydmljZVBpY2tlckRlbGVnYXRlLm1tCisrKyBiL1NvdXJj ZS9XZWJLaXQvVUlQcm9jZXNzL21hYy9XS1NoYXJpbmdTZXJ2aWNlUGlja2VyRGVsZWdhdGUubW0K QEAgLTE1NSw2ICsxNTUsNyBAQCAtICh2b2lkKXNoYXJpbmdTZXJ2aWNlOihOU1NoYXJpbmdTZXJ2 aWNlICopc2hhcmluZ1NlcnZpY2UgZGlkU2hhcmVJdGVtczooTlNBcnJheQogICAgICAgICAgICAg YXV0byBhcGlBdHRhY2htZW50ID0gX21lbnVQcm94eS0+cGFnZSgpLT5hdHRhY2htZW50Rm9ySWRl bnRpZmllcihfYXR0YWNobWVudElEKTsKICAgICAgICAgICAgIGF1dG8gYXR0YWNobWVudCA9IHdy YXBwZXIoYXBpQXR0YWNobWVudCk7CiAgICAgICAgICAgICBbYXR0YWNobWVudCBzZXREYXRhOmRh dGEgbmV3Q29udGVudFR5cGU6U3RyaW5nKE5TUGFzdGVib2FyZFR5cGVUSUZGKV07CisgICAgICAg ICAgICBfbWVudVByb3h5LT5wYWdlKCktPmRpZEludmFsaWRhdGVEYXRhRm9yQXR0YWNobWVudCgq YXBpQXR0YWNobWVudC5nZXQoKSk7CiAgICAgICAgIH1dOwogICAgICAgICBBTExPV19ERVBSRUNB VEVEX0RFQ0xBUkFUSU9OU19FTkQKICAgICAgICAgcmV0dXJuOwo= 447068 2021-12-13 14:35:32 -0800 2022-02-10 16:44:29 -0800 Patch bug-234266-20211213143531.patch text/plain 2282 megan_gardner U3VidmVyc2lvbiBSZXZpc2lvbjogMjg2OTYwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDllMDQzNTVlZDBjMmViYTkw NjJjOGMyMDZmYjUwNWQ5OGIwYmJmYjkuLjYzZDQxOTFlMjc1NTgyNjcxMjVkODRiMzY1OGZiMDQ1 ZTBmODYyNWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjEtMTItMTMgIE1lZ2FuIEdh cmRuZXIgIDxtZWdhbl9nYXJkbmVyQGFwcGxlLmNvbT4KKworICAgICAgICBBdHRhY2htZW50IGRv ZXMgbm90IHVwZGF0ZSBhZnRlciBtYXJrdXAuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0yMzQyNjYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBJZiB3ZSBkb24ndCBjYWxsIHRoZSBkZWxpZ2F0ZSB0byBpbmZv cm0gTWFpbCBhYm91dCB0aGUgbmV3IGF0dGFjaG1lbnQgZGF0YSwKKyAgICAgICAgaXQgd2lsbCBu b3QgdXBkYXRlIGFuZCB0aGUgb3JpZ2luYWwgaW1hZ2Ugd2lsbCBiZSBzZW50LgorCisgICAgICAg ICogVUlQcm9jZXNzL21hYy9XS1NoYXJpbmdTZXJ2aWNlUGlja2VyRGVsZWdhdGUubW06CisgICAg ICAgICgtW1dLU2hhcmluZ1NlcnZpY2VQaWNrZXJEZWxlZ2F0ZSBzaGFyaW5nU2VydmljZTpkaWRT aGFyZUl0ZW1zOl0pOgorCiAyMDIxLTEyLTEzICBFbGxpb3R0IFdpbGxpYW1zICA8ZW13QGFwcGxl LmNvbT4KIAogICAgICAgICBEZXBsb3ltZW50IHRhcmdldCBmb3IgbWFjT1MgMTErIGRvZXMgbm90 IGZvbGxvdyBtaW5vciB2ZXJzaW9uIGJ1bXBzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJ UHJvY2Vzcy9tYWMvV0tTaGFyaW5nU2VydmljZVBpY2tlckRlbGVnYXRlLm1tIGIvU291cmNlL1dl YktpdC9VSVByb2Nlc3MvbWFjL1dLU2hhcmluZ1NlcnZpY2VQaWNrZXJEZWxlZ2F0ZS5tbQppbmRl eCBmYmU5OGEwODM5YWRhMWM0MWQ1ZjMyMjFkNDQ5YWRmZmY0ZjIyMDE0Li5hZjE2MWNhNmZmMTAy YjYxYmMwNzhhYzUwYWJmYWEwZDNlMzE1YmE3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJ UHJvY2Vzcy9tYWMvV0tTaGFyaW5nU2VydmljZVBpY2tlckRlbGVnYXRlLm1tCisrKyBiL1NvdXJj ZS9XZWJLaXQvVUlQcm9jZXNzL21hYy9XS1NoYXJpbmdTZXJ2aWNlUGlja2VyRGVsZWdhdGUubW0K QEAgLTE0OSwxMiArMTQ5LDIxIEBAIC0gKHZvaWQpc2hhcmluZ1NlcnZpY2U6KE5TU2hhcmluZ1Nl cnZpY2UgKilzaGFyaW5nU2VydmljZSBkaWRTaGFyZUl0ZW1zOihOU0FycmF5CiAgICAgICAgIAog ICAgICAgICBBTExPV19ERVBSRUNBVEVEX0RFQ0xBUkFUSU9OU19CRUdJTgogICAgICAgICBbaXRl bVByb3ZpZGVyIGxvYWREYXRhUmVwcmVzZW50YXRpb25Gb3JUeXBlSWRlbnRpZmllcjooTlNTdHJp bmcgKilrVVRUeXBlRGF0YSBjb21wbGV0aW9uSGFuZGxlcjpeKE5TRGF0YSAqZGF0YSwgTlNFcnJv ciAqZXJyb3IpIHsKKyAgICAgICAgICAgIFdlYWtQdHIgd2ViUGFnZSA9IF9tZW51UHJveHktPnBh Z2UoKTsKKyAgICAgICAgICAgIAorICAgICAgICAgICAgaWYgKCF3ZWJQYWdlKQorICAgICAgICAg ICAgICAgIHJldHVybjsKKyAgICAgICAgICAgIAogICAgICAgICAgICAgaWYgKGVycm9yKQogICAg ICAgICAgICAgICAgIHJldHVybjsKICAgICAgICAgICAgIAotICAgICAgICAgICAgYXV0byBhcGlB dHRhY2htZW50ID0gX21lbnVQcm94eS0+cGFnZSgpLT5hdHRhY2htZW50Rm9ySWRlbnRpZmllcihf YXR0YWNobWVudElEKTsKKyAgICAgICAgICAgIGF1dG8gYXBpQXR0YWNobWVudCA9IHdlYlBhZ2Ut PmF0dGFjaG1lbnRGb3JJZGVudGlmaWVyKF9hdHRhY2htZW50SUQpOworICAgICAgICAgICAgaWYg KCFhcGlBdHRhY2htZW50KQorICAgICAgICAgICAgICAgIHJldHVybjsKKyAgICAgICAgICAgIAog ICAgICAgICAgICAgYXV0byBhdHRhY2htZW50ID0gd3JhcHBlcihhcGlBdHRhY2htZW50KTsKICAg ICAgICAgICAgIFthdHRhY2htZW50IHNldERhdGE6ZGF0YSBuZXdDb250ZW50VHlwZTpTdHJpbmco TlNQYXN0ZWJvYXJkVHlwZVRJRkYpXTsKKyAgICAgICAgICAgIHdlYlBhZ2UtPmRpZEludmFsaWRh dGVEYXRhRm9yQXR0YWNobWVudCgqYXBpQXR0YWNobWVudC5nZXQoKSk7CiAgICAgICAgIH1dOwog ICAgICAgICBBTExPV19ERVBSRUNBVEVEX0RFQ0xBUkFUSU9OU19FTkQKICAgICAgICAgcmV0dXJu Owo= 447072 2021-12-13 14:54:18 -0800 2021-12-14 11:24:18 -0800 Patch bug-234266-20211213145417.patch text/plain 2566 megan_gardner U3VidmVyc2lvbiBSZXZpc2lvbjogMjg2OTYwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDllMDQzNTVlZDBjMmViYTkw NjJjOGMyMDZmYjUwNWQ5OGIwYmJmYjkuLjYzZDQxOTFlMjc1NTgyNjcxMjVkODRiMzY1OGZiMDQ1 ZTBmODYyNWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjEtMTItMTMgIE1lZ2FuIEdh cmRuZXIgIDxtZWdhbl9nYXJkbmVyQGFwcGxlLmNvbT4KKworICAgICAgICBBdHRhY2htZW50IGRv ZXMgbm90IHVwZGF0ZSBhZnRlciBtYXJrdXAuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0yMzQyNjYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBJZiB3ZSBkb24ndCBjYWxsIHRoZSBkZWxpZ2F0ZSB0byBpbmZv cm0gTWFpbCBhYm91dCB0aGUgbmV3IGF0dGFjaG1lbnQgZGF0YSwKKyAgICAgICAgaXQgd2lsbCBu b3QgdXBkYXRlIGFuZCB0aGUgb3JpZ2luYWwgaW1hZ2Ugd2lsbCBiZSBzZW50LgorCisgICAgICAg ICogVUlQcm9jZXNzL21hYy9XS1NoYXJpbmdTZXJ2aWNlUGlja2VyRGVsZWdhdGUubW06CisgICAg ICAgICgtW1dLU2hhcmluZ1NlcnZpY2VQaWNrZXJEZWxlZ2F0ZSBzaGFyaW5nU2VydmljZTpkaWRT aGFyZUl0ZW1zOl0pOgorCiAyMDIxLTEyLTEzICBFbGxpb3R0IFdpbGxpYW1zICA8ZW13QGFwcGxl LmNvbT4KIAogICAgICAgICBEZXBsb3ltZW50IHRhcmdldCBmb3IgbWFjT1MgMTErIGRvZXMgbm90 IGZvbGxvdyBtaW5vciB2ZXJzaW9uIGJ1bXBzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJ UHJvY2Vzcy9tYWMvV0tTaGFyaW5nU2VydmljZVBpY2tlckRlbGVnYXRlLm1tIGIvU291cmNlL1dl YktpdC9VSVByb2Nlc3MvbWFjL1dLU2hhcmluZ1NlcnZpY2VQaWNrZXJEZWxlZ2F0ZS5tbQppbmRl eCBmYmU5OGEwODM5YWRhMWM0MWQ1ZjMyMjFkNDQ5YWRmZmY0ZjIyMDE0Li5iOGRmOTdhYzQzODIz YjZiZDRhNTI2NzE4N2Q0NDIxZGFhYjRjNzIwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJ UHJvY2Vzcy9tYWMvV0tTaGFyaW5nU2VydmljZVBpY2tlckRlbGVnYXRlLm1tCisrKyBiL1NvdXJj ZS9XZWJLaXQvVUlQcm9jZXNzL21hYy9XS1NoYXJpbmdTZXJ2aWNlUGlja2VyRGVsZWdhdGUubW0K QEAgLTE0OCwxMyArMTQ4LDIzIEBAIC0gKHZvaWQpc2hhcmluZ1NlcnZpY2U6KE5TU2hhcmluZ1Nl cnZpY2UgKilzaGFyaW5nU2VydmljZSBkaWRTaGFyZUl0ZW1zOihOU0FycmF5CiAgICAgICAgIE5T SXRlbVByb3ZpZGVyICppdGVtUHJvdmlkZXIgPSAoTlNJdGVtUHJvdmlkZXIgKilpdGVtOwogICAg ICAgICAKICAgICAgICAgQUxMT1dfREVQUkVDQVRFRF9ERUNMQVJBVElPTlNfQkVHSU4KLSAgICAg ICAgW2l0ZW1Qcm92aWRlciBsb2FkRGF0YVJlcHJlc2VudGF0aW9uRm9yVHlwZUlkZW50aWZpZXI6 KE5TU3RyaW5nICopa1VUVHlwZURhdGEgY29tcGxldGlvbkhhbmRsZXI6XihOU0RhdGEgKmRhdGEs IE5TRXJyb3IgKmVycm9yKSB7CisgICAgICAgIFdlYWtQdHIgd2Vha1BhZ2UgPSBfbWVudVByb3h5 LT5wYWdlKCk7CisgICAgICAgIFtpdGVtUHJvdmlkZXIgbG9hZERhdGFSZXByZXNlbnRhdGlvbkZv clR5cGVJZGVudGlmaWVyOihOU1N0cmluZyAqKWtVVFR5cGVEYXRhIGNvbXBsZXRpb25IYW5kbGVy Olt3ZWFrUGFnZSwgYXR0YWNobWVudElEID0gX2F0dGFjaG1lbnRJRF0oTlNEYXRhICpkYXRhLCBO U0Vycm9yICplcnJvcikgeworICAgICAgICAgICAgUmVmUHRyIHdlYlBhZ2UgPSB3ZWFrUGFnZS5n ZXQoKTsKKyAgICAgICAgICAgIAorICAgICAgICAgICAgaWYgKCF3ZWJQYWdlKQorICAgICAgICAg ICAgICAgIHJldHVybjsKKyAgICAgICAgICAgIAogICAgICAgICAgICAgaWYgKGVycm9yKQogICAg ICAgICAgICAgICAgIHJldHVybjsKICAgICAgICAgICAgIAotICAgICAgICAgICAgYXV0byBhcGlB dHRhY2htZW50ID0gX21lbnVQcm94eS0+cGFnZSgpLT5hdHRhY2htZW50Rm9ySWRlbnRpZmllcihf YXR0YWNobWVudElEKTsKKyAgICAgICAgICAgIGF1dG8gYXBpQXR0YWNobWVudCA9IHdlYlBhZ2Ut PmF0dGFjaG1lbnRGb3JJZGVudGlmaWVyKGF0dGFjaG1lbnRJRCk7CisgICAgICAgICAgICBpZiAo IWFwaUF0dGFjaG1lbnQpCisgICAgICAgICAgICAgICAgcmV0dXJuOworICAgICAgICAgICAgCiAg ICAgICAgICAgICBhdXRvIGF0dGFjaG1lbnQgPSB3cmFwcGVyKGFwaUF0dGFjaG1lbnQpOwogICAg ICAgICAgICAgW2F0dGFjaG1lbnQgc2V0RGF0YTpkYXRhIG5ld0NvbnRlbnRUeXBlOlN0cmluZyhO U1Bhc3RlYm9hcmRUeXBlVElGRildOworICAgICAgICAgICAgd2ViUGFnZS0+ZGlkSW52YWxpZGF0 ZURhdGFGb3JBdHRhY2htZW50KCphcGlBdHRhY2htZW50LmdldCgpKTsKICAgICAgICAgfV07CiAg ICAgICAgIEFMTE9XX0RFUFJFQ0FURURfREVDTEFSQVRJT05TX0VORAogICAgICAgICByZXR1cm47 Cg==