234264 2021-12-13 13:34:37 -0800 Adhere to DisplayList iterator's API contract in MemoryDisplayList::~InMemoryDisplayList() 2021-12-14 14:17:10 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 gnavamarino gnavamarino mmaxfield webkit-bug-importer wenson_hsieh oldest_to_newest 1823724 0 gnavamarino 2021-12-13 13:34:37 -0800 We need to breakout out of iteration if the item is nullopt. 1823725 1 gnavamarino 2021-12-13 13:35:17 -0800 <rdar://problem/86152753> 1823730 2 447054 gnavamarino 2021-12-13 13:39:37 -0800 Created attachment 447054 Patch 1824116 3 447054 mmaxfield 2021-12-14 14:08:11 -0800 Comment on attachment 447054 Patch We should consider modifying DisplayList::Iterator::operator== to see if this behavior can automatically occur for all display list iteration. This is fine for now, though. 1824123 4 ews-feeder 2021-12-14 14:17:05 -0800 Committed r287048 (245245@main): <https://commits.webkit.org/245245@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 447054. 447054 2021-12-13 13:39:37 -0800 2021-12-14 14:17:07 -0800 Patch bug-234264-20211213133936.patch text/plain 1851 gnavamarino U3VidmVyc2lvbiBSZXZpc2lvbjogMjg2ODgyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjEyYTk0YzRhOWEwM2Ey ZTIxNzZhMTlmMjcyNjdkY2UwNGVlMzU5Mi4uYzBjNDc5MTY1MjJhMDVhYTYwMjhmNDljYzMzN2U3 MzdhN2ZkNjBlMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIxLTEyLTEzICBHYWJy aWVsIE5hdmEgTWFyaW5vICA8Z25hdmFtYXJpbm9AYXBwbGUuY29tPgorCisgICAgICAgIEFkaGVy ZSB0byBEaXNwbGF5TGlzdCBpdGVyYXRvcidzIEFQSSBjb250cmFjdCBpbiBNZW1vcnlEaXNwbGF5 TGlzdDo6fkluTWVtb3J5RGlzcGxheUxpc3QoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjM0MjY0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgVGhlIGNsaWVudCBpcyBub3QgYWRoZWFyaW5nIHRvIHRoZSBE aXNwbGF5TGlzdCBJdGVyYXRvcidzIEFQSSBjb250cmFjdCBpbiBNZW1vcnlEaXNwbGF5TGlzdDo6 fkluTWVtb3J5RGlzcGxheUxpc3QoKToKKyAgICAgICAgIlBhcnQgb2YgdGhlIGl0ZXJhdG9yJ3Mg QVBJIGNvbnRyYWN0IGlzIHRoYXQgaWYgdGhlIGl0ZW0gaXMgbnVsbG9wdCwgeW91J3JlIG5vdCBh bGxvd2VkIHRvIGtlZXAKKyAgICAgICAgaXRlcmF0aW5nIC0gZG9pbmcgdGhpcyB3aWxsIGxlYWQg dG8gYW4gaW5maW5pdGUgbG9vcC4iCisKKyAgICAgICAgSGVyZSB3ZSBub3cgZG8gc28gYnkgYnJl YWtpbmcgb3V0IG9mIGl0ZXJhdGlvbiBpZiB0aGUgaXRlbSBpcyBudWxsb3B0LgorCisgICAgICAg ICogcGxhdGZvcm0vZ3JhcGhpY3MvZGlzcGxheWxpc3RzL0luTWVtb3J5RGlzcGxheUxpc3QuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6RGlzcGxheUxpc3Q6OkluTWVtb3J5RGlzcGxheUxpc3Q6On5J bk1lbW9yeURpc3BsYXlMaXN0KToKKwogMjAyMS0xMi0xMCAgQW50b2luZSBRdWludCAgPGdyYW91 dHNAd2Via2l0Lm9yZz4KIAogICAgICAgICBFeHBvc2UgdGhlIG1heGltdW0gZGV2aWNlIGZyYW1l IHJhdGUgdG8gdGhlIFdlYiBBbmltYXRpb25zIG1vZGVsCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9kaXNwbGF5bGlzdHMvSW5NZW1vcnlEaXNwbGF5TGlzdC5j cHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9kaXNwbGF5bGlzdHMvSW5NZW1v cnlEaXNwbGF5TGlzdC5jcHAKaW5kZXggOGViM2IyYmMwY2YxOWViMjMxOGU0NWE5ZTg2YTUxOTM5 NDQyMDBmMy4uODc4NjIxZWU3MWVhZjc2ZTBjOTRhNzg1MTFkMmJhY2I5OGIyZmFjNSAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZGlzcGxheWxpc3RzL0luTWVt b3J5RGlzcGxheUxpc3QuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2Rpc3BsYXlsaXN0cy9Jbk1lbW9yeURpc3BsYXlMaXN0LmNwcApAQCAtNjMsNiArNjMsOCBAQCBJ bk1lbW9yeURpc3BsYXlMaXN0Ojp+SW5NZW1vcnlEaXNwbGF5TGlzdCgpCiB7CiAgICAgYXV0byBl bmQgPSB0aGlzLT5lbmQoKTsKICAgICBmb3IgKGF1dG8gZGlzcGxheUxpc3RJdGVtIDogKnRoaXMp IHsKKyAgICAgICAgaWYgKCFkaXNwbGF5TGlzdEl0ZW0pCisgICAgICAgICAgICBicmVhazsKICAg ICAgICAgYXV0byBpdGVtID0gZGlzcGxheUxpc3RJdGVtLT5pdGVtOwogICAgICAgICBBU1NFUlQo aXRlbSk7CiAgICAgICAgIGlmICghaXRlbSkK