23426 2009-01-20 03:52:08 -0800 Frame Refactor: Move isFrameSet to Document 2009-02-04 05:40:46 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 zecke webkit-unassigned oldest_to_newest 106312 0 zecke 2009-01-20 03:52:08 -0800 Move isFrameSet to Document as commented in Frame.h. 106318 1 26856 zecke 2009-01-20 04:35:40 -0800 Created attachment 26856 Carry out the move I think the added null check (if correct) looks ugly and it would be a case for leaving isFrameSet in Frame. Test cases pass on the mac. 106800 2 26856 darin 2009-01-23 14:18:32 -0800 Comment on attachment 26856 Carry out the move > +bool Document::isFrameSet() const > +{ > + if (!isHTMLDocument()) > + return false; This should be a virtual function, then, and be overridden in HTMLDocument. That wasn't possible before when this was a function on Frame. I'll say r=me, but it would be better to do it that way 107818 3 27209 zecke 2009-01-30 19:23:23 -0800 Created attachment 27209 Make isFrameSet virtual Take Darin's comment into account and make isFrameSet virtual. Reimplement it in HTMLDocument (this patch is not tested). 107819 4 26856 zecke 2009-01-30 19:52:20 -0800 Comment on attachment 26856 Carry out the move Landed in r40443, leaving this bug open due the new patch. 108147 5 27209 sam 2009-02-03 13:06:45 -0800 Comment on attachment 27209 Make isFrameSet virtual r=me > +bool HTMLDocument::isFrameSet() const > +{ > + HTMLElement *bodyElement = body(); * should be on the other side. 108260 6 zecke 2009-02-04 05:40:46 -0800 Closing it. The style fix was included. 26856 2009-01-20 04:35:40 -0800 2009-01-30 19:52:20 -0800 Carry out the move 0001-Move-Frame-isFrameSet-to-Document-isFrameSet.patch text/plain 7437 zecke RnJvbSBmMDYzYmIwZDM2OTc1ZmJjZGMwNmJjOTlhZDhlNmYxYzIyYzY3NWI2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBIb2xnZXIgSGFucyBQZXRlciBGcmV5dGhlciA8emVja2VAc2Vs ZmlzaC5vcmc+CkRhdGU6IFdlZCwgMjQgRGVjIDIwMDggMjM6NDQ6NTcgKzAxMDAKU3ViamVjdDog W1BBVENIXSBNb3ZlIEZyYW1lOjppc0ZyYW1lU2V0IHRvIERvY3VtZW50Ojppc0ZyYW1lU2V0CgpD aGFuZ2VkIHRoZSBGcmFtZUxvYWRlciBjYWxsc2l0ZS4gSSBhc3N1bWUgdGhhdCBhcyB0aGlzCnBv aW50IG1fZnJhbWUuZG9jdW1lbnQoKSBtaWdodCByZXR1cm4gYSBudWxsIHBvaW50ZXIuIENoYW5n ZQp0aGUgY29uZGl0aW9uIHRvIGVpdGhlciBub3QgaGF2aW5nIGEgZG9jdW1lbnQgb3Igbm90IGhh dmluZyBhCmZyYW1lIHNldC4gVGhpcyBzaG91bGQgYmUgc2VtYW50aWNhbGx5IGVxdWl2YWxlbnQg dG8gdGhlCm9sZCBjb2RlLgoKTWFrZSBEb2N1bWVudDo6Ym9keSgpIGNvbnN0IHRvIGJlIGFibGUg dG8gY2FsbCBpdCBmcm9tIHdpdGhpbgpEb2N1bWVudDo6aXNGcmFtZVNldC4gTGVhdmUgdGhlIGlz SFRNTERvY3VtZW50KCkgY2hlY2sgYXMgdGhpcwppcyBhIHN0cm9uZ2VyIGNvbmRpdGlvbiB0aGFu IHNpbXBseSBoYXZpbmcgYSBIVE1MRWxlbWVudCBpbiB0aGUKRE9NLgotLS0KIFdlYkNvcmUvV2Vi Q29yZS5iYXNlLmV4cCAgICAgICAgICAgICAgICAgICAgICAgfCAgICA0ICsrLS0KIFdlYkNvcmUv ZG9tL0RvY3VtZW50LmNwcCAgICAgICAgICAgICAgICAgICAgICAgfCAgIDEwICsrKysrKysrKy0K IFdlYkNvcmUvZG9tL0RvY3VtZW50LmggICAgICAgICAgICAgICAgICAgICAgICAgfCAgICAzICsr LQogV2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkZXIuY3BwICAgICAgICAgICAgICAgICB8ICAgIDIg Ky0KIFdlYkNvcmUvbG9hZGVyL2FyY2hpdmUvY2YvTGVnYWN5V2ViQXJjaGl2ZS5jcHAgfCAgICAy ICstCiBXZWJDb3JlL3BhZ2UvRnJhbWUuY3BwICAgICAgICAgICAgICAgICAgICAgICAgIHwgICAg OSAtLS0tLS0tLS0KIFdlYkNvcmUvcGFnZS9GcmFtZS5oICAgICAgICAgICAgICAgICAgICAgICAg ICAgfCAgICA1IC0tLS0tCiBXZWJLaXQvbWFjL1dlYlZpZXcvV2ViRnJhbWUubW0gICAgICAgICAg ICAgICAgIHwgICAgMyArKy0KIFdlYktpdC9tYWMvV2ViVmlldy9XZWJIVE1MVmlldy5tbSAgICAg ICAgICAgICAgfCAgICAyICstCiA5IGZpbGVzIGNoYW5nZWQsIDE4IGluc2VydGlvbnMoKyksIDIy IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1dlYkNvcmUvV2ViQ29yZS5iYXNlLmV4cCBiL1dl YkNvcmUvV2ViQ29yZS5iYXNlLmV4cAppbmRleCAxZTllYWY3Li41YTA5MTVkIDEwMDY0NAotLS0g YS9XZWJDb3JlL1dlYkNvcmUuYmFzZS5leHAKKysrIGIvV2ViQ29yZS9XZWJDb3JlLmJhc2UuZXhw CkBAIC01NzEsNyArNTcxLDYgQEAgX19aTjdXZWJDb3JlOERvY3VtZW50MjJjcmVhdGVEb2N1bWVu dEZyYWdtZW50RXYKIF9fWk43V2ViQ29yZThEb2N1bWVudDIzcmVuZGVyZWRSZWN0c0Zvck1hcmtl cnNFTlNfMTREb2N1bWVudE1hcmtlcjEwTWFya2VyVHlwZUUKIF9fWk43V2ViQ29yZThEb2N1bWVu dDI0c2V0U2hvdWxkQ3JlYXRlUmVuZGVyZXJzRWIKIF9fWk43V2ViQ29yZThEb2N1bWVudDM2dXBk YXRlTGF5b3V0SWdub3JlUGVuZGluZ1N0eWxlc2hlZXRzRXYKLV9fWk43V2ViQ29yZThEb2N1bWVu dDRib2R5RXYKIF9fWk43V2ViQ29yZThEb2N1bWVudDRoZWFkRXYKIF9fWk43V2ViQ29yZThEcmFn RGF0YUMxRVAxMW9iamNfb2JqZWN0UktOU184SW50UG9pbnRFUzVfTlNfMTNEcmFnT3BlcmF0aW9u RVBOU18xNlBhc3RlYm9hcmRIZWxwZXJFCiBfX1pON1dlYkNvcmU4Rm9ybURhdGFEMUV2CkBAIC04 MTEsNyArODEwLDYgQEAgX19aTks3V2ViQ29yZTROb2RlOW5vZGVJbmRleEV2CiBfX1pOSzdXZWJD b3JlNFBhZ2UxMHBsdWdpbkRhdGFFdgogX19aTks3V2ViQ29yZTRQYWdlMzRpbkxvd1F1YWxpdHlJ bWFnZUludGVycG9sYXRpb25Nb2RlRXYKIF9fWk5LN1dlYkNvcmU0UGFnZTlncm91cE5hbWVFdgot X19aTks3V2ViQ29yZTVGcmFtZTEwaXNGcmFtZVNldEV2CiBfX1pOSzdXZWJDb3JlNUZyYW1lMTFj dXJyZW50Rm9ybUV2CiBfX1pOSzdXZWJDb3JlNUZyYW1lMTF0eXBpbmdTdHlsZUV2CiBfX1pOSzdX ZWJDb3JlNUZyYW1lMTJldmVudEhhbmRsZXJFdgpAQCAtODgwLDYgKzg3OCw4IEBAIF9fWk5LN1dl YkNvcmU4RG9jdW1lbnQxMWNvbXBsZXRlVVJMRVJLTlNfNlN0cmluZ0UKIF9fWk5LN1dlYkNvcmU4 RG9jdW1lbnQxM2F4T2JqZWN0Q2FjaGVFdgogX19aTks3V2ViQ29yZThEb2N1bWVudDIwY2FjaGVE b2N1bWVudEVsZW1lbnRFdgogX19aTks3V2ViQ29yZThEb2N1bWVudDZkb21haW5FdgorX19aTks3 V2ViQ29yZThEb2N1bWVudDRib2R5RXYKK19fWk5LN1dlYkNvcmU4RG9jdW1lbnQxMGlzRnJhbWVT ZXRFdgogX19aTks3V2ViQ29yZThJbnRQb2ludGN2OF9OU1BvaW50RXYKIF9fWk5LN1dlYkNvcmU4 UG9zaXRpb24xMGRvd25zdHJlYW1FdgogX19aTks3V2ViQ29yZThQb3NpdGlvbjI1bGVhZGluZ1do aXRlc3BhY2VQb3NpdGlvbkVOU185RUFmZmluaXR5RWIKZGlmZiAtLWdpdCBhL1dlYkNvcmUvZG9t L0RvY3VtZW50LmNwcCBiL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcAppbmRleCA4YzFiYjk0Li5m ZmQyMzBlIDEwMDY0NAotLS0gYS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAKKysrIGIvV2ViQ29y ZS9kb20vRG9jdW1lbnQuY3BwCkBAIC0xMDM1LDYgKzEwMzUsMTQgQEAgTm9kZTo6Tm9kZVR5cGUg RG9jdW1lbnQ6Om5vZGVUeXBlKCkgY29uc3QKICAgICByZXR1cm4gRE9DVU1FTlRfTk9ERTsKIH0K IAorYm9vbCBEb2N1bWVudDo6aXNGcmFtZVNldCgpIGNvbnN0Cit7CisgICAgaWYgKCFpc0hUTUxE b2N1bWVudCgpKQorICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgSFRNTEVsZW1lbnQgKmJvZHlF bGVtZW50ID0gYm9keSgpOworICAgIHJldHVybiBib2R5RWxlbWVudCAmJiBib2R5RWxlbWVudC0+ cmVuZGVyZXIoKSAmJiBib2R5RWxlbWVudC0+aGFzVGFnTmFtZShmcmFtZXNldFRhZyk7Cit9CisK IEZyYW1lVmlldyogRG9jdW1lbnQ6OnZpZXcoKSBjb25zdAogewogICAgIHJldHVybiBtX2ZyYW1l ID8gbV9mcmFtZS0+dmlldygpIDogMDsKQEAgLTE0NjUsNyArMTQ3Myw3IEBAIHZvaWQgRG9jdW1l bnQ6OmltcGxpY2l0T3BlbigpCiAgICAgc2V0UGFyc2luZyh0cnVlKTsKIH0KIAotSFRNTEVsZW1l bnQqIERvY3VtZW50Ojpib2R5KCkKK0hUTUxFbGVtZW50KiBEb2N1bWVudDo6Ym9keSgpIGNvbnN0 CiB7CiAgICAgTm9kZSogZGUgPSBkb2N1bWVudEVsZW1lbnQoKTsKICAgICBpZiAoIWRlKQpkaWZm IC0tZ2l0IGEvV2ViQ29yZS9kb20vRG9jdW1lbnQuaCBiL1dlYkNvcmUvZG9tL0RvY3VtZW50LmgK aW5kZXggOTNiMTBjMS4uOTgwNWJhMiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9kb20vRG9jdW1lbnQu aAorKysgYi9XZWJDb3JlL2RvbS9Eb2N1bWVudC5oCkBAIC0zMTMsNiArMzEzLDcgQEAgcHVibGlj OgogI2lmIEVOQUJMRShXTUwpCiAgICAgdmlydHVhbCBib29sIGlzV01MRG9jdW1lbnQoKSBjb25z dCB7IHJldHVybiBmYWxzZTsgfQogI2VuZGlmCisgICAgYm9vbCBpc0ZyYW1lU2V0KCkgY29uc3Q7 CiAgICAgCiAgICAgQ1NTU3R5bGVTZWxlY3Rvciogc3R5bGVTZWxlY3RvcigpIGNvbnN0IHsgcmV0 dXJuIG1fc3R5bGVTZWxlY3RvcjsgfQogCkBAIC02ODEsNyArNjgyLDcgQEAgcHVibGljOgogICAg IHZvaWQgcmVtb3ZlSW1hZ2VNYXAoSFRNTE1hcEVsZW1lbnQqKTsKICAgICBIVE1MTWFwRWxlbWVu dCogZ2V0SW1hZ2VNYXAoY29uc3QgU3RyaW5nJiB1cmwpIGNvbnN0OwogCi0gICAgSFRNTEVsZW1l bnQqIGJvZHkoKTsKKyAgICBIVE1MRWxlbWVudCogYm9keSgpIGNvbnN0OwogICAgIHZvaWQgc2V0 Qm9keShQYXNzUmVmUHRyPEhUTUxFbGVtZW50PiwgRXhjZXB0aW9uQ29kZSYpOwogCiAgICAgSFRN TEhlYWRFbGVtZW50KiBoZWFkKCk7CmRpZmYgLS1naXQgYS9XZWJDb3JlL2xvYWRlci9GcmFtZUxv YWRlci5jcHAgYi9XZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRlci5jcHAKaW5kZXggNGJiMWI4OS4u NTZlZDQzYiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkZXIuY3BwCisrKyBi L1dlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcApAQCAtMzg3OCw3ICszODc4LDcgQEAgYm9v bCBGcmFtZUxvYWRlcjo6c2hvdWxkU2Nyb2xsVG9BbmNob3IoYm9vbCBpc0Zvcm1TdWJtaXNzaW9u LCBGcmFtZUxvYWRUeXBlIGxvYWQKICAgICAgICAgJiYgIXNob3VsZFJlbG9hZCh0aGlzLT51cmwo KSwgdXJsKQogICAgICAgICAvLyBXZSBkb24ndCB3YW50IHRvIGp1c3Qgc2Nyb2xsIGlmIGEgbGlu ayBmcm9tIHdpdGhpbiBhCiAgICAgICAgIC8vIGZyYW1lc2V0IGlzIHRyeWluZyB0byByZWxvYWQg dGhlIGZyYW1lc2V0IGludG8gX3RvcC4KLSAgICAgICAgJiYgIW1fZnJhbWUtPmlzRnJhbWVTZXQo KTsKKyAgICAgICAgJiYgKCFtX2ZyYW1lLT5kb2N1bWVudCgpIHx8ICFtX2ZyYW1lLT5kb2N1bWVu dCgpLT5pc0ZyYW1lU2V0KCkpOwogfQogCiB2b2lkIEZyYW1lTG9hZGVyOjpvcGVuZWQoKQpkaWZm IC0tZ2l0IGEvV2ViQ29yZS9sb2FkZXIvYXJjaGl2ZS9jZi9MZWdhY3lXZWJBcmNoaXZlLmNwcCBi L1dlYkNvcmUvbG9hZGVyL2FyY2hpdmUvY2YvTGVnYWN5V2ViQXJjaGl2ZS5jcHAKaW5kZXggNTQ0 OTBkNC4uZTZiYjNlZiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9sb2FkZXIvYXJjaGl2ZS9jZi9MZWdh Y3lXZWJBcmNoaXZlLmNwcAorKysgYi9XZWJDb3JlL2xvYWRlci9hcmNoaXZlL2NmL0xlZ2FjeVdl YkFyY2hpdmUuY3BwCkBAIC01NjcsNyArNTY3LDcgQEAgUGFzc1JlZlB0cjxMZWdhY3lXZWJBcmNo aXZlPiBMZWdhY3lXZWJBcmNoaXZlOjpjcmVhdGVGcm9tU2VsZWN0aW9uKEZyYW1lKiBmcmFtZSkK ICAgICAKICAgICBSZWZQdHI8TGVnYWN5V2ViQXJjaGl2ZT4gYXJjaGl2ZSA9IGNyZWF0ZShtYXJr dXBTdHJpbmcsIGZyYW1lLCBub2RlTGlzdCk7CiAgICAgCi0gICAgaWYgKCFmcmFtZS0+aXNGcmFt ZVNldCgpKSAKKyAgICBpZiAoIWZyYW1lLT5kb2N1bWVudCgpIHx8ICFmcmFtZS0+ZG9jdW1lbnQo KS0+aXNGcmFtZVNldCgpKQogICAgICAgICByZXR1cm4gYXJjaGl2ZS5yZWxlYXNlKCk7CiAgICAg ICAgIAogICAgIC8vIFdyYXAgdGhlIGZyYW1lc2V0IGRvY3VtZW50IGluIGFuIGlmcmFtZSBzbyBp dCBjYW4gYmUgcGFzdGVkIGludG8KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGFnZS9GcmFtZS5jcHAg Yi9XZWJDb3JlL3BhZ2UvRnJhbWUuY3BwCmluZGV4IDIzM2E1MzguLjNiNzg3NjggMTAwNjQ0Ci0t LSBhL1dlYkNvcmUvcGFnZS9GcmFtZS5jcHAKKysrIGIvV2ViQ29yZS9wYWdlL0ZyYW1lLmNwcApA QCAtMTIxMSwxNSArMTIxMSw2IEBAIHZvaWQgRnJhbWU6OnNlbGVjdGlvblRleHRSZWN0cyhWZWN0 b3I8RmxvYXRSZWN0PiYgcmVjdHMsIGJvb2wgY2xpcFRvVmlzaWJsZUNvbnRlCiB9CiAKIAotYm9v bCBGcmFtZTo6aXNGcmFtZVNldCgpIGNvbnN0Ci17Ci0gICAgRG9jdW1lbnQqIGRvY3VtZW50ID0g bV9kb2MuZ2V0KCk7Ci0gICAgaWYgKCFkb2N1bWVudCB8fCAhZG9jdW1lbnQtPmlzSFRNTERvY3Vt ZW50KCkpCi0gICAgICAgIHJldHVybiBmYWxzZTsKLSAgICBOb2RlICpib2R5ID0gc3RhdGljX2Nh c3Q8SFRNTERvY3VtZW50Kj4oZG9jdW1lbnQpLT5ib2R5KCk7Ci0gICAgcmV0dXJuIGJvZHkgJiYg Ym9keS0+cmVuZGVyZXIoKSAmJiBib2R5LT5oYXNUYWdOYW1lKGZyYW1lc2V0VGFnKTsKLX0KLQog Ly8gU2NhbnMgbG9naWNhbGx5IGZvcndhcmQgZnJvbSAic3RhcnQiLCBpbmNsdWRpbmcgYW55IGNo aWxkIGZyYW1lcwogc3RhdGljIEhUTUxGb3JtRWxlbWVudCAqc2NhbkZvckZvcm0oTm9kZSAqc3Rh cnQpCiB7CmRpZmYgLS1naXQgYS9XZWJDb3JlL3BhZ2UvRnJhbWUuaCBiL1dlYkNvcmUvcGFnZS9G cmFtZS5oCmluZGV4IDIxZDJjODMuLjFmYzk0ODUgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGFnZS9G cmFtZS5oCisrKyBiL1dlYkNvcmUvcGFnZS9GcmFtZS5oCkBAIC0xNzIsMTEgKzE3Miw2IEBAIHB1 YmxpYzoKIHByaXZhdGU6CiAgICAgdm9pZCBsaWZlU3VwcG9ydFRpbWVyRmlyZWQoVGltZXI8RnJh bWU+Kik7CiAKLS8vID09PSB0byBiZSBtb3ZlZCBpbnRvIERvY3VtZW50Ci0KLXB1YmxpYzoKLSAg ICBib29sIGlzRnJhbWVTZXQoKSBjb25zdDsKLQogLy8gPT09IHRvIGJlIG1vdmVkIGludG8gRXZl bnRIYW5kbGVyCiAKIHB1YmxpYzoKZGlmZiAtLWdpdCBhL1dlYktpdC9tYWMvV2ViVmlldy9XZWJG cmFtZS5tbSBiL1dlYktpdC9tYWMvV2ViVmlldy9XZWJGcmFtZS5tbQppbmRleCBhODAwMGQ3Li42 YzU2OGE0IDEwMDY0NAotLS0gYS9XZWJLaXQvbWFjL1dlYlZpZXcvV2ViRnJhbWUubW0KKysrIGIv V2ViS2l0L21hYy9XZWJWaWV3L1dlYkZyYW1lLm1tCkBAIC0xMDk5LDcgKzEwOTksOCBAQCBzdGF0 aWMgaW5saW5lIFdlYkRhdGFTb3VyY2UgKmRhdGFTb3VyY2UoRG9jdW1lbnRMb2FkZXIqIGxvYWRl cikKIAogLSAoQk9PTClfaXNGcmFtZVNldAogewotICAgIHJldHVybiBfcHJpdmF0ZS0+Y29yZUZy YW1lLT5pc0ZyYW1lU2V0KCk7CisgICAgRG9jdW1lbnQqIGRvY3VtZW50ID0gX3ByaXZhdGUtPmNv cmVGcmFtZS0+ZG9jdW1lbnQoKTsKKyAgICByZXR1cm4gZG9jdW1lbnQgJiYgZG9jdW1lbnQtPmlz RnJhbWVTZXQoKTsKIH0KIAogLSAoQk9PTClfZmlyc3RMYXlvdXREb25lCmRpZmYgLS1naXQgYS9X ZWJLaXQvbWFjL1dlYlZpZXcvV2ViSFRNTFZpZXcubW0gYi9XZWJLaXQvbWFjL1dlYlZpZXcvV2Vi SFRNTFZpZXcubW0KaW5kZXggYmU0ZDhkYi4uNmYzZWUyZCAxMDA2NDQKLS0tIGEvV2ViS2l0L21h Yy9XZWJWaWV3L1dlYkhUTUxWaWV3Lm1tCisrKyBiL1dlYktpdC9tYWMvV2ViVmlldy9XZWJIVE1M Vmlldy5tbQpAQCAtMzU0OCw3ICszNTQ4LDcgQEAgbm9Qcm9taXNlZERhdGE6CiAgICAgRnJhbWUq IGZyYW1lID0gY29yZShbc2VsZiBfZnJhbWVdKTsKICAgICBpZiAoIWZyYW1lKQogICAgICAgICBy ZXR1cm4gTk87Ci0gICAgaWYgKCFmcmFtZS0+aXNGcmFtZVNldCgpKSB7CisgICAgaWYgKCFmcmFt ZS0+ZG9jdW1lbnQoKSB8fCAhZnJhbWUtPmRvY3VtZW50KCktPmlzRnJhbWVTZXQoKSkgewogICAg ICAgICBmbG9hdCBwYXBlcldpZHRoID0gW3NlbGYgX2F2YWlsYWJsZVBhcGVyV2lkdGhGb3JQcmlu dE9wZXJhdGlvbjpbTlNQcmludE9wZXJhdGlvbiBjdXJyZW50T3BlcmF0aW9uXV07CiAgICAgICAg IG1pbkxheW91dFdpZHRoID0gcGFwZXJXaWR0aCAqIFByaW50aW5nTWluaW11bVNocmlua0ZhY3Rv cjsKICAgICAgICAgbWF4TGF5b3V0V2lkdGggPSBwYXBlcldpZHRoICogUHJpbnRpbmdNYXhpbXVt U2hyaW5rRmFjdG9yOwotLSAKMS42LjAuMgoK 27209 2009-01-30 19:23:23 -0800 2009-02-03 13:06:45 -0800 Make isFrameSet virtual foo.diff text/plain 2702 zecke ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MTcyYmRkYS4uNjM4ZmRkNSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwyMSBAQAogMjAwOS0wMS0zMCAgSG9sZ2VyIEhhbnMg UGV0ZXIgRnJleXRoZXIgIDx6ZWNrZUBzZWxmaXNoLm9yZz4KIAorICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjM0MjYKKworICAgICAgICBNYWtlIGlzRnJhbWVTZXQgdmlydHVhbCBhbmQg YnkgZGVmYXVsdCByZXR1cm4gZmFsc2UuIFJlaW1wbGVtZW50CisgICAgICAgIGl0IGluIEhUTUxE b2N1bWVudC4KKworICAgICAgICAqIGRvbS9Eb2N1bWVudC5jcHA6CisgICAgICAgICogZG9tL0Rv Y3VtZW50Lmg6CisgICAgICAgIChXZWJDb3JlOjpEb2N1bWVudDo6aXNGcmFtZVNldCk6CisgICAg ICAgICogaHRtbC9IVE1MRG9jdW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTERvY3Vt ZW50Ojppc0ZyYW1lU2V0KToKKyAgICAgICAgKiBodG1sL0hUTUxEb2N1bWVudC5oOgorCisyMDA5 LTAxLTMwICBIb2xnZXIgSGFucyBQZXRlciBGcmV5dGhlciAgPHplY2tlQHNlbGZpc2gub3JnPgor CiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgogCiAgICAgICAgIE1vdmUgRnJhbWU6 OmlzRnJhbWVTZXQgdG8gRG9jdW1lbnQ6OmlzRnJhbWVTZXQKZGlmZiAtLWdpdCBhL1dlYkNvcmUv ZG9tL0RvY3VtZW50LmNwcCBiL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcAppbmRleCAzYzViNzU5 Li43YWEwODQ4IDEwMDY0NAotLS0gYS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAKKysrIGIvV2Vi Q29yZS9kb20vRG9jdW1lbnQuY3BwCkBAIC0xMDM1LDE0ICsxMDM1LDYgQEAgTm9kZTo6Tm9kZVR5 cGUgRG9jdW1lbnQ6Om5vZGVUeXBlKCkgY29uc3QKICAgICByZXR1cm4gRE9DVU1FTlRfTk9ERTsK IH0KIAotYm9vbCBEb2N1bWVudDo6aXNGcmFtZVNldCgpIGNvbnN0Ci17Ci0gICAgaWYgKCFpc0hU TUxEb2N1bWVudCgpKQotICAgICAgICByZXR1cm4gZmFsc2U7Ci0gICAgSFRNTEVsZW1lbnQgKmJv ZHlFbGVtZW50ID0gYm9keSgpOwotICAgIHJldHVybiBib2R5RWxlbWVudCAmJiBib2R5RWxlbWVu dC0+cmVuZGVyZXIoKSAmJiBib2R5RWxlbWVudC0+aGFzVGFnTmFtZShmcmFtZXNldFRhZyk7Ci19 Ci0KIEZyYW1lVmlldyogRG9jdW1lbnQ6OnZpZXcoKSBjb25zdAogewogICAgIHJldHVybiBtX2Zy YW1lID8gbV9mcmFtZS0+dmlldygpIDogMDsKZGlmZiAtLWdpdCBhL1dlYkNvcmUvZG9tL0RvY3Vt ZW50LmggYi9XZWJDb3JlL2RvbS9Eb2N1bWVudC5oCmluZGV4IDkxYjA0OWQuLjUwNmNhOTQgMTAw NjQ0Ci0tLSBhL1dlYkNvcmUvZG9tL0RvY3VtZW50LmgKKysrIGIvV2ViQ29yZS9kb20vRG9jdW1l bnQuaApAQCAtMzE0LDcgKzMxNCw3IEBAIHB1YmxpYzoKICNpZiBFTkFCTEUoV01MKQogICAgIHZp cnR1YWwgYm9vbCBpc1dNTERvY3VtZW50KCkgY29uc3QgeyByZXR1cm4gZmFsc2U7IH0KICNlbmRp ZgotICAgIGJvb2wgaXNGcmFtZVNldCgpIGNvbnN0OworICAgIHZpcnR1YWwgYm9vbCBpc0ZyYW1l U2V0KCkgY29uc3QgeyByZXR1cm4gZmFsc2U7IH0KICAgICAKICAgICBDU1NTdHlsZVNlbGVjdG9y KiBzdHlsZVNlbGVjdG9yKCkgY29uc3QgeyByZXR1cm4gbV9zdHlsZVNlbGVjdG9yOyB9CiAKZGlm ZiAtLWdpdCBhL1dlYkNvcmUvaHRtbC9IVE1MRG9jdW1lbnQuY3BwIGIvV2ViQ29yZS9odG1sL0hU TUxEb2N1bWVudC5jcHAKaW5kZXggMDQ3MTZiZi4uODg1YzJiNiAxMDA2NDQKLS0tIGEvV2ViQ29y ZS9odG1sL0hUTUxEb2N1bWVudC5jcHAKKysrIGIvV2ViQ29yZS9odG1sL0hUTUxEb2N1bWVudC5j cHAKQEAgLTQyMSw1ICs0MjEsMTEgQEAgdm9pZCBIVE1MRG9jdW1lbnQ6OmNsZWFyKCkKICAgICAv LyBXZSd2ZSBsb25nIGhhZCBhIGNvbW1lbnQgc2F5aW5nIHRoYXQgSUUgZG9lc24ndCBzdXBwb3J0 IHRoaXMuCiAgICAgLy8gQnV0IEkgZG8gc2VlIGl0IGluIHRoZSBkb2N1bWVudGF0aW9uIGZvciBN b3ppbGxhLgogfQotICAgIAorCitib29sIEhUTUxEb2N1bWVudDo6aXNGcmFtZVNldCgpIGNvbnN0 Cit7CisgICAgSFRNTEVsZW1lbnQgKmJvZHlFbGVtZW50ID0gYm9keSgpOworICAgIHJldHVybiBi b2R5RWxlbWVudCAmJiBib2R5RWxlbWVudC0+cmVuZGVyZXIoKSAmJiBib2R5RWxlbWVudC0+aGFz VGFnTmFtZShmcmFtZXNldFRhZyk7Cit9CisgCiB9CmRpZmYgLS1naXQgYS9XZWJDb3JlL2h0bWwv SFRNTERvY3VtZW50LmggYi9XZWJDb3JlL2h0bWwvSFRNTERvY3VtZW50LmgKaW5kZXggZGU4NGM3 MC4uYWI1ZGE1MCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9odG1sL0hUTUxEb2N1bWVudC5oCisrKyBi L1dlYkNvcmUvaHRtbC9IVE1MRG9jdW1lbnQuaApAQCAtODgsNiArODgsNyBAQCBwcm90ZWN0ZWQ6 CiAKIHByaXZhdGU6CiAgICAgdmlydHVhbCBib29sIGlzSFRNTERvY3VtZW50KCkgY29uc3QgeyBy ZXR1cm4gdHJ1ZTsgfQorICAgIHZpcnR1YWwgYm9vbCBpc0ZyYW1lU2V0KCkgY29uc3Q7CiAgICAg dmlydHVhbCBUb2tlbml6ZXIqIGNyZWF0ZVRva2VuaXplcigpOwogICAgIHZpcnR1YWwgdm9pZCBk ZXRlcm1pbmVQYXJzZU1vZGUoKTsKIAo=