23425 2009-01-19 16:58:52 -0800 Clean up setShouldAntialias/setUseAntialiasing on GraphicsContext 2009-01-20 13:01:29 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Mac OS X 10.5 RESOLVED INVALID P2 Normal --- 1 simon.fraser rwlbuis darin eric oldest_to_newest 106293 0 simon.fraser 2009-01-19 16:58:52 -0800 The patch for bug 16182 added GraphicsContext::setUseAntialiasing(). However, GraphicsContexet already has: void setShouldAntialias(bool); bool shouldAntialias() const; so now we have 2 antialiasing methods. This needs cleaning up. 106310 1 rwlbuis 2009-01-19 23:40:13 -0800 Hi Simon, (In reply to comment #0) > The patch for bug 16182 added GraphicsContext::setUseAntialiasing(). However, > GraphicsContexet already has: > > void setShouldAntialias(bool); > bool shouldAntialias() const; > > so now we have 2 antialiasing methods. This needs cleaning up. Ok, I'll have a look tonight. Cheers, Rob. 106374 2 rwlbuis 2009-01-20 12:55:36 -0800 Hi Simon, (In reply to comment #0) > The patch for bug 16182 added GraphicsContext::setUseAntialiasing(). However, > GraphicsContexet already has: > > void setShouldAntialias(bool); > bool shouldAntialias() const; > > so now we have 2 antialiasing methods. This needs cleaning up. Now that I looked at it, setUseAntialiasing is gone! It was removed in the same patch that added setShouldAntialias .Also the shape-rendering.svg test still works fine, so I think this report can be closed. Cheers, Rob. PS: I do see setUseAntialiasing mentioned in WebCore/WebCore.order, but I am not sure in what context that is important? 106376 3 darin 2009-01-20 12:59:44 -0800 (In reply to comment #2) > PS: I do see setUseAntialiasing mentioned in WebCore/WebCore.order, but I am > not sure in what context that is important? That’s a file used to optimize performance on Mac OS X that has to be regenerated from time to time by actually testing some usage scenarios. It’s quite out of date at the moment. There’s no harm in having it mention a function that doesn’t exist. 106377 4 simon.fraser 2009-01-20 13:01:29 -0800 OK, sorry about filing this. I was confused by a conflict I had with some local changes. I think we're all good.