234241 2021-12-13 06:31:17 -0800 Missing includes in SessionStorage breaks non-unified builds 2021-12-14 03:17:20 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED INVALID P2 Normal --- 1 clord clord cdumez sihui_liu oldest_to_newest 1823511 0 clord 2021-12-13 06:31:17 -0800 I actually hit this in unified builds after making small, unrelated changes, but presumably it also breaks non-unified builds. SessionStorage.h is missing a couple of includes. 1823512 1 447000 clord 2021-12-13 06:34:28 -0800 Created attachment 447000 Patch 1823520 2 447000 cdumez 2021-12-13 07:22:12 -0800 Comment on attachment 447000 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=447000&action=review > Source/WebKit/NetworkProcess/storage/SessionStorageManager.h:31 > +#include <WebCore/ClientOrigin.h> Should likely be a forward declaration. 1823570 3 447015 clord 2021-12-13 09:14:14 -0800 Created attachment 447015 Patch 1823954 4 clord 2021-12-14 03:17:20 -0800 This was fixed by unreviewed change https://trac.webkit.org/changeset/286946/webkit 447000 2021-12-13 06:34:28 -0800 2021-12-13 09:14:10 -0800 Patch bug-234241-20211213143427.patch text/plain 1289 clord U3VidmVyc2lvbiBSZXZpc2lvbjogMjg2OTQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGNhOTY1M2EzOGIxYTRkMDBj NTNjYjNjMzBiNjQ5MWZiZTE5MTRlY2IuLmFhYjc4NWUyMjkzYzU4NjNjY2ViMWM0YTg4NjQ4YmQ5 YTllZGVhMjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMjEtMTItMTMgIENocmlzIExv cmQgIDxjbG9yZEBpZ2FsaWEuY29tPgorCisgICAgICAgIE1pc3NpbmcgaW5jbHVkZXMgaW4gU2Vz c2lvblN0b3JhZ2UgYnJlYWtzIG5vbi11bmlmaWVkIGJ1aWxkcworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjM0MjQxCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIG1pc3NpbmcgQ29ubmVjdGlvbi5oIGFu ZCBXZWJDb3JlL0NsaWVudE9yaWdpbi5oIHRvCisgICAgICAgIFNlc3Npb25TdG9yYWdlTWFuYWdl ci5oLgorCisgICAgICAgICogTmV0d29ya1Byb2Nlc3Mvc3RvcmFnZS9TZXNzaW9uU3RvcmFnZU1h bmFnZXIuaDoKKwogMjAyMS0xMi0xMyAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+ CiAKICAgICAgICAgRml4IFNlcnZpY2VXb3JrZXIgZG93bmxvYWRzCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL3N0b3JhZ2UvU2Vzc2lvblN0b3JhZ2VNYW5hZ2VyLmgg Yi9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL3N0b3JhZ2UvU2Vzc2lvblN0b3JhZ2VNYW5h Z2VyLmgKaW5kZXggMzM3Y2JkODk3YTE1MGVlZTIyZWI3MjgwZWU1MmQwMjRkZGM1NTVmZS4uMDg4 YWI0MTNjYjQ5MzEwODA0OWQ2OGZmYmEwNTlmYzA5MGIyNjNmOCAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9zdG9yYWdlL1Nlc3Npb25TdG9yYWdlTWFuYWdlci5oCisr KyBiL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3Mvc3RvcmFnZS9TZXNzaW9uU3RvcmFnZU1h bmFnZXIuaApAQCAtMjUsOCArMjUsMTAgQEAKIAogI3ByYWdtYSBvbmNlCiAKKyNpbmNsdWRlICJD b25uZWN0aW9uLmgiCiAjaW5jbHVkZSAiU3RvcmFnZUFyZWFJZGVudGlmaWVyLmgiCiAjaW5jbHVk ZSAiU3RvcmFnZU5hbWVzcGFjZUlkZW50aWZpZXIuaCIKKyNpbmNsdWRlIDxXZWJDb3JlL0NsaWVu dE9yaWdpbi5oPgogCiBuYW1lc3BhY2UgV2ViS2l0IHsKIAo= 447015 2021-12-13 09:14:14 -0800 2021-12-13 09:14:35 -0800 Patch bug-234241-20211213171413.patch text/plain 1328 clord U3VidmVyc2lvbiBSZXZpc2lvbjogMjg2OTQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGNhOTY1M2EzOGIxYTRkMDBj NTNjYjNjMzBiNjQ5MWZiZTE5MTRlY2IuLmFhYjc4NWUyMjkzYzU4NjNjY2ViMWM0YTg4NjQ4YmQ5 YTllZGVhMjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMjEtMTItMTMgIENocmlzIExv cmQgIDxjbG9yZEBpZ2FsaWEuY29tPgorCisgICAgICAgIE1pc3NpbmcgaW5jbHVkZXMgaW4gU2Vz c2lvblN0b3JhZ2UgYnJlYWtzIG5vbi11bmlmaWVkIGJ1aWxkcworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjM0MjQxCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIG1pc3NpbmcgQ29ubmVjdGlvbi5oIGFu ZCBXZWJDb3JlL0NsaWVudE9yaWdpbi5oIHRvCisgICAgICAgIFNlc3Npb25TdG9yYWdlTWFuYWdl ci5oLgorCisgICAgICAgICogTmV0d29ya1Byb2Nlc3Mvc3RvcmFnZS9TZXNzaW9uU3RvcmFnZU1h bmFnZXIuaDoKKwogMjAyMS0xMi0xMyAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+ CiAKICAgICAgICAgRml4IFNlcnZpY2VXb3JrZXIgZG93bmxvYWRzCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL3N0b3JhZ2UvU2Vzc2lvblN0b3JhZ2VNYW5hZ2VyLmgg Yi9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL3N0b3JhZ2UvU2Vzc2lvblN0b3JhZ2VNYW5h Z2VyLmgKaW5kZXggMzM3Y2JkODk3YTE1MGVlZTIyZWI3MjgwZWU1MmQwMjRkZGM1NTVmZS4uZDMx MjI2M2I3MDhmYjhjMjk2OGVjNjMwMTVjNTU5NmJmYjFmYWZhMiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9zdG9yYWdlL1Nlc3Npb25TdG9yYWdlTWFuYWdlci5oCisr KyBiL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3Mvc3RvcmFnZS9TZXNzaW9uU3RvcmFnZU1h bmFnZXIuaApAQCAtMjUsOSArMjUsMTQgQEAKIAogI3ByYWdtYSBvbmNlCiAKKyNpbmNsdWRlICJD b25uZWN0aW9uLmgiCiAjaW5jbHVkZSAiU3RvcmFnZUFyZWFJZGVudGlmaWVyLmgiCiAjaW5jbHVk ZSAiU3RvcmFnZU5hbWVzcGFjZUlkZW50aWZpZXIuaCIKIAorbmFtZXNwYWNlIFdlYkNvcmUgewor c3RydWN0IENsaWVudE9yaWdpbjsKK30KKwogbmFtZXNwYWNlIFdlYktpdCB7CiAKIGNsYXNzIE1l bW9yeVN0b3JhZ2VBcmVhOwo=