234239 2021-12-13 05:15:24 -0800 [GTK] build fails with undefined symbol in ANGLE if USE_ANGLE_WEBGL is enabled. 2021-12-21 05:31:17 -0800 1 1 1 Unclassified WebKit ANGLE WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=234293 InRadar P2 Normal --- 1 crzwdjk crzwdjk annulen aperez clord dino don.olmstead ews-watchlist fujii gyuyoung.kim kbr kkinnunen kondapallykalyan ryuan.choi sergio webkit-bug-importer oldest_to_newest 1823485 0 crzwdjk 2021-12-13 05:15:24 -0800 After the recent update of ANGLE, enabling USE_ANGLE_WEBGL on Linux platforms results in the build failing with "undefined reference to 'angle::DrmFourCCFormatToGLInternalFormat(int, bool*)'" because the Source/ThirdParty/ANGLE/src/common/linux/ directory doesn't get built. 1823489 1 446992 crzwdjk 2021-12-13 05:20:34 -0800 Created attachment 446992 Patch 1823490 2 ews-watchlist 2021-12-13 05:21:20 -0800 Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE 1823508 3 446992 clord 2021-12-13 06:26:25 -0800 Comment on attachment 446992 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=446992&action=review LGTM, with one noted change. > Source/ThirdParty/ANGLE/GL.cmake:237 > +if (is_android OR is_linux OR is_chromeos) > + list(APPEND _gl_backend_sources > + "src/common/linux/dma_buf_utils.cpp" > + "src/common/linux/dma_buf_utils.h" > + ) > +endif() Why not add these to the existing block at line 127? 1823709 4 447047 crzwdjk 2021-12-13 13:12:00 -0800 Created attachment 447047 Patch 1823710 5 447048 crzwdjk 2021-12-13 13:14:58 -0800 Created attachment 447048 Patch 1823856 6 447048 fujii 2021-12-13 17:45:30 -0800 Comment on attachment 447048 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=447048&action=review > Source/ThirdParty/ANGLE/GL.cmake:156 > + "src/common/linux/dma_buf_utils.h" I think you shouldn't edit GL.cmake because it is genereated by gni-to-cmake.py. 1823957 7 clord 2021-12-14 03:49:54 -0800 (In reply to Fujii Hironori from comment #6) > Comment on attachment 447048 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=447048&action=review > > > Source/ThirdParty/ANGLE/GL.cmake:156 > > + "src/common/linux/dma_buf_utils.h" > > I think you shouldn't edit GL.cmake because it is genereated by > gni-to-cmake.py. It's hand-edited after the generation, I think given the coarseness of this tool and that this file is already hand-edited (re-running the listed command at the top of the file generates a different file), it's reasonable to add this manually. The current script isn't sophisticated enough to interpret the build file in src/common/linux (in fact, it currently just strips out that definition entirely, so using the script generates an empty file). 1823985 8 crzwdjk 2021-12-14 07:03:54 -0800 I guess what I had in the back of my mind when I added the stuff in a separate block is that the other blocks were auto-generated, and this one is manually added and thus easier to merge with the auto-generated stuff. Maybe I should put a comment in to that effect as well? I honestly am not that familiar with the process of importing ANGLE and converting the build scripts so I am not sure what the right approach is and I am glad we are having this discussion. 1823993 9 clord 2021-12-14 07:31:40 -0800 (In reply to Arcady Goldmints-Orlov from comment #8) > I guess what I had in the back of my mind when I added the stuff in a > separate block is that the other blocks were auto-generated, and this one is > manually added and thus easier to merge with the auto-generated stuff. Maybe > I should put a comment in to that effect as well? I honestly am not that > familiar with the process of importing ANGLE and converting the build > scripts so I am not sure what the right approach is and I am glad we are > having this discussion. That sounds reasonable to me - I guess if we really don't want to touch the auto-generated files, it could be a separate file or included in PlatformGTK. These build files and the process of generating them doesn't really seem to be so involved that we should be worrying too much about this, imho. 1824063 10 447048 don.olmstead 2021-12-14 11:56:26 -0800 Comment on attachment 447048 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=447048&action=review >>> Source/ThirdParty/ANGLE/GL.cmake:156 >>> + "src/common/linux/dma_buf_utils.h" >> >> I think you shouldn't edit GL.cmake because it is genereated by gni-to-cmake.py. > > It's hand-edited after the generation, I think given the coarseness of this tool and that this file is already hand-edited (re-running the listed command at the top of the file generates a different file), it's reasonable to add this manually. > > The current script isn't sophisticated enough to interpret the build file in src/common/linux (in fact, it currently just strips out that definition entirely, so using the script generates an empty file). I looked at those dma_buf_util files and in the GN its actually its own library which is probably why it isn't being picked up. I didn't write that gni-to-cmake.py script and I don't think it ran successfully on Windows if I'm remembering correctly. Ideally this should be generated in the GLESv2.cmake file NOT GL.cmake. You'll notice that the backend CMake files only append sources in `src/libANGLE/renderer/${name}`. I'm okay with this change happening in GLESv2.cmake with a big ol FIXME with an actual bug associated with it so next time there's a roll someone hopefully notices it. I'm also okay with just adding it in the PlatformGTK.cmake in the root but I do think there should be a bug about it either way. 1824069 11 447048 fujii 2021-12-14 12:07:56 -0800 Comment on attachment 447048 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=447048&action=review >>>> Source/ThirdParty/ANGLE/GL.cmake:156 >>>> + "src/common/linux/dma_buf_utils.h" >>> >>> I think you shouldn't edit GL.cmake because it is genereated by gni-to-cmake.py. >> >> It's hand-edited after the generation, I think given the coarseness of this tool and that this file is already hand-edited (re-running the listed command at the top of the file generates a different file), it's reasonable to add this manually. >> >> The current script isn't sophisticated enough to interpret the build file in src/common/linux (in fact, it currently just strips out that definition entirely, so using the script generates an empty file). > > I looked at those dma_buf_util files and in the GN its actually its own library which is probably why it isn't being picked up. I didn't write that gni-to-cmake.py script and I don't think it ran successfully on Windows if I'm remembering correctly. > > Ideally this should be generated in the GLESv2.cmake file NOT GL.cmake. You'll notice that the backend CMake files only append sources in `src/libANGLE/renderer/${name}`. > > I'm okay with this change happening in GLESv2.cmake with a big ol FIXME with an actual bug associated with it so next time there's a roll someone hopefully notices it. I'm also okay with just adding it in the PlatformGTK.cmake in the root but I do think there should be a bug about it either way. It's not a library. It's a source set that is used by GL and Valkan backends. I think we should add linux.cmake, and include it from PlatformGTK.cmake and PlatformWPE.cmake, or from CMakeLists.txt. 1824071 12 447048 don.olmstead 2021-12-14 12:18:57 -0800 Comment on attachment 447048 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=447048&action=review >>>>> Source/ThirdParty/ANGLE/GL.cmake:156 >>>>> + "src/common/linux/dma_buf_utils.h" >>>> >>>> I think you shouldn't edit GL.cmake because it is genereated by gni-to-cmake.py. >>> >>> It's hand-edited after the generation, I think given the coarseness of this tool and that this file is already hand-edited (re-running the listed command at the top of the file generates a different file), it's reasonable to add this manually. >>> >>> The current script isn't sophisticated enough to interpret the build file in src/common/linux (in fact, it currently just strips out that definition entirely, so using the script generates an empty file). >> >> I looked at those dma_buf_util files and in the GN its actually its own library which is probably why it isn't being picked up. I didn't write that gni-to-cmake.py script and I don't think it ran successfully on Windows if I'm remembering correctly. >> >> Ideally this should be generated in the GLESv2.cmake file NOT GL.cmake. You'll notice that the backend CMake files only append sources in `src/libANGLE/renderer/${name}`. >> >> I'm okay with this change happening in GLESv2.cmake with a big ol FIXME with an actual bug associated with it so next time there's a roll someone hopefully notices it. I'm also okay with just adding it in the PlatformGTK.cmake in the root but I do think there should be a bug about it either way. > > It's not a library. It's a source set that is used by GL and Valkan backends. > I think we should add linux.cmake, and include it from PlatformGTK.cmake and PlatformWPE.cmake, or from CMakeLists.txt. Ok with that route I guess we would just list the sources in a variable and then the GTK/WPE folks can just append those values to it. 1825715 13 447628 crzwdjk 2021-12-20 13:33:18 -0800 Created attachment 447628 Patch 1825732 14 447628 kbr 2021-12-20 14:04:38 -0800 Comment on attachment 447628 Patch Looks fine! r+. 1825979 15 ews-feeder 2021-12-21 05:30:52 -0800 Committed r287312 (245464@main): <https://commits.webkit.org/245464@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 447628. 1825980 16 webkit-bug-importer 2021-12-21 05:31:17 -0800 <rdar://problem/86765194> 446992 2021-12-13 05:20:34 -0800 2021-12-13 13:11:57 -0800 Patch bug-234239-20211213082033.patch text/plain 1238 crzwdjk U3VidmVyc2lvbiBSZXZpc2lvbjogMjg2NjU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9BTkdMRS9DaGFuZ2VMb2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cKaW5k ZXggMTcyN2IwZmNjYTI0YTA2NWM5YjM0ZjdkMzIyNTA4NzE0ZDc2MzFjZC4uYzYwMzQ1ZGU0ZjUy NzdjYWNmNDE0ZWJhMjc5YWJkN2JiNmNiMTI1ZiAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFy dHkvQU5HTEUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDEyIEBACisyMDIxLTEyLTEzICBBcmNhZHkgR29sZG1pbnRzLU9ybG92ICA8 YWdvbGRtaW50c0BpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdIGJ1aWxkIGZhaWxzIHdpdGgg dW5kZWZpbmVkIHN5bWJvbCBpbiBBTkdMRSBpZiBVU0VfQU5HTEVfV0VCR0wgaXMgZW5hYmxlZC4K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNDIzOQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogR0wuY21h a2U6IEFkZCBhIG1hbnVhbCB0cmFuc2xhdGlvbiBvZiBzcmMvY29tbW9uL2xpbnV4L0JVSUxELmdu CisKIDIwMjEtMTItMDcgIE15bGVzIEMuIE1heGZpZWxkICA8bW1heGZpZWxkQGFwcGxlLmNvbT4K IAogICAgICAgICBbTWFjQ2F0YWx5c3RdIEZpeCBidWlsZCBhZnRlciByMjg2NjAzCmRpZmYgLS1n aXQgYS9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9HTC5jbWFrZSBiL1NvdXJjZS9UaGlyZFBhcnR5 L0FOR0xFL0dMLmNtYWtlCmluZGV4IDMwMzMyMzYwYjkyNWU0YjM4NDI5MDU1YjJkZTI3ZWM3NjRl YmRmYjMuLmVmYTU3MDJkZmExZmZiYThhZTNmOWU0ZWNlY2MxN2VlZmNiYTA0MTYgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0dMLmNtYWtlCisrKyBiL1NvdXJjZS9UaGlyZFBh cnR5L0FOR0xFL0dMLmNtYWtlCkBAIC0yMjksMyArMjI5LDkgQEAgaWYoYW5nbGVfZW5hYmxlX2ds X251bGwpCiAgICAgKQogZW5kaWYoKQogCitpZiAoaXNfYW5kcm9pZCBPUiBpc19saW51eCBPUiBp c19jaHJvbWVvcykKKyAgICBsaXN0KEFQUEVORCBfZ2xfYmFja2VuZF9zb3VyY2VzCisgICAgICAg ICJzcmMvY29tbW9uL2xpbnV4L2RtYV9idWZfdXRpbHMuY3BwIgorICAgICAgICAic3JjL2NvbW1v bi9saW51eC9kbWFfYnVmX3V0aWxzLmgiCisgICAgKQorZW5kaWYoKQo= 447047 2021-12-13 13:12:00 -0800 2021-12-13 13:14:55 -0800 Patch bug-234239-20211213161159.patch text/plain 1238 crzwdjk U3VidmVyc2lvbiBSZXZpc2lvbjogMjg2NjU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9BTkdMRS9DaGFuZ2VMb2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cKaW5k ZXggMTcyN2IwZmNjYTI0YTA2NWM5YjM0ZjdkMzIyNTA4NzE0ZDc2MzFjZC4uYzYwMzQ1ZGU0ZjUy NzdjYWNmNDE0ZWJhMjc5YWJkN2JiNmNiMTI1ZiAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFy dHkvQU5HTEUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDEyIEBACisyMDIxLTEyLTEzICBBcmNhZHkgR29sZG1pbnRzLU9ybG92ICA8 YWdvbGRtaW50c0BpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdIGJ1aWxkIGZhaWxzIHdpdGgg dW5kZWZpbmVkIHN5bWJvbCBpbiBBTkdMRSBpZiBVU0VfQU5HTEVfV0VCR0wgaXMgZW5hYmxlZC4K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNDIzOQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogR0wuY21h a2U6IEFkZCBhIG1hbnVhbCB0cmFuc2xhdGlvbiBvZiBzcmMvY29tbW9uL2xpbnV4L0JVSUxELmdu CisKIDIwMjEtMTItMDcgIE15bGVzIEMuIE1heGZpZWxkICA8bW1heGZpZWxkQGFwcGxlLmNvbT4K IAogICAgICAgICBbTWFjQ2F0YWx5c3RdIEZpeCBidWlsZCBhZnRlciByMjg2NjAzCmRpZmYgLS1n aXQgYS9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9HTC5jbWFrZSBiL1NvdXJjZS9UaGlyZFBhcnR5 L0FOR0xFL0dMLmNtYWtlCmluZGV4IDMwMzMyMzYwYjkyNWU0YjM4NDI5MDU1YjJkZTI3ZWM3NjRl YmRmYjMuLmVmYTU3MDJkZmExZmZiYThhZTNmOWU0ZWNlY2MxN2VlZmNiYTA0MTYgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0dMLmNtYWtlCisrKyBiL1NvdXJjZS9UaGlyZFBh cnR5L0FOR0xFL0dMLmNtYWtlCkBAIC0yMjksMyArMjI5LDkgQEAgaWYoYW5nbGVfZW5hYmxlX2ds X251bGwpCiAgICAgKQogZW5kaWYoKQogCitpZiAoaXNfYW5kcm9pZCBPUiBpc19saW51eCBPUiBp c19jaHJvbWVvcykKKyAgICBsaXN0KEFQUEVORCBfZ2xfYmFja2VuZF9zb3VyY2VzCisgICAgICAg ICJzcmMvY29tbW9uL2xpbnV4L2RtYV9idWZfdXRpbHMuY3BwIgorICAgICAgICAic3JjL2NvbW1v bi9saW51eC9kbWFfYnVmX3V0aWxzLmgiCisgICAgKQorZW5kaWYoKQo= 447048 2021-12-13 13:14:58 -0800 2021-12-20 13:33:14 -0800 Patch bug-234239-20211213161458.patch text/plain 1328 crzwdjk U3VidmVyc2lvbiBSZXZpc2lvbjogMjg2NjU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9BTkdMRS9DaGFuZ2VMb2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cKaW5k ZXggMTcyN2IwZmNjYTI0YTA2NWM5YjM0ZjdkMzIyNTA4NzE0ZDc2MzFjZC4uYzYwMzQ1ZGU0ZjUy NzdjYWNmNDE0ZWJhMjc5YWJkN2JiNmNiMTI1ZiAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFy dHkvQU5HTEUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDEyIEBACisyMDIxLTEyLTEzICBBcmNhZHkgR29sZG1pbnRzLU9ybG92ICA8 YWdvbGRtaW50c0BpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdIGJ1aWxkIGZhaWxzIHdpdGgg dW5kZWZpbmVkIHN5bWJvbCBpbiBBTkdMRSBpZiBVU0VfQU5HTEVfV0VCR0wgaXMgZW5hYmxlZC4K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNDIzOQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogR0wuY21h a2U6IEFkZCBhIG1hbnVhbCB0cmFuc2xhdGlvbiBvZiBzcmMvY29tbW9uL2xpbnV4L0JVSUxELmdu CisKIDIwMjEtMTItMDcgIE15bGVzIEMuIE1heGZpZWxkICA8bW1heGZpZWxkQGFwcGxlLmNvbT4K IAogICAgICAgICBbTWFjQ2F0YWx5c3RdIEZpeCBidWlsZCBhZnRlciByMjg2NjAzCmRpZmYgLS1n aXQgYS9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9HTC5jbWFrZSBiL1NvdXJjZS9UaGlyZFBhcnR5 L0FOR0xFL0dMLmNtYWtlCmluZGV4IDMwMzMyMzYwYjkyNWU0YjM4NDI5MDU1YjJkZTI3ZWM3NjRl YmRmYjMuLjFlZTljYmY5ZDc0YzgzMjg3YzkwZjg3ZDQ1MzVhMjJmNDVhYmY2MDAgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0dMLmNtYWtlCisrKyBiL1NvdXJjZS9UaGlyZFBh cnR5L0FOR0xFL0dMLmNtYWtlCkBAIC0xNTIsNiArMTUyLDggQEAgaWYoaXNfYW5kcm9pZCBPUiBp c19saW51eCBPUiBpc19jaHJvbWVvcykKICAgICAgICAgInNyYy9saWJBTkdMRS9yZW5kZXJlci9n bC9lZ2wvZWdsX3V0aWxzLmNwcCIKICAgICAgICAgInNyYy9saWJBTkdMRS9yZW5kZXJlci9nbC9l Z2wvZWdsX3V0aWxzLmgiCiAgICAgICAgICJzcmMvbGliQU5HTEUvcmVuZGVyZXIvZ2wvZWdsL2Z1 bmN0aW9uc2VnbF90eXBlZGVmcy5oIgorICAgICAgICAic3JjL2NvbW1vbi9saW51eC9kbWFfYnVm X3V0aWxzLmNwcCIKKyAgICAgICAgInNyYy9jb21tb24vbGludXgvZG1hX2J1Zl91dGlscy5oIgog ICAgICkKIGVuZGlmKCkKIAo= 447628 2021-12-20 13:33:18 -0800 2021-12-21 05:30:55 -0800 Patch bug-234239-20211220163317.patch text/plain 2173 crzwdjk U3VidmVyc2lvbiBSZXZpc2lvbjogMjg3MjYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9BTkdMRS9DaGFuZ2VMb2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cKaW5k ZXggNTRjYzMzNTg2MGVmMWVmZTRhN2FkN2I0OGQ3YzBlOTdkNmIxMTRmMi4uOGFlM2YwNThjYmYw OTczNDkyNWQ5Mzg4ODhjMzhjNjY2ZmU5ZDI1MSAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFy dHkvQU5HTEUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE2IEBACisyMDIxLTEyLTEzICBBcmNhZHkgR29sZG1pbnRzLU9ybG92ICA8 YWdvbGRtaW50c0BpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdIGJ1aWxkIGZhaWxzIHdpdGgg dW5kZWZpbmVkIHN5bWJvbCBpbiBBTkdMRSBpZiBVU0VfQU5HTEVfV0VCR0wgaXMgZW5hYmxlZC4K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNDIzOQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBhIG5l dyBsaW51eC5jbWFrZSBmaWxlIHRoYXQgZGVmaW5lcyBhbmdsZV9kbWFfYnVmX3NvdXJjZXMuCisg ICAgICAgIFRoaXMgbGlzdCBnZXRzIGFwcGVuZGVkIGl0IGludG8gQU5HTEVfU09VUkNFUyBpbiBQ bGF0Zm9ybUdUSy5jbWFrZS4KKworICAgICAgICAqIGxpbnV4LmNtYWtlOiBBZGRlZC4gTWFudWFs IHRyYW5zbGF0aW9uIG9mIHNyYy9jb21tb24vbGludXgvQlVJTEQuZ24uCisgICAgICAgICogUGxh dGZvcm1HVEsuY21ha2U6CisKIDIwMjEtMTItMTcgIEZ1amlpIEhpcm9ub3JpICA8SGlyb25vcmku RnVqaWlAc29ueS5jb20+CiAKICAgICAgICAgW0FOR0xFXSAiV0FSTjogZHJpdmVyX3V0aWxzLmNw cDoxNjkgKHJ4OjpHZXRWZW5kb3JTdHJpbmcpOiEgVW5pbXBsZW1lbnRlZDogcng6OkdldFZlbmRv clN0cmluZyIgb24gV2luQ2Fpcm8gZGVidWcgdGVzdGluZyBib3QKZGlmZiAtLWdpdCBhL1NvdXJj ZS9UaGlyZFBhcnR5L0FOR0xFL1BsYXRmb3JtR1RLLmNtYWtlIGIvU291cmNlL1RoaXJkUGFydHkv QU5HTEUvUGxhdGZvcm1HVEsuY21ha2UKaW5kZXggM2NjOWRkZGE2ZGY4ZDJkMTgzMWVjY2YxZjBl YTk1NDllYmFkNTJjYi4uODQzMmQxMTYyM2I2NmVkODdhY2ZjNGIwYjI3MWQ1NGRhOGFlZDQ2NyAx MDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvUGxhdGZvcm1HVEsuY21ha2UKKysr IGIvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvUGxhdGZvcm1HVEsuY21ha2UKQEAgLTEsNCArMSw1 IEBACiBsaXN0KEFQUEVORCBBTkdMRV9ERUZJTklUSU9OUyBBTkdMRV9QTEFURk9STV9MSU5VWCkK K2luY2x1ZGUobGludXguY21ha2UpCiAKIGlmIChVU0VfT1BFTkdMKQogICAgICMgRW5hYmxlIEdM U0wgY29tcGlsZXIgb3V0cHV0LgpAQCAtMTIsNiArMTMsOCBAQCBpZiAoVVNFX0FOR0xFX0VHTCBP UiBVU0VfQU5HTEVfV0VCR0wpCiAgICAgICAgICR7YW5nbGVfc3lzdGVtX3V0aWxzX3NvdXJjZXNf bGludXh9CiAgICAgICAgICR7YW5nbGVfc3lzdGVtX3V0aWxzX3NvdXJjZXNfcG9zaXh9CiAKKyAg ICAgICAgJHthbmdsZV9kbWFfYnVmX3NvdXJjZXN9CisKICAgICAgICAgJHtsaWJhbmdsZV9nbF9l Z2xfZGxfc291cmNlc30KICAgICAgICAgJHtsaWJhbmdsZV9nbF9lZ2xfc291cmNlc30KICAgICAg ICAgJHtsaWJhbmdsZV9nbF9zb3VyY2VzfQpkaWZmIC0tZ2l0IGEvU291cmNlL1RoaXJkUGFydHkv QU5HTEUvbGludXguY21ha2UgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9saW51eC5jbWFrZQpu ZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwLi5mM2Q5Y2MwNmUwM2ViNTU5MTM2NjYxMjk5ZGJmMmEzZDViYzU0ZGZlCi0tLSAv ZGV2L251bGwKKysrIGIvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvbGludXguY21ha2UKQEAgLTAs MCArMSw2IEBACitpZihpc19hbmRyb2lkIE9SIGlzX2xpbnV4IE9SIGlzX2Nocm9tZW9zKQorICBz ZXQoYW5nbGVfZG1hX2J1Zl9zb3VyY2VzCisgICAgInNyYy9jb21tb24vbGludXgvZG1hX2J1Zl91 dGlscy5jcHAiCisgICAgInNyYy9jb21tb24vbGludXgvZG1hX2J1Zl91dGlscy5oIgorICApCitl bmRpZigpCg==