234238 2021-12-13 05:12:46 -0800 FetchResponse::clone should use the relevant realm for the cloned response 2021-12-14 04:52:06 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=230941 InRadar P2 Normal --- 1 youennf youennf achristensen ashvayka cdumez esprehn+autocc ews-watchlist kondapallykalyan webkit-bug-importer oldest_to_newest 1823483 0 youennf 2021-12-13 05:12:46 -0800 FetchResponse::clone should use the relevant realm for the cloned response 1823487 1 446991 youennf 2021-12-13 05:18:57 -0800 Created attachment 446991 Patch 1823488 2 webkit-bug-importer 2021-12-13 05:19:55 -0800 <rdar://problem/86407662> 1823560 3 446991 ashvayka 2021-12-13 09:02:12 -0800 Comment on attachment 446991 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=446991&action=review This is marvelous! I was looking into Fetch stuff during https://bugs.webkit.org/show_bug.cgi?id=230941 yet didn't come up with a test case. With that said, are there any fetch methods we can fix in the same way? Namely the SEC FetchResponse's error() / redirect() are using to create another response? > LayoutTests/http/wpt/fetch/clone-realm.html:1 > +<!doctype html> There is no way we can WPT export this test, right? 1823626 4 youennf 2021-12-13 10:46:11 -0800 > With that said, are there any fetch methods we can fix in the same way? > Namely the SEC FetchResponse's error() / redirect() are using to create > another response? These are static methods and I am not sure there are some observable behavior so maybe it is just fine > > LayoutTests/http/wpt/fetch/clone-realm.html:1 > > +<!doctype html> > > There is no way we can WPT export this test, right? We could but, as written it only passes in Chrome and Safari, not Firefox. 1823633 5 ashvayka 2021-12-13 11:02:36 -0800 (In reply to youenn fablet from comment #4) > > With that said, are there any fetch methods we can fix in the same way? > > Namely the SEC FetchResponse's error() / redirect() are using to create > > another response? > > These are static methods and I am not sure there are some observable > behavior so maybe it is just fine Oh, I've totally missed that. It's a bit weird that spec uses "this's relevant Realm" prose for non-platform objects. In https://bugs.webkit.org/show_bug.cgi?id=230941 I've ignored both static methods and constructors regarding _current_ vs _relevant_. I guess you are right and there might be some weird test case involving Object.setPrototypeOf() for constructors. Not expecting anyone to investigate it though. > > > > LayoutTests/http/wpt/fetch/clone-realm.html:1 > > > +<!doctype html> > > > > There is no way we can WPT export this test, right? > > We could but, as written it only passes in Chrome and Safari, not Firefox. The test looks solid, and the spec normatively requires _relevant_ realm. I would say Firefox's failure is +1 reason to export. 1823668 6 youennf 2021-12-13 11:41:49 -0800 > > > > LayoutTests/http/wpt/fetch/clone-realm.html:1 > > > > +<!doctype html> > > > > > > There is no way we can WPT export this test, right? > > > > We could but, as written it only passes in Chrome and Safari, not Firefox. > > The test looks solid, and the spec normatively requires _relevant_ realm. I > would say Firefox's failure is +1 reason to export. I'll check again but I think Firefox is generating a valid Response, whose body is in a somewhat special state, calling text() will return a promise that never resolves for instance. Let's land this one for now and I'll follow up with a WPT proper upstream with WPT review. 1823692 7 ews-feeder 2021-12-13 12:29:18 -0800 Committed r286970 (245192@main): <https://commits.webkit.org/245192@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 446991. 1823964 8 youennf 2021-12-14 04:52:06 -0800 Digging further, Chrome is not always throwing when cloning in detached contexts. This might create a backward compatibility risk so we might want to reduce our throwing as well. 446991 2021-12-13 05:18:57 -0800 2021-12-13 12:29:22 -0800 Patch bug-234238-20211213141856.patch text/plain 5533 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjg2OTM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDNmYzA0MWFmMTUxMzQ2 MTI2MjMyMmQ4OTgzNzEzZTNjZGYwYTNjMS4uNzBhMzk5MmQ5MzQ5NTIxZmExNDRkMjdkMjIzNDBi ZTM4MWMyODljOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIxLTEyLTEzICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBGZXRjaFJlc3BvbnNlOjpj bG9uZSBzaG91bGQgdXNlIHRoZSByZWxldmFudCByZWFsbSBmb3IgdGhlIGNsb25lZCByZXNwb25z ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjM0MjM4 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmV1c2Ug dGhlIHJlbGV2YW50IHJlYWxtIGZvciBjbG9uaW5nIGFzIHBlciBodHRwczovL2ZldGNoLnNwZWMu d2hhdHdnLm9yZy8jZG9tLXJlc3BvbnNlLWNsb25lIHN0ZXAgMy4KKyAgICAgICAgSWYgY29udGV4 dCBpcyBzdG9wcGVkLCB0aHJvdyBhbiBJbnZhbGlkU3RhdGVFcnJvciBleGNlcHRpb24sIGxpa2Ug ZG9uZSBpbiBDaHJvbWUuCisKKyAgICAgICAgVGVzdDogaHR0cC93cHQvZmV0Y2gvY2xvbmUtcmVh bG0uaHRtbAorCisgICAgICAgICogTW9kdWxlcy9mZXRjaC9GZXRjaFJlc3BvbnNlLmNwcDoKKyAg ICAgICAgKiBNb2R1bGVzL2ZldGNoL0ZldGNoUmVzcG9uc2UuaDoKKyAgICAgICAgKiBNb2R1bGVz L2ZldGNoL0ZldGNoUmVzcG9uc2UuaWRsOgorCiAyMDIxLTEyLTEzICBZb3Vlbm4gRmFibGV0ICA8 eW91ZW5uQGFwcGxlLmNvbT4KIAogICAgICAgICBOdWxsIHBvaW50ZXIgY3Jhc2ggaW4gRmV0Y2hS ZXNwb25zZTo6Y2xvbmUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvZmV0Y2gv RmV0Y2hSZXNwb25zZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2ZldGNoL0ZldGNoUmVz cG9uc2UuY3BwCmluZGV4IGE2MzNiNGU0NTAwNDAxNjhjNmIzNjMwMWE1ZGUxZjgyNmFhNTZmNjEu LmMxNjQ3MzMzYmY5ZGUyODI2YmQ2ZThjYmEwYTlkNmU3NzQyMGE3ZTEgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL01vZHVsZXMvZmV0Y2gvRmV0Y2hSZXNwb25zZS5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvTW9kdWxlcy9mZXRjaC9GZXRjaFJlc3BvbnNlLmNwcApAQCAtMTY5LDEyICsxNjks MTYgQEAgRmV0Y2hSZXNwb25zZTo6RmV0Y2hSZXNwb25zZShTY3JpcHRFeGVjdXRpb25Db250ZXh0 JiBjb250ZXh0LCBzdGQ6Om9wdGlvbmFsPEZldGMKIHsKIH0KIAotRXhjZXB0aW9uT3I8UmVmPEZl dGNoUmVzcG9uc2U+PiBGZXRjaFJlc3BvbnNlOjpjbG9uZShTY3JpcHRFeGVjdXRpb25Db250ZXh0 JiBjb250ZXh0KQorRXhjZXB0aW9uT3I8UmVmPEZldGNoUmVzcG9uc2U+PiBGZXRjaFJlc3BvbnNl OjpjbG9uZSgpCiB7CisgICAgaWYgKGlzQ29udGV4dFN0b3BwZWQoKSkKKyAgICAgICAgcmV0dXJu IEV4Y2VwdGlvbiB7IEludmFsaWRTdGF0ZUVycm9yLCAiQ29udGV4dCBpcyBzdG9wcGVkIl9zIH07 CisKICAgICBpZiAoaXNEaXN0dXJiZWRPckxvY2tlZCgpKQogICAgICAgICByZXR1cm4gRXhjZXB0 aW9uIHsgVHlwZUVycm9yLCAiQm9keSBpcyBkaXN0dXJiZWQgb3IgbG9ja2VkIl9zIH07CiAKICAg ICBBU1NFUlQoc2NyaXB0RXhlY3V0aW9uQ29udGV4dCgpKTsKKyAgICBhdXRvJiBjb250ZXh0ID0g KnNjcmlwdEV4ZWN1dGlvbkNvbnRleHQoKTsKIAogICAgIC8vIElmIGxvYWRpbmcsIGxldCdzIGNy ZWF0ZSBhIHN0cmVhbSBzbyB0aGF0IGRhdGEgaXMgdGVlZCBvbiBib3RoIGNsb25lcy4KICAgICBp ZiAoaXNMb2FkaW5nKCkgJiYgIW1fcmVhZGFibGVTdHJlYW1Tb3VyY2UpIHsKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvZmV0Y2gvRmV0Y2hSZXNwb25zZS5oIGIvU291cmNlL1dl YkNvcmUvTW9kdWxlcy9mZXRjaC9GZXRjaFJlc3BvbnNlLmgKaW5kZXggMzc0OGM4ZjU5MjcyOTMw YmJjMmQxNjY2YzZhZWI1NDdhMWI1ZWYwNi4uNmY0YTI0ZTI3NWUxNjlhMTM3NzE0NTAwZGFmY2Qx ZDY1NWNhZjUxNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9mZXRjaC9GZXRj aFJlc3BvbnNlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9mZXRjaC9GZXRjaFJlc3Bv bnNlLmgKQEAgLTc5LDcgKzc5LDcgQEAgcHVibGljOgogCiAgICAgY29uc3QgRmV0Y2hIZWFkZXJz JiBoZWFkZXJzKCkgY29uc3QgeyByZXR1cm4gbV9oZWFkZXJzOyB9CiAgICAgRmV0Y2hIZWFkZXJz JiBoZWFkZXJzKCkgeyByZXR1cm4gbV9oZWFkZXJzOyB9Ci0gICAgRXhjZXB0aW9uT3I8UmVmPEZl dGNoUmVzcG9uc2U+PiBjbG9uZShTY3JpcHRFeGVjdXRpb25Db250ZXh0Jik7CisgICAgRXhjZXB0 aW9uT3I8UmVmPEZldGNoUmVzcG9uc2U+PiBjbG9uZSgpOwogCiAgICAgdm9pZCBjb25zdW1lQm9k eUFzU3RyZWFtKCkgZmluYWw7CiAgICAgdm9pZCBmZWVkU3RyZWFtKCkgZmluYWw7CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2ZldGNoL0ZldGNoUmVzcG9uc2UuaWRsIGIvU291 cmNlL1dlYkNvcmUvTW9kdWxlcy9mZXRjaC9GZXRjaFJlc3BvbnNlLmlkbAppbmRleCBjZWY2YzE5 YzY1M2RiMzQwMjUzMzBjNTJiOTYzZjcxMTc3MjIyN2NlLi5jNGFhZmNkMWY0MzJmMjc1YTlkYTZl OTEwODNiYWE2MWVlMmY1OWEyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2Zl dGNoL0ZldGNoUmVzcG9uc2UuaWRsCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvZmV0Y2gv RmV0Y2hSZXNwb25zZS5pZGwKQEAgLTU3LDcgKzU3LDcgQEAgZGljdGlvbmFyeSBGZXRjaFJlc3Bv bnNlSW5pdCB7CiAgICAgcmVhZG9ubHkgYXR0cmlidXRlIEJ5dGVTdHJpbmcgc3RhdHVzVGV4dDsK ICAgICBbU2FtZU9iamVjdF0gcmVhZG9ubHkgYXR0cmlidXRlIEZldGNoSGVhZGVycyBoZWFkZXJz OwogCi0gICAgW0NhbGxXaXRoPVNjcmlwdEV4ZWN1dGlvbkNvbnRleHQsIE5ld09iamVjdF0gRmV0 Y2hSZXNwb25zZSBjbG9uZSgpOworICAgIFtOZXdPYmplY3RdIEZldGNoUmVzcG9uc2UgY2xvbmUo KTsKIH07CiAKIEZldGNoUmVzcG9uc2UgaW5jbHVkZXMgRmV0Y2hCb2R5OwpkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDA0NzY1 ZTBkYjEyMjVkNGJkYmIzYzBiNWFlZWExYjZmNDFjYzEzZTIuLjhiMzdkMDhlOGNlZTBlN2E2OGNj YmQyOWExMjU2NDUyNzcwNDUwYzAgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZwor KysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAyMS0xMi0xMyAg WW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CisKKyAgICAgICAgRmV0Y2hSZXNwb25z ZTo6Y2xvbmUgc2hvdWxkIHVzZSB0aGUgcmVsZXZhbnQgcmVhbG0gZm9yIHRoZSBjbG9uZWQgcmVz cG9uc2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIz NDIzOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog aHR0cC93cHQvZmV0Y2gvY2xvbmUtcmVhbG0tZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAg KiBodHRwL3dwdC9mZXRjaC9jbG9uZS1yZWFsbS5odG1sOiBBZGRlZC4KKwogMjAyMS0xMi0xMyAg WW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAKICAgICAgICAgWyBNYWMgd2syIGFu ZCBpT1Mgd2syIF0gd2VicnRjL2xpYndlYnJ0Yy9kZXNjcmlwdGlvbkdldHRlcnMuaHRtbCBpcyBm bGFreSBmYWlsaW5nLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaHR0cC93cHQvZmV0Y2gvY2xv bmUtcmVhbG0tZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvaHR0cC93cHQvZmV0Y2gvY2xvbmUt cmVhbG0tZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmE5MTczNWMwNTYyODhkMGIwYTJkNDYzNzJk ZWNkNzQ2YjBhNGRmYjIKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9odHRwL3dwdC9m ZXRjaC9jbG9uZS1yZWFsbS1leHBlY3RlZC50eHQKQEAgLTAsMCArMSwzIEBACisKK1BBU1MgQ2xv bmluZyBhIHJlc3BvbnNlIGZhaWxzIHdoZW4gaXRzIGZyYW1lIGlzIGRldGFjaGVkCisKZGlmZiAt LWdpdCBhL0xheW91dFRlc3RzL2h0dHAvd3B0L2ZldGNoL2Nsb25lLXJlYWxtLmh0bWwgYi9MYXlv dXRUZXN0cy9odHRwL3dwdC9mZXRjaC9jbG9uZS1yZWFsbS5odG1sCm5ldyBmaWxlIG1vZGUgMTAw NjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmE1MmYy MjNiNDkxYjQ5MDkwMDJhYThjOGEzM2QzN2E5NGJmN2ExMTIKLS0tIC9kZXYvbnVsbAorKysgYi9M YXlvdXRUZXN0cy9odHRwL3dwdC9mZXRjaC9jbG9uZS1yZWFsbS5odG1sCkBAIC0wLDAgKzEsMzIg QEAKKzwhZG9jdHlwZSBodG1sPgorPGh0bWw+CisgICAgPGhlYWQ+CisgICAgICAgIDxtZXRhIGNo YXJzZXQ9InV0Zi04Ij4KKyAgICAgICAgPHNjcmlwdCBzcmM9Ii9yZXNvdXJjZXMvdGVzdGhhcm5l c3MuanMiPjwvc2NyaXB0PgorICAgICAgICA8c2NyaXB0IHNyYz0iL3Jlc291cmNlcy90ZXN0aGFy bmVzc3JlcG9ydC5qcyI+PC9zY3JpcHQ+CisgICAgPC9oZWFkPgorICAgIDxib2R5PgorPHNjcmlw dD4KK2Z1bmN0aW9uIHdpdGhfaWZyYW1lKHVybCkgeworICByZXR1cm4gbmV3IFByb21pc2UoZnVu Y3Rpb24ocmVzb2x2ZSkgeworICAgICAgdmFyIGZyYW1lID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVu dCgnaWZyYW1lJyk7CisgICAgICBmcmFtZS5zcmMgPSB1cmw7CisgICAgICBmcmFtZS5vbmxvYWQg PSBmdW5jdGlvbigpIHsgcmVzb2x2ZShmcmFtZSk7IH07CisgICAgICBkb2N1bWVudC5ib2R5LmFw cGVuZENoaWxkKGZyYW1lKTsKKyAgICB9KTsKK30KK3Byb21pc2VfdGVzdChhc3luYyAodCkgPT4g eworICAgIGNvbnN0IGZyYW1lID0gYXdhaXQgd2l0aF9pZnJhbWUoJy8nKTsKKyAgICBjb25zdCBy ZXNwb25zZSA9IGF3YWl0IGZyYW1lLmNvbnRlbnRXaW5kb3cuZmV0Y2goJy8nKTsKKyAgICBhd2Fp dCByZXNwb25zZS5jbG9uZSgpLnRleHQoKTsKKyAgICBmcmFtZS5yZW1vdmUoKTsKKyAgICB0cnkg eworICAgICAgICByZXNwb25zZS5jbG9uZSgpOworICAgICAgICBhc3NlcnRfbm90X3JlYWNoZWQo KTsKKyAgICB9IGNhdGNoIChlKSB7CisgICAgICAgIGFzc2VydF9lcXVhbHMoZS5uYW1lLCAnSW52 YWxpZFN0YXRlRXJyb3InKTsKKyAgICB9Cit9LCAiQ2xvbmluZyBhIHJlc3BvbnNlIGZhaWxzIHdo ZW4gaXRzIGZyYW1lIGlzIGRldGFjaGVkIik7Cis8L3NjcmlwdD4KKyAgICA8L2JvZHk+Cis8L2h0 bWw+Cg==