234189 2021-12-10 17:23:22 -0800 Momentum Event Dispatcher: Magic Mouse doesn't use momentum event dispatcher 2021-12-10 19:45:03 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton simon.fraser webkit-bug-importer oldest_to_newest 1823118 0 thorton 2021-12-10 17:23:22 -0800 Momentum Event Dispatcher: Magic Mouse doesn't use momentum event dispatcher 1823121 1 446850 thorton 2021-12-10 17:24:40 -0800 Created attachment 446850 Patch 1823122 2 thorton 2021-12-10 17:24:43 -0800 <rdar://problem/86344954> 1823124 3 446850 simon.fraser 2021-12-10 17:27:57 -0800 Comment on attachment 446850 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=446850&action=review > Source/WebKit/Shared/mac/ScrollingAccelerationCurveMac.mm:123 > + return fromFixedPoint([(NSNumber *)valueCF.get() floatValue]); Do we need to guard against it not being a CFNumber? 1823126 4 446850 thorton 2021-12-10 17:29:59 -0800 Comment on attachment 446850 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=446850&action=review >> Source/WebKit/Shared/mac/ScrollingAccelerationCurveMac.mm:123 >> + return fromFixedPoint([(NSNumber *)valueCF.get() floatValue]); > > Do we need to guard against it not being a CFNumber? see the dynamic_cf_cast above 1823153 5 ews-feeder 2021-12-10 19:45:00 -0800 Committed r286900 (245128@main): <https://commits.webkit.org/245128@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 446850. 446850 2021-12-10 17:24:40 -0800 2021-12-10 19:45:01 -0800 Patch bug-234189-20211210172440.patch text/plain 6444 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMjg2ODgxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDdlZDI4NDc2MDIzNWEwN2Fm MjM0NTZmY2E1NDkwMzg5ODY0MTM3NzkuLjA3OTMyYjNlNWM1ZmQ5NWNlNDEzZDNiMDRjMWZjOGNi ZjlmM2NkYTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjggQEAKKzIwMjEtMTItMTAgIFRpbSBIb3J0 b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisKKyAgICAgICAgTW9tZW50dW0gRXZlbnQg RGlzcGF0Y2hlcjogTWFnaWMgTW91c2UgZG9lc24ndCB1c2UgbW9tZW50dW0gZXZlbnQgZGlzcGF0 Y2hlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjM0 MTg5CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS84NjM0NDk1ND4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNoYXJlZC9tYWMvU2Nyb2xsaW5nQWNj ZWxlcmF0aW9uQ3VydmVNYWMubW06CisgICAgICAgIChXZWJLaXQ6OmZyb21JT0hJRERldmljZSk6 CisgICAgICAgIEZpeCB0aGUgRklYTUUgaGVyZSBhYm91dCB0aGUgYWRkaXRpb25hbCBmYWxsYmFj ayB2YWx1ZXM7IGl0IHR1cm5zIG91dAorICAgICAgICBNYWdpYyBNb3VzZSBpcyBvbmUgZGV2aWNl IHRoYXQgZG9lcyBub3QgaGF2ZSBhIHZhbHVlIGZvcgorICAgICAgICBrSU9ISURTY3JvbGxBY2Nl bGVyYXRpb25UeXBlS2V5LCBzbyB3ZSBuZWVkIHRoZSBmdWxsIGZhbGxiYWNrIGNoYWluIHRvIHN1 cHBvcnQgaXQuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcDoKKyAgICAg ICAgKFdlYktpdDo6V2ViUGFnZVByb3h5OjpzZW5kV2hlZWxFdmVudCk6CisgICAgICAgIFVuLXdy YXBwaW5nIHRoaXMgb3B0aW9uYWwgcmVzdWx0cyBpbiBsb3NpbmcgdGhlIGVuZ2FnZWQgc3RhdGUs IGFuZCBzZW5kaW5nCisgICAgICAgIGEgZ2FyYmFnZSBTY3JvbGxpbmdBY2NlbGVyYXRpb25DdXJ2 ZSBhY3Jvc3MgdGhlIHdpcmUuCisgICAgICAgIFRoZSBtZXNzYWdlIGFyZ3VtZW50IGlzIGFsc28g YW4gb3B0aW9uYWwsIHNvIGp1c3QgcGFzcyBpdCBhbG9uZy4KKworICAgICAgICBUaGUgcmVzdWx0 IG9mIHRoaXMgYnVnIHdhcyB0aGF0IGlmIHlvdSBoYWQgZXZlciB1c2VkIGEgZGV2aWNlIHdpdGgg YSBjdXJ2ZQorICAgICAgICBmb3IgYSBnaXZlbiBwYWdlLCBhbmQgdGhlbiB1c2VkIGEgZGV2aWNl IHdpdGggbm8gY3VydmUsIE1vbWVudHVtRXZlbnREaXNwYXRjaGVyCisgICAgICAgIHdvdWxkIGhh dmUgYSBnYXJiYWdlIGN1cnZlIChmcm9tIHRoaXMgbWVzc2FnZSB0cnlpbmcgdG8gInVuc2V0IiB0 aGUgb3B0aW9uYWwpLAorICAgICAgICBhbmQgYSBnYXJiYWdlIGN1cnZlIHJlc3VsdHMgaW4gY2hh b3RpYyBzY3JvbGxpbmcuCisKIDIwMjEtMTItMTAgIEFkaXR5YSBLZWVydGhpICA8YWtlZXJ0aGlA YXBwbGUuY29tPgogCiAgICAgICAgIFtpT1NdIFN1cHBvcnQgZmluZC1pbi1wYWdlIGtleWJvYXJk IHNob3J0Y3V0cwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9TaGFyZWQvbWFjL1Njcm9sbGlu Z0FjY2VsZXJhdGlvbkN1cnZlTWFjLm1tIGIvU291cmNlL1dlYktpdC9TaGFyZWQvbWFjL1Njcm9s bGluZ0FjY2VsZXJhdGlvbkN1cnZlTWFjLm1tCmluZGV4IGY2ZDBmNTY3NmU4NjYyODZhZTFkY2Vi MTI3OTRhN2I4MGVmODJmYjcuLjE4YjRkNTZhNDZjNDM1OGU4ZDkxMjIwMDM3MzM4YzM2Y2M2NmFj Y2QgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvU2hhcmVkL21hYy9TY3JvbGxpbmdBY2NlbGVy YXRpb25DdXJ2ZU1hYy5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9tYWMvU2Nyb2xsaW5n QWNjZWxlcmF0aW9uQ3VydmVNYWMubW0KQEAgLTExNiwzMyArMTE2LDQ0IEBAIHN0YXRpYyBzdGQ6 Om9wdGlvbmFsPFNjcm9sbGluZ0FjY2VsZXJhdGlvbkN1cnZlPiBmcm9tSU9ISUREZXZpY2UoSU9I SURFdmVudFNlbmRlCiAgICAgICAgIHJldHVybiBzdGQ6Om51bGxvcHQ7CiAgICAgfQogCi0gICAg Ly8gRklYTUU6IFRoZXJlIGlzIHNvbWUgYWRkaXRpb25hbCBmYWxsYmFjayB0byBpbXBsZW1lbnQg aGVyZSwgdGhvdWdoIHRoaXMgc2VlbXMgdXN1YWxseSBzdWZmaWNpZW50LgotICAgIGF1dG8gc2Ny b2xsQWNjZWxlcmF0aW9uVHlwZSA9IGFkb3B0Q0YoZHluYW1pY19jZl9jYXN0PENGU3RyaW5nUmVm PihJT0hJRFNlcnZpY2VDbGllbnRDb3B5UHJvcGVydHkoaW9ISURTZXJ2aWNlLmdldCgpLCBDRlNU UigiSElEU2Nyb2xsQWNjZWxlcmF0aW9uVHlwZSIpKSkpOwotICAgIGlmICghc2Nyb2xsQWNjZWxl cmF0aW9uVHlwZSkgewotICAgICAgICBSRUxFQVNFX0xPRyhTY3JvbGxBbmltYXRpb25zLCAiU2Ny b2xsaW5nQWNjZWxlcmF0aW9uQ3VydmU6OmZyb21JT0hJRERldmljZSBmYWlsZWQgdG8gbG9vayB1 cCBhY2NlbGVyYXRpb24gdHlwZSIpOwotICAgICAgICByZXR1cm4gc3RkOjpudWxsb3B0OwotICAg IH0KKyAgICBhdXRvIHJlYWRGaXhlZFBvaW50U2VydmljZUtleSA9IFsmXSAoQ0ZTdHJpbmdSZWYg a2V5KSAtPiBzdGQ6Om9wdGlvbmFsPGZsb2F0PiB7CisgICAgICAgIGF1dG8gdmFsdWVDRiA9IGFk b3B0Q0YoZHluYW1pY19jZl9jYXN0PENGTnVtYmVyUmVmPihJT0hJRFNlcnZpY2VDbGllbnRDb3B5 UHJvcGVydHkoaW9ISURTZXJ2aWNlLmdldCgpLCBrZXkpKSk7CisgICAgICAgIGlmICghdmFsdWVD RikKKyAgICAgICAgICAgIHJldHVybiBzdGQ6Om51bGxvcHQ7CisgICAgICAgIHJldHVybiBmcm9t Rml4ZWRQb2ludChbKE5TTnVtYmVyICopdmFsdWVDRi5nZXQoKSBmbG9hdFZhbHVlXSk7CisgICAg fTsKKworICAgIGF1dG8gc2Nyb2xsQWNjZWxlcmF0aW9uID0gWyZdICgpIC0+IHN0ZDo6b3B0aW9u YWw8ZmxvYXQ+IHsKKyAgICAgICAgaWYgKGF1dG8gc2Nyb2xsQWNjZWxlcmF0aW9uVHlwZSA9IGFk b3B0Q0YoZHluYW1pY19jZl9jYXN0PENGU3RyaW5nUmVmPihJT0hJRFNlcnZpY2VDbGllbnRDb3B5 UHJvcGVydHkoaW9ISURTZXJ2aWNlLmdldCgpLCBDRlNUUigiSElEU2Nyb2xsQWNjZWxlcmF0aW9u VHlwZSIpKSkpKSB7CisgICAgICAgICAgICBpZiAoYXV0byBhY2NlbGVyYXRpb24gPSByZWFkRml4 ZWRQb2ludFNlcnZpY2VLZXkoc2Nyb2xsQWNjZWxlcmF0aW9uVHlwZS5nZXQoKSkpCisgICAgICAg ICAgICAgICAgcmV0dXJuIGFjY2VsZXJhdGlvbjsKKyAgICAgICAgfQogCi0gICAgYXV0byBzY3Jv bGxBY2NlbGVyYXRpb25DRiA9IGFkb3B0Q0YoZHluYW1pY19jZl9jYXN0PENGTnVtYmVyUmVmPihJ T0hJRFNlcnZpY2VDbGllbnRDb3B5UHJvcGVydHkoaW9ISURTZXJ2aWNlLmdldCgpLCBzY3JvbGxB Y2NlbGVyYXRpb25UeXBlLmdldCgpKSkpOwotICAgIGlmICghc2Nyb2xsQWNjZWxlcmF0aW9uQ0Yp IHsKLSAgICAgICAgUkVMRUFTRV9MT0coU2Nyb2xsQW5pbWF0aW9ucywgIlNjcm9sbGluZ0FjY2Vs ZXJhdGlvbkN1cnZlOjpmcm9tSU9ISUREZXZpY2UgZmFpbGVkIHRvIGxvb2sgdXAgYWNjZWxlcmF0 aW9uIHZhbHVlIik7CisgICAgICAgIGlmIChhdXRvIGFjY2VsZXJhdGlvbiA9IHJlYWRGaXhlZFBv aW50U2VydmljZUtleShDRlNUUihrSU9ISURNb3VzZVNjcm9sbEFjY2VsZXJhdGlvbktleSkpKQor ICAgICAgICAgICAgcmV0dXJuIGFjY2VsZXJhdGlvbjsKKworICAgICAgICBpZiAoYXV0byBhY2Nl bGVyYXRpb24gPSByZWFkRml4ZWRQb2ludFNlcnZpY2VLZXkoQ0ZTVFIoa0lPSElEU2Nyb2xsQWNj ZWxlcmF0aW9uS2V5KSkpCisgICAgICAgICAgICByZXR1cm4gYWNjZWxlcmF0aW9uOworCisgICAg ICAgIHJldHVybiBzdGQ6Om51bGxvcHQ7CisgICAgfSgpOworICAgIGlmICghc2Nyb2xsQWNjZWxl cmF0aW9uKSB7CisgICAgICAgIFJFTEVBU0VfTE9HKFNjcm9sbEFuaW1hdGlvbnMsICJTY3JvbGxp bmdBY2NlbGVyYXRpb25DdXJ2ZTo6ZnJvbUlPSElERGV2aWNlIGZhaWxlZCB0byBsb29rIHVwIGFj Y2VsZXJhdGlvbiIpOwogICAgICAgICByZXR1cm4gc3RkOjpudWxsb3B0OwogICAgIH0KLSAgICBh dXRvIHNjcm9sbEFjY2VsZXJhdGlvbiA9IGZyb21GaXhlZFBvaW50KGZyb21DRk51bWJlcihzY3Jv bGxBY2NlbGVyYXRpb25DRi5nZXQoKSkpOwogCi0gICAgYXV0byByZXNvbHV0aW9uQ0YgPSBhZG9w dENGKGR5bmFtaWNfY2ZfY2FzdDxDRk51bWJlclJlZj4oSU9ISURTZXJ2aWNlQ2xpZW50Q29weVBy b3BlcnR5KGlvSElEU2VydmljZS5nZXQoKSwgQ0ZTVFIoa0lPSElEU2Nyb2xsUmVzb2x1dGlvbktl eSkpKSk7Ci0gICAgaWYgKCFyZXNvbHV0aW9uQ0YpIHsKKyAgICBhdXRvIHJlc29sdXRpb24gPSBy ZWFkRml4ZWRQb2ludFNlcnZpY2VLZXkoQ0ZTVFIoa0lPSElEU2Nyb2xsUmVzb2x1dGlvbktleSkp OworICAgIGlmICghcmVzb2x1dGlvbikgewogICAgICAgICBSRUxFQVNFX0xPRyhTY3JvbGxBbmlt YXRpb25zLCAiU2Nyb2xsaW5nQWNjZWxlcmF0aW9uQ3VydmU6OmZyb21JT0hJRERldmljZSBmYWls ZWQgdG8gbG9vayB1cCByZXNvbHV0aW9uIik7CiAgICAgICAgIHJldHVybiBzdGQ6Om51bGxvcHQ7 CiAgICAgfQotICAgIGF1dG8gcmVzb2x1dGlvbiA9IGZyb21GaXhlZFBvaW50KFsoTlNOdW1iZXIg KilyZXNvbHV0aW9uQ0YuZ2V0KCkgZmxvYXRWYWx1ZV0pOwogCiAgICAgc3RhdGljIENGU3RyaW5n UmVmIGRpc3BhdGNoRnJhbWVSYXRlS2V5ID0gQ0ZTVFIoIlNjcm9sbE1vbWVudHVtRGlzcGF0Y2hS YXRlIik7CiAgICAgc3RhdGljIGNvbnN0ZXhwciBmbG9hdCBkZWZhdWx0RGlzcGF0Y2hGcmFtZVJh dGUgPSA2MDsKICAgICBhdXRvIGZyYW1lUmF0ZUNGID0gYWRvcHRDRihkeW5hbWljX2NmX2Nhc3Q8 Q0ZOdW1iZXJSZWY+KElPSElEU2VydmljZUNsaWVudENvcHlQcm9wZXJ0eShpb0hJRFNlcnZpY2Uu Z2V0KCksIGRpc3BhdGNoRnJhbWVSYXRlS2V5KSkpOwogICAgIGZsb2F0IGZyYW1lUmF0ZSA9IGZy YW1lUmF0ZUNGID8gZnJvbUNGTnVtYmVyKGZyYW1lUmF0ZUNGLmdldCgpKSA6IGRlZmF1bHREaXNw YXRjaEZyYW1lUmF0ZTsKIAotICAgIHJldHVybiBmcm9tSU9ISURDdXJ2ZUFycmF5V2l0aEFjY2Vs ZXJhdGlvbigoTlNBcnJheSAqKWN1cnZlcy5nZXQoKSwgc2Nyb2xsQWNjZWxlcmF0aW9uLCByZXNv bHV0aW9uLCBmcmFtZVJhdGUpOworICAgIHJldHVybiBmcm9tSU9ISURDdXJ2ZUFycmF5V2l0aEFj Y2VsZXJhdGlvbigoTlNBcnJheSAqKWN1cnZlcy5nZXQoKSwgKnNjcm9sbEFjY2VsZXJhdGlvbiwg KnJlc29sdXRpb24sIGZyYW1lUmF0ZSk7CiB9CiAKIHN0ZDo6b3B0aW9uYWw8U2Nyb2xsaW5nQWNj ZWxlcmF0aW9uQ3VydmU+IFNjcm9sbGluZ0FjY2VsZXJhdGlvbkN1cnZlOjpmcm9tTmF0aXZlV2hl ZWxFdmVudChjb25zdCBOYXRpdmVXZWJXaGVlbEV2ZW50JiBuYXRpdmVXZWJXaGVlbEV2ZW50KQpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcCBiL1Nv dXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAKaW5kZXggMTNjNWQyOTJlZmRm MmJjZTgwMzNkN2M5NDBhYjk1Y2ZiNDlmYWQ2NC4uZmY5ZTk2ZDQxMTkxNDhiOTM4ZmQ1NzYzZmM1 YjdhMzhhYjdhNzBhMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUGFn ZVByb3h5LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3Bw CkBAIC0yOTU2LDcgKzI5NTYsNyBAQCB2b2lkIFdlYlBhZ2VQcm94eTo6c2VuZFdoZWVsRXZlbnQo Y29uc3QgV2ViV2hlZWxFdmVudCYgZXZlbnQpCiAKICNpZiBFTkFCTEUoTU9NRU5UVU1fRVZFTlRf RElTUEFUQ0hFUikKICAgICBpZiAoZXZlbnQubW9tZW50dW1QaGFzZSgpID09IFdlYldoZWVsRXZl bnQ6OlBoYXNlQmVnYW4gJiYgbV9zY3JvbGxpbmdBY2NlbGVyYXRpb25DdXJ2ZSAhPSBtX2xhc3RT ZW50U2Nyb2xsaW5nQWNjZWxlcmF0aW9uQ3VydmUpIHsKLSAgICAgICAgY29ubmVjdGlvbi0+c2Vu ZChNZXNzYWdlczo6RXZlbnREaXNwYXRjaGVyOjpTZXRTY3JvbGxpbmdBY2NlbGVyYXRpb25DdXJ2 ZShtX3dlYlBhZ2VJRCwgKm1fc2Nyb2xsaW5nQWNjZWxlcmF0aW9uQ3VydmUpLCAwLCB7IH0sIFRo cmVhZDo6UU9TOjpVc2VySW50ZXJhY3RpdmUpOworICAgICAgICBjb25uZWN0aW9uLT5zZW5kKE1l c3NhZ2VzOjpFdmVudERpc3BhdGNoZXI6OlNldFNjcm9sbGluZ0FjY2VsZXJhdGlvbkN1cnZlKG1f d2ViUGFnZUlELCBtX3Njcm9sbGluZ0FjY2VsZXJhdGlvbkN1cnZlKSwgMCwgeyB9LCBUaHJlYWQ6 OlFPUzo6VXNlckludGVyYWN0aXZlKTsKICAgICAgICAgbV9sYXN0U2VudFNjcm9sbGluZ0FjY2Vs ZXJhdGlvbkN1cnZlID0gbV9zY3JvbGxpbmdBY2NlbGVyYXRpb25DdXJ2ZTsKICAgICB9CiAjZW5k aWYK