234132 2021-12-10 01:50:53 -0800 [WPE] Unable to launch Cog browser with run-minibrowser 2021-12-10 07:34:56 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED MOVED https://github.com/Igalia/cog/pull/376 https://github.com/Igalia/cog/pull/383 P2 Normal --- 1 pnormand pnormand aperez bugs-noreply ews-watchlist glenn jbedard oldest_to_newest 1822582 0 pnormand 2021-12-10 01:50:53 -0800 Its path changed.... 1822585 1 446687 pnormand 2021-12-10 01:53:06 -0800 Created attachment 446687 Patch 1822594 2 446690 pnormand 2021-12-10 02:11:57 -0800 Created attachment 446690 Patch 1822673 3 aperez 2021-12-10 06:28:21 -0800 The binary moved as a result of merging https://github.com/Igalia/cog/pull/376 I think it will be nicer to change the CMakeLists.txt in Cog to make it place the compiled binaries inside the top build directory instead of in the “launcher/” subdirectory — when developing I would rather run ”./build/cog …” to tests things rather than “./build/launcher/cog …“ OTOH, I think it is valuable to add the unit test anyway, so it's easier to catch the problem if the binaries get accidentally moved again :) 1822680 4 aperez 2021-12-10 06:37:24 -0800 Location set to the old one in https://github.com/Igalia/cog/pull/383 :) 446687 2021-12-10 01:53:06 -0800 2021-12-10 02:11:51 -0800 Patch bug-234132-20211210015305.patch text/plain 1834 pnormand U3VidmVyc2lvbiBSZXZpc2lvbjogMjg2ODM4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOWQ1N2ZhMzUwYzE4YzFmZDUyZTU5YzAwY2MzN2M1ZTky NDNlYzU0Yi4uMGE1YzVmYjJkZDU3MjdiZTJjN2NhN2I0MzZkZTIxZGI4MWMyM2I4OCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDIxLTEyLTEwICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4K KworICAgICAgICBbV1BFXSBVbmFibGUgdG8gbGF1bmNoIENvZyBicm93c2VyIHdpdGggcnVuLW1p bmlicm93c2VyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yMzQxMzIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBBZGp1c3QgcGF0aCB0byBjb2cgYmluYXJ5LgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRw eS9wb3J0L3dwZS5weToKKyAgICAgICAgKFdQRVBvcnQuYnJvd3Nlcl9uYW1lKToKKyAgICAgICAg KFdQRVBvcnQucnVuX21pbmlicm93c2VyKToKKwogMjAyMS0xMi0xMCAgS2ltbW8gS2lubnVuZW4g IDxra2lubnVuZW5AYXBwbGUuY29tPgogCiAgICAgICAgIElPU3VyZmFjZSBtZW1vcnkgYXR0cmli dXRpb24gaXMgaGFyZCB0byB1c2UgaW4gY29uc3RydWN0b3JzCmRpZmYgLS1naXQgYS9Ub29scy9T Y3JpcHRzL3dlYmtpdHB5L3BvcnQvd3BlLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0 L3dwZS5weQppbmRleCBjOTQzNGYzZDUxZDkxYmZmYWRkYjg5MmJiYTU5MWNkNGE1MzczZjQxLi4x NDRiOWEwYTgwNmY5ZjgwY2IzYTc5OWUzZTAxYjI3MGQ4YWUxMDY5IDEwMDY0NAotLS0gYS9Ub29s cy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvd3BlLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0 cHkvcG9ydC93cGUucHkKQEAgLTE2NCw3ICsxNjQsNyBAQCBjbGFzcyBXUEVQb3J0KFBvcnQpOgog ICAgICAgICBpZiBicm93c2VyOgogICAgICAgICAgICAgcHJpbnQoIlVua25vd24gYnJvd3NlciB7 fS4gRGVmYXVsdGluZyB0byBDb2cgYW5kIE1pbmlCcm93c2VyIHNlbGVjdGlvbiIuZm9ybWF0KGJy b3dzZXIpKQogCi0gICAgICAgIGlmIHNlbGYuX2ZpbGVzeXN0ZW0uaXNmaWxlKHNlbGYuY29nX3Bh dGhfdG8oJ2NvZycpKToKKyAgICAgICAgaWYgc2VsZi5fZmlsZXN5c3RlbS5pc2ZpbGUoc2VsZi5j b2dfcGF0aF90byhvcy5wYXRoLmpvaW4oJ2xhdW5jaGVyJywgJ2NvZycpKSk6CiAgICAgICAgICAg ICByZXR1cm4gImNvZyIKICAgICAgICAgcmV0dXJuICJtaW5pYnJvd3NlciIKIApAQCAtMTgzLDcg KzE4Myw3IEBAIGNsYXNzIFdQRVBvcnQoUG9ydCk6CiAgICAgICAgIG1pbmlCcm93c2VyID0gTm9u ZQogCiAgICAgICAgIGlmIHNlbGYuYnJvd3Nlcl9uYW1lKCkgPT0gImNvZyI6Ci0gICAgICAgICAg ICBtaW5pQnJvd3NlciA9IHNlbGYuY29nX3BhdGhfdG8oJ2NvZycpCisgICAgICAgICAgICBtaW5p QnJvd3NlciA9IHNlbGYuY29nX3BhdGhfdG8ob3MucGF0aC5qb2luKCdsYXVuY2hlcicsICdjb2cn KSkKICAgICAgICAgICAgIGlmIG5vdCBzZWxmLl9maWxlc3lzdGVtLmlzZmlsZShtaW5pQnJvd3Nl cik6CiAgICAgICAgICAgICAgICAgcHJpbnQoIkNvZyBub3QgZm91bmQg8J+Yoi4gSWYgeW91IHdp c2ggdG8gZW5hYmxlIGl0LCByZWJ1aWxkIHdpdGggYC1ERU5BQkxFX0NPRz1PTmAuIEZhbGxpbmcg YmFjayB0byBnb29kIG9sZCBNaW5pQnJvd3NlciIpCiAgICAgICAgICAgICAgICAgbWluaUJyb3dz ZXIgPSBOb25lCg== 446690 2021-12-10 02:11:57 -0800 2021-12-10 07:34:43 -0800 Patch bug-234132-20211210021155.patch text/plain 3020 pnormand U3VidmVyc2lvbiBSZXZpc2lvbjogMjg2ODM4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOWQ1N2ZhMzUwYzE4YzFmZDUyZTU5YzAwY2MzN2M1ZTky NDNlYzU0Yi4uMGE1YzVmYjJkZDU3MjdiZTJjN2NhN2I0MzZkZTIxZGI4MWMyM2I4OCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDIxLTEyLTEwICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4K KworICAgICAgICBbV1BFXSBVbmFibGUgdG8gbGF1bmNoIENvZyBicm93c2VyIHdpdGggcnVuLW1p bmlicm93c2VyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yMzQxMzIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBBZGp1c3QgcGF0aCB0byBjb2cgYmluYXJ5LgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRw eS9wb3J0L3dwZS5weToKKyAgICAgICAgKFdQRVBvcnQuYnJvd3Nlcl9uYW1lKToKKyAgICAgICAg KFdQRVBvcnQucnVuX21pbmlicm93c2VyKToKKwogMjAyMS0xMi0xMCAgS2ltbW8gS2lubnVuZW4g IDxra2lubnVuZW5AYXBwbGUuY29tPgogCiAgICAgICAgIElPU3VyZmFjZSBtZW1vcnkgYXR0cmli dXRpb24gaXMgaGFyZCB0byB1c2UgaW4gY29uc3RydWN0b3JzCmRpZmYgLS1naXQgYS9Ub29scy9T Y3JpcHRzL3dlYmtpdHB5L3BvcnQvd3BlLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0 L3dwZS5weQppbmRleCBjOTQzNGYzZDUxZDkxYmZmYWRkYjg5MmJiYTU5MWNkNGE1MzczZjQxLi4x NDRiOWEwYTgwNmY5ZjgwY2IzYTc5OWUzZTAxYjI3MGQ4YWUxMDY5IDEwMDY0NAotLS0gYS9Ub29s cy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvd3BlLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0 cHkvcG9ydC93cGUucHkKQEAgLTE2NCw3ICsxNjQsNyBAQCBjbGFzcyBXUEVQb3J0KFBvcnQpOgog ICAgICAgICBpZiBicm93c2VyOgogICAgICAgICAgICAgcHJpbnQoIlVua25vd24gYnJvd3NlciB7 fS4gRGVmYXVsdGluZyB0byBDb2cgYW5kIE1pbmlCcm93c2VyIHNlbGVjdGlvbiIuZm9ybWF0KGJy b3dzZXIpKQogCi0gICAgICAgIGlmIHNlbGYuX2ZpbGVzeXN0ZW0uaXNmaWxlKHNlbGYuY29nX3Bh dGhfdG8oJ2NvZycpKToKKyAgICAgICAgaWYgc2VsZi5fZmlsZXN5c3RlbS5pc2ZpbGUoc2VsZi5j b2dfcGF0aF90byhvcy5wYXRoLmpvaW4oJ2xhdW5jaGVyJywgJ2NvZycpKSk6CiAgICAgICAgICAg ICByZXR1cm4gImNvZyIKICAgICAgICAgcmV0dXJuICJtaW5pYnJvd3NlciIKIApAQCAtMTgzLDcg KzE4Myw3IEBAIGNsYXNzIFdQRVBvcnQoUG9ydCk6CiAgICAgICAgIG1pbmlCcm93c2VyID0gTm9u ZQogCiAgICAgICAgIGlmIHNlbGYuYnJvd3Nlcl9uYW1lKCkgPT0gImNvZyI6Ci0gICAgICAgICAg ICBtaW5pQnJvd3NlciA9IHNlbGYuY29nX3BhdGhfdG8oJ2NvZycpCisgICAgICAgICAgICBtaW5p QnJvd3NlciA9IHNlbGYuY29nX3BhdGhfdG8ob3MucGF0aC5qb2luKCdsYXVuY2hlcicsICdjb2cn KSkKICAgICAgICAgICAgIGlmIG5vdCBzZWxmLl9maWxlc3lzdGVtLmlzZmlsZShtaW5pQnJvd3Nl cik6CiAgICAgICAgICAgICAgICAgcHJpbnQoIkNvZyBub3QgZm91bmQg8J+Yoi4gSWYgeW91IHdp c2ggdG8gZW5hYmxlIGl0LCByZWJ1aWxkIHdpdGggYC1ERU5BQkxFX0NPRz1PTmAuIEZhbGxpbmcg YmFjayB0byBnb29kIG9sZCBNaW5pQnJvd3NlciIpCiAgICAgICAgICAgICAgICAgbWluaUJyb3dz ZXIgPSBOb25lCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvd3BlX3Vu aXR0ZXN0LnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L3dwZV91bml0dGVzdC5weQpp bmRleCAyMDUyMmVmZTkwOTU4NTkyOGRkMTU3N2UxY2Y4MjdmY2M0ZjQ1MDZjLi5mMGUxMGY3Mzg5 NWMwZmNkYjc4ZTUxOTZkOGU4MzA3OWIwOGJmYjY1IDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRz L3dlYmtpdHB5L3BvcnQvd3BlX3VuaXR0ZXN0LnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0 cHkvcG9ydC93cGVfdW5pdHRlc3QucHkKQEAgLTg2LDcgKzg2LDcgQEAgY2xhc3MgV1BFUG9ydFRl c3QocG9ydF90ZXN0Y2FzZS5Qb3J0VGVzdENhc2UpOgogICAgICAgICB3aXRoIHBhdGNoKCdvcy5l bnZpcm9uJywgeydXUEVfQlJPV1NFUic6ICcnfSk6CiAgICAgICAgICAgICBwb3J0ID0gc2VsZi5t YWtlX3BvcnQoKQogICAgICAgICAgICAgcG9ydC5fZmlsZXN5c3RlbSA9IE1vY2tGaWxlU3lzdGVt KHsKLSAgICAgICAgICAgICAgICAiL21vY2stYnVpbGQvVG9vbHMvY29nLXByZWZpeC9zcmMvY29n LWJ1aWxkL2NvZyI6ICIiLAorICAgICAgICAgICAgICAgICIvbW9jay1idWlsZC9Ub29scy9jb2ct cHJlZml4L3NyYy9jb2ctYnVpbGQvbGF1bmNoZXIvY29nIjogIiIsCiAgICAgICAgICAgICB9KQog ICAgICAgICAgICAgc2VsZi5hc3NlcnRFcXVhbChwb3J0LmJyb3dzZXJfbmFtZSgpLCAiY29nIikK IApAQCAtOTQsNyArOTQsNyBAQCBjbGFzcyBXUEVQb3J0VGVzdChwb3J0X3Rlc3RjYXNlLlBvcnRU ZXN0Q2FzZSk6CiAgICAgICAgIHdpdGggcGF0Y2goJ29zLmVudmlyb24nLCB7J1dQRV9CUk9XU0VS JzogJ01pbmlCcm93c2VyJ30pOgogICAgICAgICAgICAgcG9ydCA9IHNlbGYubWFrZV9wb3J0KCkK ICAgICAgICAgICAgIHBvcnQuX2ZpbGVzeXN0ZW0gPSBNb2NrRmlsZVN5c3RlbSh7Ci0gICAgICAg ICAgICAgICAgIi9tb2NrLWJ1aWxkL1Rvb2xzL2NvZy1wcmVmaXgvc3JjL2NvZy1idWlsZC9jb2ci OiAiIiwKKyAgICAgICAgICAgICAgICAiL21vY2stYnVpbGQvVG9vbHMvY29nLXByZWZpeC9zcmMv Y29nLWJ1aWxkL2xhdW5jaGVyL2NvZyI6ICIiLAogICAgICAgICAgICAgfSkKICAgICAgICAgICAg IHNlbGYuYXNzZXJ0RXF1YWwocG9ydC5icm93c2VyX25hbWUoKSwgIm1pbmlicm93c2VyIikKIAo=