234095 2021-12-09 11:34:04 -0800 [Playstation] Fix build break after r286751 with INTELLIGENT_TRACKING_PREVENTION enabled 2021-12-09 20:51:23 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jigen.zhou jigen.zhou darin don.olmstead webkit-bug-importer oldest_to_newest 1822234 0 jigen.zhou 2021-12-09 11:34:04 -0800 In file included from WebKit/DerivedSources/unified-sources/UnifiedSource-72468c22-4.cpp:1: In file included from C:/work/webkit/jenkins/neko/Source/WebKit\NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp:32: C:/work/webkit/jenkins/neko/Source/WebKit/NetworkProcess\NetworkSession.h:197:174: error: no type named 'ResourceError' in namespace 'WebCore' virtual void requestResource(WebPageProxyIdentifier, WebCore::ResourceRequest&&, CompletionHandler<void(const IPC::DataReference&, WebCore::ResourceResponse&&, WebCore::ResourceError&&)>&&) { } ~~~~~~~~~^ 1 error generated. 1822249 1 446585 jigen.zhou 2021-12-09 12:02:12 -0800 Created attachment 446585 Patch 1822259 2 446585 don.olmstead 2021-12-09 12:26:32 -0800 Comment on attachment 446585 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=446585&action=review > Source/WebKit/NetworkProcess/NetworkSession.h:44 > +#include <WebCore/ResourceError.h> Can you confirm that a forward declaration wouldn't resolve the issue? Ideally we only include what we absolutely need to in the header file. 1822274 3 446593 jigen.zhou 2021-12-09 12:55:41 -0800 Created attachment 446593 Patch Yes, a forward declaration works. Thanks. 1822501 4 ews-feeder 2021-12-09 20:50:02 -0800 Committed r286830 (245063@main): <https://commits.webkit.org/245063@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 446593. 1822502 5 webkit-bug-importer 2021-12-09 20:51:23 -0800 <rdar://problem/86305720> 446585 2021-12-09 12:02:12 -0800 2021-12-09 12:55:41 -0800 Patch PATCH text/plain 1277 jigen.zhou ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggYjgxNTY4MjNhNzEyLi4wOGJmMTNlNmU3MjEgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMTYgQEAKKzIwMjEtMTItMDkgIEppZ2VuIFpob3UgIDxqaWdlbi56aG91QHNvbnkuY29tPgor CisgICAgICAgIFtQbGF5c3RhdGlvbl0gRml4IGJ1aWxkIGJyZWFrIGFmdGVyIHIyODY3NTEgd2l0 aCBJTlRFTExJR0VOVF9UUkFDS0lOR19QUkVWRU5USU9OIGVuYWJsZWQKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNDA5NQorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZGVkIGhlYWRlciA8V2ViQ29yZS9S ZXNvdXJjZUVycm9yLmg+IHRvIE5ldHdvcmtTZXNzaW9uLmggdG8gcmVzb2x2ZQorICAgICAgICBh IGNvbXBpbGluZyBlcnJvci4gTm8gbmV3IHRlc3QgaXMgbmVlZCBzaW5jZSBubyBiZWhhdmlvciBj aGFuZ2UgaXMKKyAgICAgICAgZXhwZWN0ZWQuCisKKyAgICAgICAgKiBOZXR3b3JrUHJvY2Vzcy9O ZXR3b3JrU2Vzc2lvbi5oOgorCiAyMDIxLTEyLTA4ICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlz dGVuc2VuQHdlYmtpdC5vcmc+CiAKICAgICAgICAgQWRkIFNQSSB0byBsb2FkIGEgcmVzb3VyY2Ug aW4gdGhlIGNvbnRleHQgb2YgYSBwYWdlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L05ldHdv cmtQcm9jZXNzL05ldHdvcmtTZXNzaW9uLmggYi9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNz L05ldHdvcmtTZXNzaW9uLmgKaW5kZXggZjg1MTFmZjE1OGJjLi43NjE3YmExYWQ3NWQgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvTmV0d29ya1Nlc3Npb24uaAorKysg Yi9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL05ldHdvcmtTZXNzaW9uLmgKQEAgLTQxLDYg KzQxLDcgQEAKICNpbmNsdWRlIDxXZWJDb3JlL05ldHdvcmtTdG9yYWdlU2Vzc2lvbi5oPgogI2lu Y2x1ZGUgPFdlYkNvcmUvUHJpdmF0ZUNsaWNrTWVhc3VyZW1lbnQuaD4KICNpbmNsdWRlIDxXZWJD b3JlL1JlZ2lzdHJhYmxlRG9tYWluLmg+CisjaW5jbHVkZSA8V2ViQ29yZS9SZXNvdXJjZUVycm9y Lmg+CiAjaW5jbHVkZSA8cGFsL1Nlc3Npb25JRC5oPgogI2luY2x1ZGUgPHd0Zi9IYXNoU2V0Lmg+ CiAjaW5jbHVkZSA8d3RmL1JlZi5oPgo= 446593 2021-12-09 12:55:41 -0800 2021-12-09 20:50:04 -0800 Patch PATCH text/plain 1262 jigen.zhou ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggYjgxNTY4MjNhNzEyLi45ODM5MWQ0NDc0YWYgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMTUgQEAKKzIwMjEtMTItMDkgIEppZ2VuIFpob3UgIDxqaWdlbi56aG91QHNvbnkuY29tPgor CisgICAgICAgIFtQbGF5c3RhdGlvbl0gRml4IGJ1aWxkIGJyZWFrIGFmdGVyIHIyODY3NTEgd2l0 aCBJTlRFTExJR0VOVF9UUkFDS0lOR19QUkVWRU5USU9OIGVuYWJsZWQKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNDA5NQorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZGVkIGEgZm9yd2FyZCBkZWNsYXJh dGlvbiBvZiBjbGFzcyBSZXNvdXJjZUVycm9yIHRvIE5ldHdvcmtTZXNzaW9uLmggdG8gcmVzb2x2 ZQorICAgICAgICBhIGNvbXBpbGluZyBlcnJvci4gTm8gbmV3IHRlc3QgaXMgbmVlZCBzaW5jZSBu byBiZWhhdmlvciBjaGFuZ2UgaXMgZXhwZWN0ZWQuCisKKyAgICAgICAgKiBOZXR3b3JrUHJvY2Vz cy9OZXR3b3JrU2Vzc2lvbi5oOgorCiAyMDIxLTEyLTA4ICBBbGV4IENocmlzdGVuc2VuICA8YWNo cmlzdGVuc2VuQHdlYmtpdC5vcmc+CiAKICAgICAgICAgQWRkIFNQSSB0byBsb2FkIGEgcmVzb3Vy Y2UgaW4gdGhlIGNvbnRleHQgb2YgYSBwYWdlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L05l dHdvcmtQcm9jZXNzL05ldHdvcmtTZXNzaW9uLmggYi9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9j ZXNzL05ldHdvcmtTZXNzaW9uLmgKaW5kZXggZjg1MTFmZjE1OGJjLi40YjgwZTUyOGE0NGMgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvTmV0d29ya1Nlc3Npb24uaAor KysgYi9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL05ldHdvcmtTZXNzaW9uLmgKQEAgLTU0 LDYgKzU0LDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogY2xhc3MgQ2VydGlmaWNhdGVJbmZvOwog Y2xhc3MgTmV0d29ya1N0b3JhZ2VTZXNzaW9uOwogY2xhc3MgUmVzb3VyY2VSZXF1ZXN0OworY2xh c3MgUmVzb3VyY2VFcnJvcjsKIGVudW0gY2xhc3MgSW5jbHVkZUh0dHBPbmx5Q29va2llcyA6IGJv b2w7CiBlbnVtIGNsYXNzIFNob3VsZFNhbXBsZSA6IGJvb2w7CiBzdHJ1Y3QgU2VjdXJpdHlPcmln aW5EYXRhOwo=