234085 2021-12-09 08:30:43 -0800 AX: Improve ASSERT while processing tree appends in AXIsolatedTree::applyPendingChanges 2021-12-09 15:21:59 -0800 1 1 1 Unclassified WebKit Accessibility WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 tyler_w tyler_w aboxhall andresg_22 apinheiro cfleizach dmazzoni ews-watchlist jcraig jdiggs samuel_white webkit-bug-importer oldest_to_newest 1822137 0 tyler_w 2021-12-09 08:30:43 -0800 The current assert: ASSERT_UNUSED(addResult, addResult.iterator->value->refCount() == 2 || (addResult.iterator->value.ptr() == m_rootNode.get() && m_rootNode->refCount() == 3)); Doesn't say what the refcount actually is, making it harder to debug. This was a problem for me when working on a previous patch. 1822139 1 446552 tyler_w 2021-12-09 08:34:10 -0800 Created attachment 446552 Patch 1822290 2 webkit-bug-importer 2021-12-09 13:12:43 -0800 <rdar://problem/86287382> 1822376 3 ews-feeder 2021-12-09 15:21:54 -0800 Committed r286811 (245047@main): <https://commits.webkit.org/245047@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 446552. 446552 2021-12-09 08:34:10 -0800 2021-12-09 15:21:57 -0800 Patch bug-234085-20211209103409.patch text/plain 2620 tyler_w U3VidmVyc2lvbiBSZXZpc2lvbjogMjg2NzgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2RiMmM4OGI1NDQ1M2Iy ODE3MDEwYjBiYjVhMWZlNjllNDQ4MDgzYS4uODg4MDA4NDBlNzY5N2FlNTlkOWI1Mzg5MjQ3MDhm OTU4MWIyMmViMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDIxLTEyLTA5ICBUeWxl ciBXaWxjb2NrICA8dHlsZXJfd0BhcHBsZS5jb20+CisKKyAgICAgICAgQVg6IEltcHJvdmUgQVNT RVJUIHdoaWxlIHByb2Nlc3NpbmcgdHJlZSBhcHBlbmRzIGluIEFYSXNvbGF0ZWRUcmVlOjphcHBs eVBlbmRpbmdDaGFuZ2VzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0yMzQwODUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBXaGVuIHByb2Nlc3NpbmcgbV9wZW5kaW5nQXBwZW5kcyBpbiBBWElzb2xhdGVkVHJl ZTo6YXBwbHlQZW5kaW5nQ2hhbmdlcywKKyAgICAgICAgd2UgQVNTRVJUIHRvIHZlcmlmeSB0aGUg cmVmY291bnQgaXMgd2hhdCB3ZSBleHBlY3Q6CisKKyAgICAgICAgQVNTRVJUX1VOVVNFRChhZGRS ZXN1bHQsIGFkZFJlc3VsdC5pdGVyYXRvci0+dmFsdWUtPnJlZkNvdW50KCkgPT0gMgorICAgICAg ICAgICAgfHwgKGFkZFJlc3VsdC5pdGVyYXRvci0+dmFsdWUucHRyKCkgPT0gbV9yb290Tm9kZS5n ZXQoKSAmJiBtX3Jvb3ROb2RlLT5yZWZDb3VudCgpID09IDMpKTsKKworICAgICAgICBCdXQgdGhp cyBkb2Vzbid0IGluY2x1ZGUgdGhlIGFjdHVhbCByZWZjb3VudCBpbiB0aGUgQVNTRVJUIG1lc3Nh Z2UsCisgICAgICAgIG1ha2luZyBpdCBoYXJkZXIgdG8gZGVidWcuCisKKyAgICAgICAgVGhpcyBw YXRjaCB1c2VzIEFTU0VSVF9XSVRIX01FU1NBR0UgdG8gZGlzcGxheSB0aGUgYWN0dWFsIHJlZmNv dW50LgorCisgICAgICAgICogYWNjZXNzaWJpbGl0eS9pc29sYXRlZHRyZWUvQVhJc29sYXRlZFRy ZWUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6QVhJc29sYXRlZFRyZWU6OmFwcGx5UGVuZGluZ0No YW5nZXMpOgorCiAyMDIxLTEyLTA5ICBUeWxlciBXaWxjb2NrICA8dHlsZXJfd0BhcHBsZS5jb20+ CiAKICAgICAgICAgQVg6IFVzZSBSZWZQdHI8QVhDb3JlT2JqZWN0PiBpbnN0ZWFkIG9mIHJhdyBB WENvcmVPYmplY3QqIHBvaW50ZXJzIGluIEFjY2Vzc2liaWxpdHk6OmZpbmRNYXRjaGluZ09iamVj dHMgYW5kIGRvd25zdHJlYW0gZnVuY3Rpb25zCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9h Y2Nlc3NpYmlsaXR5L2lzb2xhdGVkdHJlZS9BWElzb2xhdGVkVHJlZS5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9hY2Nlc3NpYmlsaXR5L2lzb2xhdGVkdHJlZS9BWElzb2xhdGVkVHJlZS5jcHAKaW5kZXgg YmVhY2VjNThlNmVhYmZlYzAxM2NkMjM0ZjZiZjQ1YTc0ZGI4NjI0Ny4uNDBiMjk0ZmJjM2U0NmE2 ZTcwM2RjZDEwYmNhYmY2NmE0M2E0YjNjMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYWNj ZXNzaWJpbGl0eS9pc29sYXRlZHRyZWUvQVhJc29sYXRlZFRyZWUuY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL2FjY2Vzc2liaWxpdHkvaXNvbGF0ZWR0cmVlL0FYSXNvbGF0ZWRUcmVlLmNwcApAQCAt NTEyLDggKzUxMiwxMCBAQCB2b2lkIEFYSXNvbGF0ZWRUcmVlOjphcHBseVBlbmRpbmdDaGFuZ2Vz KCkKICAgICAgICAgLy8gVGhlIHJlZmVyZW5jZSBjb3VudCBvZiB0aGUganVzdCBhZGRlZCBJc29s YXRlZE9iamVjdCBtdXN0IGJlIDIKICAgICAgICAgLy8gYmVjYXVzZSBpdCBpcyByZWZlcmVuY2Vk IGJ5IG1fcmVhZGVyVGhyZWFkTm9kZU1hcCBhbmQgbV9wZW5kaW5nQXBwZW5kcy4KICAgICAgICAg Ly8gV2hlbiBtX3BlbmRpbmdBcHBlbmRzIGlzIGNsZWFyZWQsIHRoZSBvYmplY3Qgd2lsbCBiZSBo ZWxkIG9ubHkgYnkgbV9yZWFkZXJUaHJlYWROb2RlTWFwLiBUaGUgZXhjZXB0aW9uIGlzIHRoZSBy b290IG5vZGUgd2hvc2UgcmVmZXJlbmNlIGNvdW50IGlzIDMuCi0gICAgICAgIEFTU0VSVF9VTlVT RUQoYWRkUmVzdWx0LCBhZGRSZXN1bHQuaXRlcmF0b3ItPnZhbHVlLT5yZWZDb3VudCgpID09IDIK LSAgICAgICAgICAgIHx8IChhZGRSZXN1bHQuaXRlcmF0b3ItPnZhbHVlLnB0cigpID09IG1fcm9v dE5vZGUuZ2V0KCkgJiYgbV9yb290Tm9kZS0+cmVmQ291bnQoKSA9PSAzKSk7CisgICAgICAgIEFT U0VSVF9XSVRIX01FU1NBR0UoCisgICAgICAgICAgICBhZGRSZXN1bHQuaXRlcmF0b3ItPnZhbHVl LT5yZWZDb3VudCgpID09IDIgfHwgKGFkZFJlc3VsdC5pdGVyYXRvci0+dmFsdWUucHRyKCkgPT0g bV9yb290Tm9kZS5nZXQoKSAmJiBtX3Jvb3ROb2RlLT5yZWZDb3VudCgpID09IDMpLAorICAgICAg ICAgICAgInVuZXhwZWN0ZWQgcmVmIGNvdW50IGFmdGVyIGFkZGluZyBvYmplY3QgdG8gbV9yZWFk ZXJUaHJlYWROb2RlTWFwOiAlZCIsIGFkZFJlc3VsdC5pdGVyYXRvci0+dmFsdWUtPnJlZkNvdW50 KCkKKyAgICAgICAgKTsKICAgICB9CiAgICAgbV9wZW5kaW5nQXBwZW5kcy5jbGVhcigpOwogCg==