234056 2021-12-08 18:34:19 -0800 Use thread safe initialization for statics in Font::getCFStringAttributes 2022-07-20 20:12:35 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Local Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=234102 InRadar P2 Normal --- 233488 1 heycam heycam bfulgham darin mattwoodrow mmaxfield simon.fraser webkit-bug-importer zalan oldest_to_newest 1821920 0 heycam 2021-12-08 18:34:19 -0800 Use thread safe initialization for statics in Font::getCFStringAttributes 1821921 1 446476 heycam 2021-12-08 18:35:02 -0800 Created attachment 446476 Patch 1821922 2 heycam 2021-12-08 18:35:54 -0800 This is another one where the benefit of avoiding allocating these objects might be overwhelmed by the lines of code to do the caching. 1821943 3 446476 darin 2021-12-08 19:02:28 -0800 Comment on attachment 446476 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=446476&action=review > Source/WebCore/platform/graphics/mac/SimpleFontDataCoreText.cpp:46 > +static CFNumberRef zeroKerningValue() This function just returns a float zero. I don’t think its name should include "kerning value". It can be reused by anyone who needs a 0.0f as a CFNumber. 1822548 4 heycam 2021-12-09 23:53:27 -0800 This too won't be needed if bug 234102 works. 1824635 5 webkit-bug-importer 2021-12-15 18:35:16 -0800 <rdar://problem/86553412> 1885452 6 461058 mattwoodrow 2022-07-20 14:43:08 -0700 Created attachment 461058 Patch 1885542 7 ews-feeder 2022-07-20 20:12:33 -0700 Committed 252677@main (070a876c5310): <https://commits.webkit.org/252677@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 461058. 446476 2021-12-08 18:35:02 -0800 2021-12-08 19:02:28 -0800 Patch bug-234056-20211209133501.patch text/plain 3735 heycam U3VidmVyc2lvbiBSZXZpc2lvbjogMjg2NjM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTNlZTM2MTM0OTRjM2Qz NjMzNjdjZmFiY2ViYmUwODU5YjQyZGQ2MS4uMGYyYTYzYTY0MWFkMDg0YzUyNWMxNzI4MTk2NzM2 Nzc5MjljOTIwYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDIxLTEyLTAzICBDYW1l cm9uIE1jQ29ybWFjayAgPGhleWNhbUBhcHBsZS5jb20+CisKKyAgICAgICAgVXNlIHRocmVhZCBz YWZlIGluaXRpYWxpemF0aW9uIGZvciBzdGF0aWNzIGluIEZvbnQ6OmdldENGU3RyaW5nQXR0cmli dXRlcworICAgICAgICBOZWVkIHRoZSBidWcgVVJMIChPT1BTISkuCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRm9udDo6Z2V0Q0ZTdHJpbmdBdHRyaWJ1 dGVzIGNhbiBiZSBjYWxsZWQgZnJvbSB3b3JrZXIgdGhyZWFkcyB1c2luZworICAgICAgICBPZmZz Y3JlZW5DYW52YXMsIGJ1dCBkb2Vzbid0IGluaXRpYWxpemUgaXRzIHN0YXRpYyB2YXJpYWJsZXMK KyAgICAgICAgcGFyYWdyYXBoU3R5bGUgYW5kIHplcm9LZXJuaW5nVmFsdWUgaW4gYSB0aHJlYWQg c2FmZSBtYW5uZXIgKGdpdmVuIHRoZQorICAgICAgICAtZm5vLXRocmVhZHNhZmUtc3RhdGljcyBj b25maWd1cmF0aW9uIEFwcGxlIHBvcnRzIHVzZSkuIFVzZQorICAgICAgICBzdGQ6OmNhbGxfb25j ZSB0byBlbnN1cmUgb25seSBvbmUgdGhyZWFkIHdpbGwgaW5pdGlhbGl6ZSB0aGUgdmFyaWFibGVz LgorICAgICAgICBUaGUgQ1RQYXJhZ3JhcGhTdHlsZSBhbmQgQ0ZOdW1iZXIgb2JqZWN0cyBjcmVh dGVkIGlzIHNhZmUgdG8gdXNlIGZyb20KKyAgICAgICAgYW55IHRocmVhZCBhZnRlciBjcmVhdGlv bi4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL21hYy9TaW1wbGVGb250RGF0YUNvcmVU ZXh0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OnBhcmFncmFwaFN0eWxlV2l0aENvbXBvc2l0aW9u TGFuZ3VhZ2VOb25lKToKKyAgICAgICAgKFdlYkNvcmU6Onplcm9LZXJuaW5nVmFsdWUpOgorICAg ICAgICAoV2ViQ29yZTo6Rm9udDo6Z2V0Q0ZTdHJpbmdBdHRyaWJ1dGVzIGNvbnN0KToKKwogMjAy MS0xMi0wMyAgQ2FtZXJvbiBNY0Nvcm1hY2sgIDxoZXljYW1AYXBwbGUuY29tPgogCiAgICAgICAg IFVzZSB0aHJlYWQgc2FmZSBpbml0aWFsaXphdGlvbiBmb3Igc3RhdGljcyBpbiBDb21wbGV4VGV4 dENvbnRyb2xsZXI6OmNvbGxlY3RDb21wbGV4VGV4dFJ1bnNGb3JDaGFyYWN0ZXJzCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9tYWMvU2ltcGxlRm9udERhdGFD b3JlVGV4dC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9tYWMvU2ltcGxl Rm9udERhdGFDb3JlVGV4dC5jcHAKaW5kZXggZmFhYjZlMTRmMDI3YTQ0NGJkNmRlMjcxMmU2Njk1 NGE3NjU1ZGQxYi4uMThiNzNjZTJkYWE2YmU4MDJhZDAzOTAyYWRiNGQ2ZmY1YzRlNDRkMiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvbWFjL1NpbXBsZUZvbnRE YXRhQ29yZVRleHQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL21h Yy9TaW1wbGVGb250RGF0YUNvcmVUZXh0LmNwcApAQCAtMzIsNiArMzIsMjggQEAKIAogbmFtZXNw YWNlIFdlYkNvcmUgewogCitzdGF0aWMgQ1RQYXJhZ3JhcGhTdHlsZVJlZiBwYXJhZ3JhcGhTdHls ZVdpdGhDb21wb3NpdGlvbkxhbmd1YWdlTm9uZSgpCit7CisgICAgc3RhdGljIExhenlOZXZlckRl c3Ryb3llZDxSZXRhaW5QdHI8Q1RQYXJhZ3JhcGhTdHlsZVJlZj4+IHBhcmFncmFwaFN0eWxlOwor ICAgIHN0YXRpYyBzdGQ6Om9uY2VfZmxhZyBvbmNlRmxhZzsKKyAgICBzdGQ6OmNhbGxfb25jZShv bmNlRmxhZywgWyZdIHsKKyAgICAgICAgcGFyYWdyYXBoU3R5bGUuY29uc3RydWN0KENUUGFyYWdy YXBoU3R5bGVDcmVhdGUobnVsbHB0ciwgMCkpOworICAgICAgICBDVFBhcmFncmFwaFN0eWxlU2V0 Q29tcG9zaXRpb25MYW5ndWFnZShwYXJhZ3JhcGhTdHlsZS5nZXQoKS5nZXQoKSwga0NUQ29tcG9z aXRpb25MYW5ndWFnZU5vbmUpOworICAgIH0pOworICAgIHJldHVybiBwYXJhZ3JhcGhTdHlsZS5n ZXQoKS5nZXQoKTsKK30KKworc3RhdGljIENGTnVtYmVyUmVmIHplcm9LZXJuaW5nVmFsdWUoKQor eworICAgIHN0YXRpYyBMYXp5TmV2ZXJEZXN0cm95ZWQ8UmV0YWluUHRyPENGTnVtYmVyUmVmPj4g emVyb0tlcm5pbmdWYWx1ZTsKKyAgICBzdGF0aWMgc3RkOjpvbmNlX2ZsYWcgb25jZUZsYWc7Cisg ICAgc3RkOjpjYWxsX29uY2Uob25jZUZsYWcsIFsmXSB7CisgICAgICAgIGNvbnN0IGZsb2F0IHpl cm8gPSAwOworICAgICAgICB6ZXJvS2VybmluZ1ZhbHVlLmNvbnN0cnVjdChhZG9wdENGKENGTnVt YmVyQ3JlYXRlKGtDRkFsbG9jYXRvckRlZmF1bHQsIGtDRk51bWJlckZsb2F0VHlwZSwgJnplcm8p KSk7CisgICAgfSk7CisgICAgcmV0dXJuIHplcm9LZXJuaW5nVmFsdWUuZ2V0KCkuZ2V0KCk7Cit9 CisKIFJldGFpblB0cjxDRkRpY3Rpb25hcnlSZWY+IEZvbnQ6OmdldENGU3RyaW5nQXR0cmlidXRl cyhib29sIGVuYWJsZUtlcm5pbmcsIEZvbnRPcmllbnRhdGlvbiBvcmllbnRhdGlvbiwgY29uc3Qg QXRvbVN0cmluZyYgbG9jYWxlKSBjb25zdAogewogICAgIENGVHlwZVJlZiBrZXlzWzVdOwpAQCAt NTIsMjAgKzc0LDEzIEBAIFJldGFpblB0cjxDRkRpY3Rpb25hcnlSZWY+IEZvbnQ6OmdldENGU3Ry aW5nQXR0cmlidXRlcyhib29sIGVuYWJsZUtlcm5pbmcsIEZvbnRPCiAjZWxzZQogICAgIFVOVVNF RF9QQVJBTShsb2NhbGUpOwogI2VuZGlmCi0gICAgc3RhdGljIENUUGFyYWdyYXBoU3R5bGVSZWYg cGFyYWdyYXBoU3R5bGUgPSBbXSB7Ci0gICAgICAgIGF1dG8gcGFyYWdyYXBoU3R5bGUgPSBDVFBh cmFncmFwaFN0eWxlQ3JlYXRlKG51bGxwdHIsIDApOwotICAgICAgICBDVFBhcmFncmFwaFN0eWxl U2V0Q29tcG9zaXRpb25MYW5ndWFnZShwYXJhZ3JhcGhTdHlsZSwga0NUQ29tcG9zaXRpb25MYW5n dWFnZU5vbmUpOwotICAgICAgICByZXR1cm4gcGFyYWdyYXBoU3R5bGU7Ci0gICAgfSgpOwogICAg IGtleXNbY291bnRdID0ga0NUUGFyYWdyYXBoU3R5bGVBdHRyaWJ1dGVOYW1lOwotICAgIHZhbHVl c1tjb3VudF0gPSBwYXJhZ3JhcGhTdHlsZTsKKyAgICB2YWx1ZXNbY291bnRdID0gcGFyYWdyYXBo U3R5bGVXaXRoQ29tcG9zaXRpb25MYW5ndWFnZU5vbmUoKTsKICAgICArK2NvdW50OwogCiAgICAg aWYgKCFlbmFibGVLZXJuaW5nKSB7Ci0gICAgICAgIGNvbnN0IGZsb2F0IHplcm8gPSAwOwotICAg ICAgICBzdGF0aWMgTmV2ZXJEZXN0cm95ZWQ8UmV0YWluUHRyPENGTnVtYmVyUmVmPj4gemVyb0tl cm5pbmdWYWx1ZSA9IGFkb3B0Q0YoQ0ZOdW1iZXJDcmVhdGUoa0NGQWxsb2NhdG9yRGVmYXVsdCwg a0NGTnVtYmVyRmxvYXRUeXBlLCAmemVybykpOwogICAgICAgICBrZXlzW2NvdW50XSA9IGtDVEtl cm5BdHRyaWJ1dGVOYW1lOwotICAgICAgICB2YWx1ZXNbY291bnRdID0gemVyb0tlcm5pbmdWYWx1 ZS5nZXQoKS5nZXQoKTsKKyAgICAgICAgdmFsdWVzW2NvdW50XSA9IHplcm9LZXJuaW5nVmFsdWUo KTsKICAgICAgICAgKytjb3VudDsKICAgICB9CiAK 461058 2022-07-20 14:43:08 -0700 2022-07-20 20:12:34 -0700 Patch bug-234056-20220721094307.patch text/plain 3332 mattwoodrow RnJvbSA3ZDJkYWVjNmYwOTJjYWNmOGI2NTFiZGY2NmQxNjA1ODBiZWVhNDZiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBDYW1lcm9uIE1jQ29ybWFjayA8aGV5Y2FtQGFwcGxlLmNvbT4K RGF0ZTogTW9uLCA2IERlYyAyMDIxIDA5OjExOjI4ICsxMTAwClN1YmplY3Q6IFtQQVRDSF0gVXNl IHRocmVhZCBzYWZlIGluaXRpYWxpemF0aW9uIGZvciBzdGF0aWNzIGluCiBGb250OjpnZXRDRlN0 cmluZ0F0dHJpYnV0ZXMgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIz NDA1NgoKUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCgpGb250OjpnZXRDRlN0cmluZ0F0dHJpYnV0 ZXMgY2FuIGJlIGNhbGxlZCBmcm9tIHdvcmtlciB0aHJlYWRzIHVzaW5nCk9mZnNjcmVlbkNhbnZh cywgYnV0IGRvZXNuJ3QgaW5pdGlhbGl6ZSBpdHMgc3RhdGljIHZhcmlhYmxlcwpwYXJhZ3JhcGhT dHlsZSBhbmQgemVyb0tlcm5pbmdWYWx1ZSBpbiBhIHRocmVhZCBzYWZlIG1hbm5lciAoZ2l2ZW4g dGhlCi1mbm8tdGhyZWFkc2FmZS1zdGF0aWNzIGNvbmZpZ3VyYXRpb24gQXBwbGUgcG9ydHMgdXNl KS4gVXNlCnN0ZDo6Y2FsbF9vbmNlIHRvIGVuc3VyZSBvbmx5IG9uZSB0aHJlYWQgd2lsbCBpbml0 aWFsaXplIHRoZSB2YXJpYWJsZXMuClRoZSBDVFBhcmFncmFwaFN0eWxlIGFuZCBDRk51bWJlciBv YmplY3RzIGNyZWF0ZWQgaXMgc2FmZSB0byB1c2UgZnJvbQphbnkgdGhyZWFkIGFmdGVyIGNyZWF0 aW9uLgoKKiBwbGF0Zm9ybS9ncmFwaGljcy9tYWMvU2ltcGxlRm9udERhdGFDb3JlVGV4dC5jcHA6 CihXZWJDb3JlOjpwYXJhZ3JhcGhTdHlsZVdpdGhDb21wb3NpdGlvbkxhbmd1YWdlTm9uZSk6CihX ZWJDb3JlOjp6ZXJvVmFsdWUpOgooV2ViQ29yZTo6Rm9udDo6Z2V0Q0ZTdHJpbmdBdHRyaWJ1dGVz IGNvbnN0KToKLS0tCiAuLi4vZ3JhcGhpY3MvbWFjL1NpbXBsZUZvbnREYXRhQ29yZVRleHQuY3Bw ICAgfCAzMyArKysrKysrKysrKysrKy0tLS0tCiAxIGZpbGUgY2hhbmdlZCwgMjQgaW5zZXJ0aW9u cygrKSwgOSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9tYWMvU2ltcGxlRm9udERhdGFDb3JlVGV4dC5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9tYWMvU2ltcGxlRm9udERhdGFDb3JlVGV4dC5jcHAKaW5kZXgg ZmFhYjZlMTRmMDI3Li5jMmQ5OGY5OWJiMjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL21hYy9TaW1wbGVGb250RGF0YUNvcmVUZXh0LmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9tYWMvU2ltcGxlRm9udERhdGFDb3JlVGV4dC5j cHAKQEAgLTMyLDYgKzMyLDI4IEBACiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAorc3RhdGljIENU UGFyYWdyYXBoU3R5bGVSZWYgcGFyYWdyYXBoU3R5bGVXaXRoQ29tcG9zaXRpb25MYW5ndWFnZU5v bmUoKQoreworICAgIHN0YXRpYyBMYXp5TmV2ZXJEZXN0cm95ZWQ8UmV0YWluUHRyPENUUGFyYWdy YXBoU3R5bGVSZWY+PiBwYXJhZ3JhcGhTdHlsZTsKKyAgICBzdGF0aWMgc3RkOjpvbmNlX2ZsYWcg b25jZUZsYWc7CisgICAgc3RkOjpjYWxsX29uY2Uob25jZUZsYWcsIFsmXSB7CisgICAgICAgIHBh cmFncmFwaFN0eWxlLmNvbnN0cnVjdChDVFBhcmFncmFwaFN0eWxlQ3JlYXRlKG51bGxwdHIsIDAp KTsKKyAgICAgICAgQ1RQYXJhZ3JhcGhTdHlsZVNldENvbXBvc2l0aW9uTGFuZ3VhZ2UocGFyYWdy YXBoU3R5bGUuZ2V0KCkuZ2V0KCksIGtDVENvbXBvc2l0aW9uTGFuZ3VhZ2VOb25lKTsKKyAgICB9 KTsKKyAgICByZXR1cm4gcGFyYWdyYXBoU3R5bGUuZ2V0KCkuZ2V0KCk7Cit9CisKK3N0YXRpYyBD Rk51bWJlclJlZiB6ZXJvVmFsdWUoKQoreworICAgIHN0YXRpYyBMYXp5TmV2ZXJEZXN0cm95ZWQ8 UmV0YWluUHRyPENGTnVtYmVyUmVmPj4gemVyb1ZhbHVlOworICAgIHN0YXRpYyBzdGQ6Om9uY2Vf ZmxhZyBvbmNlRmxhZzsKKyAgICBzdGQ6OmNhbGxfb25jZShvbmNlRmxhZywgWyZdIHsKKyAgICAg ICAgY29uc3QgZmxvYXQgemVybyA9IDA7CisgICAgICAgIHplcm9WYWx1ZS5jb25zdHJ1Y3QoYWRv cHRDRihDRk51bWJlckNyZWF0ZShrQ0ZBbGxvY2F0b3JEZWZhdWx0LCBrQ0ZOdW1iZXJGbG9hdFR5 cGUsICZ6ZXJvKSkpOworICAgIH0pOworICAgIHJldHVybiB6ZXJvVmFsdWUuZ2V0KCkuZ2V0KCk7 Cit9CisKIFJldGFpblB0cjxDRkRpY3Rpb25hcnlSZWY+IEZvbnQ6OmdldENGU3RyaW5nQXR0cmli dXRlcyhib29sIGVuYWJsZUtlcm5pbmcsIEZvbnRPcmllbnRhdGlvbiBvcmllbnRhdGlvbiwgY29u c3QgQXRvbVN0cmluZyYgbG9jYWxlKSBjb25zdAogewogICAgIENGVHlwZVJlZiBrZXlzWzVdOwpA QCAtNTIsMjAgKzc0LDEzIEBAIFJldGFpblB0cjxDRkRpY3Rpb25hcnlSZWY+IEZvbnQ6OmdldENG U3RyaW5nQXR0cmlidXRlcyhib29sIGVuYWJsZUtlcm5pbmcsIEZvbnRPCiAjZWxzZQogICAgIFVO VVNFRF9QQVJBTShsb2NhbGUpOwogI2VuZGlmCi0gICAgc3RhdGljIENUUGFyYWdyYXBoU3R5bGVS ZWYgcGFyYWdyYXBoU3R5bGUgPSBbXSB7Ci0gICAgICAgIGF1dG8gcGFyYWdyYXBoU3R5bGUgPSBD VFBhcmFncmFwaFN0eWxlQ3JlYXRlKG51bGxwdHIsIDApOwotICAgICAgICBDVFBhcmFncmFwaFN0 eWxlU2V0Q29tcG9zaXRpb25MYW5ndWFnZShwYXJhZ3JhcGhTdHlsZSwga0NUQ29tcG9zaXRpb25M YW5ndWFnZU5vbmUpOwotICAgICAgICByZXR1cm4gcGFyYWdyYXBoU3R5bGU7Ci0gICAgfSgpOwog ICAgIGtleXNbY291bnRdID0ga0NUUGFyYWdyYXBoU3R5bGVBdHRyaWJ1dGVOYW1lOwotICAgIHZh bHVlc1tjb3VudF0gPSBwYXJhZ3JhcGhTdHlsZTsKKyAgICB2YWx1ZXNbY291bnRdID0gcGFyYWdy YXBoU3R5bGVXaXRoQ29tcG9zaXRpb25MYW5ndWFnZU5vbmUoKTsKICAgICArK2NvdW50OwogCiAg ICAgaWYgKCFlbmFibGVLZXJuaW5nKSB7Ci0gICAgICAgIGNvbnN0IGZsb2F0IHplcm8gPSAwOwot ICAgICAgICBzdGF0aWMgTmV2ZXJEZXN0cm95ZWQ8UmV0YWluUHRyPENGTnVtYmVyUmVmPj4gemVy b0tlcm5pbmdWYWx1ZSA9IGFkb3B0Q0YoQ0ZOdW1iZXJDcmVhdGUoa0NGQWxsb2NhdG9yRGVmYXVs dCwga0NGTnVtYmVyRmxvYXRUeXBlLCAmemVybykpOwogICAgICAgICBrZXlzW2NvdW50XSA9IGtD VEtlcm5BdHRyaWJ1dGVOYW1lOwotICAgICAgICB2YWx1ZXNbY291bnRdID0gemVyb0tlcm5pbmdW YWx1ZS5nZXQoKS5nZXQoKTsKKyAgICAgICAgdmFsdWVzW2NvdW50XSA9IHplcm9WYWx1ZSgpOwog ICAgICAgICArK2NvdW50OwogICAgIH0KIAo=