234025 2021-12-08 12:02:18 -0800 [ANGLE] Code generation happens on each build and produces SCM diffs 2021-12-09 07:35:20 -0800 1 1 1 Unclassified WebKit ANGLE WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dino dino dino ews-watchlist kbr kkinnunen kondapallykalyan mmaxfield webkit-bug-importer oldest_to_newest 1821690 0 dino 2021-12-08 12:02:18 -0800 [ANGLE] Code generation happens on each build and produces SCM diffs 1821693 1 446403 dino 2021-12-08 12:04:49 -0800 Created attachment 446403 Patch 1821699 2 ews-watchlist 2021-12-08 12:06:35 -0800 Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE 1821740 3 446403 kkinnunen 2021-12-08 13:00:48 -0800 Comment on attachment 446403 Patch I'd imagine they need to be already checked into repo, as ANGLE doesn't run scripts compile time. I'd also imagine run_code_generation.py could and should be fixed so that the output isn't nondeterministic. 1821889 4 446403 mmaxfield 2021-12-08 17:37:23 -0800 Comment on attachment 446403 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=446403&action=review > Source/ThirdParty/ANGLE/ChangeLog:14 > + We either need to generate these manually, or fix the Xcode project > + to generate them into Derived Sources so they don't appear in our > + repository. Changing the Xcode project is what https://bugs.webkit.org/show_bug.cgi?id=233990 does. 1822127 5 ews-feeder 2021-12-09 07:34:18 -0800 Committed r286779 (245020@main): <https://commits.webkit.org/245020@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 446403. 1822128 6 webkit-bug-importer 2021-12-09 07:35:20 -0800 <rdar://problem/86270605> 446403 2021-12-08 12:04:49 -0800 2021-12-09 07:34:20 -0800 Patch bug-234025-20211209070448.patch text/plain 2671 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMjg2NjYxCmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9BTkdMRS9DaGFuZ2VMb2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cKaW5k ZXggMmFjOWQwYWQ0NjQxYWZkZjIxOGRlOGYwZGNlYTcyY2NjYmNhZjJmNi4uMWMwMTdkODgyZDM4 MDVjYzU5ZjQxZDI1Y2MwZTUyZDg5NDkyNjkyNCAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFy dHkvQU5HTEUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDIwIEBACisyMDIxLTEyLTA4ICBEZWFuIEphY2tzb24gIDxkaW5vQGFwcGxl LmNvbT4KKworICAgICAgICBbQU5HTEVdIENvZGUgZ2VuZXJhdGlvbiBoYXBwZW5zIG9uIGVhY2gg YnVpbGQgYW5kIHByb2R1Y2VzIFNDTSBkaWZmcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjM0MDI1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgVGVtcG9yYXJpbHkgcmVtb3ZlIHRoZSBidWlsZCBwaGFzZSB0 aGF0IGdlbmVyYXRlcyB0aGUKKyAgICAgICAgbXRsX2RlZmF1bHRfc2hhZGVyc19zcmNfYXV0b2dl biBmaWxlcyBiZWNhdXNlIHRoZXkgYXJlIHByb2R1Y2luZworICAgICAgICBkaWZmcy4KKworICAg ICAgICBXZSBlaXRoZXIgbmVlZCB0byBnZW5lcmF0ZSB0aGVzZSBtYW51YWxseSwgb3IgZml4IHRo ZSBYY29kZSBwcm9qZWN0CisgICAgICAgIHRvIGdlbmVyYXRlIHRoZW0gaW50byBEZXJpdmVkIFNv dXJjZXMgc28gdGhleSBkb24ndCBhcHBlYXIgaW4gb3VyCisgICAgICAgIHJlcG9zaXRvcnkuCisK KyAgICAgICAgKiBBTkdMRS54Y29kZXByb2ovcHJvamVjdC5wYnhwcm9qOgorCiAyMDIxLTEyLTA4 ICBBZHJpYW4gUGVyZXogZGUgQ2FzdHJvICA8YXBlcmV6QGlnYWxpYS5jb20+CiAKICAgICAgICAg QXZvaWQgbm9pc3kgV2NvbW1lbnQgd2FybmluZ3MgYWZ0ZXIgQU5HTEUgdXBkYXRlIGluIHIyODY2 MDMKZGlmZiAtLWdpdCBhL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0FOR0xFLnhjb2RlcHJvai9w cm9qZWN0LnBieHByb2ogYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9BTkdMRS54Y29kZXByb2ov cHJvamVjdC5wYnhwcm9qCmluZGV4IDJjNzgyOTAyNDYyZGMzNjc2OTYxMjA2ZWU3YTFlMmFhMTFi M2EyNzguLjQ1NGQ3MWZjZjBiMmU1MTBjNWM3ZTQ4OWFmMjNkNTExNTQ2ZGJlMDIgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0FOR0xFLnhjb2RlcHJvai9wcm9qZWN0LnBieHBy b2oKKysrIGIvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvQU5HTEUueGNvZGVwcm9qL3Byb2plY3Qu cGJ4cHJvagpAQCAtMzUxMyw3ICszNTEzLDYgQEAKIAkJCWlzYSA9IFBCWE5hdGl2ZVRhcmdldDsK IAkJCWJ1aWxkQ29uZmlndXJhdGlvbkxpc3QgPSBGRkRBNTBDQjI2OUY4NDUxMDBBRTExRTIgLyog QnVpbGQgY29uZmlndXJhdGlvbiBsaXN0IGZvciBQQlhOYXRpdmVUYXJnZXQgIkFOR0xFTWV0YWxM aWIiICovOwogCQkJYnVpbGRQaGFzZXMgPSAoCi0JCQkJRkYxOTRGRjgyNzQ0M0JERjAwNkE5N0Ez IC8qIFNoZWxsU2NyaXB0ICovLAogCQkJCUZGREE1MEMzMjY5Rjg0NTEwMEFFMTFFMiAvKiBTb3Vy Y2VzICovLAogCQkJKTsKIAkJCWJ1aWxkUnVsZXMgPSAoCkBAIC0zNTg2LDIzICszNTg1LDYgQEAK IAkJCXNoZWxsUGF0aCA9IC9iaW4vc2g7CiAJCQlzaGVsbFNjcmlwdCA9ICJpZiBbIFwiJHtYQ09E RV9WRVJTSU9OX0FDVFVBTH1cIiAtZ2UgXCIxMTQwXCIgLWEgXCIke1dLX1VTRV9ORVdfQlVJTERf U1lTVEVNfVwiID0gXCJZRVNcIiBdOyB0aGVuXG4gICAgIyBJbiB0aGlzIGNvbmZpZ3VyYXRpb24s IHBvc3QtcHJvY2Vzc2luZyBpcyBwZXJmb3JtZWQgYXQgdGhlIHNhbWUgdGltZSBhcyBjb3B5aW5n IGluIHRoZSBwb3N0cHJvY2Vzcy1oZWFkZXItcnVsZSBzY3JpcHQsIHNvIHRoZXJlJ3Mgbm8gbmVl ZCBmb3IgdGhpcyBzZXBhcmF0ZSBzdGVwLlxuICAgIGV4aXQgMFxuZmlcblxuZXhlYyBcIiRTUkNS T09UL2FkanVzdC1hbmdsZS1pbmNsdWRlLXBhdGhzLnB5XCJcbiI7CiAJCX07Ci0JCUZGMTk0RkY4 Mjc0NDNCREYwMDZBOTdBMyAvKiBTaGVsbFNjcmlwdCAqLyA9IHsKLQkJCWlzYSA9IFBCWFNoZWxs U2NyaXB0QnVpbGRQaGFzZTsKLQkJCWJ1aWxkQWN0aW9uTWFzayA9IDIxNDc0ODM2NDc7Ci0JCQlm aWxlcyA9ICgKLQkJCSk7Ci0JCQlpbnB1dEZpbGVMaXN0UGF0aHMgPSAoCi0JCQkpOwotCQkJaW5w dXRQYXRocyA9ICgKLQkJCSk7Ci0JCQlvdXRwdXRGaWxlTGlzdFBhdGhzID0gKAotCQkJKTsKLQkJ CW91dHB1dFBhdGhzID0gKAotCQkJKTsKLQkJCXJ1bk9ubHlGb3JEZXBsb3ltZW50UG9zdHByb2Nl c3NpbmcgPSAwOwotCQkJc2hlbGxQYXRoID0gL2Jpbi9zaDsKLQkJCXNoZWxsU2NyaXB0ID0gInB5 dGhvbiBzY3JpcHRzL3J1bl9jb2RlX2dlbmVyYXRpb24ucHkgLWcgXCJNZXRhbCBkZWZhdWx0IHNo YWRlcnNcIlxuZXhpdCAwXG4iOwotCQl9OwogCQlGRkRBNTBENTI2OUY4OTU0MDBBRTExRTIgLyog QmFrZSBNZXRhbCBMaWJyYXJ5IHRvIE5TRGF0YSAqLyA9IHsKIAkJCWlzYSA9IFBCWFNoZWxsU2Ny aXB0QnVpbGRQaGFzZTsKIAkJCWJ1aWxkQWN0aW9uTWFzayA9IDIxNDc0ODM2NDc7Cg==