234012 2021-12-08 09:02:50 -0800 Web Inspector: After r286657, anonymous layers are providing an empty string for their grouping text 2021-12-14 14:06:13 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 231340 1 pangle pangle ews-watchlist hi inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1821574 0 pangle 2021-12-08 09:02:50 -0800 The frontend makes the assumption that text will only be provided for named layers, and that anonymous layers will instead forgo setting the `text` for the grouping payload. We either need to conditionalize setting the text, or handle empty strings in the frontend, not just undefined strings. 1821575 1 webkit-bug-importer 2021-12-08 09:03:08 -0800 <rdar://problem/86214025> 1821809 2 446439 pangle 2021-12-08 15:32:53 -0800 Created attachment 446439 Patch v1.0 1824080 3 447148 pangle 2021-12-14 12:43:19 -0800 Created attachment 447148 Patch v1.1 1824081 4 447148 hi 2021-12-14 12:51:52 -0800 Comment on attachment 447148 Patch v1.1 rs=me 1824114 5 ews-feeder 2021-12-14 14:06:08 -0800 Committed r287046 (245243@main): <https://commits.webkit.org/245243@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 447148. 446439 2021-12-08 15:32:53 -0800 2021-12-14 12:43:17 -0800 Patch v1.0 bug-234012-20211208153252.patch text/plain 3682 pangle U3VidmVyc2lvbiBSZXZpc2lvbjogMjg2NjYxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmNlZDhkZmUyNDIyODg1 ZWEyMjUwZGUzM2ZmMmY0NGJjM2FkYTYwOS4uNzAwNmM2NjFkN2Y2NTNlYjBhZTYxZmFkODA1MjNh MTUwZWVhZGNjMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIxLTEyLTA4ICBQYXRy aWNrIEFuZ2xlICA8cGFuZ2xlQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBB ZnRlciByMjg2NjU3LCBhbm9ueW1vdXMgbGF5ZXJzIGFyZSBwcm92aWRpbmcgYW4gZW1wdHkgc3Ry aW5nIGZvciB0aGVpciBncm91cGluZyB0ZXh0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0yMzQwMTIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBDb3ZlcmVkIGJ5IGV4aXN0aW5nIHRlc3Q6IExheW91dFRlc3Rz L2luc3BlY3Rvci9jc3MvZ2V0TWF0Y2hlZFN0eWxlc0Zvck5vZGVMYXllckdyb3VwaW5nLmh0bWwK KworICAgICAgICBGb3IgYW5vbnltb3VzIGxheWVycywgd2Ugc2hvdWxkIG5vdCBwcm92aWRlIHRo ZSBgdGV4dGAgcHJvcGVydHkgdG8gdGhlIGZyb250ZW5kLCBhcyB0aGVyZSBpcyB0ZWNobmljYWxs eSBubworICAgICAgICB0ZXh0LCBub3QgYW4gZW1wdHkgc3RyaW5nLCBwcm92aWRlZCBieSB0aGUg YXV0aG9yLiBUaGlzIHdhcyBtaXNzZWQgYnkgdGhlIGV4aXN0aW5nIGxheW91dCB0ZXN0IGR1ZSB0 byBhIHN5bnRheAorICAgICAgICBpc3N1ZSBpbiBXZWJJbnNwZWN0b3JVSSB0aGF0IGFzc3VtZWQg YW4gZW1wdHkgc3RyaW5nIHdhcyBlcXVpdmFsZW50IHRvIG5vIHN0cmluZy4KKworICAgICAgICAq IGluc3BlY3Rvci9JbnNwZWN0b3JTdHlsZVNoZWV0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmJ1 aWxkQXJyYXlGb3JHcm91cGluZ3MpOgorCiAyMDIxLTEyLTA4ICBBbnR0aSBLb2l2aXN0byAgPGFu dHRpQGFwcGxlLmNvbT4KIAogICAgICAgICBbQ1NTIENhc2NhZGUgTGF5ZXJzXSBVcGRhdGUgQ1NT T00gdG8gdGhlIHNwZWMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VM b2cgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDRhMjlhNzdjMDIyN2Yz YTlmYzU3ODBkZTg3NzIxYzQ2ODM1MWU2NWQuLmJhMzhmZGViNzI4NjdhYzdlMjliMTI1OGU3YThk ZGVlMDlkYTQwMjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisy MDIxLTEyLTA4ICBQYXRyaWNrIEFuZ2xlICA8cGFuZ2xlQGFwcGxlLmNvbT4KKworICAgICAgICBX ZWIgSW5zcGVjdG9yOiBBZnRlciByMjg2NjU3LCBhbm9ueW1vdXMgbGF5ZXJzIGFyZSBwcm92aWRp bmcgYW4gZW1wdHkgc3RyaW5nIGZvciB0aGVpciBncm91cGluZyB0ZXh0CisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzQwMTIKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGb3IgV0kuQ1NTR3JvdXBpbmcucHJv dG90eXBlLnRleHQsIGRvbid0IHRyZWF0IGFuIGVtcHR5IHN0cmluZyBhcyBudWxsLCBhcyBpdCBw cmV2ZW50cyBkZXRlcm1pbmluZyBpZiBhIHN0cmluZworICAgICAgICB3YXMgcHJvdmlkZWQgYXQg YWxsLCBvciBpZiB0aGF0IHN0cmluZyBoYXBwZW5lZCB0byBiZSBlbXB0eS4KKworICAgICAgICAq IFVzZXJJbnRlcmZhY2UvTW9kZWxzL0NTU0dyb3VwaW5nLmpzOgorICAgICAgICAoV0kuQ1NTR3Jv dXBpbmcpOgorCiAyMDIxLTEyLTA3ICBSYXp2YW4gQ2FsaW1hbiAgPHJjYWxpbWFuQGFwcGxlLmNv bT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBTdXBwb3J0IGZ1enp5IG1hdGNoaW5nIGluIENT UyBjb21wbGV0aW9ucwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3Bl Y3RvclN0eWxlU2hlZXQuY3BwIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvclN0 eWxlU2hlZXQuY3BwCmluZGV4IDc4ODJhMDU3NWU1YWZmMjE3YThiZGYzODJhZTUyYjI4MzdlYWYy MDIuLmEwYjIzMjEwYjIzODRhOWRlMDlmMjlhZTEwYWNkNjVhOWY1MGIwMGMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JTdHlsZVNoZWV0LmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yU3R5bGVTaGVldC5jcHAKQEAgLTQ3OCw3 ICs0NzgsOSBAQCBzdGF0aWMgUmVmPEpTT046OkFycmF5T2Y8UHJvdG9jb2w6OkNTUzo6R3JvdXBp bmc+PiBidWlsZEFycmF5Rm9yR3JvdXBpbmdzKENTU1J1bAogICAgICAgICAgICAgYXV0byBsYXll clJ1bGVQYXlsb2FkID0gUHJvdG9jb2w6OkNTUzo6R3JvdXBpbmc6OmNyZWF0ZSgpCiAgICAgICAg ICAgICAgICAgLnNldFR5cGUoUHJvdG9jb2w6OkNTUzo6R3JvdXBpbmc6OlR5cGU6OkxheWVyUnVs ZSkKICAgICAgICAgICAgICAgICAucmVsZWFzZSgpOwotICAgICAgICAgICAgbGF5ZXJSdWxlUGF5 bG9hZC0+c2V0VGV4dChkb3duY2FzdDxDU1NMYXllckJsb2NrUnVsZT4ocGFyZW50UnVsZSktPm5h bWUoKSk7CisgICAgICAgICAgICBhdXRvIGxheWVyTmFtZSA9IGRvd25jYXN0PENTU0xheWVyQmxv Y2tSdWxlPihwYXJlbnRSdWxlKS0+bmFtZSgpOworICAgICAgICAgICAgaWYgKCFsYXllck5hbWUu aXNFbXB0eSgpKQorICAgICAgICAgICAgICAgIGxheWVyUnVsZVBheWxvYWQtPnNldFRleHQobGF5 ZXJOYW1lKTsKICAgICAgICAgICAgIHJ1bGVHcm91cGluZ1BheWxvYWRzLmFwcGVuZChXVEZNb3Zl KGxheWVyUnVsZVBheWxvYWQpKTsKICAgICAgICAgfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Nb2RlbHMvQ1NTR3JvdXBpbmcuanMgYi9Tb3VyY2Uv V2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Nb2RlbHMvQ1NTR3JvdXBpbmcuanMKaW5kZXgg YmU2NmFjZTI2Y2UyMDFhODg1ZDM5Y2ZkYTcwMDJkZjM2ZmQ2NGY2NS4uNDA3YzY4NmEzNDBjYjMz ZTIxODZmMTE1OTBmYWJlZDYwNmQ2MjY5YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3Rv clVJL1VzZXJJbnRlcmZhY2UvTW9kZWxzL0NTU0dyb3VwaW5nLmpzCisrKyBiL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVscy9DU1NHcm91cGluZy5qcwpAQCAtMzIsNyAr MzIsNyBAQCBXSS5DU1NHcm91cGluZyA9IGNsYXNzIENTU0dyb3VwaW5nCiAgICAgICAgIGNvbnNv bGUuYXNzZXJ0KCFzb3VyY2VDb2RlTG9jYXRpb24gfHwgc291cmNlQ29kZUxvY2F0aW9uIGluc3Rh bmNlb2YgV0kuU291cmNlQ29kZUxvY2F0aW9uKTsKIAogICAgICAgICB0aGlzLl90eXBlID0gdHlw ZTsKLSAgICAgICAgdGhpcy5fdGV4dCA9IHRleHQgfHwgbnVsbDsKKyAgICAgICAgdGhpcy5fdGV4 dCA9IHRleHQgPz8gbnVsbDsKICAgICAgICAgdGhpcy5fc291cmNlQ29kZUxvY2F0aW9uID0gc291 cmNlQ29kZUxvY2F0aW9uIHx8IG51bGw7CiAgICAgfQogCg== 447148 2021-12-14 12:43:19 -0800 2021-12-14 14:06:11 -0800 Patch v1.1 bug-234012-20211214124318.patch text/plain 2101 pangle U3VidmVyc2lvbiBSZXZpc2lvbjogMjg3MDQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmIyOWNiMmIzMWVjZGU1 NzYwODU1OWU4NzFkMjRiNDA2YTA4ZjgyZC4uODlhYjgwMjJiZjNmZTMyODcyYWExY2ZiMDQ5ZjIw ODE4ZGJhZWI4NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIxLTEyLTE0ICBQYXRy aWNrIEFuZ2xlICA8cGFuZ2xlQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBB ZnRlciByMjg2NjU3LCBhbm9ueW1vdXMgbGF5ZXJzIGFyZSBwcm92aWRpbmcgYW4gZW1wdHkgc3Ry aW5nIGZvciB0aGVpciBncm91cGluZyB0ZXh0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0yMzQwMTIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBDb3ZlcmVkIGJ5IGV4aXN0aW5nIHRlc3Q6IExheW91dFRlc3Rz L2luc3BlY3Rvci9jc3MvZ2V0TWF0Y2hlZFN0eWxlc0Zvck5vZGVMYXllckdyb3VwaW5nLmh0bWwK KworICAgICAgICBGb3IgYW5vbnltb3VzIGxheWVycywgd2Ugc2hvdWxkIG5vdCBwcm92aWRlIHRo ZSBgdGV4dGAgcHJvcGVydHkgdG8gdGhlIGZyb250ZW5kLCBhcyB0aGVyZSBpcyB0ZWNobmljYWxs eSBubworICAgICAgICB0ZXh0LCBub3QgYW4gZW1wdHkgc3RyaW5nLCBwcm92aWRlZCBieSB0aGUg YXV0aG9yLiBUaGlzIGlzIGVmZmVjdGl2ZWx5IGEgbWlub3Igb3B0aW1pemF0aW9uLCBhcyB0aGUg ZnJvbnRlbmQKKyAgICAgICAgZG9lcyBjb3JyZWN0bHkgaGFuZGxlIGFuIGVtcHR5IHN0cmluZyB0 aGUgc2FtZSB3YXkgaXQgaGFuZGxlcyBubyBzdHJpbmcuCisKKyAgICAgICAgKiBpbnNwZWN0b3Iv SW5zcGVjdG9yU3R5bGVTaGVldC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpidWlsZEFycmF5Rm9y R3JvdXBpbmdzKToKKwogMjAyMS0xMi0xNCAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNl bkB3ZWJraXQub3JnPgogCiAgICAgICAgIEFkZCBfV0tDb250ZW50UnVsZUxpc3RBY3Rpb24ucmVk aXJlY3RlZCBhbmQgLm1vZGlmaWVkSGVhZGVycwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv aW5zcGVjdG9yL0luc3BlY3RvclN0eWxlU2hlZXQuY3BwIGIvU291cmNlL1dlYkNvcmUvaW5zcGVj dG9yL0luc3BlY3RvclN0eWxlU2hlZXQuY3BwCmluZGV4IDc4ODJhMDU3NWU1YWZmMjE3YThiZGYz ODJhZTUyYjI4MzdlYWYyMDIuLmEwYjIzMjEwYjIzODRhOWRlMDlmMjlhZTEwYWNkNjVhOWY1MGIw MGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JTdHlsZVNo ZWV0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yU3R5bGVTaGVl dC5jcHAKQEAgLTQ3OCw3ICs0NzgsOSBAQCBzdGF0aWMgUmVmPEpTT046OkFycmF5T2Y8UHJvdG9j b2w6OkNTUzo6R3JvdXBpbmc+PiBidWlsZEFycmF5Rm9yR3JvdXBpbmdzKENTU1J1bAogICAgICAg ICAgICAgYXV0byBsYXllclJ1bGVQYXlsb2FkID0gUHJvdG9jb2w6OkNTUzo6R3JvdXBpbmc6OmNy ZWF0ZSgpCiAgICAgICAgICAgICAgICAgLnNldFR5cGUoUHJvdG9jb2w6OkNTUzo6R3JvdXBpbmc6 OlR5cGU6OkxheWVyUnVsZSkKICAgICAgICAgICAgICAgICAucmVsZWFzZSgpOwotICAgICAgICAg ICAgbGF5ZXJSdWxlUGF5bG9hZC0+c2V0VGV4dChkb3duY2FzdDxDU1NMYXllckJsb2NrUnVsZT4o cGFyZW50UnVsZSktPm5hbWUoKSk7CisgICAgICAgICAgICBhdXRvIGxheWVyTmFtZSA9IGRvd25j YXN0PENTU0xheWVyQmxvY2tSdWxlPihwYXJlbnRSdWxlKS0+bmFtZSgpOworICAgICAgICAgICAg aWYgKCFsYXllck5hbWUuaXNFbXB0eSgpKQorICAgICAgICAgICAgICAgIGxheWVyUnVsZVBheWxv YWQtPnNldFRleHQobGF5ZXJOYW1lKTsKICAgICAgICAgICAgIHJ1bGVHcm91cGluZ1BheWxvYWRz LmFwcGVuZChXVEZNb3ZlKGxheWVyUnVsZVBheWxvYWQpKTsKICAgICAgICAgfQogCg==