23399 2009-01-16 18:33:31 -0800 AX: some buttons don't expose AXPress as an action 2009-01-19 10:19:00 -0800 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 cfleizach webkit-unassigned oldest_to_newest 106158 0 cfleizach 2009-01-16 18:33:31 -0800 <button> elements don't expose AXPress 106159 1 26820 cfleizach 2009-01-16 18:35:22 -0800 Created attachment 26820 Patch to make <button> show AXPress 106172 2 26820 hyatt 2009-01-16 20:57:59 -0800 Comment on attachment 26820 Patch to make <button> show AXPress > Index: WebCore/ChangeLog > =================================================================== > --- WebCore/ChangeLog (revision 40003) > +++ WebCore/ChangeLog (working copy) > @@ -1,3 +1,15 @@ > +2009-01-16 Chris Fleizach <cfleizach@apple.com> > + > + Reviewed by NOBODY (OOPS!). > + > + AX: some buttons don't expose AXPress as an action > + https://bugs.webkit.org/show_bug.cgi?id=23399 > + > + Test: accessibility/button-press-action.html > + > + * page/AccessibilityRenderObject.cpp: > + (WebCore::AccessibilityRenderObject::actionElement): > + > 2009-01-16 Chris Fleizach <cfleizach@apple.com> > > Reviewed by Oliver Hunt. > Index: WebCore/page/AccessibilityRenderObject.cpp > =================================================================== > --- WebCore/page/AccessibilityRenderObject.cpp (revision 40003) > +++ WebCore/page/AccessibilityRenderObject.cpp (working copy) > @@ -491,10 +491,18 @@ Element* AccessibilityRenderObject::anch > > Element* AccessibilityRenderObject::actionElement() const > { > - if (m_renderer->element() && m_renderer->element()->hasTagName(inputTag)) { > - HTMLInputElement* input = static_cast<HTMLInputElement*>(m_renderer->element()); > - if (!input->disabled() && (isCheckboxOrRadio() || input->isTextButton())) > - return input; > + if (!m_renderer) > + return 0; > + > + Node* node = m_renderer->element(); > + if (node) { > + if (node->hasTagName(inputTag)) { > + HTMLInputElement* input = static_cast<HTMLInputElement*>(node); > + if (!input->disabled() && (isCheckboxOrRadio() || input->isTextButton())) > + return input; > + } > + else if (node->hasTagName(buttonTag)) > + return static_cast<Element*>(node); The else here should be on the same line as the previous } r=me 106256 3 cfleizach 2009-01-19 10:19:00 -0800 http://trac.webkit.org/changeset/40030 26820 2009-01-16 18:35:22 -0800 2009-01-16 20:57:59 -0800 Patch to make <button> show AXPress patch.txt text/plain 3885 cfleizach SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0MDAwMykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMDktMDEtMTYgIENocmlzIEZsZWl6YWNoICA8Y2ZsZWl6YWNoQGFw cGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBBWDogc29tZSBidXR0b25zIGRvbid0IGV4cG9zZSBBWFByZXNzIGFzIGFuIGFjdGlvbgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjMzOTkKKworICAg ICAgICBUZXN0OiBhY2Nlc3NpYmlsaXR5L2J1dHRvbi1wcmVzcy1hY3Rpb24uaHRtbAorCisgICAg ICAgICogcGFnZS9BY2Nlc3NpYmlsaXR5UmVuZGVyT2JqZWN0LmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OkFjY2Vzc2liaWxpdHlSZW5kZXJPYmplY3Q6OmFjdGlvbkVsZW1lbnQpOgorCiAyMDA5LTAx LTE2ICBDaHJpcyBGbGVpemFjaCAgPGNmbGVpemFjaEBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2 aWV3ZWQgYnkgT2xpdmVyIEh1bnQuCkluZGV4OiBXZWJDb3JlL3BhZ2UvQWNjZXNzaWJpbGl0eVJl bmRlck9iamVjdC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wYWdlL0FjY2Vzc2liaWxpdHlS ZW5kZXJPYmplY3QuY3BwCShyZXZpc2lvbiA0MDAwMykKKysrIFdlYkNvcmUvcGFnZS9BY2Nlc3Np YmlsaXR5UmVuZGVyT2JqZWN0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDkxLDEwICs0OTEsMTgg QEAgRWxlbWVudCogQWNjZXNzaWJpbGl0eVJlbmRlck9iamVjdDo6YW5jaAogCiBFbGVtZW50KiBB Y2Nlc3NpYmlsaXR5UmVuZGVyT2JqZWN0OjphY3Rpb25FbGVtZW50KCkgY29uc3QKIHsKLSAgICBp ZiAobV9yZW5kZXJlci0+ZWxlbWVudCgpICYmIG1fcmVuZGVyZXItPmVsZW1lbnQoKS0+aGFzVGFn TmFtZShpbnB1dFRhZykpIHsKLSAgICAgICAgSFRNTElucHV0RWxlbWVudCogaW5wdXQgPSBzdGF0 aWNfY2FzdDxIVE1MSW5wdXRFbGVtZW50Kj4obV9yZW5kZXJlci0+ZWxlbWVudCgpKTsKLSAgICAg ICAgaWYgKCFpbnB1dC0+ZGlzYWJsZWQoKSAmJiAoaXNDaGVja2JveE9yUmFkaW8oKSB8fCBpbnB1 dC0+aXNUZXh0QnV0dG9uKCkpKQotICAgICAgICAgICAgcmV0dXJuIGlucHV0OworICAgIGlmICgh bV9yZW5kZXJlcikKKyAgICAgICAgcmV0dXJuIDA7CisgICAgCisgICAgTm9kZSogbm9kZSA9IG1f cmVuZGVyZXItPmVsZW1lbnQoKTsKKyAgICBpZiAobm9kZSkgeworICAgICAgICBpZiAobm9kZS0+ aGFzVGFnTmFtZShpbnB1dFRhZykpIHsKKyAgICAgICAgICAgIEhUTUxJbnB1dEVsZW1lbnQqIGlu cHV0ID0gc3RhdGljX2Nhc3Q8SFRNTElucHV0RWxlbWVudCo+KG5vZGUpOworICAgICAgICAgICAg aWYgKCFpbnB1dC0+ZGlzYWJsZWQoKSAmJiAoaXNDaGVja2JveE9yUmFkaW8oKSB8fCBpbnB1dC0+ aXNUZXh0QnV0dG9uKCkpKQorICAgICAgICAgICAgICAgIHJldHVybiBpbnB1dDsKKyAgICAgICAg fQorICAgICAgICBlbHNlIGlmIChub2RlLT5oYXNUYWdOYW1lKGJ1dHRvblRhZykpCisgICAgICAg ICAgICByZXR1cm4gc3RhdGljX2Nhc3Q8RWxlbWVudCo+KG5vZGUpOwogICAgIH0KICAgICAgICAg ICAgIAogICAgIGlmIChpc0ZpbGVVcGxvYWRCdXR0b24oKSkKSW5kZXg6IExheW91dFRlc3RzL0No YW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDQw MDAzKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEs MTMgQEAKKzIwMDktMDEtMTYgIENocmlzIEZsZWl6YWNoICA8Y2ZsZWl6YWNoQGFwcGxlLmNvbT4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBCdWcgMjMz OTk6IEFYOiBzb21lIGJ1dHRvbnMgZG9uJ3QgZXhwb3NlIEFYUHJlc3MgYXMgYW4gYWN0aW9uCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzM5OQorCisg ICAgICAgICogYWNjZXNzaWJpbGl0eS9idXR0b24tcHJlc3MtYWN0aW9uLWV4cGVjdGVkLnR4dDog QWRkZWQuCisgICAgICAgICogYWNjZXNzaWJpbGl0eS9idXR0b24tcHJlc3MtYWN0aW9uLmh0bWw6 IEFkZGVkLgorCiAyMDA5LTAxLTE2ICBDaHJpcyBGbGVpemFjaCAgPGNmbGVpemFjaEBhcHBsZS5j b20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgT2xpdmVyIEh1bnQuCkluZGV4OiBMYXlvdXRUZXN0 cy9hY2Nlc3NpYmlsaXR5L2J1dHRvbi1wcmVzcy1hY3Rpb24tZXhwZWN0ZWQudHh0Cj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIExheW91dFRlc3RzL2FjY2Vzc2liaWxpdHkvYnV0dG9uLXByZXNzLWFjdGlvbi1leHBl Y3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9hY2Nlc3NpYmlsaXR5L2J1dHRv bi1wcmVzcy1hY3Rpb24tZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDMgQEAK K0NsaWNrIG1lCitUZXN0IHBhc3NlZAorCkluZGV4OiBMYXlvdXRUZXN0cy9hY2Nlc3NpYmlsaXR5 L2J1dHRvbi1wcmVzcy1hY3Rpb24uaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9hY2Nl c3NpYmlsaXR5L2J1dHRvbi1wcmVzcy1hY3Rpb24uaHRtbAkocmV2aXNpb24gMCkKKysrIExheW91 dFRlc3RzL2FjY2Vzc2liaWxpdHkvYnV0dG9uLXByZXNzLWFjdGlvbi5odG1sCShyZXZpc2lvbiAw KQpAQCAtMCwwICsxLDMxIEBACis8aHRtbD4KKzxzY3JpcHQ+CisgICAgaWYgKHdpbmRvdy5sYXlv dXRUZXN0Q29udHJvbGxlcikKKyAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4 dCgpOworPC9zY3JpcHQ+Cis8Ym9keSBpZD0iYm9keSI+CisKKyAgICA8IS0tIFRoaXMgdGVzdCBt YWtlcyBzdXJlIHRoYXQgYSA8YnV0dG9uPiBlbGVtZW50IGV4cG9zZXMgQVhQcmVzcyBhcyBhbiBh Y3Rpb24gLS0+CisgCisgICAgPGJ1dHRvbiB0eXBlPSJidXR0b24iIGlkPSJidXR0b24iPkNsaWNr IG1lPC9idXR0b24+CisKKyAgICA8ZGl2IGlkPSJyZXN1bHQiPjwvZGl2PgorICAgICAKKyAgICA8 c2NyaXB0PgorICAgICAgICBpZiAod2luZG93LmFjY2Vzc2liaWxpdHlDb250cm9sbGVyKSB7Cisg ICAgICAgICAgICB2YXIgcmVzdWx0ID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInJlc3VsdCIp OworCisgICAgICAgICAgICB2YXIgYnV0dG9uID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImJ1 dHRvbiIpOworICAgICAgICAgICAgYnV0dG9uLmZvY3VzKCk7CisgICAgICAgICAgICBidXR0b24g PSBhY2Nlc3NpYmlsaXR5Q29udHJvbGxlci5mb2N1c2VkRWxlbWVudDsKKworICAgICAgICAgICAg aWYgKGJ1dHRvbi5zdXBwb3J0c1ByZXNzQWN0aW9uKSB7CisgICAgICAgICAgICAgICAgcmVzdWx0 LmlubmVyVGV4dCArPSAiVGVzdCBwYXNzZWRcbiI7CisgICAgICAgICAgICB9CisgICAgICAgICAg ICBlbHNlIHsKKyAgICAgICAgICAgICAgICAgcmVzdWx0LmlubmVyVGV4dCArPSAiVGVzdCBmYWls ZWRcbiI7CisgICAgICAgICAgICB9CisgICAgICAgIH0KKyAgICA8L3NjcmlwdD4KKzwvYm9keT4K KzwvaHRtbD4K