233978 2021-12-07 22:22:52 -0800 Make FontCascade::setShouldUseSmoothing/shouldUseSmoothing thread safe 2022-09-14 17:38:28 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 233488 1 heycam mattwoodrow bfulgham mattwoodrow mmaxfield simon.fraser webkit-bug-importer zalan oldest_to_newest 1821389 0 heycam 2021-12-07 22:22:52 -0800 Make FontCascade::setShouldUseSmoothing/shouldUseSmoothing thread safe 1821393 1 446301 heycam 2021-12-07 22:29:12 -0800 Created attachment 446301 Patch 1821990 2 446301 mmaxfield 2021-12-08 21:08:32 -0800 Comment on attachment 446301 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=446301&action=review > Source/WebCore/ChangeLog:11 > + same time from the main thread. This setting is only changed from > + Internals and WebView and at WebProcess initilization, but should WebKitLegacy and WebKit have SPI for this: + (void)_setShouldUseFontSmoothing:(BOOL)f { WebCore::FontCascade::setShouldUseSmoothing(f); } void WKContextSetShouldUseFontSmoothing(WKContextRef contextRef, bool useFontSmoothing) { WebKit::toImpl(contextRef)->setShouldUseFontSmoothing(useFontSmoothing); } > Source/WebCore/platform/graphics/FontCascade.cpp:442 > +static std::atomic<bool> shouldUseFontSmoothing = true; Is it possible to make this no longer a global? I think that would be a better solution than this. 1824253 3 webkit-bug-importer 2021-12-14 22:23:15 -0800 <rdar://problem/86506527> 1896949 4 mattwoodrow 2022-09-07 19:24:45 -0700 (In reply to Myles C. Maxfield from comment #2) > > > Source/WebCore/platform/graphics/FontCascade.cpp:442 > > +static std::atomic<bool> shouldUseFontSmoothing = true; > > Is it possible to make this no longer a global? I think that would be a > better solution than this. We could store this on the per-thread FontCache instances, but that then makes it harder to mutate with the SPI, since we'd have to dispatch it to all threads that have a FontCache initialised. 1896955 5 mmaxfield 2022-09-07 19:46:00 -0700 (In reply to Matt Woodrow from comment #4) > (In reply to Myles C. Maxfield from comment #2) > > > > > Source/WebCore/platform/graphics/FontCascade.cpp:442 > > > +static std::atomic<bool> shouldUseFontSmoothing = true; > > > > Is it possible to make this no longer a global? I think that would be a > > better solution than this. > > We could store this on the per-thread FontCache instances, but that then > makes it harder to mutate with the SPI, since we'd have to dispatch it to > all threads that have a FontCache initialised. I guess I still think that's a better solution than a global :/ 1896956 6 mmaxfield 2022-09-07 19:46:50 -0700 Alternatively, we could try to find all callers of the SPI and see if we can remove it. 1897746 7 mattwoodrow 2022-09-11 15:32:44 -0700 Pull request: https://github.com/WebKit/WebKit/pull/4240 1898601 8 ews-feeder 2022-09-14 17:38:25 -0700 Committed 254500@main (eb547e04a187): <https://commits.webkit.org/254500@main> Reviewed commits have been landed. Closing PR #4240 and removing active labels. 446301 2021-12-07 22:29:12 -0800 2022-09-11 15:30:02 -0700 Patch bug-233978-20211208172911.patch text/plain 1799 heycam U3VidmVyc2lvbiBSZXZpc2lvbjogMjg2NjM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDI1NThlY2JkYWVkNTVm NWU1OWRjYmU4NjdmNjI4ZTE4MDBlMGI5NS4uZWUxOGUwYzliNDI2YmMxYjk4MzQzMzIyYzA2YWE4 MjIxMTBhNzQ0MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIxLTEyLTAyICBDYW1l cm9uIE1jQ29ybWFjayAgPGhleWNhbUBhcHBsZS5jb20+CisKKyAgICAgICAgTWFrZSBGb250Q2Fz Y2FkZTo6c2V0U2hvdWxkVXNlU21vb3RoaW5nL3Nob3VsZFVzZVNtb290aGluZyB0aHJlYWQgc2Fm ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjMzOTc4 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRm9udENh c2NhZGU6OnNob3VsZFVzZVNtb290aGluZyBjYW4gYmUgY2FsbGVkIGZyb20gd29ya2VyIHRocmVh ZHMKKyAgICAgICAgdXNpbmcgT2Zmc2NyZWVuQ2FudmFzLCBidXQgc2V0U2hvdWxkVXNlU21vb3Ro aW5nIGNhbiBiZSBjYWxsZWQgYXQgdGhlCisgICAgICAgIHNhbWUgdGltZSBmcm9tIHRoZSBtYWlu IHRocmVhZC4gVGhpcyBzZXR0aW5nIGlzIG9ubHkgY2hhbmdlZCBmcm9tCisgICAgICAgIEludGVy bmFscyBhbmQgV2ViVmlldyBhbmQgYXQgV2ViUHJvY2VzcyBpbml0aWxpemF0aW9uLCBidXQgc2hv dWxkCisgICAgICAgIHN0aWxsIGJlIGRvbmUgaW4gYSBub24tcmFjeSB3YXkuCisKKyAgICAgICAg KiBwbGF0Zm9ybS9ncmFwaGljcy9Gb250Q2FzY2FkZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpG b250Q2FzY2FkZTo6c2V0U2hvdWxkVXNlU21vb3RoaW5nKToKKwogMjAyMS0xMi0wMiAgQ2FtZXJv biBNY0Nvcm1hY2sgIDxoZXljYW1AYXBwbGUuY29tPgogCiAgICAgICAgIEFzc2VydCBpc01haW5U aHJlYWQoKSBpbiBoYXNWYWxpZEF2ZXJhZ2VDaGFyV2lkdGgKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0ZvbnRDYXNjYWRlLmNwcCBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL0ZvbnRDYXNjYWRlLmNwcAppbmRleCAzNTIwZDVmNmNiYzBlOWFm MDg0OGI2YTgxZGJiOWU0MzYxZTQ2YjE4Li43MjA1N2ExZGJjMGM3ZjczYzhhYTM1MGJmYjBlYTg0 YjZjZWMyMDJkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9G b250Q2FzY2FkZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvRm9u dENhc2NhZGUuY3BwCkBAIC00MzksMTEgKzQzOSwxMCBAQCBTdHJpbmcgRm9udENhc2NhZGU6Om5v cm1hbGl6ZVNwYWNlcyhjb25zdCBVQ2hhciogY2hhcmFjdGVycywgdW5zaWduZWQgbGVuZ3RoKQog ICAgIHJldHVybiBub3JtYWxpemVTcGFjZXNJbnRlcm5hbChjaGFyYWN0ZXJzLCBsZW5ndGgpOwog fQogCi1zdGF0aWMgYm9vbCBzaG91bGRVc2VGb250U21vb3RoaW5nID0gdHJ1ZTsKK3N0YXRpYyBz dGQ6OmF0b21pYzxib29sPiBzaG91bGRVc2VGb250U21vb3RoaW5nID0gdHJ1ZTsKIAogdm9pZCBG b250Q2FzY2FkZTo6c2V0U2hvdWxkVXNlU21vb3RoaW5nKGJvb2wgc2hvdWxkVXNlU21vb3RoaW5n KQogewotICAgIEFTU0VSVChpc01haW5UaHJlYWQoKSk7CiAgICAgc2hvdWxkVXNlRm9udFNtb290 aGluZyA9IHNob3VsZFVzZVNtb290aGluZzsKIH0KIAo=