233976 2021-12-07 22:19:43 -0800 Assert isMainThread() in hasValidAverageCharWidth 2022-07-19 21:58:49 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 233488 1 heycam heycam bfulgham mattwoodrow mmaxfield simon.fraser webkit-bug-importer zalan oldest_to_newest 1821385 0 heycam 2021-12-07 22:19:43 -0800 . 1821387 1 446298 heycam 2021-12-07 22:21:18 -0800 Created attachment 446298 Patch 1821989 2 446298 mmaxfield 2021-12-08 21:05:08 -0800 Comment on attachment 446298 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=446298&action=review > Source/WebCore/platform/graphics/FontCascade.cpp:344 > + ASSERT(isMainThread()); This is fine, but why not any of the other functions in FontCascade? 1821991 3 heycam 2021-12-08 21:09:04 -0800 (In reply to Myles C. Maxfield from comment #2) > This is fine, but why not any of the other functions in FontCascade? Because most FontCascade functions are called from worker threads too. 1824250 4 webkit-bug-importer 2021-12-14 22:20:17 -0800 <rdar://problem/86506432> 1885215 5 461021 mattwoodrow 2022-07-19 15:48:06 -0700 Created attachment 461021 Patch 1885302 6 ews-feeder 2022-07-19 21:58:47 -0700 Committed 252634@main (4c3c8c892f78): <https://commits.webkit.org/252634@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 461021. 446298 2021-12-07 22:21:18 -0800 2021-12-08 21:05:08 -0800 Patch bug-233976-20211208172117.patch text/plain 1467 heycam U3VidmVyc2lvbiBSZXZpc2lvbjogMjg2NjM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzJhMTBjYzUwZWRjZDBm ZTJjYmJiMjEwODYzMzNmMjhhODE2NDgyOS4uZDI1NThlY2JkYWVkNTVmNWU1OWRjYmU4NjdmNjI4 ZTE4MDBlMGI5NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIxLTEyLTAyICBDYW1l cm9uIE1jQ29ybWFjayAgPGhleWNhbUBhcHBsZS5jb20+CisKKyAgICAgICAgQXNzZXJ0IGlzTWFp blRocmVhZCgpIGluIGhhc1ZhbGlkQXZlcmFnZUNoYXJXaWR0aAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjMzOTc2CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBmdW5jdGlvbiBpcyBvbmx5IGNhbGxl ZCBmcm9tIHJlbmRlciBvYmplY3RzLCBhbmQgc28gZG9lcyBub3QgbmVlZAorICAgICAgICB0byBi ZSBtYWRlIHRocmVhZCBzYWZlIGZvciBPZmZzY3JlZW5DYW52YXMuCisKKyAgICAgICAgKiBwbGF0 Zm9ybS9ncmFwaGljcy9Gb250Q2FzY2FkZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpGb250Q2Fz Y2FkZTo6aGFzVmFsaWRBdmVyYWdlQ2hhcldpZHRoIGNvbnN0KToKKwogMjAyMS0xMi0wNyAgQ2Ft ZXJvbiBNY0Nvcm1hY2sgIDxoZXljYW1AYXBwbGUuY29tPgogCiAgICAgICAgIE1ha2UgdGhlIHVz ZUJhY2tzbGFzaEFzWWVuU2lnbkZvckZhbWlseSB0YWJsZSB0aHJlYWQgc2FmZQpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvRm9udENhc2NhZGUuY3BwIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvRm9udENhc2NhZGUuY3BwCmluZGV4IGIzYzE0 ZmUxMmVjM2RjNmY3NmE0MzM3YmVkMzQ2M2Y5OTgzYWUwNDYuLjM1MjBkNWY2Y2JjMGU5YWYwODQ4 YjZhODFkYmI5ZTQzNjFlNDZiMTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL0ZvbnRDYXNjYWRlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9Gb250Q2FzY2FkZS5jcHAKQEAgLTM0MSw2ICszNDEsOCBAQCBHbHlwaERhdGEgRm9u dENhc2NhZGU6OmdseXBoRGF0YUZvckNoYXJhY3RlcihVQ2hhcjMyIGMsIGJvb2wgbWlycm9yLCBG b250VmFyaWFudAogLy8gYWxsIHBsYXRmb3Jtcy4KIGJvb2wgRm9udENhc2NhZGU6Omhhc1ZhbGlk QXZlcmFnZUNoYXJXaWR0aCgpIGNvbnN0CiB7CisgICAgQVNTRVJUKGlzTWFpblRocmVhZCgpKTsK KwogICAgIGNvbnN0IEF0b21TdHJpbmcmIGZhbWlseSA9IGZpcnN0RmFtaWx5KCk7CiAgICAgaWYg KGZhbWlseS5pc0VtcHR5KCkpCiAgICAgICAgIHJldHVybiBmYWxzZTsK 461021 2022-07-19 15:48:06 -0700 2022-07-19 21:58:48 -0700 Patch bug-233976-20220720104804.patch text/plain 1170 mattwoodrow RnJvbSBlOGZlOWEzNTFkZTQwYWZlZjc1ZDU2NWNlMmEyYTVmZmM0NjkzNDc0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBDYW1lcm9uIE1jQ29ybWFjayA8aGV5Y2FtQGFwcGxlLmNvbT4K RGF0ZTogVHVlLCAyMyBOb3YgMjAyMSAxNjowNjoxNiArMTEwMApTdWJqZWN0OiBbUEFUQ0hdIEFz c2VydCBpc01haW5UaHJlYWQoKSBpbiBoYXNWYWxpZEF2ZXJhZ2VDaGFyV2lkdGgKIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzM5NzYKClJldmlld2VkIGJ5IE15bGVz IEMuIE1heGZpZWxkLgoKVGhpcyBmdW5jdGlvbiBpcyBvbmx5IGNhbGxlZCBmcm9tIHJlbmRlciBv YmplY3RzLCBhbmQgc28gZG9lcyBub3QgbmVlZAp0byBiZSBtYWRlIHRocmVhZCBzYWZlIGZvciBP ZmZzY3JlZW5DYW52YXMuCgoqIHBsYXRmb3JtL2dyYXBoaWNzL0ZvbnRDYXNjYWRlLmNwcDoKKFdl YkNvcmU6OkZvbnRDYXNjYWRlOjpoYXNWYWxpZEF2ZXJhZ2VDaGFyV2lkdGggY29uc3QpOgotLS0K IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0ZvbnRDYXNjYWRlLmNwcCB8IDIgKysK IDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9Gb250Q2FzY2FkZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9Gb250Q2FzY2FkZS5jcHAKaW5kZXggYWM0ZWZjZjA1NDNiLi43NDI4 ODUxOGRjOWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0Zv bnRDYXNjYWRlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9Gb250 Q2FzY2FkZS5jcHAKQEAgLTMzOSw2ICszMzksOCBAQCBHbHlwaERhdGEgRm9udENhc2NhZGU6Omds eXBoRGF0YUZvckNoYXJhY3RlcihVQ2hhcjMyIGMsIGJvb2wgbWlycm9yLCBGb250VmFyaWFudAog Ly8gYWxsIHBsYXRmb3Jtcy4KIGJvb2wgRm9udENhc2NhZGU6Omhhc1ZhbGlkQXZlcmFnZUNoYXJX aWR0aCgpIGNvbnN0CiB7CisgICAgQVNTRVJUKGlzTWFpblRocmVhZCgpKTsKKwogICAgIGNvbnN0 IEF0b21TdHJpbmcmIGZhbWlseSA9IGZpcnN0RmFtaWx5KCk7CiAgICAgaWYgKGZhbWlseS5pc0Vt cHR5KCkpCiAgICAgICAgIHJldHVybiBmYWxzZTsK