233964 2021-12-07 17:33:40 -0800 Avoid noisy Wcomment warnings after ANGLE update in r286603 2021-12-08 09:08:05 -0800 1 1 1 Unclassified WebKit ANGLE WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=220896 InRadar P2 Normal --- 1 lmoura lmoura annulen aperez dino don.olmstead ews-watchlist gyuyoung.kim kbr kkinnunen kondapallykalyan mcatanzaro ryanhaddad ryuan.choi sergio webkit-bug-importer oldest_to_newest 1821307 0 lmoura 2021-12-07 17:33:40 -0800 Avoid noisy Wcomment warnings after ANGLE update in r286603 1821312 1 446268 lmoura 2021-12-07 17:36:24 -0800 Created attachment 446268 Patch 1821314 2 ews-watchlist 2021-12-07 17:37:47 -0800 Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE 1821323 3 ews-feeder 2021-12-07 18:10:49 -0800 Committed r286636 (244949@main): <https://commits.webkit.org/244949@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 446268. 1821324 4 webkit-bug-importer 2021-12-07 18:11:51 -0800 <rdar://problem/86186455> 1821433 5 aperez 2021-12-07 23:57:00 -0800 I still see a number of similar warnings, at least in RewriteArrayOfArrayOfOpaqueUniforms.cpp and RewriteStructSamplers.cpp; there might be more lurking around if one does a clean build: [269/7571] Building CXX object Source/ThirdParty/ANGLE/CMakeFiles/ANGLE.dir/src/compiler/translator/tree_ops/RewriteArrayOfArrayOfOpaqueUniforms.cpp.o /app/webkit/Source/ThirdParty/ANGLE/src/compiler/translator/tree_ops/RewriteArrayOfArrayOfOpaqueUniforms.cpp:107:1: warning: multi-line comment [-Wcomment] 107 | // / \ | ^ ... [285/7571] Building CXX object Source/ThirdParty/ANGLE/CMakeFiles/ANGLE.dir/src/compiler/translator/tree_ops/RewriteStructSamplers.cpp.o /app/webkit/Source/ThirdParty/ANGLE/src/compiler/translator/tree_ops/RewriteStructSamplers.cpp:169:1: warning: multi-line comment [-Wcomment] 169 | // / \ | ^ ... Wouldn't it have been better to tell CMake to pass -Wno-comment when building ANGLE sources? Also Lauro's patch modifies an ANGLE source file without updating Source/ThirdParty/ANGLE/changes.diff 🤔️ If possible, we should aim to have as little local changes on top of upstream ANGLE as possible. 1821450 6 446324 aperez 2021-12-08 00:20:52 -0800 Created attachment 446324 Patch 1821534 7 lmoura 2021-12-08 07:02:55 -0800 (In reply to Adrian Perez from comment #6) > Created attachment 446324 [details] > Patch Testing locally, all good. No warnings (and no changed upstream files... 🙈). 1821580 8 ews-feeder 2021-12-08 09:07:58 -0800 Committed r286659 (244972@main): <https://commits.webkit.org/244972@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 446324. 446268 2021-12-07 17:36:24 -0800 2021-12-08 00:20:33 -0800 Patch bug-233964-20211207223622.patch text/plain 2171 lmoura U3VidmVyc2lvbiBSZXZpc2lvbjogMjg2NjMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9BTkdMRS9DaGFuZ2VMb2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cKaW5k ZXggMGFjNGIzN2NiZDYxYmFlYjk4NTBmZjcxZmZkYmE2NzEzY2ViYjYyMi4uMDFhMTlhOTM3MjA1 OWMzZjU3N2YxZDY2YzdmOTNiZmQwZGE5NmE2NiAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFy dHkvQU5HTEUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDEyIEBACisyMDIxLTEyLTA3ICBMYXVybyBNb3VyYSAgPGxtb3VyYUBpZ2Fs aWEuY29tPgorCisgICAgICAgIEF2b2lkIG5vaXN5IFdjb21tZW50IHdhcm5pbmdzIGFmdGVyIEFO R0xFIHVwZGF0ZSBpbiByMjg2NjAzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0yMzM5NjQKKworICAgICAgICBVbnJldmlld2VkIHdhcm5pbmcgcmVtb3Zh bC4KKworICAgICAgICAqIHNyYy9jb21waWxlci90cmFuc2xhdG9yL3RyZWVfdXRpbC9JbnRlcm1U cmF2ZXJzZS5oOgorCiAyMDIxLTEyLTA3ICBLeWxlIFBpZGRpbmd0b24gIDxrcGlkZGluZ3RvbkBh cHBsZS5jb20+CiAgICAgICAgIAogICAgICAgICBSb2xsIEFOR0xFIHRvIGluY2x1ZGUgdXBzdHJl YW1lZCBNZXRhbCBiYWNrZW5kCmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9z cmMvY29tcGlsZXIvdHJhbnNsYXRvci90cmVlX3V0aWwvSW50ZXJtVHJhdmVyc2UuaCBiL1NvdXJj ZS9UaGlyZFBhcnR5L0FOR0xFL3NyYy9jb21waWxlci90cmFuc2xhdG9yL3RyZWVfdXRpbC9JbnRl cm1UcmF2ZXJzZS5oCmluZGV4IGZmYTZhYmVjN2RkOTc0ODc4MTc3NjExZDQ0Y2Y4MjllMmM0NjI5 ZWQuLjA4M2M3YTE5ZDc5OTM3ZjBjZGIyZmYyNjI0YWNjNWM4MGI0OGQ4ODAgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL3NyYy9jb21waWxlci90cmFuc2xhdG9yL3RyZWVfdXRp bC9JbnRlcm1UcmF2ZXJzZS5oCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL3NyYy9jb21w aWxlci90cmFuc2xhdG9yL3RyZWVfdXRpbC9JbnRlcm1UcmF2ZXJzZS5oCkBAIC0yMzksMTAgKzIz OSwxMCBAQCBjbGFzcyBUSW50ZXJtVHJhdmVyc2VyIDogYW5nbGU6Ok5vbkNvcHlhYmxlCiAgICAg Ly8KICAgICAvLyAgICAgICAgICAgICAgICAgICAgTm9kZSAxICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgTm9kZSA2CiAgICAgLy8gICAgICAgICAgICAgICAg IEVPcEluZGV4RGlyZWN0ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIEVP cEluZGV4RGlyZWN0Ci0gICAgLy8gICAgICAgICAgICAgICAgLyAgICAgICAgICBcICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIC8gICAgICAgXAorICAgIC8vICAg ICAgICAgICAgICAgIC8gICAgICAgICAgXCAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAvICAgICAgIFwuCiAgICAgLy8gICAgICAgICAgIE5vZGUgMiAgICAgICAg Tm9kZSAzICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBOb2RlIDcgICAgICAgIE5v ZGUgMwogICAgIC8vICAgICAgIEVPcEluZGV4SW5kaXJlY3QgICAgIE4gICAgIC0tPiByZXBsYWNl ZCB3aXRoIC0tPiAgICAgICBFT3BJbmRleEluZGlyZWN0ICAgICBOCi0gICAgLy8gICAgICAgICAv ICAgICAgICBcICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAvICAg ICAgICBcCisgICAgLy8gICAgICAgICAvICAgICAgICBcICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAvICAgICAgICBcLgogICAgIC8vICAgICAgTm9kZSA0ICAgIE5v ZGUgNSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgTm9kZSA4ICAgICAgTm9k ZSA1CiAgICAgLy8gICAgICBzeW1ib2wgICBleHByZXNzaW9uICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICByZXBsYWNlbWVudCAgIGV4cHJlc3Npb24KICAgICAvLyAgICAgICAgXiAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgXgo= 446324 2021-12-08 00:20:52 -0800 2021-12-08 09:08:02 -0800 Patch bug-233964-20211208102051.patch text/plain 3681 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjg2NjQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9BTkdMRS9DaGFuZ2VMb2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cKaW5k ZXggMTcyN2IwZmNjYTI0YTA2NWM5YjM0ZjdkMzIyNTA4NzE0ZDc2MzFjZC4uZDZlZDU4NWU2ZWYy OTMwZDkyODg0ZDVlZTU3MjA5YTllNTQ3Y2QwMyAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFy dHkvQU5HTEUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE2IEBACisyMDIxLTEyLTA4ICBBZHJpYW4gUGVyZXogZGUgQ2FzdHJvICA8 YXBlcmV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgQXZvaWQgbm9pc3kgV2NvbW1lbnQgd2Fybmlu Z3MgYWZ0ZXIgQU5HTEUgdXBkYXRlIGluIHIyODY2MDMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzMzk2NAorICAgICAgICA8cmRhcjovL3Byb2JsZW0v ODYxODY0NTU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBDTWFrZUxpc3RzLnR4dDogUGFzcyBhbHNvIC1Xbm8tY29tbWVudCB3aGVuIGJ1aWxkaW5n IHdpdGggR0NDIG9yIENsYW5nOyBhcnJhbmdlIHRvCisgICAgICAgIHNldCBjb21waWxlciBmbGFn cyBmb3IgYW55IG9mIHRoZSBBTkdMRSBsaWJyYXJ5IHRhcmdldHMgaW5zdGVhZCBvZiBvbmx5IGZv ciBsaWJBTkdMRS4KKyAgICAgICAgKiBzcmMvY29tcGlsZXIvdHJhbnNsYXRvci90cmVlX3V0aWwv SW50ZXJtVHJhdmVyc2UuaDogUmV2ZXJ0IGNoYW5nZSBmcm9tIDIzMzk2NCB0bworICAgICAgICBh dm9pZCBoYXZpbmcgZGlmZmVyZW5jZXMgd2l0aCB0aGUgdXBzdHJlYW0gdmVyc2lvbiBvZiB0aGUg ZmlsZS4KKwogMjAyMS0xMi0wNyAgTXlsZXMgQy4gTWF4ZmllbGQgIDxtbWF4ZmllbGRAYXBwbGUu Y29tPgogCiAgICAgICAgIFtNYWNDYXRhbHlzdF0gRml4IGJ1aWxkIGFmdGVyIHIyODY2MDMKZGlm ZiAtLWdpdCBhL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NNYWtlTGlzdHMudHh0IGIvU291cmNl L1RoaXJkUGFydHkvQU5HTEUvQ01ha2VMaXN0cy50eHQKaW5kZXggNzQ4NzY1MGQxYjllYjg2ODFl MWQ5NmRlMjdmNjM1ODkyODdjZDM1Zi4uMmNhODI3ODJkOWJlMTA4OTUzZDg4MDRjNjVhYTk2NjBm NjlmNTM3ZCAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvQ01ha2VMaXN0cy50 eHQKKysrIGIvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvQ01ha2VMaXN0cy50eHQKQEAgLTI0Mywx MiArMjQzLDE4IEBAIGlmIChVU0VfQU5HTEVfV0VCR0wpCiBlbmRpZiAoKQogCiBpZiAoQ09NUElM RVJfSVNfR0NDX09SX0NMQU5HKQotICAgIFdFQktJVF9BRERfVEFSR0VUX0NYWF9GTEFHUyhBTkdM RSAtV25vLWNhc3QtYWxpZ24KLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg LVduby1leHRyYQotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAtV25vLXN1 Z2dlc3QtYXR0cmlidXRlPWZvcm1hdAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAtV25vLXVuZGVmCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIC1X bm8tdW51c2VkLXBhcmFtZXRlcgotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAtV25vLXJldHVybi10eXBlKQorICAgIGZvcmVhY2ggKGFuZ2xlX3RhcmdldCBBTkdMRSBFR0wg R0xFU3YyKQorICAgICAgICBpZiAoVEFSR0VUICR7YW5nbGVfdGFyZ2V0fSkKKyAgICAgICAgICAg IFdFQktJVF9BRERfVEFSR0VUX0NYWF9GTEFHUygke2FuZ2xlX3RhcmdldH0KKyAgICAgICAgICAg ICAgICAtV25vLWNhc3QtYWxpZ24KKyAgICAgICAgICAgICAgICAtV25vLWV4dHJhCisgICAgICAg ICAgICAgICAgLVduby1zdWdnZXN0LWF0dHJpYnV0ZT1mb3JtYXQKKyAgICAgICAgICAgICAgICAt V25vLXVuZGVmCisgICAgICAgICAgICAgICAgLVduby11bnVzZWQtcGFyYW1ldGVyCisgICAgICAg ICAgICAgICAgLVduby1yZXR1cm4tdHlwZQorICAgICAgICAgICAgICAgIC1Xbm8tY29tbWVudCkK KyAgICAgICAgZW5kaWYgKCkKKyAgICBlbmRmb3JlYWNoICgpCiBlbmRpZiAoKQogCiB0YXJnZXRf bGlua19saWJyYXJpZXMoQU5HTEVGcmFtZXdvcmsgSU5URVJGQUNFIEFOR0xFKQpkaWZmIC0tZ2l0 IGEvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvc3JjL2NvbXBpbGVyL3RyYW5zbGF0b3IvdHJlZV91 dGlsL0ludGVybVRyYXZlcnNlLmggYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9zcmMvY29tcGls ZXIvdHJhbnNsYXRvci90cmVlX3V0aWwvSW50ZXJtVHJhdmVyc2UuaAppbmRleCAwODNjN2ExOWQ3 OTkzN2YwY2RiMmZmMjYyNGFjYzVjODBiNDhkODgwLi5mZmE2YWJlYzdkZDk3NDg3ODE3NzYxMWQ0 NGNmODI5ZTJjNDYyOWVkIDEwMDY0NAotLS0gYS9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9zcmMv Y29tcGlsZXIvdHJhbnNsYXRvci90cmVlX3V0aWwvSW50ZXJtVHJhdmVyc2UuaAorKysgYi9Tb3Vy Y2UvVGhpcmRQYXJ0eS9BTkdMRS9zcmMvY29tcGlsZXIvdHJhbnNsYXRvci90cmVlX3V0aWwvSW50 ZXJtVHJhdmVyc2UuaApAQCAtMjM5LDEwICsyMzksMTAgQEAgY2xhc3MgVEludGVybVRyYXZlcnNl ciA6IGFuZ2xlOjpOb25Db3B5YWJsZQogICAgIC8vCiAgICAgLy8gICAgICAgICAgICAgICAgICAg IE5vZGUgMSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIE5v ZGUgNgogICAgIC8vICAgICAgICAgICAgICAgICBFT3BJbmRleERpcmVjdCAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBFT3BJbmRleERpcmVjdAotICAgIC8vICAgICAgICAg ICAgICAgIC8gICAgICAgICAgXCAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAvICAgICAgIFwuCisgICAgLy8gICAgICAgICAgICAgICAgLyAgICAgICAgICBcICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIC8gICAgICAgXAogICAg IC8vICAgICAgICAgICBOb2RlIDIgICAgICAgIE5vZGUgMyAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgTm9kZSA3ICAgICAgICBOb2RlIDMKICAgICAvLyAgICAgICBFT3BJbmRleElu ZGlyZWN0ICAgICBOICAgICAtLT4gcmVwbGFjZWQgd2l0aCAtLT4gICAgICAgRU9wSW5kZXhJbmRp cmVjdCAgICAgTgotICAgIC8vICAgICAgICAgLyAgICAgICAgXCAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgLyAgICAgICAgXC4KKyAgICAvLyAgICAgICAgIC8gICAg ICAgIFwgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIC8gICAgICAg IFwKICAgICAvLyAgICAgIE5vZGUgNCAgICBOb2RlIDUgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIE5vZGUgOCAgICAgIE5vZGUgNQogICAgIC8vICAgICAgc3ltYm9sICAgZXhw cmVzc2lvbiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcmVwbGFjZW1lbnQgICBleHBy ZXNzaW9uCiAgICAgLy8gICAgICAgIF4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIF4K