233961 2021-12-07 16:56:15 -0800 Web Inspector: evaluateScriptForExtension() incorrectly unwraps internal errors 2021-12-08 16:07:17 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 bburg bburg bburg ews-watchlist hi inspector-bugzilla-changes joepeck pangle webkit-bug-importer oldest_to_newest 1821289 0 bburg 2021-12-07 16:56:15 -0800 Splitting this change from 233935. 1821292 1 bburg 2021-12-07 16:58:32 -0800 <rdar://86123763> 1821388 2 446299 bburg 2021-12-07 22:22:14 -0800 Created attachment 446299 Patch v1.0 1821746 3 446299 pangle 2021-12-08 13:03:56 -0800 Comment on attachment 446299 Patch v1.0 View in context: https://bugs.webkit.org/attachment.cgi?id=446299&action=review r=me > Source/WebKit/WebProcess/Inspector/WebInspectorUIExtensionController.cpp:255 > + LOG(Inspector, "Internal error encountered while evaluating upon the frontend: at %s:%d:%d: %s", exceptionDetails.sourceURL.utf8().data(), exceptionDetails.lineNumber, exceptionDetails.columnNumber, exceptionDetails.message.utf8().data()); Nit: Odd placement of the first colon IMO... s/`frontend: at`/`frontend at` 1821793 4 446429 bburg 2021-12-08 14:55:38 -0800 Created attachment 446429 Patch v1.1 - for landing 1821833 5 ews-feeder 2021-12-08 16:07:12 -0800 Committed r286747 (244992@main): <https://commits.webkit.org/244992@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 446429. 446299 2021-12-07 22:22:14 -0800 2021-12-08 14:55:37 -0800 Patch v1.0 bug-233961-20211207222214.patch text/plain 3614 bburg U3VidmVyc2lvbiBSZXZpc2lvbjogMjg2NTA4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDAxNWU1MjMwZDkyMTRiYzA1 Zjk1ODI1YTU3OTQ0NWUyZmE5ZWMwNzEuLmFjODczZTY2OGE5ZmVmNzNjZGQ3MzkzNDYzYjAzMTdi ZGJhNjBjMGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMjEtMTItMDcgIEJKIEJ1cmcg IDxiYnVyZ0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogZXZhbHVhdGVTY3Jp cHRGb3JFeHRlbnNpb24oKSBpbmNvcnJlY3RseSB1bndyYXBzIGludGVybmFsIGVycm9ycywgY2F1 c2luZyBhbiBBU1NFUlQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTIzMzk2MQorICAgICAgICA8cmRhcjovLzg2MTIzNzYzPgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFN0YW5kYXJkaXplIHRoZSB1bndyYXBw aW5nIGNvZGUgYmFzZWQgb24gdGhlIGV2YWx1YXRlU2NyaXB0SW5FeHRlbnNpb25UYWIgdmVyc2lv biwgd2hpY2gKKyAgICAgICAgY29ycmVjdGx5IGhhbmRsZXMgdGhlIGNhc2Ugd2hlcmUgYW4gaW50 ZXJuYWwgZXJyb3IgaXMgcmV0dXJuZWQgYnkgdGhlIGV2YWx1YXRpb24uCisgICAgICAgIFRoaXMg aGFwcGVucywgZm9yIGV4YW1wbGUsIHdoZW4gTm90SW1wbGVtZW50ZWQgaXMgcmV0dXJuZWQgZm9y IHVuc3VwcG9ydGVkIGV2YWx1YXRpb24KKyAgICAgICAgb3B0aW9ucy4KKworICAgICAgICBUaGlz IHBhcnRpY3VsYXIgaXNzdWUgd2FzIGNhdXNlZCBieSBhIGxhY2sgb2Ygc3VwcG9ydCBmb3IgdGhl ICdmcmFtZVVSTCcgb3B0aW9uLgorICAgICAgICBUaGUgZml4IGZvciB0aGF0IGlzIHRyYWNrZWQg YnkgaHR0cHM6Ly93ZWJraXQub3JnL2IvMjIyNTY4Ly4KKworICAgICAgICAqIFdlYlByb2Nlc3Mv SW5zcGVjdG9yL1dlYkluc3BlY3RvclVJRXh0ZW5zaW9uQ29udHJvbGxlci5jcHA6CisgICAgICAg IChXZWJLaXQ6OldlYkluc3BlY3RvclVJRXh0ZW5zaW9uQ29udHJvbGxlcjo6ZXZhbHVhdGVTY3Jp cHRGb3JFeHRlbnNpb24pOgorCiAyMDIxLTEyLTA3ICBCSiBCdXJnICA8YmJ1cmdAYXBwbGUuY29t PgogCiAgICAgICAgIFtDb2NvYV0gV2ViIEluc3BlY3RvcjogcHJvdmlkZSBhIHdheSBmb3IgX1dL SW5zcGVjdG9yRXh0ZW5zaW9uIGNsaWVudHMgdG8gYmUgdG8gbm90aWZpZWQgd2hlbiBhbiBleHRl bnNpb24gdGFiIG5hdmlnYXRlcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNz L0luc3BlY3Rvci9XZWJJbnNwZWN0b3JVSUV4dGVuc2lvbkNvbnRyb2xsZXIuY3BwIGIvU291cmNl L1dlYktpdC9XZWJQcm9jZXNzL0luc3BlY3Rvci9XZWJJbnNwZWN0b3JVSUV4dGVuc2lvbkNvbnRy b2xsZXIuY3BwCmluZGV4IGJmMjEwOWNlOTM5ZGU2ZDdmZmYyMzhlOWVkODBlNGJjNjc4N2MyYmEu LmY4ZWEwZmMyODAzMWU0MWMwM2RmODFhZmI5OTIwZTFkNGY1N2EwMDkgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9JbnNwZWN0b3IvV2ViSW5zcGVjdG9yVUlFeHRlbnNpb25D b250cm9sbGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvSW5zcGVjdG9yL1dl Ykluc3BlY3RvclVJRXh0ZW5zaW9uQ29udHJvbGxlci5jcHAKQEAgLTI1MCw4ICsyNTAsMTIgQEAg dm9pZCBXZWJJbnNwZWN0b3JVSUV4dGVuc2lvbkNvbnRyb2xsZXI6OmV2YWx1YXRlU2NyaXB0Rm9y RXh0ZW5zaW9uKGNvbnN0IEluc3BlY3QKICAgICAgICAgSlNDOjpKU0xvY2tIb2xkZXIgbG9jayhm cm9udGVuZEdsb2JhbE9iamVjdCk7CiAKICAgICAgICAgaWYgKGF1dG8gcGFyc2VkRXJyb3IgPSB3 ZWFrVGhpcy0+cGFyc2VFeHRlbnNpb25FcnJvckZyb21FdmFsdWF0aW9uUmVzdWx0KHJlc3VsdCkp IHsKLSAgICAgICAgICAgIGF1dG8gZXhjZXB0aW9uRGV0YWlscyA9IHJlc3VsdC52YWx1ZSgpLmVy cm9yKCk7Ci0gICAgICAgICAgICBMT0coSW5zcGVjdG9yLCAiSW50ZXJuYWwgZXJyb3IgZW5jb3Vu dGVyZWQgd2hpbGUgZXZhbHVhdGluZyB1cG9uIHRoZSBmcm9udGVuZDogYXQgJXM6JWQ6JWQ6ICVz IiwgZXhjZXB0aW9uRGV0YWlscy5zb3VyY2VVUkwudXRmOCgpLmRhdGEoKSwgZXhjZXB0aW9uRGV0 YWlscy5saW5lTnVtYmVyLCBleGNlcHRpb25EZXRhaWxzLmNvbHVtbk51bWJlciwgZXhjZXB0aW9u RGV0YWlscy5tZXNzYWdlLnV0ZjgoKS5kYXRhKCkpOworICAgICAgICAgICAgaWYgKCFyZXN1bHQu dmFsdWUoKS5oYXNfdmFsdWUoKSkgeworICAgICAgICAgICAgICAgIGF1dG8gZXhjZXB0aW9uRGV0 YWlscyA9IHJlc3VsdC52YWx1ZSgpLmVycm9yKCk7CisgICAgICAgICAgICAgICAgTE9HKEluc3Bl Y3RvciwgIkludGVybmFsIGVycm9yIGVuY291bnRlcmVkIHdoaWxlIGV2YWx1YXRpbmcgdXBvbiB0 aGUgZnJvbnRlbmQ6IGF0ICVzOiVkOiVkOiAlcyIsIGV4Y2VwdGlvbkRldGFpbHMuc291cmNlVVJM LnV0ZjgoKS5kYXRhKCksIGV4Y2VwdGlvbkRldGFpbHMubGluZU51bWJlciwgZXhjZXB0aW9uRGV0 YWlscy5jb2x1bW5OdW1iZXIsIGV4Y2VwdGlvbkRldGFpbHMubWVzc2FnZS51dGY4KCkuZGF0YSgp KTsKKyAgICAgICAgICAgIH0gZWxzZQorICAgICAgICAgICAgICAgIExPRyhJbnNwZWN0b3IsICJJ bnRlcm5hbCBlcnJvciBlbmNvdW50ZXJlZCB3aGlsZSBldmFsdWF0aW5nIHVwb24gdGhlIGZyb250 ZW5kOiAlcyIsIGV4dGVuc2lvbkVycm9yVG9TdHJpbmcocGFyc2VkRXJyb3IudmFsdWUoKSkudXRm OCgpLmRhdGEoKSk7CisKICAgICAgICAgICAgIGNvbXBsZXRpb25IYW5kbGVyKHsgfSwgc3RkOjpu dWxsb3B0LCBwYXJzZWRFcnJvcik7CiAgICAgICAgICAgICByZXR1cm47CiAgICAgICAgIH0KQEAg LTI1OSw3ICsyNjMsNyBAQCB2b2lkIFdlYkluc3BlY3RvclVJRXh0ZW5zaW9uQ29udHJvbGxlcjo6 ZXZhbHVhdGVTY3JpcHRGb3JFeHRlbnNpb24oY29uc3QgSW5zcGVjdAogICAgICAgICAvLyBFeHBl Y3RlZCByZXN1bHQgaXMgZWl0aGVyIGFuIEVycm9yU3RyaW5nIG9yIHtyZXN1bHQ6IDxhbnk+fS4K ICAgICAgICAgYXV0byBvYmplY3RSZXN1bHQgPSB3ZWFrVGhpcy0+dW53cmFwRXZhbHVhdGlvblJl c3VsdEFzT2JqZWN0KHJlc3VsdCk7CiAgICAgICAgIGlmICghb2JqZWN0UmVzdWx0KSB7Ci0gICAg ICAgICAgICBMT0coSW5zcGVjdG9yLCAiVW5leHBlY3RlZCBub24tb2JqZWN0IHZhbHVlIHJldHVy bmVkIGZyb20gSW5zcGVjdG9yRnJvbnRlbmRBUEkuY3JlYXRlVGFiRm9yRXh0ZW5zaW9uKCkuIik7 CisgICAgICAgICAgICBMT0coSW5zcGVjdG9yLCAiVW5leHBlY3RlZCBub24tb2JqZWN0IHZhbHVl IHJldHVybmVkIGZyb20gSW5zcGVjdG9yRnJvbnRlbmRBUEkuZXZhbHVhdGVTY3JpcHRGb3JFeHRl bnNpb24oKS4iKTsKICAgICAgICAgICAgIGNvbXBsZXRpb25IYW5kbGVyKHsgfSwgc3RkOjpudWxs b3B0LCBJbnNwZWN0b3I6OkV4dGVuc2lvbkVycm9yOjpJbnRlcm5hbEVycm9yKTsKICAgICAgICAg ICAgIHJldHVybjsKICAgICAgICAgfQo= 446429 2021-12-08 14:55:38 -0800 2021-12-08 16:07:15 -0800 Patch v1.1 - for landing bug-233961-20211208145538.patch text/plain 3612 bburg U3VidmVyc2lvbiBSZXZpc2lvbjogMjg2NTA4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDAxNWU1MjMwZDkyMTRiYzA1 Zjk1ODI1YTU3OTQ0NWUyZmE5ZWMwNzEuLjZmMGI1YmZjMWM1YmFhMjA3NjE0NjA0MDgzMTY1Y2Mx NTg5ZWMxMmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMjEtMTItMDcgIEJKIEJ1cmcg IDxiYnVyZ0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogZXZhbHVhdGVTY3Jp cHRGb3JFeHRlbnNpb24oKSBpbmNvcnJlY3RseSB1bndyYXBzIGludGVybmFsIGVycm9ycywgY2F1 c2luZyBhbiBBU1NFUlQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTIzMzk2MQorICAgICAgICA8cmRhcjovLzg2MTIzNzYzPgorCisgICAgICAgIFJldmll d2VkIGJ5IFBhdHJpY2sgQW5nbGUuCisKKyAgICAgICAgU3RhbmRhcmRpemUgdGhlIHVud3JhcHBp bmcgY29kZSBiYXNlZCBvbiB0aGUgZXZhbHVhdGVTY3JpcHRJbkV4dGVuc2lvblRhYiB2ZXJzaW9u LCB3aGljaAorICAgICAgICBjb3JyZWN0bHkgaGFuZGxlcyB0aGUgY2FzZSB3aGVyZSBhbiBpbnRl cm5hbCBlcnJvciBpcyByZXR1cm5lZCBieSB0aGUgZXZhbHVhdGlvbi4KKyAgICAgICAgVGhpcyBo YXBwZW5zLCBmb3IgZXhhbXBsZSwgd2hlbiBOb3RJbXBsZW1lbnRlZCBpcyByZXR1cm5lZCBmb3Ig dW5zdXBwb3J0ZWQgZXZhbHVhdGlvbgorICAgICAgICBvcHRpb25zLgorCisgICAgICAgIFRoaXMg cGFydGljdWxhciBpc3N1ZSB3YXMgY2F1c2VkIGJ5IGEgbGFjayBvZiBzdXBwb3J0IGZvciB0aGUg J2ZyYW1lVVJMJyBvcHRpb24uCisgICAgICAgIFRoZSBmaXggZm9yIHRoYXQgaXMgdHJhY2tlZCBi eSBodHRwczovL3dlYmtpdC5vcmcvYi8yMjI1NjgvLgorCisgICAgICAgICogV2ViUHJvY2Vzcy9J bnNwZWN0b3IvV2ViSW5zcGVjdG9yVUlFeHRlbnNpb25Db250cm9sbGVyLmNwcDoKKyAgICAgICAg KFdlYktpdDo6V2ViSW5zcGVjdG9yVUlFeHRlbnNpb25Db250cm9sbGVyOjpldmFsdWF0ZVNjcmlw dEZvckV4dGVuc2lvbik6CisKIDIwMjEtMTItMDcgIEJKIEJ1cmcgIDxiYnVyZ0BhcHBsZS5jb20+ CiAKICAgICAgICAgW0NvY29hXSBXZWIgSW5zcGVjdG9yOiBwcm92aWRlIGEgd2F5IGZvciBfV0tJ bnNwZWN0b3JFeHRlbnNpb24gY2xpZW50cyB0byBiZSB0byBub3RpZmllZCB3aGVuIGFuIGV4dGVu c2lvbiB0YWIgbmF2aWdhdGVzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3Mv SW5zcGVjdG9yL1dlYkluc3BlY3RvclVJRXh0ZW5zaW9uQ29udHJvbGxlci5jcHAgYi9Tb3VyY2Uv V2ViS2l0L1dlYlByb2Nlc3MvSW5zcGVjdG9yL1dlYkluc3BlY3RvclVJRXh0ZW5zaW9uQ29udHJv bGxlci5jcHAKaW5kZXggYmYyMTA5Y2U5MzlkZTZkN2ZmZjIzOGU5ZWQ4MGU0YmM2Nzg3YzJiYS4u ZTc5ZjlmNTQ0NzE4ODNhMjM4YTRhMzEyMGZhNjU3ZWJjNjA4N2Q2NSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdC9XZWJQcm9jZXNzL0luc3BlY3Rvci9XZWJJbnNwZWN0b3JVSUV4dGVuc2lvbkNv bnRyb2xsZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9JbnNwZWN0b3IvV2Vi SW5zcGVjdG9yVUlFeHRlbnNpb25Db250cm9sbGVyLmNwcApAQCAtMjUwLDggKzI1MCwxMiBAQCB2 b2lkIFdlYkluc3BlY3RvclVJRXh0ZW5zaW9uQ29udHJvbGxlcjo6ZXZhbHVhdGVTY3JpcHRGb3JF eHRlbnNpb24oY29uc3QgSW5zcGVjdAogICAgICAgICBKU0M6OkpTTG9ja0hvbGRlciBsb2NrKGZy b250ZW5kR2xvYmFsT2JqZWN0KTsKIAogICAgICAgICBpZiAoYXV0byBwYXJzZWRFcnJvciA9IHdl YWtUaGlzLT5wYXJzZUV4dGVuc2lvbkVycm9yRnJvbUV2YWx1YXRpb25SZXN1bHQocmVzdWx0KSkg ewotICAgICAgICAgICAgYXV0byBleGNlcHRpb25EZXRhaWxzID0gcmVzdWx0LnZhbHVlKCkuZXJy b3IoKTsKLSAgICAgICAgICAgIExPRyhJbnNwZWN0b3IsICJJbnRlcm5hbCBlcnJvciBlbmNvdW50 ZXJlZCB3aGlsZSBldmFsdWF0aW5nIHVwb24gdGhlIGZyb250ZW5kOiBhdCAlczolZDolZDogJXMi LCBleGNlcHRpb25EZXRhaWxzLnNvdXJjZVVSTC51dGY4KCkuZGF0YSgpLCBleGNlcHRpb25EZXRh aWxzLmxpbmVOdW1iZXIsIGV4Y2VwdGlvbkRldGFpbHMuY29sdW1uTnVtYmVyLCBleGNlcHRpb25E ZXRhaWxzLm1lc3NhZ2UudXRmOCgpLmRhdGEoKSk7CisgICAgICAgICAgICBpZiAoIXJlc3VsdC52 YWx1ZSgpLmhhc192YWx1ZSgpKSB7CisgICAgICAgICAgICAgICAgYXV0byBleGNlcHRpb25EZXRh aWxzID0gcmVzdWx0LnZhbHVlKCkuZXJyb3IoKTsKKyAgICAgICAgICAgICAgICBMT0coSW5zcGVj dG9yLCAiSW50ZXJuYWwgZXJyb3IgZW5jb3VudGVyZWQgd2hpbGUgZXZhbHVhdGluZyB1cG9uIHRo ZSBmcm9udGVuZCBhdCAlczolZDolZDogJXMiLCBleGNlcHRpb25EZXRhaWxzLnNvdXJjZVVSTC51 dGY4KCkuZGF0YSgpLCBleGNlcHRpb25EZXRhaWxzLmxpbmVOdW1iZXIsIGV4Y2VwdGlvbkRldGFp bHMuY29sdW1uTnVtYmVyLCBleGNlcHRpb25EZXRhaWxzLm1lc3NhZ2UudXRmOCgpLmRhdGEoKSk7 CisgICAgICAgICAgICB9IGVsc2UKKyAgICAgICAgICAgICAgICBMT0coSW5zcGVjdG9yLCAiSW50 ZXJuYWwgZXJyb3IgZW5jb3VudGVyZWQgd2hpbGUgZXZhbHVhdGluZyB1cG9uIHRoZSBmcm9udGVu ZDogJXMiLCBleHRlbnNpb25FcnJvclRvU3RyaW5nKHBhcnNlZEVycm9yLnZhbHVlKCkpLnV0Zjgo KS5kYXRhKCkpOworCiAgICAgICAgICAgICBjb21wbGV0aW9uSGFuZGxlcih7IH0sIHN0ZDo6bnVs bG9wdCwgcGFyc2VkRXJyb3IpOwogICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICB9CkBAIC0y NTksNyArMjYzLDcgQEAgdm9pZCBXZWJJbnNwZWN0b3JVSUV4dGVuc2lvbkNvbnRyb2xsZXI6OmV2 YWx1YXRlU2NyaXB0Rm9yRXh0ZW5zaW9uKGNvbnN0IEluc3BlY3QKICAgICAgICAgLy8gRXhwZWN0 ZWQgcmVzdWx0IGlzIGVpdGhlciBhbiBFcnJvclN0cmluZyBvciB7cmVzdWx0OiA8YW55Pn0uCiAg ICAgICAgIGF1dG8gb2JqZWN0UmVzdWx0ID0gd2Vha1RoaXMtPnVud3JhcEV2YWx1YXRpb25SZXN1 bHRBc09iamVjdChyZXN1bHQpOwogICAgICAgICBpZiAoIW9iamVjdFJlc3VsdCkgewotICAgICAg ICAgICAgTE9HKEluc3BlY3RvciwgIlVuZXhwZWN0ZWQgbm9uLW9iamVjdCB2YWx1ZSByZXR1cm5l ZCBmcm9tIEluc3BlY3RvckZyb250ZW5kQVBJLmNyZWF0ZVRhYkZvckV4dGVuc2lvbigpLiIpOwor ICAgICAgICAgICAgTE9HKEluc3BlY3RvciwgIlVuZXhwZWN0ZWQgbm9uLW9iamVjdCB2YWx1ZSBy ZXR1cm5lZCBmcm9tIEluc3BlY3RvckZyb250ZW5kQVBJLmV2YWx1YXRlU2NyaXB0Rm9yRXh0ZW5z aW9uKCkuIik7CiAgICAgICAgICAgICBjb21wbGV0aW9uSGFuZGxlcih7IH0sIHN0ZDo6bnVsbG9w dCwgSW5zcGVjdG9yOjpFeHRlbnNpb25FcnJvcjo6SW50ZXJuYWxFcnJvcik7CiAgICAgICAgICAg ICByZXR1cm47CiAgICAgICAgIH0K