23394 2009-01-16 15:16:01 -0800 Remove calls to WebCore::setDeferringTimers() 2009-01-16 15:27:15 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All Linux RESOLVED FIXED P2 Normal --- 1 dimich webkit-unassigned alp ap oldest_to_newest 106128 0 dimich 2009-01-16 15:16:01 -0800 ResourceHandleManager for curl disables global timers during select() call to avoid being interrupted by a process signal. It appears that original effort to fix the interruption ended up using also a loop in case 'select' returns with EINTR. Loop is the sufficient way to deal with interruptions (for example, see here: http://www.wlug.org.nz/EINTR). See bug 16071 for more info. I'm removing setDeferringTimers() because nothing else uses it and I'm in the process of making TimerBase thread-aware for workers. 106129 1 26811 dimich 2009-01-16 15:18:57 -0800 Created attachment 26811 Proposed patch 106130 2 26811 alp 2009-01-16 15:22:52 -0800 Comment on attachment 26811 Proposed patch r=me 106131 3 alp 2009-01-16 15:27:15 -0800 Landed in r39991, thanks for the cleanup. Please remember to follow up soon with a bug/patch that removes the unused code. 26811 2009-01-16 15:18:57 -0800 2009-01-16 15:22:52 -0800 Proposed patch patch.txt text/plain 1740 dimich ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NDhmYWNlYy4uOGIzMjAwMSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAwOS0wMS0xNiAgRG1pdHJ5IFRpdG92 ICA8ZGltaWNoQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MjMzOTQKKyAgICAgICAgUmVtb3ZlIHVubmVjZXNzYXJ5IGNhbGxzIHRvIHNldERlZmVycmluZ1Rp bWVycygpLgorICAgICAgICBUaGlzIG1ldGhvZCBpcyB0byBiZSByZW1vdmVkIHNvb24uCisKKyAg ICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL2N1cmwvUmVzb3VyY2VIYW5kbGVNYW5hZ2VyLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OlJlc291cmNlSGFuZGxlTWFuYWdlcjo6ZG93bmxvYWRUaW1lckNh bGxiYWNrKTogcmVtb3ZlZCBzZXREZWZlcnJpbmdUaW1lcnMgY2FsbHMuCisKIDIwMDktMDEtMTQg IEFkYW0gVHJlYXQgIDxhZGFtLnRyZWF0QHRvcmNobW9iaWxlLmNvbT4KIAogICAgICAgICBQcm9z cGVjdGl2ZSBidWlsZCBmaXggZm9yIFF0IGZvbGxvd2luZyByMzk5MjIuCmRpZmYgLS1naXQgYS9X ZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY3VybC9SZXNvdXJjZUhhbmRsZU1hbmFnZXIuY3BwIGIv V2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2N1cmwvUmVzb3VyY2VIYW5kbGVNYW5hZ2VyLmNwcApp bmRleCA1YmM1MTlhLi42YTQ0MjMzIDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL25ldHdv cmsvY3VybC9SZXNvdXJjZUhhbmRsZU1hbmFnZXIuY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0v bmV0d29yay9jdXJsL1Jlc291cmNlSGFuZGxlTWFuYWdlci5jcHAKQEAgLTI2NCw4ICsyNjQsNyBA QCB2b2lkIFJlc291cmNlSGFuZGxlTWFuYWdlcjo6ZG93bmxvYWRUaW1lckNhbGxiYWNrKFRpbWVy PFJlc291cmNlSGFuZGxlTWFuYWdlcj4qCiAgICAgdGltZW91dC50dl9zZWMgPSAwOwogICAgIHRp bWVvdXQudHZfdXNlYyA9IHNlbGVjdFRpbWVvdXRNUyAqIDEwMDA7ICAgICAgIC8vIHNlbGVjdCB3 YWl0cyBtaWNyb3NlY29uZHMKIAotICAgIC8vIFRlbXBvcmFyaWx5IGRpc2FibGUgdGltZXJzIHNp bmNlIHNpZ25hbHMgbWF5IGludGVycnVwdCBzZWxlY3QoKSwgcmFpc2luZyBFSU5UUiBlcnJvcnMg b24gc29tZSBwbGF0Zm9ybXMKLSAgICBzZXREZWZlcnJpbmdUaW1lcnModHJ1ZSk7CisgICAgLy8g UmV0cnkgJ3NlbGVjdCcgaWYgaXQgd2FzIGludGVycnVwdGVkIGJ5IGEgcHJvY2VzcyBzaWduYWwu CiAgICAgaW50IHJjID0gMDsKICAgICBkbyB7CiAgICAgICAgIEZEX1pFUk8oJmZkcmVhZCk7CkBA IC0yNzgsNyArMjc3LDYgQEAgdm9pZCBSZXNvdXJjZUhhbmRsZU1hbmFnZXI6OmRvd25sb2FkVGlt ZXJDYWxsYmFjayhUaW1lcjxSZXNvdXJjZUhhbmRsZU1hbmFnZXI+KgogICAgICAgICBpZiAobWF4 ZmQgPj0gMCkKICAgICAgICAgICAgIHJjID0gOjpzZWxlY3QobWF4ZmQgKyAxLCAmZmRyZWFkLCAm ZmR3cml0ZSwgJmZkZXhjZXAsICZ0aW1lb3V0KTsKICAgICB9IHdoaWxlIChyYyA9PSAtMSAmJiBl cnJubyA9PSBFSU5UUik7Ci0gICAgc2V0RGVmZXJyaW5nVGltZXJzKGZhbHNlKTsKIAogICAgIGlm ICgtMSA9PSByYykgewogI2lmbmRlZiBOREVCVUcK