23392 2009-01-16 14:55:37 -0800 Some pixel test output includes DumpRenderTree warnings about changing main display profile 2009-03-02 11:51:54 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED http://build.webkit.org/results/trunk-mac-intel-pixel/1433/ LayoutTestFailure, Regression P2 Normal --- 1 ddkilzer pol mitz oldest_to_newest 106123 0 ddkilzer 2009-01-16 14:55:37 -0800 * SUMMARY Some pixel tests (the first test each time DumpRenderTree is restarted) contain bogus STDERR output about changing the main display profile. This shouldn't be included in the test output. * STEPS TO REPRODUCE $ ./WebKitTools/Scripts/run-webkit-tests --pixel --singly * RESULTS Every test will have STDERR output because a new DumpRenderTree process is created for each test via the "--singly" flag. This should be printed to the console instead. * REGRESSION This probably started when STDERR output begin to be captured for all tests. This warning used to get printed to the console. * NOTES The warning message: WARNING: Temporarily changing the main display color profile to "/System/Library/ColorSync/Profiles/Generic RGB Profile.icc": the colors on your screen will change for the duration of the testing. This allows the WebKit pixel-based regression tests to have consistent color values across all machines. 106125 1 ddkilzer 2009-01-16 14:56:35 -0800 One solution would be to prefix all DumpRenderTree output with a unique string (like "DRT: ") so that run-webkit-tests knows that it should print those lines out to the console (instead of including them as part of the test output). 106333 2 pol 2009-01-20 08:32:47 -0800 Why don't we just remove this warning? I left it in place when I re-implement the pixel test path of DRT, but never though it had any added value. 106334 3 mitz 2009-01-20 08:40:15 -0800 (In reply to comment #1) > One solution would be to prefix all DumpRenderTree output with a unique string > (like "DRT: ") so that run-webkit-tests knows that it should print those lines > out to the console (instead of including them as part of the test output). I think a simpler solution would be for the script, instead of DRT, to output this message. But I am fine with removing it altogether. 106339 4 ddkilzer 2009-01-20 10:14:26 -0800 (In reply to comment #3) > I think a simpler solution would be for the script, instead of DRT, to output > this message. But I am fine with removing it altogether. Ditto. 106401 5 26875 pol 2009-01-20 15:38:33 -0800 Created attachment 26875 Patch v1 106403 6 26875 darin 2009-01-20 16:07:36 -0800 Comment on attachment 26875 Patch v1 Seems OK, r=me 106406 7 pol 2009-01-20 16:30:51 -0800 Sending WebKitTools/ChangeLog Sending WebKitTools/DumpRenderTree/mac/PixelDumpSupportMac.mm Sending WebKitTools/Scripts/run-webkit-tests Transmitting file data ... Committed revision 40075. 26875 2009-01-20 15:38:33 -0800 2009-01-20 16:07:36 -0800 Patch v1 Patch.txt text/plain 2367 pol SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDQwMDc0KQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDktMDEtMjAgIFBpZXJyZS1PbGl2aWVyIExh dG91ciAgPHBvbEBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgUHJpbnQgd2FybmluZyByZWdhcmRpbmcgZGlzcGxheSBjb2xvciBwcm9m aWxlIGNoYW5nZSBpbiBydW4td2Via2l0LXRlc3RzIGluc3RlYWQgb2YgRFJULgorCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzM5MgorCisgICAgICAg ICogRHVtcFJlbmRlclRyZWUvbWFjL1BpeGVsRHVtcFN1cHBvcnRNYWMubW06CisgICAgICAgIChz ZXR1cE1haW5EaXNwbGF5Q29sb3JQcm9maWxlKToKKyAgICAgICAgKiBTY3JpcHRzL3J1bi13ZWJr aXQtdGVzdHM6CisKIDIwMDktMDEtMjAgIFBpZXJyZS1PbGl2aWVyIExhdG91ciAgPHBvbEBhcHBs ZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCkluZGV4OiBXZWJLaXRU b29scy9EdW1wUmVuZGVyVHJlZS9tYWMvUGl4ZWxEdW1wU3VwcG9ydE1hYy5tbQo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBXZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9tYWMvUGl4ZWxEdW1wU3VwcG9ydE1hYy5t bQkocmV2aXNpb24gNDAwNjMpCisrKyBXZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9tYWMvUGl4 ZWxEdW1wU3VwcG9ydE1hYy5tbQkod29ya2luZyBjb3B5KQpAQCAtOTgsOSArOTgsNiBAQCB2b2lk IHNldHVwTWFpbkRpc3BsYXlDb2xvclByb2ZpbGUoKQogICAgIHNpZ25hbChTSUdJTlQsIHJlc3Rv cmVNYWluRGlzcGxheUNvbG9yUHJvZmlsZSk7CiAgICAgc2lnbmFsKFNJR0hVUCwgcmVzdG9yZU1h aW5EaXNwbGF5Q29sb3JQcm9maWxlKTsKICAgICBzaWduYWwoU0lHVEVSTSwgcmVzdG9yZU1haW5E aXNwbGF5Q29sb3JQcm9maWxlKTsKLSAgICAKLSAgICBmcHJpbnRmKHN0ZGVyciwgIlxuXG5XQVJO SU5HOiBUZW1wb3JhcmlseSBjaGFuZ2luZyB0aGUgbWFpbiBkaXNwbGF5IGNvbG9yIHByb2ZpbGUg dG8gXCIlc1wiOiB0aGUgY29sb3JzIG9uIHlvdXIgc2NyZWVuIHdpbGwgY2hhbmdlIGZvciB0aGUg ZHVyYXRpb24gb2YgdGhlIHRlc3RpbmcuXG4iLCBQUk9GSUxFX1BBVEgpOwotICAgIGZwcmludGYo c3RkZXJyLCAiVGhpcyBhbGxvd3MgdGhlIFdlYktpdCBwaXhlbC1iYXNlZCByZWdyZXNzaW9uIHRl c3RzIHRvIGhhdmUgY29uc2lzdGVudCBjb2xvciB2YWx1ZXMgYWNyb3NzIGFsbCBtYWNoaW5lcy5c biIpOwogfQogCiBQYXNzUmVmUHRyPEJpdG1hcENvbnRleHQ+IGNyZWF0ZUJpdG1hcENvbnRleHRG cm9tV2ViVmlldyhib29sIG9uc2NyZWVuLCBib29sIGluY3JlbWVudGFsUmVwYWludCwgYm9vbCBz d2VlcEhvcml6b250YWxseSwgYm9vbCBkcmF3U2VsZWN0aW9uUmVjdCkKSW5kZXg6IFdlYktpdFRv b2xzL1NjcmlwdHMvcnVuLXdlYmtpdC10ZXN0cwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9T Y3JpcHRzL3J1bi13ZWJraXQtdGVzdHMJKHJldmlzaW9uIDQwMDczKQorKysgV2ViS2l0VG9vbHMv U2NyaXB0cy9ydW4td2Via2l0LXRlc3RzCSh3b3JraW5nIGNvcHkpCkBAIC0zMjQsNiArMzI0LDEw IEBAIG15ICR0ZXN0UmVzdWx0cyA9IGNhdGZpbGUoJHRlc3RSZXN1bHRzRGkKIHByaW50ICJSdW5u aW5nIHRlc3RzIGZyb20gJHRlc3REaXJlY3RvcnlcbiI7CiBpZiAoJHBpeGVsVGVzdHMpIHsKICAg ICBwcmludCAiRW5hYmxpbmcgcGl4ZWwgdGVzdHMgd2l0aCBhIHRvbGVyYW5jZSBvZiAkdG9sZXJh bmNlJVxuIjsKKyAgICBpZiAoaXNEYXJ3aW4oKSkgeworICAgICAgICBwcmludCAiV0FSTklORzog VGVtcG9yYXJpbHkgY2hhbmdpbmcgdGhlIG1haW4gZGlzcGxheSBjb2xvciBwcm9maWxlOiB0aGUg Y29sb3JzIG9uIHlvdXIgc2NyZWVuIHdpbGwgY2hhbmdlIGZvciB0aGUgZHVyYXRpb24gb2YgdGhl IHRlc3RpbmcuXG4iOworICAgICAgICBwcmludCAiVGhpcyBhbGxvd3MgdGhlIHBpeGVsIHRlc3Rz IHRvIGhhdmUgY29uc2lzdGVudCBjb2xvciB2YWx1ZXMgYWNyb3NzIGFsbCBtYWNoaW5lcy5cbiI7 CisgICAgfQogfQogCiBteSBAdGVzdHMgPSAoKTsK