233841 2021-12-03 16:05:10 -0800 [iOS] Web content process sometimes crashes under WebPage::positionInformation() 2021-12-03 17:36:03 -0800 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 wenson_hsieh wenson_hsieh akeerthi ggaren hi megan_gardner thorton webkit-bug-importer oldest_to_newest 1820337 0 wenson_hsieh 2021-12-03 16:05:10 -0800 rdar://85917212 1820343 1 445911 wenson_hsieh 2021-12-03 16:14:45 -0800 Created attachment 445911 Patch 1820345 2 445911 ggaren 2021-12-03 16:21:05 -0800 Comment on attachment 445911 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=445911&action=review r=me > Tools/TestWebKitAPI/Tests/WebKitCocoa/ImageAnalysisTests.mm:87 > +static CGPoint gSwizzledLocationInView = CGPoint { 100, 100 }; > static CGPoint swizzledLocationInView(id, SEL, UIView *) > { > - return CGPointMake(100, 100); > + return gSwizzledLocationInView; > } Nit: The most efficient thing to do here is "return CGPoint { 100, 100 }". On all modern hardware, that will just fill two registers with constants and return. Maybe that's the best thing to do. If we do have a specific motivation to use a constant, I'd suggest putting the static inside the function and marking it const, to reduce its scope / potential for incorrect usage. 1820346 3 wenson_hsieh 2021-12-03 16:22:53 -0800 (In reply to Geoffrey Garen from comment #2) > Comment on attachment 445911 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=445911&action=review > > r=me > > > Tools/TestWebKitAPI/Tests/WebKitCocoa/ImageAnalysisTests.mm:87 > > +static CGPoint gSwizzledLocationInView = CGPoint { 100, 100 }; > > static CGPoint swizzledLocationInView(id, SEL, UIView *) > > { > > - return CGPointMake(100, 100); > > + return gSwizzledLocationInView; > > } > > Nit: > > The most efficient thing to do here is "return CGPoint { 100, 100 }". On all > modern hardware, that will just fill two registers with constants and > return. Maybe that's the best thing to do. > > If we do have a specific motivation to use a constant, I'd suggest putting > the static inside the function and marking it const, to reduce its scope / > potential for incorrect usage. Ah, so I pulled this out into a variable because I needed to be able to change this to another value (500, 500) for the new test below. 1820348 4 445911 ggaren 2021-12-03 16:26:00 -0800 Comment on attachment 445911 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=445911&action=review >>> Tools/TestWebKitAPI/Tests/WebKitCocoa/ImageAnalysisTests.mm:87 >>> } >> >> Nit: >> >> The most efficient thing to do here is "return CGPoint { 100, 100 }". On all modern hardware, that will just fill two registers with constants and return. Maybe that's the best thing to do. >> >> If we do have a specific motivation to use a constant, I'd suggest putting the static inside the function and marking it const, to reduce its scope / potential for incorrect usage. > > Ah, so I pulled this out into a variable because I needed to be able to change this to another value (500, 500) for the new test below. Oh, lol, I totally missed that! Seems fine as-is. 1820366 5 445911 wenson_hsieh 2021-12-03 17:00:16 -0800 Comment on attachment 445911 Patch Thanks for the review! 1820389 6 ews-feeder 2021-12-03 17:36:01 -0800 Committed r286522 (244856@main): <https://commits.webkit.org/244856@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 445911. 445911 2021-12-03 16:14:45 -0800 2021-12-03 17:36:02 -0800 Patch bug-233841-20211203161444.patch text/plain 6301 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjg2Mzg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGNjNmEyNzMxYzg2NzJhZGFi NGQ2ZmMxOTM3NjNkNGFlNjY0YTkxNGQuLjVmZjZmNDZkYzdlOGM0YzczMjQ5MjlkNjA3YTYwYzVj MWNlZDVjYWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMjEtMTItMDMgIFdlbnNvbiBI c2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CisKKyAgICAgICAgW2lPU10gV2ViIGNvbnRl bnQgcHJvY2VzcyBzb21ldGltZXMgY3Jhc2hlcyB1bmRlciBXZWJQYWdlOjpwb3NpdGlvbkluZm9y bWF0aW9uKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTIzMzg0MQorICAgICAgICByZGFyOi8vODU5MTcyMTIKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgYSBtaXNzaW5nIG51bGwgY2hlY2sgaW4gdGhl IGNhc2Ugd2hlcmUgdGhlIGhpdC10ZXN0ZWQgbm9kZSBpcyBudWxsIGluIGBXZWJQYWdlOjpwb3Np dGlvbkluZm9ybWF0aW9uYC4gVGhpcworICAgICAgICBjYW4gaGFwcGVuIGluIGEgbnVtYmVyIG9m IHdheXMgKG9uZSBvZiB3aGljaCBpcyBleGVyY2lzZWQgYnkgdGhlIG5ldyBBUEkgdGVzdCkuCisK KyAgICAgICAgVGVzdDogSW1hZ2VBbmFseXNpc1Rlc3RzLkRvTm90Q3Jhc2hXaGVuSGl0VGVzdGlu Z091dHNpZGVPZldlYlZpZXcKKworICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9pb3MvV2Vi UGFnZUlPUy5tbToKKyAgICAgICAgKFdlYktpdDo6V2ViUGFnZTo6cG9zaXRpb25JbmZvcm1hdGlv bik6CisKIDIwMjEtMTItMDEgIENvbW1pdCBRdWV1ZSAgPGNvbW1pdC1xdWV1ZUB3ZWJraXQub3Jn PgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJldmVydGluZyByMjg2MDM3LgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlBhZ2UvaW9zL1dlYlBhZ2VJT1MubW0gYi9Tb3Vy Y2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFnZS9pb3MvV2ViUGFnZUlPUy5tbQppbmRleCA4NmUw NGM1OTYwMmQzMzVlZDcyYTFjMjFhOTkwYWQzZTNkNzY3Njg1Li5jOTVjMzg0NjM5MjIxODRmMjU3 YTcxOWRiNWJhOWE0ODI5YWVkZjFiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nl c3MvV2ViUGFnZS9pb3MvV2ViUGFnZUlPUy5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nl c3MvV2ViUGFnZS9pb3MvV2ViUGFnZUlPUy5tbQpAQCAtMzE0MSw3ICszMTQxLDcgQEAgSW50ZXJh Y3Rpb25JbmZvcm1hdGlvbkF0UG9zaXRpb24gV2ViUGFnZTo6cG9zaXRpb25JbmZvcm1hdGlvbihj b25zdCBJbnRlcmFjdGlvbkkKICAgICAgICAgICAgIGluZm8uaW1hZ2UgPSBzaGFyZWFibGVCaXRt YXBTbmFwc2hvdEZvck5vZGUoZWxlbWVudCk7CiAgICAgfQogCi0gICAgaWYgKCFpbmZvLmlzSW1h Z2UgJiYgcmVxdWVzdC5pbmNsdWRlSW1hZ2VEYXRhKSB7CisgICAgaWYgKCFpbmZvLmlzSW1hZ2Ug JiYgcmVxdWVzdC5pbmNsdWRlSW1hZ2VEYXRhICYmIGhpdFRlc3ROb2RlKSB7CiAgICAgICAgIGlm IChhdXRvIHZpZGVvID0gaG9zdFZpZGVvRWxlbWVudElnbm9yaW5nSW1hZ2VPdmVybGF5KCpoaXRU ZXN0Tm9kZSkpCiAgICAgICAgICAgICB2aWRlb1Bvc2l0aW9uSW5mb3JtYXRpb24oKnRoaXMsICp2 aWRlbywgcmVxdWVzdCwgaW5mbyk7CiAgICAgICAgIGVsc2UgaWYgKGlzPEhUTUxJbWFnZUVsZW1l bnQ+KGhpdFRlc3ROb2RlKSkKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0No YW5nZUxvZwppbmRleCAxNmI3OTY0NzQyMTFiZTY0ZGJjMTc2MTk4ZjU4NzZkMmVkOWUzODI4Li42 M2QxNDg2N2U0OWMzNDVlZTI2ZDAwMDc5YTkyOTc4NzcxZTQ3MThmIDEwMDY0NAotLS0gYS9Ub29s cy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMjEt MTItMDMgIFdlbnNvbiBIc2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CisKKyAgICAgICAg W2lPU10gV2ViIGNvbnRlbnQgcHJvY2VzcyBzb21ldGltZXMgY3Jhc2hlcyB1bmRlciBXZWJQYWdl Ojpwb3NpdGlvbkluZm9ybWF0aW9uKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTIzMzg0MQorICAgICAgICByZGFyOi8vODU5MTcyMTIKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgYSB0ZXN0IHRoYXQg ZXhlcmNpc2VzIGhpdC10ZXN0aW5nIGZvciBMaXZlIFRleHQsIGJ1dCBpbmR1Y2VzIHRoaXMgY3Jh c2ggYnkgaGl0LXRlc3Rpbmcgb3V0c2lkZSBvZiB0aGUgYm91bmRzCisgICAgICAgIG9mIHRoZSB3 ZWIgdmlldyAoc3VjaCB0aGF0IHRoZSBoaXQtdGVzdGVkIG5vZGUgZW5kcyB1cCBhcyBudWxsKS4K KworICAgICAgICAqIFRlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvSW1hZ2VBbmFseXNp c1Rlc3RzLm1tOgorICAgICAgICAoVGVzdFdlYktpdEFQSTo6c3dpenpsZWRMb2NhdGlvbkluVmll dyk6CisgICAgICAgIChUZXN0V2ViS2l0QVBJOjpURVNUKToKKwogMjAyMS0xMi0wMSAgQ2hyaXMg RHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQgQVBJIHRlc3Qg YnVpbGQgZml4LgpkaWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRD b2NvYS9JbWFnZUFuYWx5c2lzVGVzdHMubW0gYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dl YktpdENvY29hL0ltYWdlQW5hbHlzaXNUZXN0cy5tbQppbmRleCBmNzlkOWU1NWZiMTJkMzJlOGQw YzAxYjkzMjM3MWE5NzMyOTY0NmFiLi4yYzhiNTEwYjY0N2JlZmE2N2QwMjhkMDkyMTEwYjVjZjFj YzQwN2FlIDEwMDY0NAotLS0gYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29h L0ltYWdlQW5hbHlzaXNUZXN0cy5tbQorKysgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dl YktpdENvY29hL0ltYWdlQW5hbHlzaXNUZXN0cy5tbQpAQCAtODAsOSArODAsMTAgQEAgc3RhdGlj IHZvaWQgc3dpenpsZWRQcm9jZXNzUmVxdWVzdFdpdGhSZXN1bHRzKGlkLCBTRUwsIFZLSW1hZ2VB bmFseXplclJlcXVlc3QgKiwKIAogI2lmIFBMQVRGT1JNKElPU19GQU1JTFkpCiAKK3N0YXRpYyBD R1BvaW50IGdTd2l6emxlZExvY2F0aW9uSW5WaWV3ID0gQ0dQb2ludCB7IDEwMCwgMTAwIH07CiBz dGF0aWMgQ0dQb2ludCBzd2l6emxlZExvY2F0aW9uSW5WaWV3KGlkLCBTRUwsIFVJVmlldyAqKQog ewotICAgIHJldHVybiBDR1BvaW50TWFrZSgxMDAsIDEwMCk7CisgICAgcmV0dXJuIGdTd2l6emxl ZExvY2F0aW9uSW5WaWV3OwogfQogCiBzdGF0aWMgdm9pZCBzd2l6emxlZFByb2Nlc3NSZXF1ZXN0 V2l0aEVycm9yKGlkLCBTRUwsIFZLSW1hZ2VBbmFseXplclJlcXVlc3QgKiwgdm9pZCAoXikoZG91 YmxlIHByb2dyZXNzKSwgdm9pZCAoXmNvbXBsZXRpb24pKFZLSW1hZ2VBbmFseXNpcyAqYW5hbHlz aXMsIE5TRXJyb3IgKmVycm9yKSkKQEAgLTkzLDcgKzk0LDcgQEAgc3RhdGljIHZvaWQgc3dpenps ZWRQcm9jZXNzUmVxdWVzdFdpdGhFcnJvcihpZCwgU0VMLCBWS0ltYWdlQW5hbHl6ZXJSZXF1ZXN0 ICosIHYKIAogVEVTVChJbWFnZUFuYWx5c2lzVGVzdHMsIERvTm90QW5hbHl6ZUltYWdlc0luRWRp dGFibGVDb250ZW50KQogewotICAgIEluc3RhbmNlTWV0aG9kU3dpenpsZXIgZ2VzdHVyZUxvY2F0 aW9uU3dpenpsZXIgeyBVSUdlc3R1cmVSZWNvZ25pemVyLmNsYXNzLCBAc2VsZWN0b3IobG9jYXRp b25JblZpZXc6KSwgcmVpbnRlcnByZXRfY2FzdDxJTVA+KHN3aXp6bGVkTG9jYXRpb25JblZpZXcp IH07CisgICAgSW5zdGFuY2VNZXRob2RTd2l6emxlciBnZXN0dXJlTG9jYXRpb25Td2l6emxlciB7 IFVJTG9uZ1ByZXNzR2VzdHVyZVJlY29nbml6ZXIuY2xhc3MsIEBzZWxlY3Rvcihsb2NhdGlvbklu VmlldzopLCByZWludGVycHJldF9jYXN0PElNUD4oc3dpenpsZWRMb2NhdGlvbkluVmlldykgfTsK ICAgICBJbnN0YW5jZU1ldGhvZFN3aXp6bGVyIGltYWdlQW5hbHlzaXNSZXF1ZXN0U3dpenpsZXIg eyBQQUw6OmdldFZLSW1hZ2VBbmFseXplckNsYXNzKCksIEBzZWxlY3Rvcihwcm9jZXNzUmVxdWVz dDpwcm9ncmVzc0hhbmRsZXI6Y29tcGxldGlvbkhhbmRsZXI6KSwgcmVpbnRlcnByZXRfY2FzdDxJ TVA+KHN3aXp6bGVkUHJvY2Vzc1JlcXVlc3RXaXRoRXJyb3IpIH07CiAKICAgICBhdXRvIHdlYlZp ZXcgPSBhZG9wdE5TKFtbVGVzdFdLV2ViVmlldyBhbGxvY10gaW5pdFdpdGhGcmFtZTpDR1JlY3RN YWtlKDAsIDAsIDQwMCwgNDAwKV0pOwpAQCAtMTA3LDcgKzEwOCw3IEBAIFRFU1QoSW1hZ2VBbmFs eXNpc1Rlc3RzLCBEb05vdEFuYWx5emVJbWFnZXNJbkVkaXRhYmxlQ29udGVudCkKIAogVEVTVChJ bWFnZUFuYWx5c2lzVGVzdHMsIEhhbmRsZUltYWdlQW5hbHl6ZXJFcnJvcikKIHsKLSAgICBJbnN0 YW5jZU1ldGhvZFN3aXp6bGVyIGdlc3R1cmVMb2NhdGlvblN3aXp6bGVyIHsgVUlHZXN0dXJlUmVj b2duaXplci5jbGFzcywgQHNlbGVjdG9yKGxvY2F0aW9uSW5WaWV3OiksIHJlaW50ZXJwcmV0X2Nh c3Q8SU1QPihzd2l6emxlZExvY2F0aW9uSW5WaWV3KSB9OworICAgIEluc3RhbmNlTWV0aG9kU3dp enpsZXIgZ2VzdHVyZUxvY2F0aW9uU3dpenpsZXIgeyBVSUxvbmdQcmVzc0dlc3R1cmVSZWNvZ25p emVyLmNsYXNzLCBAc2VsZWN0b3IobG9jYXRpb25JblZpZXc6KSwgcmVpbnRlcnByZXRfY2FzdDxJ TVA+KHN3aXp6bGVkTG9jYXRpb25JblZpZXcpIH07CiAgICAgSW5zdGFuY2VNZXRob2RTd2l6emxl ciBpbWFnZUFuYWx5c2lzUmVxdWVzdFN3aXp6bGVyIHsgUEFMOjpnZXRWS0ltYWdlQW5hbHl6ZXJD bGFzcygpLCBAc2VsZWN0b3IocHJvY2Vzc1JlcXVlc3Q6cHJvZ3Jlc3NIYW5kbGVyOmNvbXBsZXRp b25IYW5kbGVyOiksIHJlaW50ZXJwcmV0X2Nhc3Q8SU1QPihzd2l6emxlZFByb2Nlc3NSZXF1ZXN0 V2l0aEVycm9yKSB9OwogCiAgICAgYXV0byB3ZWJWaWV3ID0gYWRvcHROUyhbW1Rlc3RXS1dlYlZp ZXcgYWxsb2NdIGluaXRXaXRoRnJhbWU6Q0dSZWN0TWFrZSgwLCAwLCA0MDAsIDQwMCldKTsKQEAg LTExOCw2ICsxMTksMjEgQEAgVEVTVChJbWFnZUFuYWx5c2lzVGVzdHMsIEhhbmRsZUltYWdlQW5h bHl6ZXJFcnJvcikKICAgICBFWFBFQ1RfRVEoZ0RpZFByb2Nlc3NSZXF1ZXN0Q291bnQsIDFVKTsK IH0KIAorVEVTVChJbWFnZUFuYWx5c2lzVGVzdHMsIERvTm90Q3Jhc2hXaGVuSGl0VGVzdGluZ091 dHNpZGVPZldlYlZpZXcpCit7CisgICAgSW5zdGFuY2VNZXRob2RTd2l6emxlciBnZXN0dXJlTG9j YXRpb25Td2l6emxlciB7IFVJTG9uZ1ByZXNzR2VzdHVyZVJlY29nbml6ZXIuY2xhc3MsIEBzZWxl Y3Rvcihsb2NhdGlvbkluVmlldzopLCByZWludGVycHJldF9jYXN0PElNUD4oc3dpenpsZWRMb2Nh dGlvbkluVmlldykgfTsKKyAgICBJbnN0YW5jZU1ldGhvZFN3aXp6bGVyIGltYWdlQW5hbHlzaXNS ZXF1ZXN0U3dpenpsZXIgeyBQQUw6OmdldFZLSW1hZ2VBbmFseXplckNsYXNzKCksIEBzZWxlY3Rv cihwcm9jZXNzUmVxdWVzdDpwcm9ncmVzc0hhbmRsZXI6Y29tcGxldGlvbkhhbmRsZXI6KSwgcmVp bnRlcnByZXRfY2FzdDxJTVA+KHN3aXp6bGVkUHJvY2Vzc1JlcXVlc3RXaXRoRXJyb3IpIH07CisK KyAgICBhdXRvIHdlYlZpZXcgPSBhZG9wdE5TKFtbVGVzdFdLV2ViVmlldyBhbGxvY10gaW5pdFdp dGhGcmFtZTpDR1JlY3RNYWtlKDAsIDAsIDQwMCwgNDAwKV0pOworICAgIFt3ZWJWaWV3IHN5bmNo cm9ub3VzbHlMb2FkVGVzdFBhZ2VOYW1lZDpAImltYWdlIl07CisKKyAgICBnU3dpenpsZWRMb2Nh dGlvbkluVmlldyA9IENHUG9pbnRNYWtlKDUwMCwgNTAwKTsKKyAgICBbd2ViVmlldyBfaW1hZ2VB bmFseXNpc0dlc3R1cmVSZWNvZ25pemVyXS5zdGF0ZSA9IFVJR2VzdHVyZVJlY29nbml6ZXJTdGF0 ZUJlZ2FuOworICAgIFt3ZWJWaWV3IHdhaXRGb3JOZXh0UHJlc2VudGF0aW9uVXBkYXRlXTsKKyAg ICBbd2ViVmlldyBleHBlY3RFbGVtZW50Q291bnQ6MSBxdWVyeVNlbGVjdG9yOkAiaW1nIl07Cisg ICAgRVhQRUNUX0VRKGdEaWRQcm9jZXNzUmVxdWVzdENvdW50LCAwVSk7Cit9CisKICNlbmRpZiAv LyBQTEFURk9STShJT1NfRkFNSUxZKQogCiBURVNUKEltYWdlQW5hbHlzaXNUZXN0cywgU3RhcnRJ bWFnZUFuYWx5c2lzV2l0aG91dElkZW50aWZpZXIpCg==